waterdrop 0.1.11 → 0.1.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 569fd25f4d1246edb49a726bbb294eb795c7ced2
-  data.tar.gz: a2feee69b17779258fa4ecb318da14f7bc1b2162
+  metadata.gz: eaaa93109e4512ca5227b24d5d07b440c5abca97
+  data.tar.gz: f6beefb7fccb3c5dd7a0bbacfc6aa949fd8a215b
 SHA512:
-  metadata.gz: 5b4524870d7e312d5678f2683725afd08eb59777b48aad03022b549f2acd2129ecd13c47fe2c0372724ad5e369c602eab719f1373d11bdada4b5506c3d11f6b7
-  data.tar.gz: 3f8d9896af0179f0d1bdd989da15212347e4db5b34ccb6ebc9a9d43ab4bdc7f96a35caffcc48c0ee451caa6b6de95561e39998bf445e2f1e88f416c26374967a
+  metadata.gz: e6bfa48ad2e2de05ab0ab93afcd3583634d83b050f11fa850cab0b574614fab67c86a66f4436df9a5ee75f62337f49c3557e16860b8b9ca639a83e433837c4d0
+  data.tar.gz: 979a187dd49c9ac2993d67b59349a0c7131b3aa96bd2563595ff78f8e1cc9634b734c84437e0478f9d541e79e91a26c6a451446e0f6a950fcffb25cfb8bfed9d

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # WaterDrop changelog
 
+## 0.1.12
+- Removed default to_json casting because of binary/other data types incompatibility. This is an incompatibility. If you use WaterDrop, please add a proper casting method to places where you use it.
+- Gem dump
+
 ## 0.1.11
 - Poseidon options extractions and tweaks
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    waterdrop (0.1.11)
+    waterdrop (0.1.12)
       aspector
       bundler
       connection_pool
@@ -13,10 +13,10 @@ GEM
   remote: https://rubygems.org/
   specs:
     abstract_type (0.0.7)
-    activemodel (4.2.4)
-      activesupport (= 4.2.4)
+    activemodel (4.2.5)
+      activesupport (= 4.2.5)
       builder (~> 3.1)
-    activesupport (4.2.4)
+    activesupport (4.2.5)
       i18n (~> 0.7)
       json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
@@ -33,7 +33,7 @@ GEM
       descendants_tracker (~> 0.0.4)
       ice_nine (~> 0.11.0)
       thread_safe (~> 0.3, >= 0.3.1)
-    brakeman (3.1.1)
+    brakeman (3.1.2)
       erubis (~> 2.6)
       fastercsv (~> 1.5)
       haml (>= 3.0, < 5.0)
@@ -41,6 +41,7 @@ GEM
       multi_json (~> 1.2)
       ruby2ruby (>= 2.1.1, < 2.3.0)
       ruby_parser (~> 3.7.0)
+      safe_yaml
       sass (~> 3.0)
       slim (>= 1.3.6, < 4.0)
       terminal-table (~> 1.4)
@@ -59,13 +60,13 @@ GEM
     docile (1.1.5)
     equalizer (0.0.11)
     erubis (2.7.0)
-    faker (1.5.0)
+    faker (1.6.1)
       i18n (~> 0.5)
     fastercsv (1.5.5)
-    flay (2.4.0)
+    flay (2.6.1)
       ruby_parser (~> 3.0)
       sexp_processor (~> 4.0)
-    flog (4.2.1)
+    flog (4.3.2)
       ruby_parser (~> 3.1, > 3.1.0)
       sexp_processor (~> 4.4)
     haml (4.0.7)
@@ -81,10 +82,10 @@ GEM
     memoizable (0.4.2)
       thread_safe (~> 0.3, >= 0.3.1)
     method_source (0.8.2)
-    minitest (5.8.1)
+    minitest (5.8.3)
     mongo (2.1.2)
       bson (~> 3.0)
-    mongoid (5.0.0)
+    mongoid (5.0.1)
       activemodel (~> 4.0)
       mongo (~> 2.1)
       origin (~> 2.1)
@@ -98,7 +99,7 @@ GEM
     origin (2.1.1)
     parser (2.2.3.0)
       ast (>= 1.1, < 3.0)
-    polishgeeks-dev-tools (1.2.0)
+    polishgeeks-dev-tools (1.2.1)
       brakeman
       faker
       haml-lint
@@ -106,13 +107,14 @@ GEM
       pry
       rspec
       rubocop
-      rubycritic (= 1.2.1)
+      rubycritic
       shoulda
       simplecov
       timecop
       yard
     poseidon (0.0.5)
     powerpack (0.1.1)
+    private_attr (1.1.0)
     procto (0.0.2)
     pry (0.10.3)
       coderay (~> 1.1.0)
@@ -120,42 +122,44 @@ GEM
       slop (~> 3.4)
     rainbow (2.0.0)
     rake (10.4.2)
-    reek (1.6.3)
-      parser (~> 2.2.0.pre.7)
-      rainbow (>= 1.99, < 3.0)
+    reek (3.6.0)
+      parser (~> 2.2, >= 2.2.2.5)
+      private_attr (~> 1.1)
+      rainbow (~> 2.0)
       unparser (~> 0.2.2)
-    rspec (3.3.0)
-      rspec-core (~> 3.3.0)
-      rspec-expectations (~> 3.3.0)
-      rspec-mocks (~> 3.3.0)
-    rspec-core (3.3.2)
-      rspec-support (~> 3.3.0)
-    rspec-expectations (3.3.1)
+    rspec (3.4.0)
+      rspec-core (~> 3.4.0)
+      rspec-expectations (~> 3.4.0)
+      rspec-mocks (~> 3.4.0)
+    rspec-core (3.4.1)
+      rspec-support (~> 3.4.0)
+    rspec-expectations (3.4.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.3.0)
-    rspec-mocks (3.3.2)
+      rspec-support (~> 3.4.0)
+    rspec-mocks (3.4.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.3.0)
-    rspec-support (3.3.0)
-    rubocop (0.34.2)
+      rspec-support (~> 3.4.0)
+    rspec-support (3.4.1)
+    rubocop (0.35.1)
       astrolabe (~> 1.3)
-      parser (>= 2.2.2.5, < 3.0)
+      parser (>= 2.2.3.0, < 3.0)
       powerpack (~> 0.1)
       rainbow (>= 1.99.1, < 3.0)
-      ruby-progressbar (~> 1.4)
+      ruby-progressbar (~> 1.7)
+      tins (<= 1.6.0)
     ruby-progressbar (1.7.5)
     ruby2ruby (2.2.0)
       ruby_parser (~> 3.1)
       sexp_processor (~> 4.0)
-    ruby_parser (3.7.1)
+    ruby_parser (3.7.2)
       sexp_processor (~> 4.1)
-    rubycritic (1.2.1)
-      flay (= 2.4.0)
-      flog (= 4.2.1)
+    rubycritic (2.2.0)
+      flay (= 2.6.1)
+      flog (= 4.3.2)
       parser (>= 2.2.0, < 3.0)
-      reek (= 1.6.3)
-      ruby2ruby (>= 2.1.1, < 3.0)
+      reek (= 3.6.0)
       virtus (~> 1.0)
+    safe_yaml (1.0.4)
     sass (3.4.19)
     sexp_processor (4.6.0)
     shoulda (3.5.0)
@@ -179,6 +183,7 @@ GEM
     thread_safe (0.3.5)
     tilt (2.0.1)
     timecop (0.8.0)
+    tins (1.6.0)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
     unparser (0.2.4)

data/README.md

@@ -69,9 +69,12 @@ To send Kafka messages, you don't need to use aspects, you can create and send m
 ```ruby
 message = WaterDrop::Message.new('topic', 'message')
 message.send!
+
+message = WaterDrop::Message.new('topic', { user_id: 1 }.to_json)
+message.send!
 ```
 
-message that you want to send should be either castable to string or to json. If it can be casted to both, it will be casted to json.
+message that you want to send should be either binary or stringified (to_s, to_json, etc).
 
 ### Using aspects to handle messages
 

data/lib/water_drop/message.rb

@@ -11,7 +11,7 @@ module WaterDrop
     #   WaterDrop::Message.new(topic, message)
     def initialize(topic, message)
       @topic = topic.to_s
-      @message = message.respond_to?(:to_json) ? message.to_json : message.to_s
+      @message = message
     end
 
     # Sents a current message to Kafka

data/lib/water_drop/producer_proxy.rb

@@ -9,6 +9,11 @@ module WaterDrop
     # send using it. After that time, we will recreate the connection
     LIFE_TIME = 5 * 60 #  5 minute
 
+    # If sending fails - how many times we should try with a new connection
+    # @note It works in a similar way to Poseidon internal max_send_retries option, but it will
+    #   create a new connection after failure (Poseidon tries to use the same one)
+    MAX_SEND_RETRIES = 1
+
     # All default poseidon parameters that we want to use
     POSEIDON_PARAMS = {
       metadata_refresh_interval_ms: 5 * 60 * 1000, # 5 minutes
@@ -17,7 +22,7 @@ module WaterDrop
       required_acks: -1,
       # @see https://issues.apache.org/jira/browse/KAFKA-1494
       retry_backoff_ms: 1000,
-      max_send_retries: 5
+      max_send_retries: 1
     }
 
     # @return [WaterDrop::ProducerProxy] proxy object to Poseidon::Producer
@@ -25,6 +30,7 @@ module WaterDrop
     #   first used when we create it
     def initialize
       touch
+      @attempts = 0
     end
 
     # Sends messages to Kafka
@@ -40,7 +46,12 @@ module WaterDrop
       producer.send_messages(messages)
     rescue StandardError => e
       reload!
+
+      retry if (@attempts += 1) <= MAX_SEND_RETRIES
+
       raise(e)
+    ensure
+      @attempts = 0
     end
 
     private

data/lib/water_drop/version.rb

@@ -1,5 +1,5 @@
 # WaterDrop library
 module WaterDrop
   # Current WaterDrop version
-  VERSION = '0.1.11'.freeze
+  VERSION = '0.1.12'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: waterdrop
 version: !ruby/object:Gem::Version
-  version: 0.1.11
+  version: 0.1.12
 platform: ruby
 authors:
 - Maciej Mensfeld
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-25 00:00:00.000000000 Z
+date: 2015-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler