warder 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 89cecf176b3b2b1883f804fd8fdb0a033d31fa8b
-  data.tar.gz: eab58ed0fbc4f928e67abc6284279170fc3d1837
+  metadata.gz: b864c54097bcb93f454fc147be1e537f9576356e
+  data.tar.gz: af7fde372eaf74e95b8b5dab73f7c6d724685e5c
 SHA512:
-  metadata.gz: 10d23faab41113d402510c954c828c11e6dd72e5e6e688f543644d5231ec094d79dfedd50d96f16dba12101bb9402ad9a3c6ce0f8e1b386905160ec7e9532241
-  data.tar.gz: 38936ad08769e784f8db07d02a02ee19b8a88df776a2491c892df915fba8e7c79d92856cedc9180a61b82b1f0bd2b767262524717da1ed2abe8b524d74e61c6f
+  metadata.gz: 6cc1754aa316c2ea9172d6d6190d8681126f82ec8b8846908b2a0cf6d752ba203439b9da08b483d8aff21c3e2fe6f863b23fcaef83a06d8909bf79fae6439486
+  data.tar.gz: 4df26aece35d2a73f1b0f71dee59f912f69057dba4bc063a96abb73b9b0a453335ce0a45e0a01df1bdd6ef0fcd54f4a2314d21a861dab1e21969f4fd0e935bb4

data/.gitignore

@@ -6,7 +6,7 @@
 .ruby-version
 .ruby-gemset
 Gemfile.lock
-TODO.md
+/TODO.md
 InstalledFiles
 _yardoc
 coverage

data/features/checks_for_all_issues.feature

@@ -3,26 +3,32 @@ Feature: checks for all issues
   As a ruby developer
   I want to run warder with --all option
 
-  @wip
   Scenario: run warder with enabled all option
     Given I have valid_rails_app project in directory
     And I am on project directory
     When I run `warder --all`
+    Then warder detects style guide issues
+    Then warder detects magick numbers issues
+    Then warder detects code complexity issues
+    Then warder detects code duplication issues
+    Then warder detects code smells issues
+    Then warder detects sandi rules violations
     Then warder detects rails best practices issues
     Then warder detects rails security issues
+    Then warder detects gem freshness issues
     Then the exit status should be 0
 
-#  Scenario: run warder with enabled rails option on invalid project
-#    Given I have invalid_rails_app project in directory
-#    And I am on project directory
-#    When I run `warder --rails`
-#    Then warder detects rails best practices issues
-#    Then warder detects rails security issues
-#    Then the exit status should be 2
-#
-#  Scenario: run warder with disabled rails option on invalid project
-#    Given I have invalid_rails_app project in directory
-#    And I am on project directory
-#    When I run `warder --no-rails`
-#    Then warder does nothing
-#    Then the exit status should be 0
+  Scenario: run warder with enabled rails option on invalid project
+    Given I have invalid_rails_app project in directory
+    And I am on project directory
+    When I run `warder --all`
+    Then warder detects style guide issues
+    Then warder detects magick numbers issues
+    Then warder detects code complexity issues
+    Then warder detects code duplication issues
+    Then warder detects code smells issues
+    Then warder detects sandi rules violations
+    Then warder detects rails best practices issues
+    Then warder detects rails security issues
+    Then warder detects gem freshness issues
+    Then the exit status should be 9

data/features/checks_for_vulnerable_gems.feature

@@ -4,19 +4,22 @@ Feature: checks for vulnerable gems
   I want to run warder with --bundle-audit option
 
   Scenario: run warder with enabled bundle audit option
-    Given I have valid gemfile in directory
+    Given I have valid_rails_app project in directory
+    And I am on project directory
     When I run `warder --bundle-audit`
     Then warder detects gem freshness issues
     Then the exit status should be 0
 
   Scenario: run warder with enabled bundle audit option on invalid file
-    Given I have invalid gemfile in directory
+    Given I have invalid_rails_app project in directory
+    And I am on project directory
     When I run `warder --bundle-audit`
     Then warder detects gem freshness issues
     Then the exit status should be 1
 
   Scenario: run warder with disabled bundle audit option on invalid file
-    Given I have invalid gemfile in directory
+    Given I have invalid_rails_app project in directory
+    And I am on project directory
     When I run `warder --no-bundle-audit`
     Then warder does nothing
     Then the exit status should be 0

data/features/step_definitions/checks_for_rails_security_issues_steps.rb

@@ -11,7 +11,9 @@ end
 
 Given(/^I have ((in)?valid_rails_app) project in directory$/) do |name, _|
   @projectname = name
-  FileUtils.ln_s "../../spec/fixtures/#{@projectname}", 'tmp/aruba/'
+  FileUtils.cp_r "spec/fixtures/#{@projectname}", 'tmp/aruba/'
+  FileUtils.mv "tmp/aruba/#{@projectname}/Gemfile_lock",
+               "tmp/aruba/#{@projectname}/Gemfile.lock"
   expect(`ls tmp/aruba`).to match(@projectname)
 end
 

data/features/step_definitions/checks_for_vulnerable_gems_steps.rb

@@ -3,11 +3,10 @@ def executing_gem_freshness
 end
 
 def gem_freshness_output
-  `cd tmp/aruba/ && bundle-audit check`
-end
-
-Given(/^I have ((in)?valid) gemfile in directory$/) do |state, _|
-  @filename = "#{state}_Gemfile.lock"
-  FileUtils.ln_s "../../spec/fixtures/#{@filename}", 'tmp/aruba/Gemfile.lock'
-  expect(`ls tmp/aruba`).to match('Gemfile.lock')
+  if @projectname
+    prep = "cd spec/fixtures/#{@projectname}/ && cp Gemfile_lock Gemfile.lock"
+    `#{prep} && bundle-audit check; rm -f Gemfile.lock`
+  else
+    fail NotImplementedError
+  end
 end

data/features/step_definitions/detects_code_complexity_steps.rb

@@ -3,8 +3,9 @@ def executing_code_complexity
 end
 
 def code_complexity_output
-  `cd spec/fixtures/ && flog -a -c -g -m ./#{@filename}`
-    .split("\n")
-    .reject { |line| line.match(/total|average/) }
-    .join("\n")
+  raw_output = command_output_for_project_or_file('flog -a -c -g -m')
+  raw_output.split("\n").reject do |line|
+    /total|average/.match(line) ||
+      Warder::CodeComplexityRunner::FLOG_SCORE > line.to_i
+  end.join("\n")
 end

data/features/step_definitions/detects_code_duplication_steps.rb

@@ -3,5 +3,5 @@ def executing_code_duplication
 end
 
 def code_duplication_output
-  `cd spec/fixtures/ && flay -d ./#{@filename}`
+  command_output_for_project_or_file('flay -d')
 end

data/features/step_definitions/detects_code_smells_steps.rb

@@ -3,5 +3,5 @@ def executing_code_smells
 end
 
 def code_smells_output
-  `cd spec/fixtures/ && reek #{@filename}`
+  command_output_for_project_or_file('reek')
 end

data/features/step_definitions/detects_magick_numbers_steps.rb

@@ -3,5 +3,5 @@ def executing_magick_numbers
 end
 
 def magick_numbers_output
-  `cd spec/fixtures/ && mago #{@filename}`
+  command_output_for_project_or_file('mago')
 end

data/features/step_definitions/run_steps.rb

@@ -25,3 +25,13 @@ Then(/^warder detects (.+) (issues|violations)$/) do |what, _|
     step "the output should contain \"#{string}\""
   end
 end
+
+def command_output_for_project_or_file(cmd)
+  if @filename
+    `cd spec/fixtures/ && #{cmd} ./#{@filename}`
+  elsif @projectname
+    `cd spec/fixtures/#{@projectname} && #{cmd} ./`
+  else
+    fail NotImplementedError
+  end
+end

data/features/step_definitions/validates_style_guide_steps.rb

@@ -3,5 +3,5 @@ def executing_style_guide
 end
 
 def style_guide_output
-  `cd spec/fixtures/ && rubocop #{@filename}`
+  command_output_for_project_or_file('rubocop')
 end

data/lib/warder/code_smells_runner.rb

@@ -5,6 +5,6 @@ module Warder
     CLI_FULL_OPTION = 'code-smells'
     DESCRIPTION = 'Run code smells validation'
     COMMAND_NAME = 'reek'
-    FAILURE_REGEXP = / -- (\d+) warnings?:/
+    FAILURE_REGEXP = /(\d+) warnings?/
   end
 end

data/lib/warder/style_guide_runner.rb

@@ -5,6 +5,6 @@ module Warder
     CLI_FULL_OPTION = 'style-guide'
     DESCRIPTION = 'Run style guide validation'
     COMMAND_NAME = 'rubocop'
-    FAILURE_REGEXP = /(\d+|no) offence/
+    FAILURE_REGEXP = /(\d+|no) offense/
   end
 end

data/lib/warder/version.rb

@@ -1,4 +1,4 @@
 # define warder version
 module Warder
-  VERSION = '0.1.6'
+  VERSION = '0.1.7'
 end

data/spec/fixtures/invalid_rails_app/Gemfile

@@ -1,3 +1,4 @@
 source 'https://rubygems.org'
 
 gem 'rails', '4.0.0'
+gem 'ftpd', '0.2.1'

data/spec/fixtures/invalid_rails_app/Gemfile_lock

@@ -0,0 +1,82 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+    actionmailer (4.0.0)
+      actionpack (= 4.0.0)
+      mail (~> 2.5.3)
+    actionpack (4.0.0)
+      activesupport (= 4.0.0)
+      builder (~> 3.1.0)
+      erubis (~> 2.7.0)
+      rack (~> 1.5.2)
+      rack-test (~> 0.6.2)
+    activemodel (4.0.0)
+      activesupport (= 4.0.0)
+      builder (~> 3.1.0)
+    activerecord (4.0.0)
+      activemodel (= 4.0.0)
+      activerecord-deprecated_finders (~> 1.0.2)
+      activesupport (= 4.0.0)
+      arel (~> 4.0.0)
+    activerecord-deprecated_finders (1.0.3)
+    activesupport (4.0.0)
+      i18n (~> 0.6, >= 0.6.4)
+      minitest (~> 4.2)
+      multi_json (~> 1.3)
+      thread_safe (~> 0.1)
+      tzinfo (~> 0.3.37)
+    arel (4.0.2)
+    atomic (1.1.14)
+    builder (3.1.4)
+    erubis (2.7.0)
+    hike (1.2.3)
+    i18n (0.6.9)
+    mail (2.5.4)
+      mime-types (~> 1.16)
+      treetop (~> 1.4.8)
+    memoizer (1.0.1)
+    mime-types (1.25.1)
+    minitest (4.7.5)
+    multi_json (1.8.4)
+    polyglot (0.3.3)
+    rack (1.5.2)
+    rack-test (0.6.2)
+      rack (>= 1.0)
+    rails (4.0.0)
+      actionmailer (= 4.0.0)
+      actionpack (= 4.0.0)
+      activerecord (= 4.0.0)
+      activesupport (= 4.0.0)
+      bundler (>= 1.3.0, < 2.0)
+      railties (= 4.0.0)
+      sprockets-rails (~> 2.0.0)
+    railties (4.0.0)
+      actionpack (= 4.0.0)
+      activesupport (= 4.0.0)
+      rake (>= 0.8.7)
+      thor (>= 0.18.1, < 2.0)
+    rake (10.1.1)
+    sprockets (2.10.1)
+      hike (~> 1.2)
+      multi_json (~> 1.0)
+      rack (~> 1.0)
+      tilt (~> 1.1, != 1.3.0)
+    sprockets-rails (2.0.1)
+      actionpack (>= 3.0)
+      activesupport (>= 3.0)
+      sprockets (~> 2.8)
+    thor (0.18.1)
+    thread_safe (0.1.3)
+      atomic
+    tilt (1.4.1)
+    treetop (1.4.15)
+      polyglot
+      polyglot (>= 0.3.1)
+    tzinfo (0.3.38)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  ftpd (= 0.2.1)
+  rails (= 4.0.0)

data/spec/fixtures/invalid_rails_app/app/controllers/application_controller.rb

@@ -3,13 +3,17 @@ class ApplicationController < ActionController::Base
   # For APIs, you may want to use :null_session instead.
   protect_from_forgery with: :exception
 
+  def hello
+    render text: 'Hello world!'
+  end
+
   def welcome
     @user = User.new(params[:first_name], params[:last_name], params[:email], params[:password], params[:password_confirmation])
     if @user
       @logged_in = true
       render text: "Hello #{@user.full_name}!"
     else
-      render text: "Hello Anonymous!"
+      render text: 'Hello Anonymous!'
     end
   end
 end

data/spec/fixtures/invalid_rails_app/config/application.rb

@@ -13,7 +13,8 @@ module Invalid
     # -- all .rb files in that directory are automatically loaded.
 
     # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
-    # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
+    # Run "rake -D time" for a list of tasks for finding time zone names.
+    # Default is UTC.
     # config.time_zone = 'Central Time (US & Canada)'
 
     # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.

data/spec/fixtures/invalid_rails_app/config/environments/test.rb

@@ -14,7 +14,7 @@ Invalid::Application.configure do
 
   # Configure static asset server for tests with Cache-Control for performance.
   config.serve_static_assets  = true
-  config.static_cache_control = "public, max-age=3600"
+  config.static_cache_control = 'public, max-age=3600'
 
   # Show full error reports and disable caching.
   config.consider_all_requests_local       = true

data/spec/fixtures/invalid_rails_app/config/initializers/secret_token.rb

@@ -9,4 +9,4 @@
 
 # Make sure your secret_key_base is kept private
 # if you're sharing your code publicly.
-Invalid::Application.config.secret_key_base = '5ad3a18ee258ed8a5ff14aa38324b4088ac59fef42a56af0ef4e4f3dc1106413627eb3c1d68faa03affb2bef74a0f4cb053fa19334e6ae41ec24c2ed3540f5d4'
+Valid::Application.config.secret_key_base = SecureRandom.hex(32)

data/spec/fixtures/invalid_rails_app/lib/invalid_code_complexity.rb

@@ -0,0 +1,13 @@
+def a
+  b = 1 + 2 + 3 + 4 + 5
+  c = 6 + 7 + 8 + 9 + 0
+  d = 1 + 7 + 3 + 9 + 5
+  e = 6 + 2 + 8 + 4 + 0
+  f = 1 + 2 + 3 + 4 + 5
+  g = 6 + 7 + 8 + 9 + 0
+  h = 1 + 7 + 3 + 9 + 5
+  i = 6 + 2 + 8 + 4 + 0
+  j = b + c + d + e + f + g + h + i
+end
+
+puts a

data/spec/fixtures/invalid_rails_app/lib/invalid_code_duplication.rb

@@ -0,0 +1,40 @@
+##
+# I am a dog.
+
+class Dog
+  def x
+    return 1
+  end
+
+  def w
+    return 2 + q
+  end
+
+  private
+
+  def q
+    return 3
+  end
+end
+
+##
+# I
+# am
+# a
+# cat.
+
+class Cat
+  def y
+    return 1
+  end
+
+  def z
+    return 2 + s
+  end
+
+  private
+
+  def s
+    return 3
+  end
+end

data/spec/fixtures/valid_rails_app/Gemfile

@@ -1,5 +1,5 @@
 source 'https://rubygems.org'
 
-gem 'rails', '~> 4.0.2'
+gem 'rails', '~> 4.0.4'
 
 gem 'sqlite3'

data/spec/fixtures/valid_rails_app/Gemfile_lock

@@ -0,0 +1,80 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+    actionmailer (4.0.4)
+      actionpack (= 4.0.4)
+      mail (~> 2.5.4)
+    actionpack (4.0.4)
+      activesupport (= 4.0.4)
+      builder (~> 3.1.0)
+      erubis (~> 2.7.0)
+      rack (~> 1.5.2)
+      rack-test (~> 0.6.2)
+    activemodel (4.0.4)
+      activesupport (= 4.0.4)
+      builder (~> 3.1.0)
+    activerecord (4.0.4)
+      activemodel (= 4.0.4)
+      activerecord-deprecated_finders (~> 1.0.2)
+      activesupport (= 4.0.4)
+      arel (~> 4.0.0)
+    activerecord-deprecated_finders (1.0.3)
+    activesupport (4.0.4)
+      i18n (~> 0.6, >= 0.6.9)
+      minitest (~> 4.2)
+      multi_json (~> 1.3)
+      thread_safe (~> 0.1)
+      tzinfo (~> 0.3.37)
+    arel (4.0.2)
+    builder (3.1.4)
+    erubis (2.7.0)
+    hike (1.2.3)
+    i18n (0.6.9)
+    mail (2.5.4)
+      mime-types (~> 1.16)
+      treetop (~> 1.4.8)
+    mime-types (1.25.1)
+    minitest (4.7.5)
+    multi_json (1.9.2)
+    polyglot (0.3.4)
+    rack (1.5.2)
+    rack-test (0.6.2)
+      rack (>= 1.0)
+    rails (4.0.4)
+      actionmailer (= 4.0.4)
+      actionpack (= 4.0.4)
+      activerecord (= 4.0.4)
+      activesupport (= 4.0.4)
+      bundler (>= 1.3.0, < 2.0)
+      railties (= 4.0.4)
+      sprockets-rails (~> 2.0.0)
+    railties (4.0.4)
+      actionpack (= 4.0.4)
+      activesupport (= 4.0.4)
+      rake (>= 0.8.7)
+      thor (>= 0.18.1, < 2.0)
+    rake (10.3.1)
+    sprockets (2.12.1)
+      hike (~> 1.2)
+      multi_json (~> 1.0)
+      rack (~> 1.0)
+      tilt (~> 1.1, != 1.3.0)
+    sprockets-rails (2.0.1)
+      actionpack (>= 3.0)
+      activesupport (>= 3.0)
+      sprockets (~> 2.8)
+    sqlite3 (1.3.9)
+    thor (0.19.1)
+    thread_safe (0.3.3)
+    tilt (1.4.1)
+    treetop (1.4.15)
+      polyglot
+      polyglot (>= 0.3.1)
+    tzinfo (0.3.39)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  rails (~> 4.0.4)
+  sqlite3

data/spec/fixtures/valid_rails_app/Rakefile

@@ -1,5 +1,6 @@
 # Add your own tasks in files placed in lib/tasks ending in .rake,
-# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
+# for example lib/tasks/capistrano.rake, and they will automatically be
+# available to Rake.
 
 require File.expand_path('../config/application', __FILE__)
 

data/spec/fixtures/valid_rails_app/app/controllers/application_controller.rb

@@ -1,3 +1,4 @@
+# application controller
 class ApplicationController < ActionController::Base
   # Prevent CSRF attacks by raising an exception.
   # For APIs, you may want to use :null_session instead.

data/spec/fixtures/valid_rails_app/config/application.rb

@@ -7,17 +7,23 @@ require 'rails/all'
 Bundler.require(:default, Rails.env)
 
 module Valid
+  # application config
   class Application < Rails::Application
-    # Settings in config/environments/* take precedence over those specified here.
+    # Settings in config/environments/* take precedence over those specified
+    # here.
     # Application configuration should go into files in config/initializers
     # -- all .rb files in that directory are automatically loaded.
 
-    # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
-    # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
+    # Set Time.zone default to the specified zone and make Active Record
+    # auto-convert to this zone.
+    # Run "rake -D time" for a list of tasks for finding time zone names.
+    # Default is UTC.
     # config.time_zone = 'Central Time (US & Canada)'
 
-    # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
-    # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
+    # The default locale is :en and all translations from
+    # config/locales/*.rb,yml are auto loaded.
+    # config.i18n.load_path +=
+    #   Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
     # config.i18n.default_locale = :de
   end
 end

data/spec/fixtures/valid_rails_app/config/boot.rb

@@ -1,4 +1,4 @@
 # Set up gems listed in the Gemfile.
 ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
 
-require 'bundler/setup' if File.exists?(ENV['BUNDLE_GEMFILE'])
+require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE'])

data/spec/fixtures/valid_rails_app/config/environments/development.rb

@@ -1,5 +1,6 @@
 Valid::Application.configure do
-  # Settings specified here will take precedence over those in config/application.rb.
+  # Settings specified here will take precedence over those in
+  # config/application.rb.
 
   # In the development environment your application's code is reloaded on
   # every request. This slows down response time but is perfect for development

data/spec/fixtures/valid_rails_app/config/environments/production.rb

@@ -1,5 +1,6 @@
 Valid::Application.configure do
-  # Settings specified here will take precedence over those in config/application.rb.
+  # Settings specified here will take precedence over those in
+  # config/application.rb.
 
   # Code is not reloaded between requests.
   config.cache_classes = true
@@ -16,7 +17,8 @@ Valid::Application.configure do
 
   # Enable Rack::Cache to put a simple HTTP cache in front of your application
   # Add `rack-cache` to your Gemfile before enabling this.
-  # For large-scale production use, consider using a caching reverse proxy like nginx, varnish or squid.
+  # For large-scale production use, consider using a caching reverse proxy like
+  # nginx, varnish or squid.
   # config.action_dispatch.rack_cache = true
 
   # Disable Rails's static asset server (Apache or nginx will already do this).
@@ -39,7 +41,8 @@ Valid::Application.configure do
   # config.action_dispatch.x_sendfile_header = "X-Sendfile" # for apache
   # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for nginx
 
-  # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
+  # Force all access to the app over SSL, use Strict-Transport-Security, and
+  # use secure cookies.
   # config.force_ssl = true
 
   # Set to :debug to see everything in the log.
@@ -54,15 +57,18 @@ Valid::Application.configure do
   # Use a different cache store in production.
   # config.cache_store = :mem_cache_store
 
-  # Enable serving of images, stylesheets, and JavaScripts from an asset server.
+  # Enable serving of images, stylesheets, and JavaScripts from an asset
+  # server.
   # config.action_controller.asset_host = "http://assets.example.com"
 
   # Precompile additional assets.
-  # application.js, application.css, and all non-JS/CSS in app/assets folder are already added.
+  # application.js, application.css, and all non-JS/CSS in app/assets folder
+  # are already added.
   # config.assets.precompile += %w( search.js )
 
   # Ignore bad email addresses and do not raise email delivery errors.
-  # Set this to true and configure the email server for immediate delivery to raise delivery errors.
+  # Set this to true and configure the email server for immediate delivery to
+  # raise delivery errors.
   # config.action_mailer.raise_delivery_errors = false
 
   # Enable locale fallbacks for I18n (makes lookups for any locale fall back to

data/spec/fixtures/valid_rails_app/config/environments/test.rb

@@ -1,5 +1,6 @@
 Valid::Application.configure do
-  # Settings specified here will take precedence over those in config/application.rb.
+  # Settings specified here will take precedence over those in
+  # config/application.rb.
 
   # The test environment is used exclusively to run your application's
   # test suite. You never need to work with it otherwise. Remember that
@@ -14,7 +15,7 @@ Valid::Application.configure do
 
   # Configure static asset server for tests with Cache-Control for performance.
   config.serve_static_assets  = true
-  config.static_cache_control = "public, max-age=3600"
+  config.static_cache_control = 'public, max-age=3600'
 
   # Show full error reports and disable caching.
   config.consider_all_requests_local       = true

data/spec/fixtures/valid_rails_app/config/initializers/secret_token.rb

@@ -9,4 +9,5 @@
 
 # Make sure your secret_key_base is kept private
 # if you're sharing your code publicly.
-Valid::Application.config.secret_key_base = SecureRandom.hex(32)
+TOKEN_LENGTH = 32
+Valid::Application.config.secret_key_base = SecureRandom.hex(TOKEN_LENGTH)

data/spec/fixtures/valid_rails_app/config/initializers/wrap_parameters.rb

@@ -3,7 +3,8 @@
 # This file contains settings for ActionController::ParamsWrapper which
 # is enabled by default.
 
-# Enable parameter wrapping for JSON. You can disable this by setting :format to an empty array.
+# Enable parameter wrapping for JSON. You can disable this by setting :format
+# to an empty array.
 ActiveSupport.on_load(:action_controller) do
   wrap_parameters format: [:json] if respond_to?(:wrap_parameters)
 end

data/warder.gemspec

@@ -8,8 +8,8 @@ Gem::Specification.new do |spec|
   spec.version       = Warder::VERSION
   spec.authors       = ['Yura Tolstik']
   spec.email         = ['yltsrc@gmail.com']
-  spec.description   = %q{Warder of ruby code}
-  spec.summary       = %q{Warder of ruby code}
+  spec.description   = %q(Warder of ruby code)
+  spec.summary       = %q(Tool to help improve the quality of ruby code)
   spec.homepage      = 'https://github.com/yltsrc/warder'
   spec.license       = 'MIT'
 
@@ -18,20 +18,20 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(/^(test|spec|features|cucumber)\//)
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop'
-  spec.add_dependency 'reek', '~> 1.3.6'
-  spec.add_dependency 'flay', '~> 2.4.0'
-  spec.add_dependency 'flog', '~> 4.2.0'
-  spec.add_dependency 'mago', '~> 0.1.0'
-  spec.add_dependency 'brakeman', '~> 2.3.1'
-  spec.add_dependency 'rails_best_practices', '~> 1.14.4'
-  spec.add_dependency 'sandi_meter', '~> 1.0.5'
-  spec.add_dependency 'bundler-audit', '~> 0.3.0'
+  spec.add_dependency 'rubocop', '~> 0.18'
+  spec.add_dependency 'reek', '~> 1.3'
+  spec.add_dependency 'flay', '~> 2.4'
+  spec.add_dependency 'flog', '~> 4.2'
+  spec.add_dependency 'mago', '~> 0.1'
+  spec.add_dependency 'brakeman', '~> 2.4'
+  spec.add_dependency 'rails_best_practices', '~> 1.15'
+  spec.add_dependency 'sandi_meter', '~> 1.1'
+  spec.add_dependency 'bundler-audit', '~> 0.3'
 
   spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rspec', '3.0.0.beta1'
-  spec.add_development_dependency 'cucumber'
-  spec.add_development_dependency 'aruba'
-  spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rspec', '~> 2.14'
+  spec.add_development_dependency 'cucumber', '~> 1.3'
+  spec.add_development_dependency 'aruba', '~> 0.5'
+  spec.add_development_dependency 'simplecov', '~> 0.8'
 end

metadata

@@ -1,141 +1,141 @@
 --- !ruby/object:Gem::Specification
 name: warder
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Yura Tolstik
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-26 00:00:00.000000000 Z
+date: 2014-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.18'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.18'
 - !ruby/object:Gem::Dependency
   name: reek
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.6
+        version: '1.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.6
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: flay
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: '2.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: '2.4'
 - !ruby/object:Gem::Dependency
   name: flog
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: mago
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: '0.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: '0.1'
 - !ruby/object:Gem::Dependency
   name: brakeman
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.1
+        version: '2.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.1
+        version: '2.4'
 - !ruby/object:Gem::Dependency
   name: rails_best_practices
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.14.4
+        version: '1.15'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.14.4
+        version: '1.15'
 - !ruby/object:Gem::Dependency
   name: sandi_meter
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.5
+        version: '1.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.5
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: bundler-audit
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: '0.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: '0.3'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -154,72 +154,72 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0.beta1
+        version: '2.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0.beta1
+        version: '2.14'
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: aruba
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.8'
 description: Warder of ruby code
 email:
 - yltsrc@gmail.com
@@ -275,13 +275,12 @@ files:
 - lib/warder/sandi_rules_runner.rb
 - lib/warder/style_guide_runner.rb
 - lib/warder/version.rb
-- spec/fixtures/invalid_Gemfile
-- spec/fixtures/invalid_Gemfile.lock
 - spec/fixtures/invalid_code_complexity.rb
 - spec/fixtures/invalid_code_duplication.rb
 - spec/fixtures/invalid_code_smells.rb
 - spec/fixtures/invalid_magick_numbers.rb
 - spec/fixtures/invalid_rails_app/Gemfile
+- spec/fixtures/invalid_rails_app/Gemfile_lock
 - spec/fixtures/invalid_rails_app/Rakefile
 - spec/fixtures/invalid_rails_app/app/controllers/application_controller.rb
 - spec/fixtures/invalid_rails_app/app/models/user.rb
@@ -303,12 +302,13 @@ files:
 - spec/fixtures/invalid_rails_app/config/initializers/wrap_parameters.rb
 - spec/fixtures/invalid_rails_app/config/locales/en.yml
 - spec/fixtures/invalid_rails_app/config/routes.rb
+- spec/fixtures/invalid_rails_app/lib/invalid_code_complexity.rb
+- spec/fixtures/invalid_rails_app/lib/invalid_code_duplication.rb
 - spec/fixtures/invalid_style_guide.rb
 - spec/fixtures/strictly_invalid_style_guide.rb
 - spec/fixtures/valid.rb
-- spec/fixtures/valid_Gemfile
-- spec/fixtures/valid_Gemfile.lock
 - spec/fixtures/valid_rails_app/Gemfile
+- spec/fixtures/valid_rails_app/Gemfile_lock
 - spec/fixtures/valid_rails_app/Rakefile
 - spec/fixtures/valid_rails_app/app/controllers/application_controller.rb
 - spec/fixtures/valid_rails_app/app/views/layouts/application.html.erb
@@ -320,9 +320,7 @@ files:
 - spec/fixtures/valid_rails_app/config/environments/development.rb
 - spec/fixtures/valid_rails_app/config/environments/production.rb
 - spec/fixtures/valid_rails_app/config/environments/test.rb
-- spec/fixtures/valid_rails_app/config/initializers/backtrace_silencers.rb
 - spec/fixtures/valid_rails_app/config/initializers/filter_parameter_logging.rb
-- spec/fixtures/valid_rails_app/config/initializers/inflections.rb
 - spec/fixtures/valid_rails_app/config/initializers/mime_types.rb
 - spec/fixtures/valid_rails_app/config/initializers/secret_token.rb
 - spec/fixtures/valid_rails_app/config/initializers/session_store.rb
@@ -351,10 +349,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: Warder of ruby code
+summary: Tool to help improve the quality of ruby code
 test_files:
 - features/checks_for_all_issues.feature
 - features/checks_for_rails_best_practices.feature
@@ -381,13 +379,12 @@ test_files:
 - features/step_definitions/validates_style_guide_steps.rb
 - features/support/env.rb
 - features/validates_style_guide.feature
-- spec/fixtures/invalid_Gemfile
-- spec/fixtures/invalid_Gemfile.lock
 - spec/fixtures/invalid_code_complexity.rb
 - spec/fixtures/invalid_code_duplication.rb
 - spec/fixtures/invalid_code_smells.rb
 - spec/fixtures/invalid_magick_numbers.rb
 - spec/fixtures/invalid_rails_app/Gemfile
+- spec/fixtures/invalid_rails_app/Gemfile_lock
 - spec/fixtures/invalid_rails_app/Rakefile
 - spec/fixtures/invalid_rails_app/app/controllers/application_controller.rb
 - spec/fixtures/invalid_rails_app/app/models/user.rb
@@ -409,12 +406,13 @@ test_files:
 - spec/fixtures/invalid_rails_app/config/initializers/wrap_parameters.rb
 - spec/fixtures/invalid_rails_app/config/locales/en.yml
 - spec/fixtures/invalid_rails_app/config/routes.rb
+- spec/fixtures/invalid_rails_app/lib/invalid_code_complexity.rb
+- spec/fixtures/invalid_rails_app/lib/invalid_code_duplication.rb
 - spec/fixtures/invalid_style_guide.rb
 - spec/fixtures/strictly_invalid_style_guide.rb
 - spec/fixtures/valid.rb
-- spec/fixtures/valid_Gemfile
-- spec/fixtures/valid_Gemfile.lock
 - spec/fixtures/valid_rails_app/Gemfile
+- spec/fixtures/valid_rails_app/Gemfile_lock
 - spec/fixtures/valid_rails_app/Rakefile
 - spec/fixtures/valid_rails_app/app/controllers/application_controller.rb
 - spec/fixtures/valid_rails_app/app/views/layouts/application.html.erb
@@ -426,9 +424,7 @@ test_files:
 - spec/fixtures/valid_rails_app/config/environments/development.rb
 - spec/fixtures/valid_rails_app/config/environments/production.rb
 - spec/fixtures/valid_rails_app/config/environments/test.rb
-- spec/fixtures/valid_rails_app/config/initializers/backtrace_silencers.rb
 - spec/fixtures/valid_rails_app/config/initializers/filter_parameter_logging.rb
-- spec/fixtures/valid_rails_app/config/initializers/inflections.rb
 - spec/fixtures/valid_rails_app/config/initializers/mime_types.rb
 - spec/fixtures/valid_rails_app/config/initializers/secret_token.rb
 - spec/fixtures/valid_rails_app/config/initializers/session_store.rb

data/spec/fixtures/invalid_Gemfile

@@ -1,3 +0,0 @@
-source 'http://rubygems.org'
-
-gem 'activesupport', '3.2.10'

data/spec/fixtures/invalid_Gemfile.lock

@@ -1,14 +0,0 @@
-GEM
-  remote: http://rubygems.org/
-  specs:
-    activesupport (3.2.10)
-      i18n (~> 0.6)
-      multi_json (~> 1.0)
-    i18n (0.6.9)
-    multi_json (1.8.2)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activesupport (= 3.2.10)

data/spec/fixtures/valid_Gemfile

@@ -1 +0,0 @@
-source 'https://rubygems.org'

data/spec/fixtures/valid_Gemfile.lock

@@ -1,8 +0,0 @@
-GEM
-  remote: https://rubygems.org/
-  specs:
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES

data/spec/fixtures/valid_rails_app/config/initializers/backtrace_silencers.rb

@@ -1,7 +0,0 @@
-# Be sure to restart your server when you modify this file.
-
-# You can add backtrace silencers for libraries that you're using but don't wish to see in your backtraces.
-# Rails.backtrace_cleaner.add_silencer { |line| line =~ /my_noisy_library/ }
-
-# You can also remove all the silencers if you're trying to debug a problem that might stem from framework code.
-# Rails.backtrace_cleaner.remove_silencers!

data/spec/fixtures/valid_rails_app/config/initializers/inflections.rb

@@ -1,16 +0,0 @@
-# Be sure to restart your server when you modify this file.
-
-# Add new inflection rules using the following format. Inflections
-# are locale specific, and you may define rules for as many different
-# locales as you wish. All of these examples are active by default:
-# ActiveSupport::Inflector.inflections(:en) do |inflect|
-#   inflect.plural /^(ox)$/i, '\1en'
-#   inflect.singular /^(ox)en/i, '\1'
-#   inflect.irregular 'person', 'people'
-#   inflect.uncountable %w( fish sheep )
-# end
-
-# These inflection rules are supported but not enabled by default:
-# ActiveSupport::Inflector.inflections(:en) do |inflect|
-#   inflect.acronym 'RESTful'
-# end