warder 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b03990a126c35737b97b3150aa66006778a705a6
-  data.tar.gz: 87f1978be044393d4036df203d358ca1c98b9bb4
+  metadata.gz: 8fc3f7ef42e9897e30fe070ae20376ec610ef3e4
+  data.tar.gz: f8d04d91d316a1bd1b6b6318cb9d04231a00b8f5
 SHA512:
-  metadata.gz: ca3a0d169d92a065fe327d9b0db4fcaed69203d717b0258eedc4a6787900511039bfb0e011c65b0d75bb37fe3e22ee2427fcfa3f77b7f58966720d835502b315
-  data.tar.gz: db3a88db71e0142b8bc2f4a899cda5e90abe47b58ef7a54df085b5c5f240d29ad8ad2a090ed0c805320488a1d2aff0b37585479ca6050cdfdeb1bd68146784d4
+  metadata.gz: b00b71994d9e5af8d39cf5634bb91c80c26ae7a9554f93c96c807b3839ba9104e41571081abde3cee0cdef33c1662feae0bff756829bb9455aa13522595a5efc
+  data.tar.gz: d8105384af5092c059ae96aa48f207f07355704061da94af94a94b3ee8f46e04e76b0298a46bdc732322ab6f2cec803ba6827224a0b01861c7bbacf45adc7d17

data/features/checks_for_rails_best_practices.feature

@@ -1,5 +1,5 @@
-Feature: checks for rails related security issues
-  In order to find security issues
+Feature: checks for rails best practices advices
+  In order to get rails advices
   As a ruby developer
   I want to run warder with --rails-advice option
 

data/features/checks_for_sandi_metz_rules.feature

@@ -0,0 +1,25 @@
+Feature: checks for Sandi Metz rules violations
+  In order to find Sandi Metz rules violations
+  As a ruby developer
+  I want to run warder with --sandi-rules option
+
+  Scenario: run warder with enabled sandi rules option
+    Given I have valid_rails_app project in directory
+    And I am on project directory
+    When I run `warder --sandi-rules`
+    Then warder detects sandi rules violations
+    Then the exit status should be 0
+
+  Scenario: run warder with enabled sandi rules option on invalid project
+    Given I have invalid_rails_app project in directory
+    And I am on project directory
+    When I run `warder --sandi-rules`
+    Then warder detects sandi rules violations
+    Then the exit status should be 1
+
+  Scenario: run warder with disabled sandi rules option on invalid project
+    Given I have invalid_rails_app project in directory
+    And I am on project directory
+    When I run `warder --no-sandi-rules`
+    Then warder does nothing
+    Then the exit status should be 0

data/features/step_definitions/checks_for_sandi_metz_rules_step.rb

@@ -0,0 +1,7 @@
+def executing_sandi_rules
+  "executing 'sandi_meter -d -p .'"
+end
+
+def sandi_rules_output
+  `cd tmp/aruba/#{@projectname}/ && sandi_meter -d -p .`
+end

data/features/step_definitions/run_steps.rb

@@ -16,7 +16,7 @@ Then(/^warder does nothing$/) do
   step 'the output should match /.{0}/'
 end
 
-Then(/^warder detects (.+) issues$/) do |what|
+Then(/^warder detects (.+) (issues|violations)$/) do |what, _|
   executing_output = send(:"executing_#{what.gsub(' ', '_')}")
   step "the output should contain \"#{executing_output}\""
 

data/lib/warder.rb

@@ -8,6 +8,7 @@ require 'warder/code_smells_runner'
 require 'warder/code_complexity_runner'
 require 'warder/rails_security_runner'
 require 'warder/rails_advice_runner'
+require 'warder/sandi_rules_runner'
 require 'warder/bundle_audit_runner'
 require 'warder/cli/arguments'
 require 'warder/cli'

data/lib/warder/runner.rb

@@ -2,6 +2,7 @@ module Warder
   # abstract class for command runners
   class Runner
     SCORE = 30
+    FAILURE_THRESHOLD = 0
 
     def initialize(stdout, options = {})
       @stdout = stdout
@@ -31,8 +32,9 @@ module Warder
     end
 
     def failed?(line)
-      match = self.class::FAILURE_REGEXP.match(line)
-      match && match[1].to_i != 0
+      klass = self.class
+      match = klass::FAILURE_REGEXP.match(line)
+      match && match[1].to_i != klass::FAILURE_THRESHOLD
     end
 
     def printable?(*)

data/lib/warder/sandi_rules_runner.rb

@@ -0,0 +1,18 @@
+module Warder
+  # responsible for run Sandi Metz rules validation
+  class SandiRulesRunner < Runner
+    CLI_OPTION = 'r'
+    CLI_FULL_OPTION = 'sandi-rules'
+    DESCRIPTION = 'Run Sandi Metz rules validation'
+    COMMAND_NAME = 'sandi_meter'
+    FAILURE_REGEXP = /\d\. (\d+)%/
+    FAILURE_THRESHOLD = 100
+
+    private
+
+    def command_with_options
+      path = @options.files.split(' ').first
+      "#{COMMAND_NAME} -d -p #{path}"
+    end
+  end
+end

data/lib/warder/version.rb

@@ -1,4 +1,4 @@
 # define warder version
 module Warder
-  VERSION = '0.1.4'
+  VERSION = '0.1.5'
 end

data/spec/fixtures/invalid_rails_app/app/controllers/application_controller.rb

@@ -4,6 +4,12 @@ class ApplicationController < ActionController::Base
   protect_from_forgery with: :exception
 
   def welcome
-
+    @user = User.new(params[:first_name], params[:last_name], params[:email], params[:password], params[:password_confirmation])
+    if @user
+      @logged_in = true
+      render text: "Hello #{@user.full_name}!"
+    else
+      render text: "Hello Anonymous!"
+    end
   end
 end

data/spec/fixtures/invalid_rails_app/app/models/user.rb

@@ -0,0 +1,5 @@
+User < Struct.new(:first_name, :last_name, :email, :password, :password_confirmation) do
+  def full_name
+    [first_name, last_name].join(' ')
+  end
+end

data/warder.gemspec

@@ -26,8 +26,8 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'mago'
   spec.add_dependency 'brakeman'
   spec.add_dependency 'rails_best_practices'
+  spec.add_dependency 'sandi_meter'
   spec.add_dependency 'bundler-audit'
-  # spec.add_dependency 'sandi_meter'
 
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: warder
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Yura Tolstik
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-11 00:00:00.000000000 Z
+date: 2014-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -122,6 +122,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: sandi_meter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler-audit
   requirement: !ruby/object:Gem::Requirement
@@ -238,6 +252,7 @@ files:
 - cucumber.yml
 - features/checks_for_rails_best_practices.feature
 - features/checks_for_rails_security_issues.feature
+- features/checks_for_sandi_metz_rules.feature
 - features/checks_for_vulnerable_gems.feature
 - features/detects_code_complexity.feature
 - features/detects_code_duplication.feature
@@ -247,6 +262,7 @@ files:
 - features/show_version.feature
 - features/step_definitions/checks_for_rails_best_practices_steps.rb
 - features/step_definitions/checks_for_rails_security_issues_steps.rb
+- features/step_definitions/checks_for_sandi_metz_rules_step.rb
 - features/step_definitions/checks_for_vulnerable_gems_steps.rb
 - features/step_definitions/detects_code_complexity_steps.rb
 - features/step_definitions/detects_code_duplication_steps.rb
@@ -268,6 +284,7 @@ files:
 - lib/warder/rails_advice_runner.rb
 - lib/warder/rails_security_runner.rb
 - lib/warder/runner.rb
+- lib/warder/sandi_rules_runner.rb
 - lib/warder/style_guide_runner.rb
 - lib/warder/version.rb
 - spec/fixtures/invalid_Gemfile
@@ -279,6 +296,7 @@ files:
 - spec/fixtures/invalid_rails_app/Gemfile
 - spec/fixtures/invalid_rails_app/Rakefile
 - spec/fixtures/invalid_rails_app/app/controllers/application_controller.rb
+- spec/fixtures/invalid_rails_app/app/models/user.rb
 - spec/fixtures/invalid_rails_app/app/views/layouts/application.html.erb
 - spec/fixtures/invalid_rails_app/config.ru
 - spec/fixtures/invalid_rails_app/config/application.rb
@@ -352,6 +370,7 @@ summary: Warder of ruby code
 test_files:
 - features/checks_for_rails_best_practices.feature
 - features/checks_for_rails_security_issues.feature
+- features/checks_for_sandi_metz_rules.feature
 - features/checks_for_vulnerable_gems.feature
 - features/detects_code_complexity.feature
 - features/detects_code_duplication.feature
@@ -361,6 +380,7 @@ test_files:
 - features/show_version.feature
 - features/step_definitions/checks_for_rails_best_practices_steps.rb
 - features/step_definitions/checks_for_rails_security_issues_steps.rb
+- features/step_definitions/checks_for_sandi_metz_rules_step.rb
 - features/step_definitions/checks_for_vulnerable_gems_steps.rb
 - features/step_definitions/detects_code_complexity_steps.rb
 - features/step_definitions/detects_code_duplication_steps.rb
@@ -380,6 +400,7 @@ test_files:
 - spec/fixtures/invalid_rails_app/Gemfile
 - spec/fixtures/invalid_rails_app/Rakefile
 - spec/fixtures/invalid_rails_app/app/controllers/application_controller.rb
+- spec/fixtures/invalid_rails_app/app/models/user.rb
 - spec/fixtures/invalid_rails_app/app/views/layouts/application.html.erb
 - spec/fixtures/invalid_rails_app/config.ru
 - spec/fixtures/invalid_rails_app/config/application.rb