warder 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 113fd7d19ada4fb760793d5c72fd0c3e739653e7
-  data.tar.gz: bdc5fb0e9de6c1bf0c5a5bbdef4f7427c29f798a
+  metadata.gz: b03990a126c35737b97b3150aa66006778a705a6
+  data.tar.gz: 87f1978be044393d4036df203d358ca1c98b9bb4
 SHA512:
-  metadata.gz: 199fb858d92abff4390d4691616134ab2818816eeeaa67a5739e32074e253c1a704e35dada071a84d084b6f1bd20a952a36289daf4795b7ca376937e5ecb8c14
-  data.tar.gz: f07d90d73cf49617f9d7bff699fe16e3307cddcdaabb86bf6606914553f8cb02dec510f2224ff039d00be7be81ba0076efc3406277b172a87dabc131cf8991e1
+  metadata.gz: ca3a0d169d92a065fe327d9b0db4fcaed69203d717b0258eedc4a6787900511039bfb0e011c65b0d75bb37fe3e22ee2427fcfa3f77b7f58966720d835502b315
+  data.tar.gz: db3a88db71e0142b8bc2f4a899cda5e90abe47b58ef7a54df085b5c5f240d29ad8ad2a090ed0c805320488a1d2aff0b37585479ca6050cdfdeb1bd68146784d4

data/features/checks_for_rails_best_practices.feature

@@ -0,0 +1,25 @@
+Feature: checks for rails related security issues
+  In order to find security issues
+  As a ruby developer
+  I want to run warder with --rails-advice option
+
+  Scenario: run warder with enabled rails advice option
+    Given I have valid_rails_app project in directory
+    And I am on project directory
+    When I run `warder --rails-advice`
+    Then warder detects rails best practices issues
+    Then the exit status should be 0
+
+  Scenario: run warder with enabled rails advice option on invalid project
+    Given I have invalid_rails_app project in directory
+    And I am on project directory
+    When I run `warder --rails-advice`
+    Then warder detects rails best practices issues
+    Then the exit status should be 1
+
+  Scenario: run warder with disabled rails advice option on invalid project
+    Given I have invalid_rails_app project in directory
+    And I am on project directory
+    When I run `warder --no-rails-advice`
+    Then warder does nothing
+    Then the exit status should be 0

data/features/step_definitions/checks_for_rails_best_practices_steps.rb

@@ -0,0 +1,11 @@
+def rails_best_practices_cmd
+  'rails_best_practices --silent --spec --test --features .'
+end
+
+def executing_rails_best_practices
+  "executing '#{rails_best_practices_cmd}'"
+end
+
+def rails_best_practices_output
+  `cd tmp/aruba/#{@projectname}/ && #{rails_best_practices_cmd}`
+end

data/features/step_definitions/run_steps.rb

@@ -17,10 +17,10 @@ Then(/^warder does nothing$/) do
 end
 
 Then(/^warder detects (.+) issues$/) do |what|
-  executing_output = send(:"executing_#{what.sub(' ', '_')}")
+  executing_output = send(:"executing_#{what.gsub(' ', '_')}")
   step "the output should contain \"#{executing_output}\""
 
-  validation_output = send(:"#{what.sub(' ', '_')}_output")
+  validation_output = send(:"#{what.gsub(' ', '_')}_output")
   validation_output.split("\n").each do |string|
     step "the output should contain \"#{string}\""
   end

data/lib/warder.rb

@@ -7,6 +7,7 @@ require 'warder/code_duplication_runner'
 require 'warder/code_smells_runner'
 require 'warder/code_complexity_runner'
 require 'warder/rails_security_runner'
+require 'warder/rails_advice_runner'
 require 'warder/bundle_audit_runner'
 require 'warder/cli/arguments'
 require 'warder/cli'

data/lib/warder/rails_advice_runner.rb

@@ -0,0 +1,17 @@
+module Warder
+  # responsible for run rails best practices validation
+  class RailsAdviceRunner < Runner
+    CLI_OPTION = 'a'
+    CLI_FULL_OPTION = 'rails-advice'
+    DESCRIPTION = 'Run rails best practices validation'
+    COMMAND_NAME = 'rails_best_practices'
+    FAILURE_REGEXP = /Found (\d+) warnings?/
+
+    private
+
+    def command_with_options
+      path = @options.files.split(' ').first
+      "#{COMMAND_NAME} --silent --spec --test --features #{path}"
+    end
+  end
+end

data/lib/warder/rails_security_runner.rb

@@ -3,7 +3,7 @@ module Warder
   class RailsSecurityRunner < Runner
     CLI_OPTION = 'i'
     CLI_FULL_OPTION = 'rails-security'
-    DESCRIPTION = 'Run magick numbers validation'
+    DESCRIPTION = 'Run rails security validation'
     COMMAND_NAME = 'brakeman'
     FAILURE_REGEXP = /^\| Security Warnings \| (\d)+/
     PRINTABLE_REGEXP = /^(\+|\||View Warnings:)/

data/lib/warder/version.rb

@@ -1,4 +1,4 @@
 # define warder version
 module Warder
-  VERSION = '0.1.3'
+  VERSION = '0.1.4'
 end

data/spec/fixtures/invalid_rails_app/app/controllers/application_controller.rb

@@ -2,4 +2,8 @@ class ApplicationController < ActionController::Base
   # Prevent CSRF attacks by raising an exception.
   # For APIs, you may want to use :null_session instead.
   protect_from_forgery with: :exception
+
+  def welcome
+
+  end
 end

data/spec/fixtures/invalid_rails_app/config/routes.rb

@@ -1,56 +1,5 @@
 Invalid::Application.routes.draw do
-  # The priority is based upon order of creation: first created -> highest priority.
-  # See how all your routes lay out with "rake routes".
 
-  # You can have the root of your site routed with "root"
-  # root 'welcome#index'
+  root 'application#welcome'
 
-  # Example of regular route:
-  #   get 'products/:id' => 'catalog#view'
-
-  # Example of named route that can be invoked with purchase_url(id: product.id)
-  #   get 'products/:id/purchase' => 'catalog#purchase', as: :purchase
-
-  # Example resource route (maps HTTP verbs to controller actions automatically):
-  #   resources :products
-
-  # Example resource route with options:
-  #   resources :products do
-  #     member do
-  #       get 'short'
-  #       post 'toggle'
-  #     end
-  #
-  #     collection do
-  #       get 'sold'
-  #     end
-  #   end
-
-  # Example resource route with sub-resources:
-  #   resources :products do
-  #     resources :comments, :sales
-  #     resource :seller
-  #   end
-
-  # Example resource route with more complex sub-resources:
-  #   resources :products do
-  #     resources :comments
-  #     resources :sales do
-  #       get 'recent', on: :collection
-  #     end
-  #   end
-  
-  # Example resource route with concerns:
-  #   concern :toggleable do
-  #     post 'toggle'
-  #   end
-  #   resources :posts, concerns: :toggleable
-  #   resources :photos, concerns: :toggleable
-
-  # Example resource route within a namespace:
-  #   namespace :admin do
-  #     # Directs /admin/products/* to Admin::ProductsController
-  #     # (app/controllers/admin/products_controller.rb)
-  #     resources :products
-  #   end
 end

data/spec/fixtures/valid_rails_app/Gemfile

@@ -1,3 +1,5 @@
 source 'https://rubygems.org'
 
-gem 'rails', '~> 4.0'
+gem 'rails', '~> 4.0.2'
+
+gem 'sqlite3'

data/spec/fixtures/valid_rails_app/config/routes.rb

@@ -1,56 +1,2 @@
 Valid::Application.routes.draw do
-  # The priority is based upon order of creation: first created -> highest priority.
-  # See how all your routes lay out with "rake routes".
-
-  # You can have the root of your site routed with "root"
-  # root 'welcome#index'
-
-  # Example of regular route:
-  #   get 'products/:id' => 'catalog#view'
-
-  # Example of named route that can be invoked with purchase_url(id: product.id)
-  #   get 'products/:id/purchase' => 'catalog#purchase', as: :purchase
-
-  # Example resource route (maps HTTP verbs to controller actions automatically):
-  #   resources :products
-
-  # Example resource route with options:
-  #   resources :products do
-  #     member do
-  #       get 'short'
-  #       post 'toggle'
-  #     end
-  #
-  #     collection do
-  #       get 'sold'
-  #     end
-  #   end
-
-  # Example resource route with sub-resources:
-  #   resources :products do
-  #     resources :comments, :sales
-  #     resource :seller
-  #   end
-
-  # Example resource route with more complex sub-resources:
-  #   resources :products do
-  #     resources :comments
-  #     resources :sales do
-  #       get 'recent', on: :collection
-  #     end
-  #   end
-  
-  # Example resource route with concerns:
-  #   concern :toggleable do
-  #     post 'toggle'
-  #   end
-  #   resources :posts, concerns: :toggleable
-  #   resources :photos, concerns: :toggleable
-
-  # Example resource route within a namespace:
-  #   namespace :admin do
-  #     # Directs /admin/products/* to Admin::ProductsController
-  #     # (app/controllers/admin/products_controller.rb)
-  #     resources :products
-  #   end
 end

data/warder.gemspec

@@ -25,9 +25,9 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'flog'
   spec.add_dependency 'mago'
   spec.add_dependency 'brakeman'
+  spec.add_dependency 'rails_best_practices'
   spec.add_dependency 'bundler-audit'
   # spec.add_dependency 'sandi_meter'
-  # spec.add_dependency 'rails_best_practices'
 
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: warder
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Yura Tolstik
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-07 00:00:00.000000000 Z
+date: 2014-01-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -108,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rails_best_practices
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler-audit
   requirement: !ruby/object:Gem::Requirement
@@ -222,7 +236,8 @@ files:
 - Rakefile
 - bin/warder
 - cucumber.yml
-- features/checks_for_rails_related_security_issues.feature
+- features/checks_for_rails_best_practices.feature
+- features/checks_for_rails_security_issues.feature
 - features/checks_for_vulnerable_gems.feature
 - features/detects_code_complexity.feature
 - features/detects_code_duplication.feature
@@ -230,6 +245,7 @@ files:
 - features/detects_magick_numbers.feature
 - features/run.feature
 - features/show_version.feature
+- features/step_definitions/checks_for_rails_best_practices_steps.rb
 - features/step_definitions/checks_for_rails_security_issues_steps.rb
 - features/step_definitions/checks_for_vulnerable_gems_steps.rb
 - features/step_definitions/detects_code_complexity_steps.rb
@@ -249,6 +265,7 @@ files:
 - lib/warder/code_duplication_runner.rb
 - lib/warder/code_smells_runner.rb
 - lib/warder/magick_numbers_runner.rb
+- lib/warder/rails_advice_runner.rb
 - lib/warder/rails_security_runner.rb
 - lib/warder/runner.rb
 - lib/warder/style_guide_runner.rb
@@ -328,12 +345,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0.rc.1
+rubygems_version: 2.2.1
 signing_key: 
 specification_version: 4
 summary: Warder of ruby code
 test_files:
-- features/checks_for_rails_related_security_issues.feature
+- features/checks_for_rails_best_practices.feature
+- features/checks_for_rails_security_issues.feature
 - features/checks_for_vulnerable_gems.feature
 - features/detects_code_complexity.feature
 - features/detects_code_duplication.feature
@@ -341,6 +359,7 @@ test_files:
 - features/detects_magick_numbers.feature
 - features/run.feature
 - features/show_version.feature
+- features/step_definitions/checks_for_rails_best_practices_steps.rb
 - features/step_definitions/checks_for_rails_security_issues_steps.rb
 - features/step_definitions/checks_for_vulnerable_gems_steps.rb
 - features/step_definitions/detects_code_complexity_steps.rb