warder 0.0.5 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fc8cbd6a237c8d556bc4687b9b60e9e15f85f949
-  data.tar.gz: 2a924aac4f06f29fc2b0d4316d0be2bfb9781985
+  metadata.gz: 2a3b747efc10322afbbab18ffee926e8f295d49e
+  data.tar.gz: 2e19acd6acafa06d5dbbb0fb2239c9481fa2198d
 SHA512:
-  metadata.gz: 2db930a7f422e391811b59e8af1fc81ae3aa4b348887f7339550f819ccf567122570ac906de866e46cced52a8c1ffc23b956c70c6e78d32f4b2fe9dbcaab35c8
-  data.tar.gz: 70a4af9fe6971c9587db930cd7d6bb24fa29dc77a8a69e1b3e7cc6b0e867cecc3f13e2d7f36e12769184375943b5ff4f5b2a1de7bbca61b628e80b57952e8a46
+  metadata.gz: 2833211ec3ab3c9b7b0eb0e9cbd15f78a1efed8b0b0177059cb177fbb655fb8ce53ce7d31dbfd3444bf808af414f35d6e1444fc6695e0f4145f8eeace923ab4c
+  data.tar.gz: 56bb3aa2d6837e463ae48f7128c4b1dd70931a65ac83b6d9f21a300aae0e3f6e0a767aa7e5ba339c65a353880ce343c8ace60559236b6dc53dfeec1604d511fd

data/bin/warder

@@ -7,6 +7,8 @@ require 'warder'
 
 options = {}
 OptionParser.new do |opts|
+  opts.banner = "Usage: warder [options] [dir1 file1 file2 ...]"
+
   desc = 'Run style guide validation'
   opts.on('-g', '--[no-]style-guide', desc) do |value|
     options[:style_guide] = value
@@ -18,14 +20,26 @@ OptionParser.new do |opts|
   end
 
   desc = 'Run code duplication validation'
-  opts.on('-d', '--[no-]code-duplications', desc) do |value|
-    options[:code_duplications] = value
+  opts.on('-d', '--[no-]code-duplication', desc) do |value|
+    options[:code_duplication] = value
   end
 
   desc = 'Run code smells validation'
   opts.on('-s', '--[no-]code-smells', desc) do |value|
     options[:code_smells] = value
   end
+
+  desc = 'Run code complexity validation'
+  opts.on('-c', '--[no-]code-complexity', desc) do |value|
+    options[:code_complexity] = value
+  end
+
+  opts.on('-v', '--version', 'Show version') do |value|
+    puts Warder::VERSION
+    exit 0
+  end
 end.parse!
 
+options[:files] = ARGV.join(' ')
+
 Warder::CLI.new(options).perform

data/cucumber.yml

@@ -1,4 +1,4 @@
-<% std_opts = "--format 'pretty'" %>
+<% std_opts = "--color --format 'pretty'" %>
 default: <%= std_opts %> --strict features
-ok: <%= std_opts %> --no-color --strict --tags ~@wip features
+ok: <%= std_opts %> --strict --tags ~@wip features
 wip: <%= std_opts %> --tags @wip:1 --wip features

data/features/detects_code_complexity.feature

@@ -0,0 +1,30 @@
+Feature: detects code complexity
+  In order to find code complexity
+  As a ruby developer
+  I want to run warder with --code-complexity option
+
+  Scenario: run warder with enabled code complexity option
+    Given I have valid file in directory
+    When I run `warder --code-complexity`
+    Then warder detects code complexity
+    Then the exit status should be 0
+
+  Scenario: run warder with enabled code complexity option on invalid file
+    Given I have invalid_code_complexity file in directory
+    When I run `warder --code-complexity`
+    Then warder detects code complexity
+    Then the exit status should be 1
+
+  Scenario: run warder with enabled code complexity option on valid file only
+    Given I have valid file in directory
+    And I have invalid_code_complexity file in directory
+    When I run `warder --code-complexity valid.rb`
+    Then warder does nothing
+    Then the exit status should be 0
+
+  Scenario: run warder with disabled code complexity option on invalid file
+    Given I have invalid_code_complexity file in directory
+    When I run `warder --no-code-complexity`
+    Then warder does nothing
+    Then the exit status should be 0
+

data/features/detects_code_duplication.feature

@@ -0,0 +1,29 @@
+Feature: detects code duplication
+  In order to find code duplication
+  As a ruby developer
+  I want to run warder with --code-duplication option
+
+  Scenario: run warder with enabled code duplication option
+    Given I have valid file in directory
+    When I run `warder --code-duplication`
+    Then warder detects code duplication
+    Then the exit status should be 0
+
+  Scenario: run warder with enabled code duplication option on invalid file
+    Given I have invalid_code_duplication file in directory
+    When I run `warder --code-duplication`
+    Then warder detects code duplication
+    Then the exit status should be 1
+
+  Scenario: run warder with enabled code duplication option on valid file only
+    Given I have valid file in directory
+    And I have invalid_code_duplication file in directory
+    When I run `warder --code-duplication valid.rb`
+    Then warder does nothing
+    Then the exit status should be 0
+
+  Scenario: run warder with disabled code duplication option on invalid file
+    Given I have invalid_code_duplication file in directory
+    When I run `warder --no-code-duplication`
+    Then warder does nothing
+    Then the exit status should be 0

data/features/detects_code_smells.feature

@@ -15,6 +15,13 @@ Feature: detects code smells
     Then warder detects code smells
     Then the exit status should be 1
 
+  Scenario: run warder with enabled code smells option on valid file only
+    Given I have valid file in directory
+    And I have invalid_code_smells file in directory
+    When I run `warder --code-smells valid.rb`
+    Then warder does nothing
+    Then the exit status should be 0
+
   Scenario: run warder with disabled code smells option on invalid file
     Given I have invalid_code_smells file in directory
     When I run `warder --no-code-smells`

data/features/detects_magick_numbers.feature

@@ -15,6 +15,13 @@ Feature: detects magick numbers
     Then warder detects magick numbers
     Then the exit status should be 1
 
+  Scenario: run warder with enabled magick numbers option on valid file only
+    Given I have valid file in directory
+    And I have invalid_magick_numbers file in directory
+    When I run `warder --magick-numbers valid.rb`
+    Then warder does nothing
+    Then the exit status should be 0
+
   Scenario: run warder with disabled style guide option on invalid file
     Given I have invalid_magick_numbers file in directory
     When I run `warder --no-magick-numbers`

data/features/show_version.feature

@@ -0,0 +1,8 @@
+Feature: show version
+  In order to check program version
+  I want to run warder with --version option
+
+  Scenario: run warder with enabled version option
+    When I run `warder --version`
+    Then warder shows version
+    And the exit status should be 0

data/features/step_definitions/detects_code_complexity_steps.rb

@@ -0,0 +1,8 @@
+Then(/^warder detects code complexity$/) do
+  executing_flog_output = "executing 'flog -a -c -g -m .'"
+  success_flog_output = `cd spec/fixtures/ && flog  -a -c -g -m ./#{@filename}`
+  step "the output should contain \"#{executing_flog_output}\""
+  success_flog_output.split("\n").each do |string|
+    step "the output should contain \"#{string}\""
+  end
+end

data/features/step_definitions/detects_code_duplication_steps.rb

@@ -0,0 +1,8 @@
+Then(/^warder detects code duplication$/) do
+  executing_flay_output = "executing 'flay -d -m 15 .'"
+  success_flay_output = `cd spec/fixtures/ && flay -d ./#{@filename}`
+  step "the output should contain \"#{executing_flay_output}\""
+  success_flay_output.split("\n").each do |string|
+    step "the output should contain \"#{string}\""
+  end
+end

data/features/step_definitions/detects_code_smells_steps.rb

@@ -3,6 +3,6 @@ Then(/^warder detects code smells$/) do
   success_reek_output = `cd spec/fixtures/ && reek #{@filename}`
   step "the output should contain \"#{executing_reek_output}\""
   success_reek_output.split("\n").each do |string|
-    step "the output should contain \"#{string.sub('spec/fixtures/', './')}\""
+    step "the output should contain \"#{string}\""
   end
 end

data/features/step_definitions/detects_magick_numbers_steps.rb

@@ -1,8 +1,8 @@
 Then(/^warder detects magick numbers$/) do
-  executing_mago_output = "executing 'mago'"
-  success_mago_output = `mago spec/fixtures/#{@filename}`
+  executing_mago_output = "executing 'mago .'"
+  success_mago_output = `cd spec/fixtures/ && mago #{@filename}`
   step "the output should contain \"#{executing_mago_output}\""
   success_mago_output.split("\n").each do |string|
-    step "the output should contain \"#{string.sub('spec/fixtures/', './')}\""
+    step "the output should contain \"#{string}\""
   end
 end

data/features/step_definitions/show_version_steps.rb

@@ -0,0 +1,3 @@
+Then(/^warder shows version$/) do
+  step "the output should contain \"#{Warder::VERSION}\""
+end

data/features/step_definitions/validates_style_guide_steps.rb

@@ -1,6 +1,8 @@
 Then(/^warder validates style guide$/) do
-  executing_rubocop_output = "executing 'rubocop'"
-  success_rubocop_output = `rubocop spec/fixtures/#{@filename} | grep offence`
+  executing_rubocop_output = "executing 'rubocop .'"
+  success_rubocop_output = `cd spec/fixtures/ && rubocop #{@filename}`
   step "the output should contain \"#{executing_rubocop_output}\""
-  step "the output should contain \"#{success_rubocop_output}\""
+  success_rubocop_output.split("\n").each do |string|
+    step "the output should contain \"#{string}\""
+  end
 end

data/features/validates_style_guide.feature

@@ -15,6 +15,13 @@ Feature: check style guide
     Then warder validates style guide
     Then the exit status should be 1
 
+  Scenario: run warder with enabled style guide option on valid file only
+    Given I have valid file in directory
+    And I have invalid_style_guide file in directory
+    When I run `warder --style-guide valid.rb`
+    Then warder does nothing
+    Then the exit status should be 0
+
   Scenario: run warder with disabled style guide option on invalid file
     Given I have invalid_style_guide file in directory
     When I run `warder --no-style-guide`

data/lib/warder.rb

@@ -1,7 +1,9 @@
+require 'ostruct'
 require 'warder/version'
 require 'warder/runner'
 require 'warder/style_guide_runner'
 require 'warder/magick_numbers_runner'
-require 'warder/code_duplications_runner'
+require 'warder/code_duplication_runner'
 require 'warder/code_smells_runner'
+require 'warder/code_complexity_runner'
 require 'warder/cli'

data/lib/warder/cli.rb

@@ -2,20 +2,22 @@ module Warder
   # responsible for executing warder tools
   class CLI
     def initialize(options)
-      @options = options
+      options[:files] = '.' if options[:files].empty?
+      @options = OpenStruct.new(options)
     end
 
     def perform
       exit perform_style_guide_validation +
              perform_magick_numbers_validation +
-             perform_code_duplications_validation +
-             perform_code_smells_validation
+             perform_code_duplication_validation +
+             perform_code_smells_validation +
+             perform_code_complexity_validation
     end
 
     private
 
     def perform_style_guide_validation
-      if @options[:style_guide]
+      if @options.style_guide
         runner = StyleGuideRunner.new(@options)
         runner.perform
       else
@@ -24,7 +26,7 @@ module Warder
     end
 
     def perform_magick_numbers_validation
-      if @options[:magick_numbers]
+      if @options.magick_numbers
         runner = MagickNumbersRunner.new(@options)
         runner.perform
       else
@@ -32,9 +34,9 @@ module Warder
       end
     end
 
-    def perform_code_duplications_validation
-      if @options[:code_duplications]
-        runner = CodeDuplicationsRunner.new(@options)
+    def perform_code_duplication_validation
+      if @options.code_duplication
+        runner = CodeDuplicationRunner.new(@options)
         runner.perform
       else
         0
@@ -42,12 +44,21 @@ module Warder
     end
 
     def perform_code_smells_validation
-      if @options[:code_smells]
+      if @options.code_smells
         runner = CodeSmellsRunner.new(@options)
         runner.perform
       else
         0
       end
     end
+
+    def perform_code_complexity_validation
+      if @options.code_complexity
+        runner = CodeComplexityRunner.new(@options)
+        runner.perform
+      else
+        0
+      end
+    end
   end
 end

data/lib/warder/code_complexity_runner.rb

@@ -0,0 +1,22 @@
+module Warder
+  # responsible for run code complexity validation
+  class CodeComplexityRunner < Runner
+    FLOG_SCORE = SCORE
+
+    def initialize(options = {})
+      @options = options
+    end
+
+    private
+
+    def command
+      "flog -a -c -g -m #{@options.files}"
+    end
+
+    def failed?(line)
+      match = line.match(/^\s+(\d+.\d):\s+(.*)$/)
+
+      match && match[1].to_f > FLOG_SCORE && !match[2].match(/^flog/)
+    end
+  end
+end

data/lib/warder/{code_duplications_runner.rb → code_duplication_runner.rb}

@@ -1,6 +1,6 @@
 module Warder
-  # responsible for run code duplications validation
-  class CodeDuplicationsRunner < Runner
+  # responsible for run code duplication validation
+  class CodeDuplicationRunner < Runner
     FLAY_SCORE = SCORE / 2
 
     def initialize(options = {})
@@ -10,7 +10,7 @@ module Warder
     private
 
     def command
-      "flay -d -m #{FLAY_SCORE} ."
+      "flay -d -m #{FLAY_SCORE} #{@options.files}"
     end
 
     def failed?(line)

data/lib/warder/code_smells_runner.rb

@@ -8,7 +8,7 @@ module Warder
     private
 
     def command
-      'reek .'
+      "reek #{@options.files}"
     end
 
     def failed?(line)

data/lib/warder/magick_numbers_runner.rb

@@ -8,7 +8,7 @@ module Warder
     private
 
     def command
-      'mago'
+      "mago #{@options.files}"
     end
 
     def failed?(line)

data/lib/warder/style_guide_runner.rb

@@ -8,7 +8,7 @@ module Warder
     private
 
     def command
-      'rubocop'
+      "rubocop #{@options.files}"
     end
 
     def failed?(line)

data/lib/warder/version.rb

@@ -1,4 +1,4 @@
 # define warder version
 module Warder
-  VERSION = '0.0.5'
+  VERSION = '0.1.0'
 end

data/spec/fixtures/invalid_code_complexity.rb

@@ -0,0 +1,13 @@
+def a
+  b = 1 + 2 + 3 + 4 + 5
+  c = 6 + 7 + 8 + 9 + 0
+  d = 1 + 7 + 3 + 9 + 5
+  e = 6 + 2 + 8 + 4 + 0
+  f = 1 + 2 + 3 + 4 + 5
+  g = 6 + 7 + 8 + 9 + 0
+  h = 1 + 7 + 3 + 9 + 5
+  i = 6 + 2 + 8 + 4 + 0
+  j = b + c + d + e + f + g + h + i
+end
+
+puts a

data/warder.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'reek'
   spec.add_dependency 'flay'
   spec.add_dependency 'ruby2ruby'
-  # spec.add_dependency 'flog'
+  spec.add_dependency 'flog'
   spec.add_dependency 'mago'
 
   spec.add_development_dependency 'bundler', '~> 1.3'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: warder
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.1.0
 platform: ruby
 authors:
 - Yura Tolstik
@@ -66,6 +66,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: flog
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: mago
   requirement: !ruby/object:Gem::Requirement
@@ -166,26 +180,32 @@ files:
 - Rakefile
 - bin/warder
 - cucumber.yml
-- features/detects_code_duplications.feature
+- features/detects_code_complexity.feature
+- features/detects_code_duplication.feature
 - features/detects_code_smells.feature
 - features/detects_magick_numbers.feature
 - features/run.feature
-- features/step_definitions/detects_code_duplications_steps.rb
+- features/show_version.feature
+- features/step_definitions/detects_code_complexity_steps.rb
+- features/step_definitions/detects_code_duplication_steps.rb
 - features/step_definitions/detects_code_smells_steps.rb
 - features/step_definitions/detects_magick_numbers_steps.rb
 - features/step_definitions/run_steps.rb
+- features/step_definitions/show_version_steps.rb
 - features/step_definitions/validates_style_guide_steps.rb
 - features/support/env.rb
 - features/validates_style_guide.feature
 - lib/warder.rb
 - lib/warder/cli.rb
-- lib/warder/code_duplications_runner.rb
+- lib/warder/code_complexity_runner.rb
+- lib/warder/code_duplication_runner.rb
 - lib/warder/code_smells_runner.rb
 - lib/warder/magick_numbers_runner.rb
 - lib/warder/runner.rb
 - lib/warder/style_guide_runner.rb
 - lib/warder/version.rb
-- spec/fixtures/invalid_code_duplications.rb
+- spec/fixtures/invalid_code_complexity.rb
+- spec/fixtures/invalid_code_duplication.rb
 - spec/fixtures/invalid_code_smells.rb
 - spec/fixtures/invalid_magick_numbers.rb
 - spec/fixtures/invalid_style_guide.rb
@@ -218,18 +238,23 @@ signing_key:
 specification_version: 4
 summary: Warder of ruby code
 test_files:
-- features/detects_code_duplications.feature
+- features/detects_code_complexity.feature
+- features/detects_code_duplication.feature
 - features/detects_code_smells.feature
 - features/detects_magick_numbers.feature
 - features/run.feature
-- features/step_definitions/detects_code_duplications_steps.rb
+- features/show_version.feature
+- features/step_definitions/detects_code_complexity_steps.rb
+- features/step_definitions/detects_code_duplication_steps.rb
 - features/step_definitions/detects_code_smells_steps.rb
 - features/step_definitions/detects_magick_numbers_steps.rb
 - features/step_definitions/run_steps.rb
+- features/step_definitions/show_version_steps.rb
 - features/step_definitions/validates_style_guide_steps.rb
 - features/support/env.rb
 - features/validates_style_guide.feature
-- spec/fixtures/invalid_code_duplications.rb
+- spec/fixtures/invalid_code_complexity.rb
+- spec/fixtures/invalid_code_duplication.rb
 - spec/fixtures/invalid_code_smells.rb
 - spec/fixtures/invalid_magick_numbers.rb
 - spec/fixtures/invalid_style_guide.rb

data/features/detects_code_duplications.feature

@@ -1,22 +0,0 @@
-Feature: detects code duplications
-  In order to find code duplications
-  As a ruby developer
-  I want to run warder with --code-duplications option
-
-  Scenario: run warder with enabled code duplications option
-    Given I have valid file in directory
-    When I run `warder --code-duplications`
-    Then warder detects code duplications
-    Then the exit status should be 0
-
-  Scenario: run warder with enabled code duplications option on invalid file
-    Given I have invalid_code_duplications file in directory
-    When I run `warder --code-duplications`
-    Then warder detects code duplications
-    Then the exit status should be 1
-
-  Scenario: run warder with disabled code duplications option on invalid file
-    Given I have invalid_code_duplications file in directory
-    When I run `warder --no-code-duplications`
-    Then warder does nothing
-    Then the exit status should be 0

data/features/step_definitions/detects_code_duplications_steps.rb

@@ -1,8 +0,0 @@
-Then(/^warder detects code duplications$/) do
-  executing_flay_output = "executing 'flay -d -m 15 .'"
-  success_flay_output = `flay -d spec/fixtures/#{@filename}`
-  step "the output should contain \"#{executing_flay_output}\""
-  success_flay_output.split("\n").each do |string|
-    step "the output should contain \"#{string.sub('spec/fixtures/', './')}\""
-  end
-end