warder 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 08b7e90e5910c5193dada4ec370cb0bf223bb9cc
-  data.tar.gz: 09733b69ddd83cb5581aa008f879fe3d2d091a18
+  metadata.gz: fc8cbd6a237c8d556bc4687b9b60e9e15f85f949
+  data.tar.gz: 2a924aac4f06f29fc2b0d4316d0be2bfb9781985
 SHA512:
-  metadata.gz: e602f21426ba7133738b82db52db9d20aeed3cceb2cd68d1ba5a2921be9cec2a0e96a20db2a1e8aaf56b9b7fa70b1307bd24a68cbfa797f2bc08cbe726909bbd
-  data.tar.gz: 2cc2b364e1172bf40ff8e031bd1a8f176e4cd78d31bd32761bda300236b3d0f55646ca844867fe4f8176a22268c83c2dc06bb822707242322bd7d7d0c71cbbf7
+  metadata.gz: 2db930a7f422e391811b59e8af1fc81ae3aa4b348887f7339550f819ccf567122570ac906de866e46cced52a8c1ffc23b956c70c6e78d32f4b2fe9dbcaab35c8
+  data.tar.gz: 70a4af9fe6971c9587db930cd7d6bb24fa29dc77a8a69e1b3e7cc6b0e867cecc3f13e2d7f36e12769184375943b5ff4f5b2a1de7bbca61b628e80b57952e8a46

data/.travis.yml

@@ -0,0 +1,9 @@
+language: ruby
+rvm:
+  - 1.9.3
+  - 2.0.0
+  - 2.1.0
+gemfile:
+  - Gemfile
+script:
+  - bundle exec rake

data/README.md

@@ -1,5 +1,8 @@
 # Warder
 
+[![Travis CI](https://travis-ci.org/yltsrc/warder.png)](https://travis-ci.org/yltsrc/warder)
+[![Code Climate](https://codeclimate.com/github/yltsrc/warder.png)](https://codeclimate.com/github/yltsrc/warder)
+
 TODO: Write a gem description
 
 ## Installation

data/Rakefile

@@ -43,11 +43,11 @@ namespace :cucumber do
 end
 
 desc 'Alias for cucumber:ok'
-task :cucumber => 'cucumber:ok'
+task cucumber: 'cucumber:ok'
 
 desc 'Alias for spec:ok'
-task :spec => 'spec:ok'
+task spec: 'spec:ok'
 
-task :wip => %w(spec:wip cucumber:wip)
-task :all => %w(spec:all cucumber:all)
-task :default => %w(spec cucumber)
+task wip: %w(spec:wip cucumber:wip)
+task all: %w(spec:all cucumber:all)
+task default: %w(spec cucumber)

data/bin/warder

@@ -8,12 +8,12 @@ require 'warder'
 options = {}
 OptionParser.new do |opts|
   desc = 'Run style guide validation'
-  opts.on('-s', '--[no-]style-guide', desc) do |value|
+  opts.on('-g', '--[no-]style-guide', desc) do |value|
     options[:style_guide] = value
   end
 
   desc = 'Run magick numbers validation'
-  opts.on('-n', '--[no-]magick-numbers', desc) do |value|
+  opts.on('-m', '--[no-]magick-numbers', desc) do |value|
     options[:magick_numbers] = value
   end
 
@@ -21,6 +21,11 @@ OptionParser.new do |opts|
   opts.on('-d', '--[no-]code-duplications', desc) do |value|
     options[:code_duplications] = value
   end
+
+  desc = 'Run code smells validation'
+  opts.on('-s', '--[no-]code-smells', desc) do |value|
+    options[:code_smells] = value
+  end
 end.parse!
 
 Warder::CLI.new(options).perform

data/features/detects_code_duplications.feature

@@ -16,7 +16,7 @@ Feature: detects code duplications
     Then the exit status should be 1
 
   Scenario: run warder with disabled code duplications option on invalid file
-    Given I have invalid_magick_numbers file in directory
+    Given I have invalid_code_duplications file in directory
     When I run `warder --no-code-duplications`
     Then warder does nothing
     Then the exit status should be 0

data/features/detects_code_smells.feature

@@ -0,0 +1,22 @@
+Feature: detects code smells
+  In order to find code smells
+  As a ruby developer
+  I want to run warder with --code-smells option
+
+  Scenario: run warder with enabled code smells option
+    Given I have valid file in directory
+    When I run `warder --code-smells`
+    Then warder detects code smells
+    Then the exit status should be 0
+
+  Scenario: run warder with enabled code smells option on invalid file
+    Given I have invalid_code_smells file in directory
+    When I run `warder --code-smells`
+    Then warder detects code smells
+    Then the exit status should be 1
+
+  Scenario: run warder with disabled code smells option on invalid file
+    Given I have invalid_code_smells file in directory
+    When I run `warder --no-code-smells`
+    Then warder does nothing
+    Then the exit status should be 0

data/features/step_definitions/detects_code_smells_steps.rb

@@ -0,0 +1,8 @@
+Then(/^warder detects code smells$/) do
+  executing_reek_output = "executing 'reek .'"
+  success_reek_output = `cd spec/fixtures/ && reek #{@filename}`
+  step "the output should contain \"#{executing_reek_output}\""
+  success_reek_output.split("\n").each do |string|
+    step "the output should contain \"#{string.sub('spec/fixtures/', './')}\""
+  end
+end

data/lib/warder.rb

@@ -2,5 +2,6 @@ require 'warder/version'
 require 'warder/runner'
 require 'warder/style_guide_runner'
 require 'warder/magick_numbers_runner'
-require 'warder/code_duplication_runner'
+require 'warder/code_duplications_runner'
+require 'warder/code_smells_runner'
 require 'warder/cli'

data/lib/warder/cli.rb

@@ -6,8 +6,10 @@ module Warder
     end
 
     def perform
-      exit perform_style_guide_validation + perform_magick_numbers_validation +
-        perform_code_duplication_validation
+      exit perform_style_guide_validation +
+             perform_magick_numbers_validation +
+             perform_code_duplications_validation +
+             perform_code_smells_validation
     end
 
     private
@@ -30,9 +32,18 @@ module Warder
       end
     end
 
-    def perform_code_duplication_validation
+    def perform_code_duplications_validation
       if @options[:code_duplications]
-        runner = CodeDuplicationRunner.new(@options)
+        runner = CodeDuplicationsRunner.new(@options)
+        runner.perform
+      else
+        0
+      end
+    end
+
+    def perform_code_smells_validation
+      if @options[:code_smells]
+        runner = CodeSmellsRunner.new(@options)
         runner.perform
       else
         0

data/lib/warder/{code_duplication_runner.rb → code_duplications_runner.rb}

@@ -1,6 +1,6 @@
 module Warder
-  # responsible for run magick numbers validation
-  class CodeDuplicationRunner < Runner
+  # responsible for run code duplications validation
+  class CodeDuplicationsRunner < Runner
     FLAY_SCORE = SCORE / 2
 
     def initialize(options = {})

data/lib/warder/code_smells_runner.rb

@@ -0,0 +1,20 @@
+module Warder
+  # responsible for run code smells validation
+  class CodeSmellsRunner < Runner
+    def initialize(options = {})
+      @options = options
+    end
+
+    private
+
+    def command
+      'reek .'
+    end
+
+    def failed?(line)
+      match = line.match(/ -- (\d+) warnings?:/)
+
+      match && match[1].to_i != 0
+    end
+  end
+end

data/lib/warder/version.rb

@@ -1,4 +1,4 @@
 # define warder version
 module Warder
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'
 end

data/spec/fixtures/invalid_code_smells.rb

@@ -0,0 +1,4 @@
+def faild?(str)
+  match = str.match(/\d+/)
+  match && match[1].to_i != 0
+end

data/spec/fixtures/valid.rb

@@ -1 +1,2 @@
+# encoding: utf-8
 puts 'Hello world!'

data/warder.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'rubocop'
-  # spec.add_dependency 'reek'
+  spec.add_dependency 'reek'
   spec.add_dependency 'flay'
   spec.add_dependency 'ruby2ruby'
   # spec.add_dependency 'flog'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: warder
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Yura Tolstik
@@ -24,6 +24,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: reek
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: flay
   requirement: !ruby/object:Gem::Requirement
@@ -145,6 +159,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -152,9 +167,11 @@ files:
 - bin/warder
 - cucumber.yml
 - features/detects_code_duplications.feature
+- features/detects_code_smells.feature
 - features/detects_magick_numbers.feature
 - features/run.feature
 - features/step_definitions/detects_code_duplications_steps.rb
+- features/step_definitions/detects_code_smells_steps.rb
 - features/step_definitions/detects_magick_numbers_steps.rb
 - features/step_definitions/run_steps.rb
 - features/step_definitions/validates_style_guide_steps.rb
@@ -162,13 +179,14 @@ files:
 - features/validates_style_guide.feature
 - lib/warder.rb
 - lib/warder/cli.rb
-- lib/warder/code_duplication_runner.rb
+- lib/warder/code_duplications_runner.rb
+- lib/warder/code_smells_runner.rb
 - lib/warder/magick_numbers_runner.rb
 - lib/warder/runner.rb
 - lib/warder/style_guide_runner.rb
 - lib/warder/version.rb
-- rubocop-todo.yml
 - spec/fixtures/invalid_code_duplications.rb
+- spec/fixtures/invalid_code_smells.rb
 - spec/fixtures/invalid_magick_numbers.rb
 - spec/fixtures/invalid_style_guide.rb
 - spec/fixtures/strictly_invalid_style_guide.rb
@@ -201,15 +219,18 @@ specification_version: 4
 summary: Warder of ruby code
 test_files:
 - features/detects_code_duplications.feature
+- features/detects_code_smells.feature
 - features/detects_magick_numbers.feature
 - features/run.feature
 - features/step_definitions/detects_code_duplications_steps.rb
+- features/step_definitions/detects_code_smells_steps.rb
 - features/step_definitions/detects_magick_numbers_steps.rb
 - features/step_definitions/run_steps.rb
 - features/step_definitions/validates_style_guide_steps.rb
 - features/support/env.rb
 - features/validates_style_guide.feature
 - spec/fixtures/invalid_code_duplications.rb
+- spec/fixtures/invalid_code_smells.rb
 - spec/fixtures/invalid_magick_numbers.rb
 - spec/fixtures/invalid_style_guide.rb
 - spec/fixtures/strictly_invalid_style_guide.rb

data/rubocop-todo.yml

@@ -1,18 +0,0 @@
-# This configuration was generated by `rubocop --auto-gen-config`.
-# The point is for the user to remove these configuration records
-# one by one as the offences are removed from the code base.
-
-AssignmentInCondition:
-  Enabled: false
-
-Documentation:
-  Enabled: false
-
-EmptyLinesAroundBody:
-  Enabled: false
-
-IfUnlessModifier:
-  Enabled: false
-
-UselessAssignment:
-  Enabled: false