walmart_open 0.0.2 → 0.0.3

checksums.yaml

@@ -0,0 +1,15 @@
+---
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    NTAwODg3ZDIxMDFmYjVmZGRmMjFmOGYwOTk3NzQ3ODc1ZjVlYjU2Zg==
+  data.tar.gz: !binary |-
+    NmY5MTY3NmJkOTgwNGJkMDg1MDI4MWRkYWQwZTU3MzE5ODgyMzMwOQ==
+SHA512:
+  metadata.gz: !binary |-
+    NGI5M2EwMzhlZjRiZWNiNjVjYmY2ZjYxYjQzMWE1YjRjODVjNzg1ZGNlYmRi
+    YTA1YWUyMzE2YTAzZDI4NTI3Njk5OWM3YzYxYzc4MTkzM2Q2MDhjNGM5ZWYz
+    OWE3YmI5ZGRhMjZiMDFjMDgyNThjODQzZGQzNGQ0N2M1ZjQ3MGM=
+  data.tar.gz: !binary |-
+    Yjg0M2JiNWIyNzhkZmRjN2I5YTU0MDRjMWUwZjU1Y2JhMjU5Njk3YzQ3M2U4
+    ZGZjNTRhMDMwMWExZDNmY2NmYjFhM2UwYjIyYjNiZmJjOGQwNTZkNjU0MzUz
+    YTAzNGI0ZTI1ZDk4MDBjZDcxYmI3NzQ5ODkyMmY3ZTJhOTU0NDQ=

data/lib/walmart_open/order.rb

@@ -11,6 +11,10 @@ module WalmartOpen
                   :partner_order_id, :phone, :items
 
     def initialize(params)
+      params = params.each_with_object({}) do |pair, obj|
+        obj[pair.first.to_sym] = pair.last
+      end
+
       @shipping_address = nil
       @items = []
       @billing_id = params[:billing_id]

data/lib/walmart_open/shipping_address.rb

@@ -1,23 +1,21 @@
 module WalmartOpen
   class ShippingAddress
-    API_ATTRIBUTES_MAPPING = {
-        street1:  "street1",
-        street2:  "street2",
-        city:     "city",
-        state:    "state",
-        zipcode:  "zipcode",
-        country:  "country",
-    }
-
-    API_ATTRIBUTES_MAPPING.each_value do |attr_name|
-      attr_reader attr_name
-    end
-
-    attr_reader :raw_attributes
+    ATTRIBUTES = [
+        :street1,
+        :street2,
+        :city,
+        :state,
+        :zipcode,
+        :country
+    ]
+    attr_reader *ATTRIBUTES
 
     def initialize(params)
-      @raw_attributes = params
-      extract_known_attributes
+      params = params.each_with_object({}) do |pair, obj|
+        obj[pair.first.to_sym] = pair.last
+      end
+
+      set_attributes(params)
     end
 
     def valid?
@@ -25,11 +23,12 @@ module WalmartOpen
     end
 
     private
-    def extract_known_attributes
-      API_ATTRIBUTES_MAPPING.each do |api_attr, attr|
-        next unless raw_attributes.has_key?(api_attr)
 
-        instance_variable_set("@#{attr}", raw_attributes[api_attr])
+    def set_attributes(attrs)
+      ATTRIBUTES.each do |attr|
+        next unless attrs.include?(attr)
+
+        instance_variable_set("@#{attr}", attrs[attr])
       end
     end
   end

data/lib/walmart_open/version.rb

@@ -1,3 +1,3 @@
 module WalmartOpen
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/walmart_open/order_spec.rb

@@ -5,23 +5,23 @@ describe WalmartOpen::Order do
   context "create order" do
     let(:order_params) do
       {
-          billing_id:         1,
-          first_name:         "James",
-          last_name:          "Fong",
-          partner_order_id:   "42",
-          phone:              "606-478-0850",
-          partner_order_time: Time.now
+        billing_id:         1,
+        first_name:         "James",
+        last_name:          "Fong",
+        partner_order_id:   "42",
+        phone:              "606-478-0850",
+        partner_order_time: Time.now
       }
     end
 
     let(:shipping_addr_params) do
       {
-          street1:  "Listia Inc, 200 Blossom Ln",
-          street2:  "street2 test",
-          city:     "Mountain View",
-          state:    "CA",
-          zipcode:  "94043",
-          country:  "USA"
+        street1:  "Listia Inc, 200 Blossom Ln",
+        street2:  "street2 test",
+        city:     "Mountain View",
+        state:    "CA",
+        zipcode:  "94043",
+        country:  "USA"
       }
     end
 
@@ -38,6 +38,22 @@ describe WalmartOpen::Order do
         expect(order.partner_order_id).to eq(order_params[:partner_order_id])
         expect(order.partner_order_time).to eq(order_params[:partner_order_time])
       end
+
+      it "accepts string keys" do
+        stringified_order_params = order_params.each_with_object({}) do |pair, obj|
+          obj[pair.first.to_s] = pair.last
+        end
+        WalmartOpen::Order.new(stringified_order_params)
+
+        expect(order.shipping_address).to be_nil
+        expect(order.items).to be_empty
+        expect(order.billing_id).to eql(order_params[:billing_id])
+        expect(order.first_name).to eql(order_params[:first_name])
+        expect(order.last_name).to eql(order_params[:last_name])
+        expect(order.phone).to eql(order_params[:phone])
+        expect(order.partner_order_id).to eq(order_params[:partner_order_id])
+        expect(order.partner_order_time).to eq(order_params[:partner_order_time])
+      end
     end
 
     context "#add_shipping_address" do

data/spec/walmart_open/shipping_address_spec.rb

@@ -27,11 +27,20 @@ describe WalmartOpen::ShippingAddress do
     it "sets attributes" do
       shipping_address = WalmartOpen::ShippingAddress.new(valid_attrs)
 
-      WalmartOpen::ShippingAddress::API_ATTRIBUTES_MAPPING.each do |key, value|
-        expect(shipping_address.public_send(value)).to eq(valid_attrs[key])
+      WalmartOpen::ShippingAddress::ATTRIBUTES.each do |attr|
+        expect(shipping_address.public_send(attr)).to eq(valid_attrs[attr])
       end
+    end
+
+    it "accepts string keys" do
+      stringified_valid_attrs = valid_attrs.each_with_object({}) do |pair, obj|
+        obj[pair.first.to_s] = pair.last
+      end
+      shipping_address = WalmartOpen::ShippingAddress.new(stringified_valid_attrs)
 
-      expect(shipping_address.raw_attributes).to eq(valid_attrs)
+      WalmartOpen::ShippingAddress::ATTRIBUTES.each do |attr|
+        expect(shipping_address.public_send(attr)).to eq(valid_attrs[attr])
+      end
     end
   end
 

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: walmart_open
 version: !ruby/object:Gem::Version
-  prerelease: 
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Ngan Pham
@@ -10,136 +9,120 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-12 00:00:00.000000000 Z
+date: 2013-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
+  type: :runtime
+  prerelease: false
   name: httparty
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.10'
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.10'
+- !ruby/object:Gem::Dependency
   type: :runtime
   prerelease: false
-- !ruby/object:Gem::Dependency
   name: builder
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
-  type: :runtime
-  prerelease: false
 - !ruby/object:Gem::Dependency
+  type: :development
+  prerelease: false
   name: bundler
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
+- !ruby/object:Gem::Dependency
   type: :development
   prerelease: false
-- !ruby/object:Gem::Dependency
   name: rake
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
   type: :development
   prerelease: false
-- !ruby/object:Gem::Dependency
   name: rspec
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 3.0.0.beta1
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 3.0.0.beta1
+- !ruby/object:Gem::Dependency
   type: :development
   prerelease: false
-- !ruby/object:Gem::Dependency
   name: debugger
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
+- !ruby/object:Gem::Dependency
   type: :development
   prerelease: false
-- !ruby/object:Gem::Dependency
   name: timecop
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.7'
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.7'
+- !ruby/object:Gem::Dependency
   type: :development
   prerelease: false
-- !ruby/object:Gem::Dependency
   name: webmock
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 1.16.0
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 1.16.0
-  type: :development
-  prerelease: false
 description: Ruby implementation for Walmart Open API.
 email:
 - ngan@listia.com
@@ -194,27 +177,26 @@ files:
 homepage: https://github.com/listia/walmart_open
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.1.9
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Ruby implementation for Walmart Open API
 test_files:
 - spec/spec_helper.rb