waiting_rspec_matchers 0.2 → 0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d8cbc120933f6ab6460124a0cd2382bf96c1c6f7
-  data.tar.gz: 7b2ab64c10d3dadbc4367cee535c97b35a69e039
+  metadata.gz: 99be2f59b452f566aa05847760a02bd088b4384d
+  data.tar.gz: 6b694444e1a1ded769882a57514f3abadbb4b498
 SHA512:
-  metadata.gz: 2aae9a6546d15e32025975e08defb8d1bd4ea6c23eb488f4801dcd40006c939b35b02a5b0a65f475c413e80d557031ab43eb45cfa80722aa8bf1bbcdafa94af7
-  data.tar.gz: 2bcfe967fd2d61bcada02684da836a4000ba67ac37a9755c49ca5624a321c24aa2fab3b39bc89d75eeb17c38eff61e9c8d171b7fc14e36f7f9c2a201f4529e3e
+  metadata.gz: 39d425a4a73b8ecaa10e9b80634db1ae6ccc423212f8ae5c7f019fe227a8e9816cdb85743426fa29c01e2a4d39083046dc1d25b0aef8594c3c7dc307433bb8b8
+  data.tar.gz: 51c18ae54c6b0dd88a6dde556b7652bdf8932189fa022cd0c57a6b457315c96ed691767cde3bddfed37ec8258e3f1e94f8ea2b520a9981b44b660076ed94371b

data/lib/waiting_rspec_matchers.rb

@@ -17,106 +17,107 @@ module WaitingRspecMatchers
     config.default_delay = 0.05
   end
 
-  private
-
-  BECOME_REGEX = /^become_(.+)/
+  # @api private
+  # Provides the implementation for `become_<matcher_name>`.
+  # Not intended to be instantiated directly.
+  class Become
+    include ::RSpec::Matchers
+    include ::RSpec::Matchers::Composable
+
+    def initialize(rspec_matcher_name, where_included, *args, &expected_block)
+      @rspec_matcher_name = rspec_matcher_name
+      @where_included = where_included
+      @args = args
+      @expected_block = expected_block
+      @chains = []
+    end
 
-  def method_missing(method_name, *args, &expected_block)
-    if m = method_name.to_s.match(BECOME_REGEX)
-      rspec_matcher_name = m[1]
-      unless respond_to?(rspec_matcher_name)
-        raise ArgumentError, "Matcher #{rspec_matcher_name.inspect} doesn't exist"
-      end
-      matcher_class_name = "Become#{rspec_matcher_name.capitalize}Matcher"
-      if ::WaitingRspecMatchers.const_defined?(matcher_class_name)
-        k = ::WaitingRspecMatchers.const_get(matcher_class_name)
-      else
-        k = define_matcher_class
-        ::WaitingRspecMatchers.const_set(matcher_class_name, k)
-      end
+    # @api public
+    # Specifies a number of seconds that WaitingRspecMatchers should wait for a matcher to succeed
+    # @param [Numeric]
+    def during(max_wait_time_in_seconds)
+      @max_wait_time = max_wait_time_in_seconds
+      self
+    end
 
-      k.new(rspec_matcher_name, self, *args, &expected_block)
-    else
-      super
+    # @api public
+    # Specifies period between tries that WaitingRspecMatchers should make when waiting for a matcher to succeed
+    # @param [Numeric]
+    def delay(seconds)
+      @delay = seconds
+      self
     end
-  end
 
-  def respond_to_missing?(method_name, *)
-    method_name.to_s =~ BECOME_REGEX || super
-  end
+    def method_missing(method, *args)
+      @chains << [method, args]
+      self
+    end
 
-  def define_matcher_class
-    Class.new do
-      include ::RSpec::Matchers
-      include ::RSpec::Matchers::Composable
-
-      def initialize(rspec_matcher_name, where_included, *args, &expected_block)
-        @rspec_matcher_name = rspec_matcher_name
-        @where_included = where_included
-        @args = args
-        @expected_block = expected_block
-        @chains = []
-      end
+    def matches?(block)
+      match_helper(:to, &block)
+    end
 
-      def during(max_wait_time_in_seconds)
-        @max_wait_time = max_wait_time_in_seconds
-        self
-      end
+    def does_not_match?(block)
+      match_helper(:not_to, &block)
+    end
 
-      def max_wait_time
-        @max_wait_time || WaitingRspecMatchers.default_wait_time
-      end
+    def failure_message
+      @failure_message
+    end
 
-      def delay(seconds)
-        @delay = seconds
-        self
-      end
+    def failure_message_when_negated
+      @failure_message
+    end
 
-      def method_missing(method, *args)
-        @chains << [method, args]
-        self
-      end
+    def supports_block_expectations?
+      true
+    end
 
-      def match_helper(to_or_not_to, &block)
-        start_time = Time.now
-        begin
-          matcher = @where_included.__send__(@rspec_matcher_name.to_sym, *@args, &@expected_block)
-          @chains.each do |chain|
-            matcher = matcher.__send__(chain[0], *chain[1])
-          end
-          if matcher.respond_to?(:supports_block_expectations?) && matcher.supports_block_expectations?
-            expect { block.call }.__send__(to_or_not_to, matcher)
-          else
-            expect(block.call).__send__(to_or_not_to, matcher)
-          end
-        rescue RSpec::Expectations::ExpectationNotMetError => e
-          @failure_message = e.message
-          return false if (Time.now - start_time) >= max_wait_time
-          sleep @delay || WaitingRspecMatchers.default_delay
-          retry
-        end
-        true
-      end
+    private
 
-      def matches?(block)
-        match_helper(:to, &block)
-      end
+    def max_wait_time
+      @max_wait_time || WaitingRspecMatchers.default_wait_time
+    end
 
-      def does_not_match?(block)
-        match_helper(:not_to, &block)
+    def match_helper(to_or_not_to, &block)
+      start_time = Time.now
+      begin
+        matcher = @where_included.__send__(@rspec_matcher_name.to_sym, *@args, &@expected_block)
+        @chains.each do |chain|
+          matcher = matcher.__send__(chain[0], *chain[1])
+        end
+        if matcher.respond_to?(:supports_block_expectations?) && matcher.supports_block_expectations?
+          expect { block.call }.__send__(to_or_not_to, matcher)
+        else
+          expect(block.call).__send__(to_or_not_to, matcher)
+        end
+      rescue ::RSpec::Expectations::ExpectationNotMetError => e
+        @failure_message = e.message
+        return false if (Time.now - start_time) >= max_wait_time
+        sleep @delay || WaitingRspecMatchers.default_delay
+        retry
       end
+      true
+    end
+  end
 
-      def failure_message
-        @failure_message
-      end
+  private
 
-      def failure_message_when_negated
-        @failure_message
-      end
+  BECOME_REGEX = /^become_(.+)/
 
-      def supports_block_expectations?
-        true
+  def method_missing(method_name, *args, &expected_block)
+    if m = method_name.to_s.match(BECOME_REGEX)
+      rspec_matcher_name = m[1]
+      unless respond_to?(rspec_matcher_name)
+        raise ArgumentError, "Method `#{rspec_matcher_name}` doesn't exist. It was expected to exist and return instance of class that implements RSpec's matcher protocol."
       end
+      Become.new(rspec_matcher_name, self, *args, &expected_block)
+    else
+      super
     end
   end
+
+  def respond_to_missing?(method_name, *)
+    method_name.to_s =~ BECOME_REGEX || super
+  end
 end

data/lib/waiting_rspec_matchers/version.rb

@@ -1,3 +1,3 @@
 module WaitingRspecMatchers
-  VERSION = "0.2"
+  VERSION = "0.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: waiting_rspec_matchers
 version: !ruby/object:Gem::Version
-  version: '0.2'
+  version: '0.3'
 platform: ruby
 authors:
 - Andrey Botalov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-04 00:00:00.000000000 Z
+date: 2014-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-expectations
@@ -97,5 +97,5 @@ rubyforge_project:
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: New become_* RSpec matchers that do the same as * matchers but also wait
+summary: become_* RSpec matchers that do the same as * matchers but also wait
 test_files: []