w3c_rspec_validators 0.2.1 → 0.3.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: e38ccd736f2de04563e2b28fa08369342aaa4e9a9e76945f36a17f9ee453f499
+  data.tar.gz: a003e4dac5b1960593ea848d0f1d0e4bad9ec031105330ac9fa25bbb8e4e2c30
+SHA512:
+  metadata.gz: ffa189cb7fe33744cbc17d6bf7fdcbd4ab293a08df7b4400d6511ebb34dd9d3d0ebca0cf3000bec41e8b99206f1cbc30202ad5e0d7da38a4b11dbf4ee7880aa9
+  data.tar.gz: 82dafcdbfd4b52047035a64acef9e9601ea093b40541ff2174ed92ce677cf3a9adb03b2c08f26349a9c0b037403ced185bbcc9c9bac89175f1e3a3628c70398d

data/Gemfile

@@ -2,10 +2,6 @@ source "http://rubygems.org"
 
 gem "w3c_validators"
 gem "rspec"
-gem "linecache19", git: "git://github.com/mark-moseley/linecache", require: "ruby-debug"
-gem "ruby-debug-base19x", "~> 0.11.30.pre4"
-gem "ruby-debug19"
-
 
 # Specify your gem's dependencies in w3c_rspec_validators.gemspec
 gemspec

data/lib/w3c_rspec_validators/config.rb

@@ -1,7 +1,7 @@
 require "rails"
 
 module W3cRspecValidators
-    
+
   class Railtie < Rails::Railtie
     initializer "initialize config" do
       config_file = Rails.root.join("config", "w3c_rspec_validators.yml")
@@ -12,14 +12,14 @@ module W3cRspecValidators
      # puts ActionDispatch::Routing::UrlFor::url_for("/")
     end
   end
-  
+
   class Config
     @@config = {
-      validator_uri: "" 
+      validator_uri: ""
     }
 
     def self.load! config_file
-      @@config = YAML.load(File.open(config_file))["config"] 
+      @@config = YAML.load(File.open(config_file))["config"]
     end
 
     def self.get

data/lib/w3c_rspec_validators/rspec.rb

@@ -1,18 +1,18 @@
 module W3cRspecValidators
-  
+
   RSpec::Matchers.define :be_valid_html do
     validator = Validator.new
     match do |body|
       validator.validate_html(body)
       validator.response.errors.length == 0
     end
-    failure_message_for_should do |actual|
+    failure_message do |actual|
       validator.response.errors.map do |err|
         ErrorParser.parse_html_error(err, actual)
       end.join("\n")
     end
   end
-  
+
   RSpec::Matchers.define :be_valid_css do
     validator = Validator.new
     match do |css|
@@ -20,7 +20,7 @@ module W3cRspecValidators
       validator.response.errors.length == 0
     end
 
-    failure_message_for_should do |actual|
+    failure_message do |actual|
       validator.response.errors.map do |err|
         ErrorParser.parse_css_error(err, actual)
       end.join("\n")

data/lib/w3c_rspec_validators/validator.rb

@@ -1,10 +1,12 @@
 module W3cRspecValidators
   class Validator
+    class Error < StandardError; end
+
     attr_reader :response
     include W3CValidators
 
     def initialize
-      @html_validator = MarkupValidator.new validator_uri: Config.get["w3c_service_uri"]
+      @html_validator = NuValidator.new validator_uri: Config.get["w3c_service_uri"]
       @css_validator = CSSValidator.new validator_uri: Config.get["w3c_css_service_uri"]
     end
 
@@ -23,7 +25,7 @@ module W3cRspecValidators
         @response = @html_validator.validate_text(text)
       }
       try validate
-      raise "Error: Invalid validation response! Tip: check if validator.nu engine is configured correctly" if @response.checked_by.blank?
+      raise Error, "Error: Invalid validation response! Tip: check if validator.nu engine is configured correctly" if @response.checked_by.blank?
       @response
     end
 
@@ -32,7 +34,7 @@ module W3cRspecValidators
         @response = @css_validator.validate_text(text)
       }
       try validate
-      raise "Error: Invalid validation response! Tip: check if validator.nu engine is configured correctly" if @response.checked_by.blank?
+      raise Error, "Error: Invalid validation response! Tip: check if validator.nu engine is configured correctly" if @response.checked_by.blank?
       @response
     end
   end

data/lib/w3c_rspec_validators/version.rb

@@ -1,3 +1,3 @@
 module W3cRspecValidators
-  VERSION = "0.2.1"
+  VERSION = "0.3.0"
 end

data/spec/css_files_spec.rb

@@ -2,17 +2,23 @@ require "w3c_rspec_validators"
 
 describe "css_files" do
   describe "self.compiled" do
-  
+
     before(:each) do
-      Object.should_receive(:system).with "rake -q assets:precompile"
-      Rails.stub(:root).and_return "railsroot"
-      FileUtils.should_receive(:rm_rf).with "railsroot/public/assets/"
+      expect(Object).to receive(:system).with("rake -q assets:precompile")
+      expect(Rails).to receive(:root).and_return(Pathname.new("railsroot"))
+      expect(FileUtils).to receive(:rm_rf).with("railsroot/public/assets/")
     end
 
     it "should read css files from a directory" do
       directory = File.dirname(__FILE__)
-      W3cRspecValidators::CssFiles.compiled(["#{directory}/fixtures/*.css"])
-        .should == "#home {}\nbody {\n}\n"
+
+      compiled = W3cRspecValidators::CssFiles.compiled(["#{directory}/fixtures/*.css"])
+
+      expect(compiled).to eq <<~CSS
+      body {
+      }
+      #home {}
+      CSS
     end
   end
 end

data/spec/error_parser_spec.rb

@@ -4,8 +4,8 @@ describe "error_parser" do
 
   describe "self.parse_css" do
     before(:each) do
-      @css_error_message = "ERROR; URI: file://localhost/TextArea; line 7: 
-        
+      @css_error_message = "ERROR; URI: file://localhost/TextArea; line 7:
+
                                 Property foo doesn't exist :"
       @css = "
 body {
@@ -18,9 +18,10 @@ body {
     end
 
     it "should properly format css errors" do
-      W3cRspecValidators::ErrorParser.parse_css_error(@css_error_message, @css)
-        .should == "######
- Property foo doesn't exist :
+      error = W3cRspecValidators::ErrorParser.parse_css_error(@css_error_message, @css)
+
+      expect(error).to eq "######
+Property foo doesn't exist :
 Real code location(guessed) in File ../../app/assets/stylesheets/home.css.scss on line 2
 
 Code context:
@@ -46,8 +47,9 @@ Code context:
     end
 
     it "should properly format a html error message" do
-      W3cRspecValidators::ErrorParser.parse_html_error(@html_error_message, @html)
-        .should == "######
+      error = W3cRspecValidators::ErrorParser.parse_html_error(@html_error_message, @html)
+
+      expect(error).to eq "######
 line 7: An img element must have an alt attribute, except under certain conditions. For details, consult guidance on providing text alternatives for images.
 
           </head>

data/spec/matchers_spec.rb

@@ -21,29 +21,37 @@ describe "rspec matchers" do
 
   describe "be_valid_html" do
     it "should be valid" do
-      "<!DOCTYPE HTML SYSTEM>
+      body = <<~HTML
+        <!DOCTYPE HTML>
         <html>
           <head>
             <title>dd</title>
           </head>
           <body>
           </body>
-        </html>".should be_valid_html
+        </html>
+      HTML
+
+      expect(body).to be_valid_html
     end
 
     it "should not be valid" do
-      "<!DOCTYPE HTML SYSTEM>
+      body = <<~HTML
+        <!DOCTYPE HTML>
         <html>
           <head>
             <titled>dd</title>
           </head>
           <body></body>
-        </html>".should_not be_valid_html
+        </html>
+      HTML
+
+      expect(body).to_not be_valid_html
     end
 
     it "should complain about an missing src attribute" do
-      lambda {
-        "<!DOCTYPE HTML SYSTEM>
+      body = <<~HTML
+        <!DOCTYPE HTML>
         <html>
           <head>
             <title>dd</title>
@@ -51,35 +59,36 @@ describe "rspec matchers" do
           <body>
             <img />
           </body>
-        </html>".should be_valid_html
-      }.should fail_matching(/line 7: required attribute "SRC" not specified.*<img \/>/m)
+        </html>
+      HTML
+
+      expect {
+        expect(body).to be_valid_html
+      }.to fail_matching(/line 7: Element “img” is missing required attr/m)
     end
 
     it "should use a custom uri if provided" do
-      W3cRspecValidators::Config.stub(:get).and_return("w3c_service_uri" => "http://blubb.de")
-      
-      validator = MarkupValidator.new
-      MarkupValidator.should_receive(:new).with(:validator_uri => "http://blubb.de").and_return validator
+      allow(W3cRspecValidators::Config).to receive(:get).and_return("w3c_service_uri" => "https://validator.nu/")
 
-      "dummy".should_not be_valid_html
+      expect(NuValidator).to receive(:new).with(validator_uri: "https://validator.nu/").and_call_original
+
+      expect("dummy").to_not be_valid_html
     end
   end
 
   describe "be_valid_css" do
     it "should be valid" do
-      "body {}".should be_valid_css
+      expect("body {}").to be_valid_css
     end
 
     it "should not be valid" do
-      "body { foo: 12px; }".should_not be_valid_css
+      expect("body { foo: 12px; }").to_not be_valid_css
     end
 
     it "should not be valid" do
-      lambda {
-        "body { foo: 12px; }".should be_valid_css
-      }.should fail_matching(/Property foo doesn't exist/)
+      expect {
+        expect("body { foo: 12px; }").to be_valid_css
+      }.to fail_matching(/Property “foo” doesn't exist/)
     end
-
   end
-
 end

data/spec/validator_spec.rb

@@ -5,9 +5,9 @@ describe W3cRspecValidators::Validator do
 
   describe "initialize" do
     it "should initialize MarkupValidator with config value" do
-      W3cRspecValidators::Config.stub(:get).and_return("w3c_service_uri" => "http://blubb.de", "w3c_css_service_uri" => "http://test.de")
-      MarkupValidator.should_receive(:new).with(validator_uri: "http://blubb.de")
-      CSSValidator.should_receive(:new).with(validator_uri: "http://test.de")
+      allow(W3cRspecValidators::Config).to receive(:get).and_return("w3c_service_uri" => "http://blubb.de", "w3c_css_service_uri" => "http://test.de")
+      expect(NuValidator).to receive(:new).with(validator_uri: "http://blubb.de")
+      expect(CSSValidator).to receive(:new).with(validator_uri: "http://test.de")
 
       W3cRspecValidators::Validator.new
     end
@@ -20,23 +20,24 @@ describe W3cRspecValidators::Validator do
           ""
         end
       end
-      MarkupValidator.any_instance.stub(:validate_text).and_return Dummy.new
-      
+
+      allow_any_instance_of(NuValidator).to receive(:validate_text).and_return(Dummy.new)
+
       expect {
-        W3cRspecValidators::Validator.new.validate_text("dummy")
-      }.to raise_exception
+        W3cRspecValidators::Validator.new.validate_html("dummy")
+      }.to raise_exception(W3cRspecValidators::Validator::Error)
     end
   end
 
   describe "error handling" do
     it "should retry 3 times if there is a connection error" do
-      MarkupValidator.any_instance.stub(:validate_text).and_raise "error"
+      allow_any_instance_of(NuValidator).to receive(:validate_text).and_raise(StandardError)
       validator = W3cRspecValidators::Validator.new
-      validator.should_receive(:sleep).exactly(2).times
-      
-      lambda {
+      expect(validator).to receive(:sleep).exactly(2).times
+
+      expect {
         validator.validate_html("dummy")
-      }.should raise_error()
+      }.to raise_exception(StandardError)
     end
   end
 end

metadata

@@ -1,49 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: w3c_rspec_validators
 version: !ruby/object:Gem::Version
-  version: 0.2.1
-  prerelease: 
+  version: 0.3.0
 platform: ruby
 authors:
 - Dominik Goltermann
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-23 00:00:00.000000000 Z
+date: 2018-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: w3c_validators
-  requirement: &13658840 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *13658840
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &13658240 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *13658240
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &13657220 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *13657220
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Allows testing vor valid html (including html5) and css. In addition
   you can configure the gem to use a locally installed validation service instead
   of the online w3c servers
@@ -53,7 +61,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - README.md
 - Rakefile
@@ -75,27 +83,25 @@ files:
 - w3c_rspec_validators.gemspec
 homepage: ''
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: w3c_rspec_validators
-rubygems_version: 1.8.10
+rubygems_version: 2.7.6
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: This gem adds w3c validation in form of rspec matchers
 test_files: []
-has_rdoc: