w3c_rspec_validators 0.2.0 → 0.2.1

data/lib/w3c_rspec_validators/validator.rb

@@ -8,14 +8,30 @@ module W3cRspecValidators
       @css_validator = CSSValidator.new validator_uri: Config.get["w3c_css_service_uri"]
     end
 
+    def try method, try_count = 1
+      begin
+        method.call
+      rescue Exception => e
+        raise e if try_count >= 3
+        sleep 3
+        try(method, try_count + 1)
+      end
+    end
+
     def validate_html text
-      @response = @html_validator.validate_text(text)
+      validate = Proc.new {
+        @response = @html_validator.validate_text(text)
+      }
+      try validate
       raise "Error: Invalid validation response! Tip: check if validator.nu engine is configured correctly" if @response.checked_by.blank?
       @response
     end
 
     def validate_css text
-      @response = @css_validator.validate_text(text)
+      validate = Proc.new {
+        @response = @css_validator.validate_text(text)
+      }
+      try validate
       raise "Error: Invalid validation response! Tip: check if validator.nu engine is configured correctly" if @response.checked_by.blank?
       @response
     end

data/lib/w3c_rspec_validators/version.rb

@@ -1,3 +1,3 @@
 module W3cRspecValidators
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/spec/validator_spec.rb

@@ -14,7 +14,7 @@ describe W3cRspecValidators::Validator do
   end
 
   describe "validate_text" do
-    it "should raise an exception if validation fails silently" do
+    it "should raise an exception if validation fails silently (eg. validator.nu engine misconfiguration)" do
       class Dummy
         def checked_by
           ""
@@ -27,4 +27,16 @@ describe W3cRspecValidators::Validator do
       }.to raise_exception
     end
   end
+
+  describe "error handling" do
+    it "should retry 3 times if there is a connection error" do
+      MarkupValidator.any_instance.stub(:validate_text).and_raise "error"
+      validator = W3cRspecValidators::Validator.new
+      validator.should_receive(:sleep).exactly(2).times
+      
+      lambda {
+        validator.validate_html("dummy")
+      }.should raise_error()
+    end
+  end
 end

data/w3c_rspec_validators.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |s|
   s.email       = ["dominik@goltermann.cc"]
   s.homepage    = ""
   s.summary     = %q{This gem adds w3c validation in form of rspec matchers}
-  s.description = %q{At this time it allows for validation of html (including html5) produced by rspec acceptance tests. In addition you can configure the gem to use a locally installed validation service instead of the online w3c servers}
+  s.description = %q{Allows testing vor valid html (including html5) and css. In addition you can configure the gem to use a locally installed validation service instead of the online w3c servers}
 
   s.rubyforge_project = "w3c_rspec_validators"
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: w3c_rspec_validators
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-03-31 00:00:00.000000000 Z
+date: 2012-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: w3c_validators
-  requirement: &19268480 !ruby/object:Gem::Requirement
+  requirement: &13658840 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *19268480
+  version_requirements: *13658840
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &19267980 !ruby/object:Gem::Requirement
+  requirement: &13658240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *19267980
+  version_requirements: *13658240
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &19267560 !ruby/object:Gem::Requirement
+  requirement: &13657220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *19267560
-description: At this time it allows for validation of html (including html5) produced
-  by rspec acceptance tests. In addition you can configure the gem to use a locally
-  installed validation service instead of the online w3c servers
+  version_requirements: *13657220
+description: Allows testing vor valid html (including html5) and css. In addition
+  you can configure the gem to use a locally installed validation service instead
+  of the online w3c servers
 email:
 - dominik@goltermann.cc
 executables: []