voyager_oracle_api 0.3.5 → 1.0.0

data/VERSION

@@ -1 +1 @@
-0.3.5
+1.0.0

data/lib/status.rb

@@ -38,7 +38,14 @@ module Voyager
       statuses
     end
 
+
+    # available statuses
+
     # 1 Not Charged
+    # 11  Discharged
+
+    # not available statuses
+
     # 2 Charged
     # 3 Renewed
     # 4 Overdue
@@ -48,21 +55,24 @@ module Voyager
     # 8 In Transit
     # 9 In Transit Discharged           no longer used but appear in records
     # 10  In Transit On Hold            no longer used but appear in records
-    # 11  Discharged
+    # 9 + 10 converted to 8 in GetHoldingsService
     # 12  Missing
     # 13  Lost--Library Applied
     # 14  Lost--System Applied
-    # 15  Claims Returned               x
-    # 16  Damaged                       x
-    # 17  Withdrawn                     skip item
     # 18  At Bindery
-    # 19  Cataloging Review             x
-    # 20  Circulation Review            x
     # 21  Scheduled
     # 22  In Process
     # 23  Call Slip Request
     # 24  Short Loan Request
     # 25  Remote Storage Request
+
+    # not used to determine status in Voyager application or apis
+
+    # 15  Claims Returned               x
+    # 16  Damaged                       x
+    # 17  Withdrawn                     x
+    # 19  Cataloging Review             x
+    # 20  Circulation Review            x
     
     def determine_status(items)
       
@@ -72,17 +82,14 @@ module Voyager
       ucnt = 0  # count of unavailable items
       
       items.each_pair do |itemid,statuses|
-        # skip withdrawn
-        unless statuses.include?(17)
-          icnt += 1
-          # the overwhelming majority of items have only one status
-          if statuses.length == 1
-            ucnt += 1 unless [1,9,11].any? {|code| statuses.include?(code)}
-          else
-            # some unavalable statuses can be in combination with 1, 9 and 11 so we test for them first
-            if [2,3,4,5,6,7,8,10,12,13,14,18,21,22,23,24,25].any? {|code| statuses.include?(code)}
-              ucnt += 1
-            end
+        icnt += 1
+        # the overwhelming majority of items have only one status
+        if statuses.length == 1
+          ucnt += 1 unless [1,11].any? {|code| statuses.include?(code)}
+        else
+          # some unavalable statuses can be in combination with 1 and 11 so we test for them first
+          if [2,3,4,5,6,7,8,9,10,12,13,14,18,21,22,23,24,25].any? {|code| statuses.include?(code)}
+            ucnt += 1
           end
         end
       end

metadata

@@ -2,7 +2,7 @@
 name: voyager_oracle_api
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.3.5
+  version: 1.0.0
 platform: ruby
 authors: 
 - James Stuart
@@ -11,7 +11,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-10-04 00:00:00 Z
+date: 2012-10-18 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: activesupport
@@ -210,7 +210,6 @@ files:
 - test/test_fixtures.rb
 - test/test_simple.rb
 - test/test_voyager_connection.rb
-- voyager_api.gemspec
 - voyager_oracle_api.gemspec
 homepage: http://github.com/cul/voyager_oracle_api
 licenses: 
@@ -225,7 +224,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 1040777007
+      hash: 1065477551
       segments: 
       - 0
       version: "0"

data/voyager_api.gemspec

@@ -1,115 +0,0 @@
-# Generated by jeweler
-# DO NOT EDIT THIS FILE DIRECTLY
-# Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
-# -*- encoding: utf-8 -*-
-
-Gem::Specification.new do |s|
-  s.name = %q{voyager_api}
-  s.version = "0.1.2"
-
-  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.authors = [%q{James Stuart}, %q{Gary Bertchume}]
-  s.date = %q{2011-09-13}
-  s.description = %q{Middleware gem for Voyager 7 API calls, specificially holdings information }
-  s.email = %q{github@jamesstuart.org}
-  s.extra_rdoc_files = [
-    "LICENSE.txt",
-    "README.rdoc"
-  ]
-  s.files = [
-    ".document",
-    ".rvmrc.07.27.2011-15:02:08",
-    "Gemfile",
-    "Gemfile.lock",
-    "Guardfile",
-    "LICENSE.txt",
-    "README.rdoc",
-    "Rakefile",
-    "VERSION",
-    "lib/holdings/collection.rb",
-    "lib/holdings/item.rb",
-    "lib/holdings/order.rb",
-    "lib/holdings/record.rb",
-    "lib/voyager_api.rb",
-    "lib/voyager_connection.rb",
-    "test/fixtures/fixtures_readme",
-    "test/fixtures/holdings_289196.xml",
-    "test/fixtures/holdings_3708764.xml",
-    "test/fixtures/holdings_4191079.xml",
-    "test/fixtures/holdings_4949188.xml",
-    "test/fixtures/holdings_4949188_2.xml",
-    "test/fixtures/holdings_526843.xml",
-    "test/fixtures/holdings_5351573.xml",
-    "test/fixtures/holdings_5656993.xml",
-    "test/fixtures/holdings_6269409.xml",
-    "test/fixtures/holdings_7140519.xml",
-    "test/fixtures/holdings_7471326.xml",
-    "test/fixtures/holdings_7658449.xml",
-    "test/fixtures/holdings_7658454.xml",
-    "test/fixtures/holdings_7784963.xml",
-    "test/fixtures/holdings_8189127.xml",
-    "test/fixtures/holdings_8267323.xml",
-    "test/fixtures/holdings_8615744.xml",
-    "test/fixtures/holdings_8661671.xml",
-    "test/fixtures/holdings_8828760.xml",
-    "test/fixtures/holdings_8889994.xml",
-    "test/fixtures/holdings_8891001.xml",
-    "test/fixtures/holdings_8891001_2.xml",
-    "test/fixtures/holdings_8918502.xml",
-    "test/helper.rb",
-    "test/holdings/test_collection.rb",
-    "test/holdings/test_collection_output.rb",
-    "test/holdings/test_holdings_test_case.rb",
-    "test/holdings/test_item.rb",
-    "test/holdings/test_order.rb",
-    "test/holdings/test_record.rb",
-    "test/test_voyager_api.rb",
-    "test/test_voyager_connection.rb",
-    "voyager_api.gemspec"
-  ]
-  s.homepage = %q{http://github.com/cul/voyager_api}
-  s.licenses = [%q{MIT}]
-  s.require_paths = [%q{lib}]
-  s.rubygems_version = %q{1.8.6}
-  s.summary = %q{Columbia University Voyager 7 API wrapper}
-
-  if s.respond_to? :specification_version then
-    s.specification_version = 3
-
-    if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<httpclient>, [">= 0"])
-      s.add_runtime_dependency(%q<nokogiri>, [">= 0"])
-      s.add_development_dependency(%q<minitest>, [">= 0"])
-      s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
-      s.add_development_dependency(%q<jeweler>, ["~> 1.6.4"])
-      s.add_development_dependency(%q<rcov>, [">= 0"])
-      s.add_development_dependency(%q<guard-minitest>, [">= 0"])
-      s.add_development_dependency(%q<rb-fsevent>, [">= 0"])
-      s.add_development_dependency(%q<mocha>, [">= 0"])
-      s.add_development_dependency(%q<growl>, [">= 0"])
-    else
-      s.add_dependency(%q<httpclient>, [">= 0"])
-      s.add_dependency(%q<nokogiri>, [">= 0"])
-      s.add_dependency(%q<minitest>, [">= 0"])
-      s.add_dependency(%q<bundler>, ["~> 1.0.0"])
-      s.add_dependency(%q<jeweler>, ["~> 1.6.4"])
-      s.add_dependency(%q<rcov>, [">= 0"])
-      s.add_dependency(%q<guard-minitest>, [">= 0"])
-      s.add_dependency(%q<rb-fsevent>, [">= 0"])
-      s.add_dependency(%q<mocha>, [">= 0"])
-      s.add_dependency(%q<growl>, [">= 0"])
-    end
-  else
-    s.add_dependency(%q<httpclient>, [">= 0"])
-    s.add_dependency(%q<nokogiri>, [">= 0"])
-    s.add_dependency(%q<minitest>, [">= 0"])
-    s.add_dependency(%q<bundler>, ["~> 1.0.0"])
-    s.add_dependency(%q<jeweler>, ["~> 1.6.4"])
-    s.add_dependency(%q<rcov>, [">= 0"])
-    s.add_dependency(%q<guard-minitest>, [">= 0"])
-    s.add_dependency(%q<rb-fsevent>, [">= 0"])
-    s.add_dependency(%q<mocha>, [">= 0"])
-    s.add_dependency(%q<growl>, [">= 0"])
-  end
-end
-