voyager_oracle_api 0.3.0 → 0.3.2

data/VERSION

@@ -1 +1 @@
-0.3.0
+0.3.2

data/lib/oracle_connection.rb

@@ -5,19 +5,21 @@ module Voyager
     attr_accessor :results 
 
     def initialize(args = {})
-      @connection = args['connection'] 
-
+      args.symbolize_keys!
+      @connection = args[:connection] 
+    
 
-      unless args.has_key?('connection')
+      unless args.has_key?(:connection)
         app_config_filename = File.join(File.dirname(__FILE__), "..",  "config" ,"app_config.yml")
 
         args = YAML.load_file(app_config_filename)['oracle_connection_details'] if args == {} and File.exists?(app_config_filename)
+        args.symbolize_keys!
 
-        raise "Need argument 'user'" unless args.has_key?('user') 
-        raise "Need argument 'password'" unless args.has_key?('password')
-        raise "Need argument 'service'" unless args.has_key?('service')
+        raise "Need argument 'user'" unless args.has_key?(:user) 
+        raise "Need argument 'password'" unless args.has_key?(:password)
+        raise "Need argument 'service'" unless args.has_key?(:service)
 
-        @connection = OCI8.new(args['user'], args['password'], args['service'])
+        @connection = OCI8.new(args[:user], args[:password], args[:service])
         @connection.prefetch_rows = 1000
       end
 
@@ -27,6 +29,8 @@ module Voyager
 
     
     def retrieve_holdings(*bibids)
+      bibids = Array.wrap(bibids).flatten
+
       query = <<-HERE
         select a.bib_id, a.mfhd_id, c.item_id, item_status
         from bib_mfhd a, mfhd_master b, mfhd_item c, item_status d

data/lib/request.rb

@@ -1,9 +1,11 @@
 module Voyager
   module Request
-    def self.simple_holdings_check(*bibids)
+    def self.simple_holdings_check(args = {})
       
-      con = OracleConnection.new()
-      con.retrieve_holdings(*bibids)
+      con = args.delete(:connection)
+      con ||= OracleConnection.new(args.delete(:connection_details))
+      bibids = Array.wrap(args.delete(:bibids))
+      con.retrieve_holdings(bibids)
       
       results = {}
 

data/voyager_oracle_api.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "voyager_oracle_api"
-  s.version = "0.3.0"
+  s.version = "0.3.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["James Stuart", "Gary Bertchume"]
-  s.date = "2012-10-03"
+  s.date = "2012-10-04"
   s.description = "Middleware gem for Voyager Oracle API calls, specificially holdings information "
   s.email = "github@jamesstuart.org"
   s.extra_rdoc_files = [

metadata

@@ -2,7 +2,7 @@
 name: voyager_oracle_api
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.3.0
+  version: 0.3.2
 platform: ruby
 authors: 
 - James Stuart
@@ -11,7 +11,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-10-03 00:00:00 Z
+date: 2012-10-04 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: activesupport
@@ -214,7 +214,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -614486029
+      hash: 551596431
       segments: 
       - 0
       version: "0"