voting 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f0f7788833c3a076eb925aac474527ff11af91bf
-  data.tar.gz: b49e89a0bfae1c14bfbaafc785b49901d3d987ea
+  metadata.gz: cb95d0887656cb736919fb5ab9fda2b3689dc3d3
+  data.tar.gz: 5078155552f020da3f0a75434caceeb81b8c1355
 SHA512:
-  metadata.gz: 285ef836d6e3468fdd140d20342b6a6dd2eb728f323e1265632c0591e49d3e74abed06faac44bb0e0c2f15fa0b570e7ce94ec6dd5503d3cb0ce891fe63de8d3e
-  data.tar.gz: eabf0323ba058330e694692f5fe9611234410f2335b6a0bae6500acc096a3d214f18b24298214cd118ce23cc5701728c2f98492dec90d22f8701b7c7332818b0
+  metadata.gz: c9b1fc20e7a7d4b4524121a54ec98bf3f98f6e835ff431466fba4aa2b55eeedba562b9e6b07ad86b4209da3a9bb65db3a1b56c8940c53a2576de686daec07df6
+  data.tar.gz: 02d4e5c839d2a71fb8209bbf35cee97d15532491c4a9ff968de4f3054e2fdd3becdd694e7c30f4e68cdb2c14a09984d16b3f4588b46269a91b53148350037268

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## v0.3.0
+
+### News
+
+- Added method `status` to return the status of some vote record.
+
+### Updates
+
+- The voting warm up registers is only made on creation to avoid overhead.
+
 ## v0.2.0
 
 ### News

data/README.md

@@ -58,6 +58,19 @@ author_1.vote(resource, 1)  # +1 vote
 author_2.vote(resource, -1) # -1 vote
 ```
 
+### status
+
+This mehod will return the status of a `Voting::Vote` object as `positive`, `negative` or `none`.
+
+```ruby
+author   = Author.first
+resource = Comment.last
+
+author.vote(resource, 1).status # 'positive'
+author.vote(resource, -1)       # 'negative'
+author.vote(resource, -1)       # 'none'
+```
+
 ### voting
 
 A voted resource exposes a cached data about it state:

data/lib/voting/models/voting/extension.rb

@@ -56,7 +56,7 @@ module Voting
 
     module ClassMethods
       def voting(as: nil, scoping: nil)
-        after_save -> { voting_warm_up scoping: scoping }, unless: -> { as == :author }
+        after_create -> { voting_warm_up scoping: scoping }, unless: -> { as == :author }
 
         has_many :voting_records,
           as:         :resource,

data/lib/voting/models/voting/vote.rb

@@ -18,6 +18,12 @@ module Voting
       scope:          %i[author_type resource_id resource_type scopeable_id scopeable_type]
     }
 
+    def status
+      return 'positive' if positive == 1
+
+      negative == 1 ? 'negative' : 'none'
+    end
+
     def self.create(author:, resource:, scopeable: nil, value:)
       record    = find_or_initialize_by(author: author, resource: resource, scopeable: scopeable)
       attribute = value.positive? ? :positive : :negative

data/lib/voting/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Voting
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

data/spec/models/extension/{after_save_spec.rb → after_create_spec.rb}

@@ -2,7 +2,7 @@
 
 require 'rails_helper'
 
-RSpec.describe Voting::Extension, 'after_save' do
+RSpec.describe Voting::Extension, 'after_create' do
   context 'when record is author' do
     let!(:record) { build :author }
 
@@ -33,5 +33,15 @@ RSpec.describe Voting::Extension, 'after_save' do
         record.save
       end
     end
+
+    context 'when update is made' do
+      let!(:record) { create :comment }
+
+      it 'does not warm up the cache' do
+        expect(record).not_to receive(:voting_warm_up)
+
+        record.save
+      end
+    end
   end
 end

data/spec/models/vote/status_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe Voting::Vote, '.status' do
+  let!(:author)   { create :author }
+  let!(:resource) { create :comment }
+
+  context 'with no scope' do
+
+    it 'returns the status' do
+      expect(author.up(resource).status).to   eq 'positive'
+      expect(author.down(resource).status).to eq 'negative'
+      expect(author.down(resource).status).to eq 'none'
+    end
+  end
+
+  context 'with scope' do
+    let!(:scope) { create :category }
+
+    it 'returns the status' do
+      expect(author.up(resource, scope: scope).status).to   eq 'positive'
+      expect(author.down(resource, scope: scope).status).to eq 'negative'
+      expect(author.down(resource, scope: scope).status).to eq 'none'
+    end
+  end
+
+  it 'respect the scope' do
+    no_scope   = author.up(resource)
+    with_scope = author.down(resource, scope: create(:category))
+
+    expect(no_scope.status).to   eq 'positive'
+    expect(with_scope.status).to eq 'negative'
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: voting
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Washington Botelho
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-29 00:00:00.000000000 Z
+date: 2018-02-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -151,7 +151,7 @@ files:
 - spec/factories/comment.rb
 - spec/factories/voting/vote.rb
 - spec/factories/voting/voting.rb
-- spec/models/extension/after_save_spec.rb
+- spec/models/extension/after_create_spec.rb
 - spec/models/extension/as_spec.rb
 - spec/models/extension/down_spec.rb
 - spec/models/extension/order_by_voting_spec.rb
@@ -167,6 +167,7 @@ files:
 - spec/models/extension/voting_spec.rb
 - spec/models/extension/voting_warm_up_spec.rb
 - spec/models/vote/create_spec.rb
+- spec/models/vote/status_spec.rb
 - spec/models/vote/vote_for_spec.rb
 - spec/models/vote_spec.rb
 - spec/models/voting/update_voting_spec.rb
@@ -214,6 +215,7 @@ summary: A Binomial proportion confidence interval voting system with scope and
   enabled.
 test_files:
 - spec/models/vote/vote_for_spec.rb
+- spec/models/vote/status_spec.rb
 - spec/models/vote/create_spec.rb
 - spec/models/voting_spec.rb
 - spec/models/vote_spec.rb
@@ -228,8 +230,8 @@ test_files:
 - spec/models/extension/voting_records_spec.rb
 - spec/models/extension/as_spec.rb
 - spec/models/extension/voted_spec.rb
+- spec/models/extension/after_create_spec.rb
 - spec/models/extension/votes_spec.rb
-- spec/models/extension/after_save_spec.rb
 - spec/models/extension/votes_records_spec.rb
 - spec/models/extension/up_spec.rb
 - spec/models/voting/update_voting_spec.rb