votd 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b25aca7bbd23dfa9a4ecd49e2880b3f9e059f7a0fa0ff04a3d97fbda46c3a92b
-  data.tar.gz: 32bb871d6a200a34d553fbb784c94af5d56358f203dbe6387db6e7e40c11ed7f
+  metadata.gz: 57bcf6e57b91887386c042964ec51f28f4ab4c14b9e90a148b2912b0f5068fe6
+  data.tar.gz: 80b0bf8a03ff966a8db709ae04e1607cc2b8cbae184b3d0a5160eec14bcb058b
 SHA512:
-  metadata.gz: 2e65b6ff4787364c3eb269baa095503a13d561e87b40e81f83da2fc0d69d8635d648b59738adfc396cea5f528978073ba5b6f4b61cb231b6291f554c02ba5039
-  data.tar.gz: 2800cfef14f6fb8ee2f1968022c6748888badc38f2121bce001f3e565590ce0ab942b654ba19eb5f4b39321379831e82379e5dd52dfb3a0aeb24fa3f62a3a5c1
+  metadata.gz: ececd1be7cdddd745cd30c1ebf5820174b28256630909b5b6a76943df9458a7e7f05df35a0de12ab0a43aa0f68b1914d95e410e3f55b9a62de70c9650e50e2be
+  data.tar.gz: ccbc79d8895676c15f7b7bfef738e87cc6a2ceecc43355c665db3bb0e7cd4df900e6c102b290b38c698926ce22adb46745a386a064d41d2ad676d4cdaff25163

data/CHANGELOG.md

@@ -1,6 +1,12 @@
 Changelog
 =========
 
+3.0.1
+-----
+*November 27, 2019*
+
+* Throw error when invalid version option passed to BibleGateway initializer
+
 3.0.0
 -----
 *November 27, 2019*
@@ -9,7 +15,7 @@ Changelog
   for supported versions)
 * Add `.version_name` (alias: `.translation_name`) to get full version name.
   (e.g. "New International Version")
-* Add `.link` to get a link to the verse on the associated Bible site.
+* Add `.link` to get a link to the verse on the associated Bible site
 
 2.2.0
 -----

data/lib/votd/bible_gateway.rb

@@ -46,6 +46,8 @@ module Votd
     # Initializes the BibleGateway class
     # @return [BibleGateway]
     def initialize(version = :niv)
+      raise InvalidBibleVersion unless BIBLE_VERSIONS.has_key?(version)
+
       @version = version.to_s.upcase
       @version_number = BIBLE_VERSIONS[version][:id]
       @version_name = BIBLE_VERSIONS[version][:name]

data/lib/votd/version.rb

@@ -1,4 +1,4 @@
 module Votd
   # Gem version number
-  VERSION = "3.0.0"
+  VERSION = "3.0.1"
 end

data/lib/votd/votd_error.rb

@@ -3,4 +3,7 @@ module Votd
   # by Votd.
   class VotdError < StandardError
   end
-end
+
+  class InvalidBibleVersion < VotdError
+  end
+end

data/spec/lib/votd/bible_gateway_spec.rb

@@ -135,22 +135,26 @@ describe "Votd::BibleGateway" do
       fake_a_uri("#{Votd::BibleGateway::URI}#{51}", 'bible_gateway/bible_gateway_nlt.rss')
     end
 
-    describe ".text" do
-      it "returns the correct scripture verse" do
-        expect(votd_nlt.text).to eq "Let the message about Christ, in all its richness, fill your lives. Teach and counsel each other with all the wisdom he gives. Sing psalms and hymns and spiritual songs to God with thankful hearts."
-      end
+    it "returns the correct scripture verse" do
+      expect(votd_nlt.text).to eq "Let the message about Christ, in all its richness, fill your lives. Teach and counsel each other with all the wisdom he gives. Sing psalms and hymns and spiritual songs to God with thankful hearts."
+    end
 
-      it 'returns the correct version info' do
-        expect(votd_nlt.version).to eq 'NLT'
-        expect(votd_nlt.version_name).to eq 'New Living Translation'
-      end
+    it 'returns the correct version info' do
+      expect(votd_nlt.version).to eq 'NLT'
+      expect(votd_nlt.version_name).to eq 'New Living Translation'
+    end
 
-      it "returns copyright information" do
-        expect(votd_nlt.copyright).to eq "Brought to you by BibleGateway.com. Copyright (C) NLT. All Rights Reserved."
-      end
+    it "returns copyright information" do
+      expect(votd_nlt.copyright).to eq "Brought to you by BibleGateway.com. Copyright (C) NLT. All Rights Reserved."
+    end
 
-      it 'returns the link' do
-        expect(votd_nlt.link).to eq 'https://www.biblegateway.com/passage/?search=Colossians+3%3A16&version=51'
+    it 'returns the link' do
+      expect(votd_nlt.link).to eq 'https://www.biblegateway.com/passage/?search=Colossians+3%3A16&version=51'
+    end
+
+    context 'with an invalid version code' do
+      it 'throws an error' do
+        expect{ Votd::BibleGateway.new(:foo) }.to raise_error(Votd::InvalidBibleVersion)
       end
     end
   end

data/votd.gemspec

@@ -5,7 +5,7 @@ Gem::Specification.new do |gem|
   gem.authors       = ["Steve Clarke", "Chris Clarke"]
   gem.email         = ["steve@sevenview.ca", "chris@seven7.ca"]
   gem.summary       = %q{Generate a (Bible) Verse of the Day using various web service wrappers}
-  gem.homepage      = "http://sevenview.github.com/votd"
+  gem.homepage      = "https://github.com/sevenview/votd"
 
   gem.files         = `git ls-files`.split($\)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: votd
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - Steve Clarke
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-27 00:00:00.000000000 Z
+date: 2019-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -206,7 +206,7 @@ files:
 - spec/lib/votd_spec.rb
 - spec/spec_helper.rb
 - votd.gemspec
-homepage: http://sevenview.github.com/votd
+homepage: https://github.com/sevenview/votd
 licenses:
 - MIT
 metadata: {}