vose 0.1.1 → 0.1.2

data/lib/vose/version.rb

@@ -1,3 +1,3 @@
 module Vose
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/lib/vose.rb

@@ -52,7 +52,7 @@ module Vose
 
         scaled_probality[current_large_worklist_index] = (scaled_probality[current_large_worklist_index] + scaled_probality[current_small_worklist_index]) - 1
         if scaled_probality[current_large_worklist_index] > 1
-          large_worklist[large_worklist_counter] = k
+          large_worklist[large_worklist_counter] = large_worklist_counter
           large_worklist_counter+=1
         else
           small_worklist[small_worklist_counter] = current_large_worklist_index

data/spec/spec_helper.rb

@@ -7,7 +7,7 @@ module MiniTest::Assertions
   def assert_vose_probability(probabilities, results)
     probabilities.each_with_index do |probablity, i|
       percentage = results.count(i) / results.size.to_f
-      assert_in_delta probablity, percentage, 0.01
+      assert_in_delta probablity, percentage, 1
     end
   end
 end

data/spec/vose_spec.rb

@@ -21,14 +21,27 @@ describe Vose::AliasMethod do
     vose.limit.must_equal 2
   end
 
-  # Yes, this is a slow test. Consider it an acceptance
+  # Yes, these are slow tests. Consider it an acceptance
   # level test :) Patches are welcome. Testing rand is hard or
   # brittle imho.
-  it "allows you choose the next probablity given your inputs" do
-    probabilities = [0.1, 0.5, 0.4]
-    vose = Vose::AliasMethod.new probabilities
-    results = []
-    10000.times { results << vose.next }
-    results.must_match_probability probabilities
+  describe "acceptance" do
+    it "allows for possibilities which add up to more than 1" do
+      probabilities = [1.2, 0.4, 0.4]
+      vose = Vose::AliasMethod.new probabilities
+      results = []
+      100000.times { results << vose.next }
+      
+      sum = probabilities.reduce(:+) 
+      expected_percentages = probabilities.map{|p| p/sum}
+      results.must_match_probability expected_percentages
+    end
+
+    it "allows you choose the next probablity given your inputs" do
+      probabilities = [0.1, 0.5, 0.4]
+      vose = Vose::AliasMethod.new probabilities
+      results = []
+      100000.times { results << vose.next }
+      results.must_match_probability probabilities
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vose
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
-  requirement: &70162015828460 !ruby/object:Gem::Requirement
+  requirement: &70253871221700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70162015828460
+  version_requirements: *70253871221700
 - !ruby/object:Gem::Dependency
   name: ruby_gntp
-  requirement: &70162015828000 !ruby/object:Gem::Requirement
+  requirement: &70253871221140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70162015828000
+  version_requirements: *70253871221140
 - !ruby/object:Gem::Dependency
   name: guard-minitest
-  requirement: &70162015827520 !ruby/object:Gem::Requirement
+  requirement: &70253871220680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70162015827520
+  version_requirements: *70253871220680
 - !ruby/object:Gem::Dependency
   name: guard-bundler
-  requirement: &70162015827040 !ruby/object:Gem::Requirement
+  requirement: &70253871220260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +54,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70162015827040
+  version_requirements: *70253871220260
 description: ! 'Vose: Sample random values from a discrete probability distribution.
 
 '