volabit 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eee00815e91c6b9ef5675445fbec8583f0933994
-  data.tar.gz: b29d96bb6053d3afd0767cb0161d26dbb827f69a
+  metadata.gz: 77b6cf56dff88cc357d9a04856919e788333b3a4
+  data.tar.gz: 152fef3f3cdb0f918f41e23a61f7f7a7a5619bae
 SHA512:
-  metadata.gz: 8474154744464f82bd1d6c05608e6c7f2b812dc9235bc7be2284d639c3395d089040d19a96319f7b541fa4e390547126341693927c6918ed4868447b04cf5439
-  data.tar.gz: e004c534fbf1b59ab8f0db75acd69ca030e144a31ab1cd0aa427d1c6c02c5e373465671b7553e7a1b11de6fd062325b26fc0ab7e4b116254a644acea79017b9a
+  metadata.gz: 9055028c38257d73ec0245cf1fe67a2d3319da8cc7abf9762282d9a40ae5b0c2001d9ec5a4223d19bd506985d814c046e4ffaaca1266556b6b9e96ce81932bb0
+  data.tar.gz: e82b112a608316ac63bb648be8b76acf2658e66e9723452754410872385b67adfe507208c17d5577c76d9405a56945dbc95f360bdaf081a48488e58769441dfa

data/.rubocop.yml

@@ -0,0 +1,14 @@
+AllCops:
+  TargetRubyVersion: 2.1
+
+Style/AccessModifierIndentation:
+  EnforcedStyle: outdent
+
+Metrics/LineLength:
+  Max: 90
+
+Style/Documentation:
+  Enabled: false
+
+Style/HashSyntax:
+  EnforcedStyle: ruby19

data/.travis.yml

@@ -0,0 +1,13 @@
+language: ruby
+sudo: false
+rvm:
+- 2.1
+- 2.2
+- 2.3.0
+notifications:
+  email:
+    on_success: change
+    on_failure: always
+script:
+- bundle exec rubocop
+- bundle exec rspec

data/CHANGELOG.md

@@ -5,20 +5,24 @@ You can see the supported releases on the [project GitHub repository](http://htt
 ## To Do
 - Add specs.
 - Add proper docs.
-- Automatics test suite run. (Codeship)
 
 ## Unreleased
 ### Added
 - No recent changes.
 
+## v1.1.1
+- Add travis builds
+- Add bumper using `./bump [-m, -n, -p, -h]`
+- Add rubocop and fix code style
+
 ## v1.1.0
 ### Added
-- Better token handling with `tokens`, `request_tokens`, `ùse_tokens` and `refresh_tokens` available from the client public methods.
+- Better token handling with `tokens`, `request_tokens`, `use_tokens` and `refresh_tokens` available from the client public methods.
 - Aliases for the methods with name changes.
-- `send_money` (`send_funds`) method replaces the `send` method to avoid the clash with the `Òbject#send` method.
+- `send_money` (`send_funds`) method replaces the `send` method to avoid the clash with the `Object#send` method.
 - ArgumentError exceptions for params on methods that use them to build the resource URL.
 
-###Fixed
+### Fixed
 - Refreshing the tokens now correctly sets the newly obtained tokens.
 - `Client#new_payment` docs tell that the method is available to all the users.
 

data/README.md

@@ -1,5 +1,6 @@
 
 [![Gem Version](https://badge.fury.io/rb/volabit.svg)](http://badge.fury.io/rb/volabit)
+[![Build Status](https://travis-ci.org/coincovemx/ruby-api-client.svg?branch=master)](https://travis-ci.org/coincovemx/ruby-api-client)
 
 # Volabit
 
@@ -64,10 +65,14 @@ auth_url = volabit_client.authorize
 volabit_client.request_tokens 'The given authorization code.'
 ```
 
-Or, if you already have a `token` and a `refresh_token` you can use:
+Or, if you already have an `access_token` and a `refresh_token` from the last call, you can use:
 
 ```ruby
-volabit_client.use_tokens 'token', 'refresh_token'
+tokens = {
+  access_token: 'access_token',
+  refresh_token: 'refresh_token'
+}
+volabit_client.use_tokens(tokens)
 ```
 
 4) You're ready to use our API. Just call any method listed [here][wiki].

data/Rakefile

@@ -1,4 +1,3 @@
-
 require 'bundler/gem_tasks'
 
 begin
@@ -9,6 +8,8 @@ begin
   RSpec::Core::RakeTask.new
   task default: :spec
   task test:    :spec
+end
 
-rescue LoadError
+task :console do
+  exec 'irb -r volabit -I ./lib'
 end

data/bump

@@ -0,0 +1,70 @@
+#!/usr/bin/env python
+import re, glob, sys, os
+
+__USAGE__ = \
+"""BUMP is a semantic versioning bump script which accepts the following
+mutually exclusive arguments:
+   -m - a "major" version bump equal to +1.0.0
+   -n - a "minor" version bump equal to +0.1.0
+   -p - a "patch" version bump equal to +0.0.1
+   -h - a "hot fix" version bump equal to +0.0.1
+
+   All of these options allow for the -r flag, which indicates that the state
+   is a RELEASE not a SNAPSHOT. If -r is not specified, then -SNAPSHOT is
+   appended to the updated version string."""
+
+__INITIAL__ = ['0', '0', '1']
+
+
+if __name__ == "__main__":
+    v = []
+    try:
+        version_file = glob.glob("lib/*/version.rb")[0]
+        raw_v = re.search(r'VERSION = \'(.*)\'', open(version_file).read(), re.M|re.I|re.S).group(1)
+        v = re.split(re.compile("\.|-"), raw_v)
+        v = v[0:3]
+        map(int, v)
+
+    except ValueError:
+        print("failed to parse the existing VERSION file, assuming v 0.0.1")
+        v = ['0', '0', '1']
+
+    except FileNotFoundError:
+        print("failed to find a VERSION file, assuming v 0.0.0")
+        v = ['0', '0', '0']
+
+    op = ''
+    try:
+        op = sys.argv[1]
+    except:
+        print(__USAGE__)
+        sys.exit(-1)
+
+    if(op == '-m'):
+        v = [str(int(v[0])+1), '0', '0']
+
+    elif(op == '-n'):
+        v = [v[0], str(int(v[1])+1), '0']
+
+    elif(op == '-p' or op == '-h'):
+        v = [v[0], v[1], str(int(v[2])+1)]
+
+    else:
+        print(__USAGE__)
+        sys.exit(-1)
+
+    v = '.'.join(v)
+
+    if(op == '-h'):
+      os.system("git checkout -b hotfix/v%s master" % v)
+
+    else:
+      os.system("git checkout -b release/v%s development" % v)
+
+    os.system("bump set %s" % v)
+
+    v += "\n"
+
+    print(v)
+
+    sys.exit(0)

data/lib/volabit.rb

@@ -4,7 +4,6 @@ require_relative 'volabit/api'
 require_relative 'volabit/version'
 
 module Volabit
-
   # Class that handles authorizations and API calls.
   class Client
     include Auth

data/lib/volabit/api.rb

@@ -6,7 +6,7 @@ require_relative 'api/transactions'
 
 module Volabit
   module API
-    private
+  private
 
     # Request given resource using the provided method and params.
     def resource(verb, resource, params = nil)
@@ -14,7 +14,7 @@ module Volabit
       refresh_tokens if @token.expired?
 
       response = @token.send(verb, resource, params: params)
-      JSON.parse response.body, :symbolize_names => true
+      JSON.parse response.body, symbolize_names: true
     end
 
     # Raises an exception intended when there is no OAuth2::AccessToken

data/lib/volabit/api/rates.rb

@@ -7,11 +7,10 @@ module Rates
   def spot_prices(amount, from: 'BTC', to: 'MXN')
     same_currencies_error if from.eql? to
 
-    resource :get, 'api/v1/spot-prices', {
-      currency_from: from,
-      currency_to: to,
-      amount: amount
-    }
+    resource :get, 'api/v1/spot-prices',
+             currency_from: from,
+             currency_to: to,
+             amount: amount
   end
 
   # Gets the exchange price list for the supported currencies.
@@ -19,7 +18,7 @@ module Rates
     resource :get, 'api/v1/tickers'
   end
 
-  private
+private
 
   def same_currencies_error
     raise ArgumentError, 'Currencies must be different.'

data/lib/volabit/api/slips.rb

@@ -3,14 +3,13 @@
 module Slips
   # Creates a slip that can be used to load the user wallet.
   def new_slip(currency:, amount:, type:)
-    resource :post, 'api/v1/users/me/slips', {
-      currency: currency,
-      amount: amount,
-      type: type
-    }
+    resource :post, 'api/v1/users/me/slips',
+             currency: currency,
+             amount: amount,
+             type: type
   end
 
-  alias_method :create_slip, :new_slip
+  alias create_slip new_slip
 
   # Gets the information of a specific slip.
   def get_slip_data(id:)
@@ -18,7 +17,7 @@ module Slips
     resource :get, "api/v1/users/me/slips/#{id}"
   end
 
-  alias_method :slip_data, :get_slip_data
+  alias slip_data get_slip_data
 
   # Deletes a specific slip.
   def delete_slip(id:)
@@ -29,21 +28,21 @@ module Slips
   # Informs of a receipt used to load a wallet's slip.
   def report_receipt(id:, amount:, affiliation:, authorization:)
     empty_param_error('id') if id.to_s.eql? ''
-    resource :post, "api/v1/users/me/slips/#{id}/report", {
-      amount: amount,
-      affiliation_number: affiliation,
-      authorization_number: authorization
-    }
+    resource :post, "api/v1/users/me/slips/#{id}/report",
+             amount: amount,
+             affiliation_number: affiliation,
+             authorization_number: authorization
   end
 
   # Lists the available options to load a slip.
-  def get_load_methods
+  def load_methods
     resource :get, 'api/v1/users/me/slips/methods'
   end
 
-  alias_method :load_methods, :get_load_methods
+  alias get_load_methods load_methods
+
+private
 
-  private
   def empty_param_error(param)
     raise ArgumentError, ":#{param} must not be nil or empty."
   end

data/lib/volabit/api/transactions.rb

@@ -4,39 +4,33 @@ module Transactions
   # Instantly buy bitcoins using fiat balance.
   # @note The amount is expected in satoshis.
   def buy_bitcoins(amount:)
-    resource :post, 'api/v1/users/me/buys', {
-      amount: amount
-    }
+    resource :post, 'api/v1/users/me/buys', amount: amount
   end
 
   # Instantly sell bitcoins to get fiat balance.
   # @note The amount is expected in satoshis.
   def sell_bitcoins(amount:)
-    resource :post, 'api/v1/users/me/sells', {
-      amount: amount
-    }
+    resource :post, 'api/v1/users/me/sells', amount: amount
   end
 
   # Instantly send fiat or bitcoins to an address.
   # @note The amount is expected in satoshis for bitcoins and cents for
   #       fiat currencies.
   def send_money(currency:, amount:, address:)
-    resource :post, 'api/v1/users/me/send', {
-      amount: amount,
-      address: address,
-      currency: currency
-    }
+    resource :post, 'api/v1/users/me/send',
+             amount: amount,
+             address: address,
+             currency: currency
   end
 
-  alias_method :send_funds, :send_money
+  alias send_funds send_money
 
   # Requests a special address to receive a bitcoin payment that will be
   # converted to the designated currency.
   def new_payment(currency:, amount:)
-    resource :post, 'api/v1/users/me/green-addresses', {
-      currency: currency,
-      amount: amount
-    }
+    resource :post, 'api/v1/users/me/green-addresses',
+             currency: currency,
+             amount: amount
   end
 end
 

data/lib/volabit/api/users.rb

@@ -4,22 +4,22 @@ module Users
   # Request the creation of a new user with the given params.
   # @note This action requires partner privileges.
   def create_user(acceptance:, email:, pass: '')
-    resource :post, 'api/v1/users', {
-      accepts_terms_of_service: acceptance,
-      user: {
-        email: email, password: pass
-      }
-    }
+    resource :post, 'api/v1/users',
+             accepts_terms_of_service: acceptance,
+             user: {
+               email: email,
+               password: pass
+             }
   end
 
-  alias_method :new_user, :create_user
+  alias new_user create_user
 
   # Gets the information details of the app user.
   def me
     resource :get, 'api/v1/users/me'
   end
 
-  alias_method :user_data, :me
+  alias user_data me
 end
 
 module Volabit

data/lib/volabit/auth.rb

@@ -25,7 +25,7 @@ module Volabit
     #         expiration POSIX time, or an error message it one occurs
     #         while requesting the tokens.
     def tokens
-      (@token.kind_of? OAuth2::AccessToken) ? @token.to_hash : @token
+      (@token.is_a? OAuth2::AccessToken) ? @token.to_hash : @token
     end
 
     # Requests and sets the access and refresh tokens to use the Volabit API
@@ -38,7 +38,7 @@ module Volabit
       tokens
     end
 
-    alias_method :get_token, :request_tokens
+    alias get_token request_tokens
 
     # Loads the client with the provided token information.
     #
@@ -51,7 +51,7 @@ module Volabit
       tokens
     end
 
-    alias_method :use_token, :use_tokens
+    alias use_token use_tokens
 
     # Triggers a refresh of the current tokens.
     #
@@ -73,7 +73,7 @@ module Volabit
       end
     end
 
-    private
+  private
 
     # Gets and sets information about the expiration time for provided
     # tokens without it.
@@ -91,10 +91,12 @@ module Volabit
 
     # Instances a new OAuth client to manage authorizations.
     def set_oauth_client(id, secret, env)
-      @oauth_client = OAuth2::Client.new(id, secret, {
+      @oauth_client = OAuth2::Client.new(
+        id,
+        secret,
         site: Volabit.site_for(env),
         raise_errors: false
-      })
+      )
     end
   end
 end

data/lib/volabit/common/constants.rb

@@ -3,9 +3,9 @@ module Volabit
   module Common
     module Constants
       # Base URL for the Volabit production environment.
-      PRODUCTION_SITE = 'https://www.volabit.com'
+      PRODUCTION_SITE = 'https://www.volabit.com'.freeze
       # Base URL for the Volabit test environment.
-      SANDBOX_SITE    = 'https://sandbox.volabit.com'
+      SANDBOX_SITE    = 'https://sandbox.volabit.com'.freeze
     end
   end
 end

data/lib/volabit/version.rb

@@ -1,3 +1,3 @@
 module Volabit
-  VERSION = "1.1.0"
+  VERSION = '1.1.1'.freeze
 end

data/spec/spec_helper.rb

@@ -1,84 +1,22 @@
-
-# Given that it is always loaded, you are encouraged to keep this file as
-# light-weight as possible. Requiring heavyweight dependencies from this file
-# will add to the boot time of your test suite on EVERY test run, even for an
-# individual file that may not need all of that loaded. Instead, consider making
-# a separate helper file that requires the additional dependencies and performs
-# the additional setup, and require it from the spec files that actually need it.
-#
-# The `.rspec` file also contains a few flags that are not defaults but that
-# users commonly want.
+require 'simplecov'
+# require 'coveralls'
+SimpleCov.start do
+  add_filter '/spec/'
+end
+# Coveralls.wear!
 
 require 'awesome_print'
 require 'pry-byebug'
 require 'pry-coolline'
 
-# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-  # rspec-expectations config goes here. You can use an alternate
-  # assertion/expectation library such as wrong or the stdlib/minitest
-  # assertions if you prefer.
   config.expect_with :rspec do |expectations|
-    # This option will default to `true` in RSpec 4. It makes the `description`
-    # and `failure_message` of custom matchers include text for helper methods
-    # defined using `chain`, e.g.:
-    # be_bigger_than(2).and_smaller_than(4).description
-    #   # => "be bigger than 2 and smaller than 4"
-    # ...rather than:
-    #   # => "be bigger than 2"
     expectations.include_chain_clauses_in_custom_matcher_descriptions = true
   end
 
-  # rspec-mocks config goes here. You can use an alternate test double
-  # library (such as bogus or mocha) by changing the `mock_with` option here.
   config.mock_with :rspec do |mocks|
-    # Prevents you from mocking or stubbing a method that does not exist on
-    # a real object. This is generally recommended, and will default to
-    # `true` in RSpec 4.
     mocks.verify_partial_doubles = true
   end
-
-  # The settings below are suggested to provide a good initial experience
-  # with RSpec, but feel free to customize to your heart's content.
-
-  # These two settings work together to allow you to limit a spec run
-  # to individual examples or groups you care about by tagging them with
-  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
-  # get run.
   config.filter_run :focus
   config.run_all_when_everything_filtered = true
-
-  # Limits the available syntax to the non-monkey patched syntax that is recommended.
-  # For more details, see:
-  #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
-  #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
-  #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
-  # config.disable_monkey_patching!
-
-  # Many RSpec users commonly either run the entire suite or an individual
-  # file, and it's useful to allow more verbose output when running an
-  # individual spec file.
-  if config.files_to_run.one?
-    # Use the documentation formatter for detailed output,
-    # unless a formatter has already been configured
-    # (e.g. via a command-line flag).
-    config.default_formatter = 'doc'
-  end
-
-  # Print the 10 slowest examples and example groups at the
-  # end of the spec run, to help surface which specs are running
-  # particularly slow.
-  # config.profile_examples = 10
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  # config.order = :random
-
-  # Seed global randomization in this process using the `--seed` CLI option.
-  # Setting this allows you to use `--seed` to deterministically reproduce
-  # test failures related to randomization by passing the same `--seed` value
-  # as the one that triggered the failure.
-  # Kernel.srand config.seed
 end

data/spec/volabit/volabit_spec.rb

@@ -2,8 +2,8 @@
 require File.expand_path('spec/spec_helper')
 require File.expand_path('lib/volabit')
 
-PRODUCTION_URL = 'https://www.volabit.com'
-SANDBOX_URL    = 'https://sandbox.volabit.com'
+PRODUCTION_URL = 'https://www.volabit.com'.freeze
+SANDBOX_URL    = 'https://sandbox.volabit.com'.freeze
 
 RSpec.describe Volabit do
   subject { described_class }

data/volabit.gemspec

@@ -4,19 +4,19 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'volabit/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "volabit"
+  spec.name          = 'volabit'
   spec.version       = Volabit::VERSION
-  spec.authors       = ["The Volabit Team & Contributors"]
-  spec.email         = ["hola@volabit.com"]
-  spec.summary       = %q{Library for the Volabit API.}
-  spec.description   = %q{Integrate the Volabit services in your app with ease.}
-  spec.homepage      = "https://github.com/coincovemx/api-client"
-  spec.license       = "MIT"
+  spec.authors       = ['The Volabit Team & Contributors']
+  spec.email         = ['hola@volabit.com']
+  spec.summary       = 'Library for the Volabit API.'
+  spec.description   = 'Integrate the Volabit services in your app with ease.'
+  spec.homepage      = 'https://github.com/coincovemx/api-client'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
   spec.add_runtime_dependency 'oauth2', '~> 1.0'
 
@@ -26,4 +26,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'pry-byebug', '~> 3.0'
   spec.add_development_dependency 'awesome_print', '~> 1.6'
   spec.add_development_dependency 'pry-coolline', '~> 0.2'
+  spec.add_development_dependency 'rubocop', '~> 0.36'
+  spec.add_development_dependency 'simplecov',   '~> 0.11'
+  spec.add_development_dependency 'bump', '~> 0.5', '>= 0.5.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: volabit
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - The Volabit Team & Contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-23 00:00:00.000000000 Z
+date: 2016-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oauth2
@@ -108,6 +108,54 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.2'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.36'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.36'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.11'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.11'
+- !ruby/object:Gem::Dependency
+  name: bump
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.5.3
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.5.3
 description: Integrate the Volabit services in your app with ease.
 email:
 - hola@volabit.com
@@ -118,6 +166,8 @@ files:
 - ".editorconfig"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".travis.yml"
 - ".yardopts"
 - CHANGELOG.md
 - CONTRIBUTORS.md
@@ -125,6 +175,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- bump
 - lib/volabit.rb
 - lib/volabit/api.rb
 - lib/volabit/api/rates.rb
@@ -159,7 +210,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Library for the Volabit API.