voipms_rates 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2f7dbba975776307743338eaaea14dfcc16ac458
-  data.tar.gz: ed82f5766454b66d3d54ee26ce3e04dab092f1d4
+  metadata.gz: 6cf6662e6e349dcb6c70f6d332ae8e3a78002324
+  data.tar.gz: 537ef583c571d0be3181a16d4d6f332d64bac9c6
 SHA512:
-  metadata.gz: 42206a0d55a8e60b0fe57b6b37c8f4bc971b29484e63c8b917df2d05f1ad45e6a070401df39e33942f19f6ebf57c9f3b2f8b8045742b8da92458657b74fa66ac
-  data.tar.gz: f8d81ff82ea99a071c7d2ee74f42fdcb382f77170c6f0964d02dc2eaf7a1680f8b09abae47055509305247237e3abfe2ea29e638b12e11a14f12859c47a43e47
+  metadata.gz: 6089e3f79a9f9f1a10d9e11d5353ee76620076914fe2f1b4bee65fb1ba1a7c89c43d536b3fe6f38983cab79e20ced17b348508a657dead8f0226334a5ea7b1a5
+  data.tar.gz: a34112c627adef82de063d13f2859040f7af588db046d78a931e9c5d626bae2c08b670461d657eacd539f691e8c079de36f474379721e1cc99d287509221d496

data/lib/voipms_rates/version.rb

@@ -1,3 +1,3 @@
 module VoipmsRates
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/lib/voipms_rates/version.rb~

@@ -1,3 +1,3 @@
 module VoipmsRates
-  VERSION = "0.0.1"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: voipms_rates
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Coaxial
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-20 00:00:00.000000000 Z
+date: 2015-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: adhearsion
@@ -150,8 +150,8 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 2.9.3
-description: Uses the voip.ms public API to fetch premium or value rates per minute
-  for any phone number.
+description: An Adhearsion plugin using the voip.ms public API to fetch premium or
+  value rates per minute for any phone number.
 email:
 - py@poujade.org
 executables: []
@@ -162,20 +162,14 @@ files:
 - README.md
 - Rakefile
 - lib/voipms_rates.rb
-- lib/voipms_rates.rb~
 - lib/voipms_rates/controller_methods.rb
-- lib/voipms_rates/controller_methods.rb~
 - lib/voipms_rates/plugin.rb
-- lib/voipms_rates/plugin.rb~
 - lib/voipms_rates/version.rb
 - lib/voipms_rates/version.rb~
 - spec/spec_helper.rb
-- spec/spec_helper.rb~
 - spec/support/vcr_setup.rb
-- spec/support/vcr_setup.rb~
 - spec/voipms_rates/controller_methods_spec.rb
-- spec/voipms_rates/controller_methods_spec.rb~
-homepage: ''
+homepage: https://github.com/Coaxial/voipms_rates
 licenses:
 - MIT
 metadata: {}
@@ -195,14 +189,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: voipms_rates
-rubygems_version: 2.2.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
-summary: Get voip.ms calling rates for given phone numbers.
+summary: voip.ms calling rates within your Adhearsion app.
 test_files:
 - spec/spec_helper.rb
-- spec/spec_helper.rb~
 - spec/support/vcr_setup.rb
-- spec/support/vcr_setup.rb~
 - spec/voipms_rates/controller_methods_spec.rb
-- spec/voipms_rates/controller_methods_spec.rb~

data/lib/voipms_rates.rb~

@@ -1,4 +0,0 @@
-# VoipmsRates = Module.new
-require "voipms_rates/version"
-require "voipms_rates/plugin"
-require "voipms_rates/controller_methods"

data/lib/voipms_rates/controller_methods.rb~

@@ -1,69 +0,0 @@
-module VoipmsRates
-  module ControllerMethods
-
-    require 'rest-client'
-    require 'nokogiri'
-
-    # Parameters:
-    # phone_number [Int] The number for which we want to get the rate
-    def get_rate_for(phone_number)
-      if phone_number.match(/(\d*)@.*/)
-        @digits = phone_number.match(/(\d*)@.*/)[1] 
-      elsif phone_number.match(/[\d]+/)
-        @digits = phone_number.match(/(\d+)/)[1]
-      else
-        raise(TypeError)
-      end
-
-      return try_patterns(@digits)
-    end
-
-    def try_patterns(digits)
-      rates_endpoint = Adhearsion.config[:voipms_rates].rates_endpoint
-      # The rates API only works with part of the phone number. If it gets the full phone number, it won't find the
-      # rate. If it doesn't get enough digits, it won't find the rate either. And if it gets too many digits, it won't
-      # find the rate...
-      # For example:
-      # To get the rate for '33912345678' (France), you would need to send '339'
-      # To get the rate for '15145551234' (Canada), you would need to send '1514'
-      # To get the rate for '12125551234' (USA), you would need to send '1'
-      #
-      high_count = digits.length >= 5 ? 5 : digits.length # This speeds things up with shorter numbers
-      for i in high_count.downto(1) do
-        pattern = digits[0, i]
-        api_response = RestClient.get(rates_endpoint, {
-          params: {
-            pattern: pattern 
-          }
-        })
-        
-        xml_doc = Nokogiri::XML(api_response)
-        
-        if xml_doc.xpath('/results')[0]
-          country = xml_doc.at_xpath('/results/item/short_description').content.to_s
-          return xml_doc.at_xpath('/results/item/rate_premium').content.to_f if ((country === 'Canada' && Adhearsion.config[:voipms_rates].canada_use_premium) || ((country != 'Canada' || country != 'USA') && Adhearsion.config[:voipms_rates].intl_use_premium))
-          return xml_doc.at_xpath('/results/item/rate').content.to_f
-
-          # We use the premium route for Canada but the value route for all other destinations.
-          # Because the API sends back both premium and value rates, this has to be done:
-          #
-          # country = xml_doc.at_xpath('/results/item/short_description').content.to_s
-          # case country
-          # when 'Canada'
-          #   return xml_doc.at_xpath('/results/item/rate_premium').content.to_f
-          # else
-          #   return xml_doc.at_xpath('/results/item/rate').content.to_f
-          # end
-        elsif i === 1 && xml_doc.xpath('error')[0]
-          error_code = xml_doc.at_xpath('/error/code').content.to_s
-          error_desc = xml_doc.at_xpath('/error/description').content.to_s
-
-          logger.error("No rate found for '#{pattern}', error code '#{error_code}' (#{error_desc})")
-          return nil
-        end
-      end
-    end 
-
-    private :try_patterns
-  end
-end

data/lib/voipms_rates/plugin.rb~

@@ -1,53 +0,0 @@
-module VoipmsRates
-  class Plugin < Adhearsion::Plugin
-
-    require_relative "version"
-
-    # Actions to perform when the plugin is loaded
-    #
-    init :voipms_rates do
-      logger.warn "VoipmsRates has been loaded"
-    end
-
-    # Basic configuration for the plugin
-    #
-    config :voipms_rates do
-      rates_endpoint 'https://www.voip.ms/rates/xmlapi.php', desc: "The URL for voip.ms' rates API endpoint"
-      canada_use_premium false, desc: "Set to true if you are using premium routing for calls to Canada or false for
-      standard routing (change this setting on voip.ms > Account Settings > Account Routing)"
-      intl_use_premium false, desc: "Set to true if you are using premium routing for International calls or false for
-      standard routing (change this setting on voip.ms > Account Settings > Account Routing)"
-    end
-
-    # Defining a Rake task is easy
-    # The following can be invoked with:
-    #   rake plugin_demo:info
-    #
-    tasks do
-      namespace :voipms_rates do
-        desc "Prints the PluginTemplate information"
-        task :info do
-          STDOUT.puts "VoipmsRates plugin v. #{VERSION}"
-        end
-
-        desc "Checks the current Canada routing setting (Should match your settings on voip.ms > Account Settings >
-        Account Routing)"
-        task :canada_use_premium do
-          rate = Adhearsion.config[:voipms_rates].canada_use_premium ? 'premium' : 'standard'
-          STDOUT.puts "Using Canada #{rate} routes rate."
-          # TODO edit with instructions to set in config file
-          STDOUT.puts "The value can be changed in your app's config file at config/adhearsion.rb"
-        end
-
-        desc "Checks the current International routing setting (Should match your settings on voip.ms > Account
-        Settings > Account Routing)"
-        task :intl_use_premium do
-          rate = Adhearsion.config[:voipms_rates].intl_use_premium ? 'premium' : 'standard'
-          STDOUT.puts "Using international #{rate} routes rate."
-          STDOUT.puts "The value can be changed in your app's config file at config/adhearsion.rb"
-        end
-      end
-    end
-
-  end
-end

data/spec/spec_helper.rb~

@@ -1,21 +0,0 @@
-require 'adhearsion'
-require 'voipms_rates'
-require 'webmock/rspec'
-
-# Require any .rb file in spec/support
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
-
-RSpec.configure do |config|
-  config.color = true
-  config.tty = true
-
-  config.filter_run :focus => true
-  config.run_all_when_everything_filtered = true
-
-  config.before(:each) do
-    stub_request(:get, /https:\/\/www\.voip\.ms\/rates\/xmlapi\.php/).
-     with(:headers => {'Accept'=>'*/*; q=0.5, application/xml', 'Accept-Encoding'=>'gzip, deflate', 'User-Agent'=>'Ruby'}).
-     to_return(:status => 200, :body => "", :headers => {})
-  end
-end
-

data/spec/support/vcr_setup.rb~

@@ -1,5 +0,0 @@
-require 'vcr'
-VCR.configure do |config|
-  config.cassette_library_dir = 'fixtures/vcr_cassettes'
-  config.hook_into :webmock
-end

data/spec/voipms_rates/controller_methods_spec.rb~

@@ -1,100 +0,0 @@
-require 'spec_helper'
-
-module VoipmsRates
-  describe ControllerMethods do
-    describe "mixed in to a CallController" do
-
-      class TestController < Adhearsion::CallController
-        include VoipmsRates::ControllerMethods
-      end
-
-      let(:mock_call) { double 'Call' }
-
-      subject do
-        TestController.new mock_call
-      end
-
-      describe '#get_rate_for' do
-        
-        let(:canadian_number) { '15145551234' }
-        let(:us_number) { '12125551234' }
-        let(:french_number) { '33953123456' }
-        let(:unroutable_number) { '9' }
-        let(:sip_string) { 'sip:15145551234@127.0.0.1' }
-        let(:invalid_string) { 'invalid number' }
-
-        context 'when the premium rate is requested' do
-
-          context 'with a valid number' do
-            it 'returns the premium rate for Canada' do
-              # This setting is toggled with `rake voipms_rates:canada_use_premium`
-              Adhearsion.config[:voipms_rates].canada_use_premium = true
-              VCR.use_cassette('canada_premium_rate') do
-                expect(subject.get_rate_for(canadian_number)).to eq(0.009)
-              end
-              Adhearsion.config[:voipms_rates].canada_use_premium = false
-            end
-
-            it 'returns the premium rate for the US' do
-              VCR.use_cassette('us_premium_rate') do
-                expect(subject.get_rate_for(us_number)).to eq(0.01)
-              end
-            end
-
-            it 'returns the premium rate for France' do
-              # This setting is toggled with `rake voipms_rates:intl_use_premium`
-              Adhearsion.config[:voipms_rates].intl_use_premium = true
-              VCR.use_cassette('france_premium_rate') do
-                expect(subject.get_rate_for(french_number)).to eq(0.0431)
-              end
-              Adhearsion.config[:voipms_rates].intl_use_premium = false
-            end
-          end
-
-          context 'with an unroutable number' do
-            it 'returns "nil"' do
-              VCR.use_cassette('unroutable_number') do
-                expect(subject.get_rate_for(unroutable_number)).to eq(nil)
-              end
-            end
-          end
-        end
-
-        context "when the premium rate isn't requested" do
-          context 'with a valid number' do
-            it 'returns the value rate' do
-              VCR.use_cassette('canada_standard_rate') do
-                expect(subject.get_rate_for(canadian_number)).to eq(0.0052)
-              end
-            end
-          end
-
-          context 'with an unroutable number' do
-            it 'returns "nil"' do
-              VCR.use_cassette('unroutable_number') do
-                expect(subject.get_rate_for(unroutable_number)).to eq(nil)
-              end
-            end
-          end
-
-          context 'with a sip string' do
-            it 'returns the rate' do
-              VCR.use_cassette('sip_string') do
-                expect(subject.get_rate_for(sip_string)).to eq(0.0052)
-              end
-            end
-          end
-        end
-
-        context 'with an invalid string' do
-          it 'returns a TypeError' do
-            VCR.use_cassette('invalid_string') do
-              expect{subject.get_rate_for(invalid_string)}.to raise_error
-            end
-          end
-        end
-      end
-
-    end
-  end
-end