voight_kampff 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4c6adf1c9f085e2e6635957d63cd8cab207f3a07
-  data.tar.gz: 6e2949e6c89a8c2f3aafe2f07a726788a60711c2
+  metadata.gz: f1f725ef9bb3130917b515802108e7afa6c5f923
+  data.tar.gz: db35fc150b61de1541d88893316d716d1584dd9d
 SHA512:
-  metadata.gz: e36f897ff189876f736676aca23c5fbc948562f28fd16887ca9daba33da98fc5b779d6e5a3823c9c11d0b1faa2731dc51257c6c227c0150ad9e6882e69607945
-  data.tar.gz: cc62b19d3b66917f1d8afc91f74b0ba447d7dff859cb8e0622e30fa50632325363fb30d17dc256c9e77734a3a919d5a750b08ccbd5df040cf2c8ed2074535b0f
+  metadata.gz: cfcccea8835dbb3857bae599f4b15dc93d49d846b2be5b0f27fa83b5c59cbe94b412bb71feab1b50e8ec284a94399fc4316ffdc3d6aa2852ad734b54750bc609
+  data.tar.gz: 9ac3a9a20d1c4e88faf9d4a7575c3ade972ff27efe936c4d6cfca851f2045680f0829d6353a02029b539f01bd2fcba32613dd03f3dd77f493cf9410e9aedeafa

data/lib/voight_kampff/test.rb

@@ -9,11 +9,7 @@ module VoightKampff
     end
 
     def agent
-      load_crawlers
-
-      @agent ||= @@crawlers.find do |crawler|
-        self.user_agent_string =~ Regexp.new(crawler['pattern'], Regexp::IGNORECASE)
-      end || {}
+      @agent ||= matching_crawler || {}
     end
 
     def human?
@@ -40,7 +36,24 @@ module VoightKampff
       lookup_paths.find { |path| File.exists? path }
     end
 
-    def load_crawlers
+    def matching_crawler
+      if match = crawler_regexp.match(@user_agent_string)
+        index = match.names.first.sub(/match/, '').to_i
+        crawlers[index]
+      end
+    end
+
+    def crawler_regexp
+      @@crawler_regexp ||= begin
+        # NOTE: This is admittedly a bit convoluted but the performance gains make it worthwhile
+        index = -1
+        crawler_patterns = crawlers.map{|c| index += 1; "(?<match#{index}>#{c["pattern"]})" }.join("|")
+        crawler_patterns = "(#{crawler_patterns})"
+        Regexp.new(crawler_patterns, Regexp::IGNORECASE)
+      end
+    end
+
+    def crawlers
       @@crawlers ||= JSON.load(File.open(preferred_path, 'r'))
     end
   end

data/lib/voight_kampff/version.rb

@@ -1,3 +1,3 @@
 module VoightKampff
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
 end

data/spec/lib/voight_kampff/test_spec.rb

@@ -25,4 +25,12 @@ describe VoightKampff::Test do
       end
     end
   end
+
+  context 'after the first run' do
+    before { VoightKampff::Test.new('anything').bot? }
+
+    it 'is fast' do
+      expect(Benchmark.realtime { 20.times { VoightKampff::Test.new('anything').bot? } }).to be < 0.002
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: voight_kampff
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Adam Crownoble
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-02 00:00:00.000000000 Z
+date: 2015-12-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack