voids 2.1.0 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2ddc0ec3f6eb944d0b91f7d661887b9ef36c7b6e02aa63606cf8eafff8a6c71a
-  data.tar.gz: 8fe0046ebed0bf511b7ce893a8e2cc48269233f7c617469c6e80e262d953d249
+  metadata.gz: 66922bf400447b157fb6b27cfc70a8e9cf7da4c60629824f5f40b5661fd5336a
+  data.tar.gz: 506f410f8806f92fdd5cd5e1d1b3289b0932ebd84d1dc7f0a85756598acbbfaf
 SHA512:
-  metadata.gz: 522dd880a0decbaadc5f8584e84ba822cf00f777653c829f618a7626a851a0088125c45c4ec25f382e56b7bf588a114f1a7edf5978794586bebfcb8e5a076a9c
-  data.tar.gz: 8135b1214dc06dae3f6e2e691a250a30a4708de8b661cc1b82ad96f05020ce5b10cfc1c6586e6044dd12fa0fdb94c823ef6851df4ee20acec95e7f9916fa11be
+  metadata.gz: 5482cbb6ce7d7efd0729acb4274cd6fd30440ffc48b0088b15bdef99e802ab8a880c0585dacd4a28168b35499e2878f0107696c0b29db9203eed609e8bb55b82
+  data.tar.gz: 9d2d5befe25f3f6227f907144136f7b584b0d44a770bdb47d9cadda4f4cfca7bccffa14605dbd93e0f99fb9b1935b678672001f5cf2730ed45f85963ebe040b8

data/CHANGELOG.md

@@ -1,12 +1,26 @@
-## [Unreleased]
+# [Unreleased]
+
+- ...
+
+# [3.0.0] - 2026-09-21
+
+- **Breaking:** no longer add an `:invalid` error to the association itself when a nested form is invalid. Nested errors are copied to the parent under `association.attribute` / `association[index].attribute` keys only, matching `ActiveRecord`'s autosave association behavior, which `accepts_nested_attributes_for` implies. Callers that checked `errors[:association]` should check for the copied nested keys instead.
+- Validate each nested form exactly once per parent validation, rather than two to three times.
+- Make `AssociationProxy#any?` block-aware (matching Ruby collection semantics).
+
+# [2.1.0] - 2026-09-15
 
-- Add `changes_applied:` option to `Voids::Base#assign_attributes` so callers can bulk-assign attributes without resetting dirty tracking.
 - Propagate validation context to nested forms during parent validation.
 - Validate nested forms even when parent validations fail, so nested errors still bubble up.
 - Add `Voids::Base#empty?` with default emptiness semantics based on blank attributes.
-- Make `AssociationProxy#any?` block-aware (matching Ruby collection semantics).
 - Add `AssociationProxy#reverse` for array-like read access without explicit `to_a` conversion.
+- Add `changes_applied:` option to `Voids::Base#assign_attributes` so callers can bulk-assign attributes without resetting dirty tracking.
+- Add CI/coverage/version badges to README
+
+# [2.0.0] - 2026-09-14
+
+- Re-released as voids gem
 
-## [1.0.0] - 2026-01-13
+# [1.0.0] - 2026-01-13
 
 - Initial release

data/README.md

@@ -200,6 +200,15 @@ form.valid?(:publish) # false
 form.errors.full_messages # includes nested form errors
 ```
 
+Nested errors are copied onto the parent, keyed by the association and the nested
+attribute. As in `ActiveRecord`, no error is added to the association itself:
+
+```ruby
+form.errors.messages.keys # => [:"images[0].url"]  (has_many)
+form.errors.messages.keys # => [:"author.name"]    (has_one)
+form.errors[:images]      # => []
+```
+
 ### Extracting attributes for persistence
 
 Use `model_attributes` for the form's own attributes:

data/lib/voids/base.rb

@@ -247,17 +247,15 @@ module Voids
         when :has_one
           next if nested_form.valid?(context)
 
-          errors.add(name.to_sym, :invalid)
           copy_nested_errors(name, nested_form)
           all_valid = false
         when :has_many
-          next if nested_form.valid?(context)
-
-          errors.add(name.to_sym, :invalid)
           nested_form.each_with_index do |form, index|
-            copy_nested_errors("#{name}[#{index}]", form) unless form.valid?(context)
+            next if form.valid?(context)
+
+            copy_nested_errors("#{name}[#{index}]", form)
+            all_valid = false
           end
-          all_valid = false
         end
       end
 

data/lib/voids/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Voids
-  VERSION = '2.1.0'
+  VERSION = '3.0.0'
 end

data/spec/voids/base_spec.rb

@@ -386,8 +386,8 @@ RSpec.describe Voids::Base do
       form.images.new
 
       expect(form.valid?).to be(false)
-      expect(form.errors.details[:images]).to include(error: :invalid)
-      expect(form.errors.messages.keys).to include(:'images[0].url')
+      expect(form.errors.messages.keys).to contain_exactly(:'images[0].url')
+      expect(form.errors[:images]).to be_empty
     end
 
     it 'includes nested form errors in parent errors' do
@@ -407,8 +407,8 @@ RSpec.describe Voids::Base do
       form.build_photo
       form.valid?
 
-      expect(form.errors.messages.keys).to include(:photo, :'photo.url')
-      expect(form.errors.details[:photo]).to include(error: :invalid)
+      expect(form.errors.messages.keys).to contain_exactly(:'photo.url')
+      expect(form.errors[:photo]).to be_empty
     end
 
     it 'includes nested form errors in parent even when parent has errors' do
@@ -429,8 +429,8 @@ RSpec.describe Voids::Base do
       form.build_photo
       form.valid?
 
-      expect(form.errors.messages.keys).to contain_exactly(:title, :photo, :'photo.url')
-      expect(form.errors.details[:photo]).to include(error: :invalid)
+      expect(form.errors.messages.keys).to contain_exactly(:title, :'photo.url')
+      expect(form.errors[:photo]).to be_empty
     end
 
     it 'passes the validation context to nested forms' do
@@ -452,8 +452,34 @@ RSpec.describe Voids::Base do
       form.build_photo(url: 'http://myspace.com/sicily-photos')
       form.valid?(:final_setup)
 
-      expect(form.errors.messages.keys).to contain_exactly(:photo, :'photo.url')
-      expect(form.errors.details[:photo]).to include(error: :invalid)
+      expect(form.errors.messages.keys).to contain_exactly(:'photo.url')
+      expect(form.errors[:photo]).to be_empty
+    end
+
+    it 'validates each nested form exactly once' do
+      validation_counts = Hash.new(0)
+      nested_class = Class.new(described_class) do
+        attribute :url, :string
+        validate do
+          validation_counts[url] += 1
+          errors.add(:url, :blank) if url.blank?
+        end
+      end
+      stub_const('ImageForm', nested_class)
+
+      form_class = Class.new(described_class) do
+        has_many :images
+        attribute :title, :string
+      end
+      stub_const('ImageGalleryForm', form_class)
+
+      form = form_class.new(title: 'test')
+      %w[first second].each { |url| form.images.new(url:) }
+      form.images.new(url: '')
+      form.images.new(url: 'fourth')
+      form.valid?
+
+      expect(validation_counts).to eq({ 'first' => 1, 'second' => 1, '' => 1, 'fourth' => 1 })
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: voids
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Josh Brody