voicecom_sms 2.0.1 → 3.0.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    N2M2MDhiM2JhOTI1NGMwNmE0MDVjYmQ4MWZhMjZjZDRmOTVlZWQyNQ==
+    YzRjM2YwZDEyZTg0ZGNjNTZkNDkwM2Y5NDA3ODNjMmU4OWFmM2ZlYg==
   data.tar.gz: !binary |-
-    ZjMxZWRiZDFhOWI5YWE4ZDA1MDU2MTVmYmFhYWYyM2I1ZDA4NTgyMg==
+    YTdjOGQxZDZiMGQ5NmIyNWFmZDRiMTk3MmRmNGMxODJlYjhmNWI3OQ==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    OGQ4MjY3MzI0NTRjNWQ3MGNkMDMwZmI2NDU0YzFlNzM1OTE5ZjNkMDc1YzA4
-    NmE3YmQxNGE3ZWI1OTJhNDM5ZDFlNTRhOWYzNWFlMzQxM2VhY2M3MTFmYTYz
-    ZjFmZTI3OWQwY2YxMTA5YTZmYjdhMjRlN2Q2YjM4MzQ3MmVjYzI=
+    NmVjZDk4ZjM3ZjhhZDMzZGM1NmYxZGNkYTgxNzVkYmM4NmMxZWZlNWZiZDY4
+    NGJkM2NiMmRhZTVjOGJlNTczZmNkMGQzOTJmNGZjZDBhOTQ1ZTY5NTdlYjE1
+    M2JjYTU5N2ZlMTYzODdhODkwNmFjYWRkNTY3N2VhOWI4MzdhOGQ=
   data.tar.gz: !binary |-
-    YjdhZGY4OTU3NDQwZTg0NmU3MTRhZTIyYThhZWU0YTU4MDFiOGQwYTMyNGEx
-    OTI0YzUyMjQzNTY4MDZmZTg4NGIwMGIxMTUzMDkzM2RjNDk3ZTNhM2JjY2Q5
-    MDQzNzBlYmM4M2E5YTE3M2VkODRjZjhjMjRiMjcyYjE2ZjA1MTE=
+    NDkwZTNhOTNhNjBiMTE4Yzk3NWI4YmMzZjk4YzQ3ZDg0YzUyMWVjYjhmMGM5
+    M2ZlYTJjZDFlMjZlNGRiM2Q5YTI4Y2U1MmQ4ZTc3ZjIzYzYzMWQ2Y2RkNGJi
+    ZWEzZjEzNzVlYTk4ZjgwYjc4ZjQzOWJlZjI3MTVhMDM5YWU3ZjY=

data/README.md

@@ -2,7 +2,7 @@
 
 [![Build Status](https://travis-ci.org/empowerunited/voicecom_sms.png?branch=master)](https://travis-ci.org/empowerunited/voicecom_sms)
 
-This ia a simple interface to the VoiceCom SMS API, designed for rails applications.
+This is a interface to the VoiceCom SMS API, designed for ruby application.
 
 ## Installation & Usage
 
@@ -33,7 +33,7 @@ by filling your credentials for the VioceCom API
 rails c
 
     @provider = VoicecomSms::Provider.new
-    @provider.send_sms('0888889204', "Vashiyat kod e: 1234")
+    @provider.send_sms('359888889204', "Vashiyat kod e: 1234")
 
 
 ### irb example
@@ -51,7 +51,7 @@ irb
     end
 
     @provider = VoicecomSms::Provider.new
-    @provider.send_sms('0888889204', "Вашият код в Клуб 50+ е: : 1234")
+    @provider.send_sms('359888889204', "Вашият код е: : 1234")
 
 Note:
 The message should match the template you have given to voicecom

data/VERSION

@@ -1 +1 @@
-2.0.1
+3.0.0

data/lib/voicecom_sms/provider.rb

@@ -18,6 +18,13 @@ module VoicecomSms
       @response = nil
     end
 
+    #
+    # Send the text message to the number
+    # @param  number String Only digits, country code included.
+    #                       example: for Bulgaria (+359) and mobile number 899947121 you should use '359899947121'
+    # @param  text String No idea what characters is supported by voicecom - have to experiment. UTF-8 with latin works for sure.
+    #
+    # @return integer VoicecomSms::Provider::STATUS
     def send_sms(number, text)
       message = VoicecomSms::Message.create({text: text, number: normalize_number(number), status: STATUS[:undefined]})
 
@@ -38,8 +45,6 @@ module VoicecomSms
 
     def normalize_number(number)
       number.gsub!(/\s+/, '')
-      number.sub!(/^(\+|00)/, '')
-      number.sub!(/^0/, '359')
       number
     end
 

data/spec/voicecom_sms/provider_spec.rb

@@ -33,12 +33,6 @@ describe VoicecomSms::Provider do
       }.to change(VoicecomSms::Message, :count).by(1)
     end
 
-    it "should try to convert the number to a valid one" do
-      @provider.send_sms("+#{destination_mobile_number}", 'some message')
-      message = VoicecomSms::Message.last
-      message.number.should == destination_mobile_number
-    end
-
     it "should set the query params in the request" do
       @provider.request.params.should be_blank
       @provider.send_sms(destination_mobile_number, 'some message')
@@ -69,18 +63,4 @@ describe VoicecomSms::Provider do
     end
   end
 
-  describe "#normalize_number" do
-    before(:all) do
-      @provider = VoicecomSms::Provider.new
-    end
-
-    it "should convert the number to an acceptable by the API value" do
-      acceptable_value = destination_mobile_number
-
-      @provider.normalize_number('359899947329').should == acceptable_value
-      @provider.normalize_number('0899947329').should == acceptable_value
-      @provider.normalize_number('00359899947329').should == acceptable_value
-      @provider.normalize_number('+359899947329').should == acceptable_value
-    end
-  end
 end

data/voicecom_sms.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "voicecom_sms"
-  s.version = "2.0.1"
+  s.version = "3.0.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Empowerunited", "Evgenia Manolova", "Gudata"]
-  s.date = "2013-08-09"
+  s.date = "2013-08-12"
   s.description = "A fast SMS engine that uses VoiceCom as a service provider"
   s.email = "devteam@empowerunited.com"
   s.extra_rdoc_files = [

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: voicecom_sms
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 3.0.0
 platform: ruby
 authors:
 - Empowerunited
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-09 00:00:00.000000000 Z
+date: 2013-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord