vnpay 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a1cfaf461ce01c3cec27cb39139e07386d13e7242a122336b68f15e8f61ddcb6
-  data.tar.gz: 718b20676b4b9e578a32dcc9dcee2afe09c15e727fe594b8b8bf7553459e579b
+  metadata.gz: e6ea2c77c749d22a99f73c651c26ec62db8fa5c6b1b04116bbe020083167c5ef
+  data.tar.gz: 494462d3625a556d1a90089fc7402e6fd01188a4f64ef9e18e444433a9b204aa
 SHA512:
-  metadata.gz: 81330b3a293f8f247290138ced86bd2f19a8a99ba7883149c0b2f04c790ab1bdc1b262500268116abec8f9f18b8fd18585a4b3b03d863dd4856ff37fec8452e2
-  data.tar.gz: 316fab10bd1381897a54def919d25850041001933375978da328cc60b93096af755fd0a7375fa3723b2937793ccf7b4abe26cffd632244f6ed826a00d9041461
+  metadata.gz: 4dca55f6c3f11a28eb8e2a907c4c1ced24b8722b7e43815949acf90529a8c774c90f60f75ee7ae1e81d80efe89ac9fd9d108af8d9a7e5d6069b81fc0125f73c4
+  data.tar.gz: f64a928f0d43ebf18a97ec35867cd0771d38cd093e5d3e5dd73a0ef0f611786747c1d878fe5d756bbd622fc18ffb9acbaf101d4c19ea201ecef8d5a2b43653f7

data/README.md

@@ -1,2 +1,46 @@
-# vnpay
-Ruby gem for VNPay integration
+VNPay
+========
+
+A Ruby gem for VNPay integration
+
+Introduction
+------------
+
+VNPAY Payment Gateway is an intermediate system to transmit, exchange and process payment transactions between consumers owning card, bank account or e-wallet and enterprises providing goods, services on the Internet.
+
+Installation
+------------
+
+### Bundler
+
+Add the Airbrake gem to your Gemfile:
+
+```ruby
+gem 'vnpay'
+```
+
+### Manual
+
+Invoke the following command from your terminal:
+
+```bash
+gem install vnpay
+```
+
+### Configuration
+
+To integrate VNPay with your Rails application, you need to know your secret_key, payment URL and your website code. You can ask VNPay directly to get these information, then config them as following:
+
+```ruby
+Vnpay::Config.configure do |config|
+  config.secret_key = ENV['VNPAY_SECRET_KEY']
+  config.payment_url = ENV['VNPAY_PAYMENT_URL']
+  config.website_code = ENV['VNPAY_WEBSITE_CODE']
+end
+```
+
+### How to use
+
+...
+
+

data/lib/vnpay.rb

@@ -1,4 +1,4 @@
-require 'order_info'
+require 'vnpay/order_info'
 require 'vnpay/config'
 require 'vnpay/verify'
 require 'vnpay/url'

data/lib/vnpay/order_info.rb

@@ -0,0 +1,15 @@
+module Vnpay
+  class OrderInfo
+    attr_accessor :order_type, :payment_ref, :amount, :description, :created_at
+
+    def created_at=(value)
+      @created_at = value&.strftime('%Y%m%d%H%M%S')
+    end
+
+    def valid?
+      [:order_type, :payment_ref, :amount, :description, :created_at].map do |attribute|
+        !!send(attribute)
+      end.all?
+    end
+  end
+end

data/lib/vnpay/url.rb

@@ -9,6 +9,7 @@ module Vnpay
     end
 
     def generate
+      raise "OrderInfo missing attributes" unless order_info.valid?
       config.payment_url + query_string + "&vnp_SecureHashType=MD5&vnp_SecureHash=#{secure_hash}"
     end
 
@@ -32,7 +33,7 @@ module Vnpay
         vnp_IpAddr:       ip_address,
         vnp_Locale:       'vn',
         vnp_OrderInfo:    order_info.description.to_s,
-        vnp_OrderType:    "250000",
+        vnp_OrderType:    order_info.order_type.to_s,
         vnp_ReturnUrl:    callback_url,
         vnp_TmnCode:      config.website_code,
         vnp_TxnRef:       order_info.payment_ref.to_s,
@@ -48,4 +49,4 @@ module Vnpay
       Rack::Utils.escape(string)
     end
   end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vnpay
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - nhannvu19
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.1'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Ruby library for VNPay integration
 email:
 - nhannvu.19@gmail.com
@@ -33,9 +47,9 @@ extra_rdoc_files: []
 files:
 - README.md
 - Rakefile
-- lib/order_info.rb
 - lib/vnpay.rb
 - lib/vnpay/config.rb
+- lib/vnpay/order_info.rb
 - lib/vnpay/url.rb
 - lib/vnpay/verify.rb
 homepage: https://github.com/nhannvu19/vnpay

data/lib/order_info.rb

@@ -1,7 +0,0 @@
-class OrderInfo
-  attr_accessor :payment_ref, :amount, :description, :created_at
-
-  def created_at=(value)
-    @created_at = value.strftime('%Y%m%d%H%M%S')
-  end
-end