vng 2.2.0 → 2.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4971f6a848df0d985ca1d1d86b735e80fec57624c2214cddf5c8201cdab96a9a
-  data.tar.gz: 6d4402e9d16b3b75fd8bb76da8773121e5c77d009ee234025a95d61af0928870
+  metadata.gz: 240226a07b22399db9b611a1651c0ca709b931620ac224e7ac01e2e289e4cd97
+  data.tar.gz: f10775485ccc1b6cdc9a9873a5a9296b4ac4fb2796f4d1a2afadb7eec1165264
 SHA512:
-  metadata.gz: 501643766b5bf72d595c0f45ab0b1ec8f0c445660e996ccbc39600b2f6d3ef97d84a8d1acf7f5b7be9db764926f01569bf4a0f0bd8d4faa72799250afbed4174
-  data.tar.gz: bcfd00e8cb492e7c62fe48a57c439960218acc580ef7e2fce68786774346dea12ef3c47e6f5f9317f036cd6d6b3391c3abb33d4791c6b2d8517e6539156568a5
+  metadata.gz: a61c7417e857912b88ef45a013e0567a1f3fdbf6c43b2a2a3cb8d8c390dc2830c590da0c0af7d5b6915a2fd702ce84f30876c042a7571d68ef4b68b11c6313fd
+  data.tar.gz: 31369f5292794ec854e41dc6a40537e9f5a25d3ba4d4e74c1ec02494bf97920a6a9ca82e8c022c0f841d1953fd57a89e2eb3248554f1c156957ac3c8c8219eeb

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## [2.2.1] - 2025-01-02
+
+- Always return an array for .all methods
+- Discard ZIP codes 'Owned - Not In Service'
+
 ## [2.2.0] - 2025-01-02
 
 - Adds Franchise#cell and Franchise#phone
@@ -12,7 +17,7 @@
 
 ## [2.0.0] - 2024-12-26
 
-** Breaking changes**
+**Breaking changes**
 
 - Remove ServiceType.all and ServiceType.where(zip:)
 

data/lib/vng/availability.rb

@@ -28,7 +28,7 @@ module Vng
 
       data = request path: PATH, body: body
 
-      data['Availability'].map do |availability|
+      data.fetch('Availability', []).map do |availability|
         route_id = availability['routeID'].to_i
         date = Date.strptime availability['dayID'], '%Y%m%d'
         minutes = availability['startTime'].to_i

data/lib/vng/breed.rb

@@ -19,7 +19,7 @@ module Vng
     def self.all
       data = request path: PATH
 
-      data['Breeds'].map do |breed|
+      data.fetch('Breeds', []).map do |breed|
         id = breed['breedID']
         name = breed['breed']
         species = breed['species']

data/lib/vng/franchise.rb

@@ -46,7 +46,7 @@ module Vng
     def self.all
       data = request path: PATH
 
-      data['Franchises'].filter do |franchise|
+      data.fetch('Franchises', []).filter do |franchise|
         franchise['isActive']
       end.map do |franchise|
         id = franchise['franchiseID']

data/lib/vng/mock_request.rb

@@ -54,7 +54,11 @@ module Vng
           { "Zip"=>{"zipCodeID"=>"1", "zipCode"=>"21765", "zoneName"=>"Brentwood", "defaultCity"=>"Los Angeles", "provinceAbbr"=>"CA", "franchiseID"=>"105"},
             "ServiceTypes"=>[{"serviceTypeID"=>14, "serviceType"=>"Pet Grooming", "duration" => 45}]}
         else
-          { "Zips"=>[{ "zip"=>"21765", "zoneName"=>"Brentwood", "state"=>"MD" }] }
+          { "Zips"=>[
+            { "zip"=>"21763", "zoneName"=>"Brentwood", "state"=>"MD", "zipStatus"=>"Owned - Not In Service" },
+            { "zip"=>"21764", "zoneName"=>"Brentwood", "state"=>"MD", "zipStatus"=>"Owned – Deactivated" },
+            { "zip"=>"21765", "zoneName"=>"Brentwood", "state"=>"MD", "zipStatus"=>"Owned - Currently Serviced" },
+          ] }
         end
       when '/api/v1/resources/franchises/'
         if @body.key?(:objectID)

data/lib/vng/price_list.rb

@@ -15,7 +15,7 @@ module Vng
     def self.all
       data = request path: PATH
 
-      data['PriceLists'].filter_map do |price_list|
+      data.fetch('PriceLists', []).filter_map do |price_list|
         next unless price_list['isActive']
         next unless price_list['serviceTypeID'].eql?(14)
 

data/lib/vng/route.rb

@@ -15,7 +15,7 @@ module Vng
     def self.all
       data = request path: PATH
 
-      data['Routes'].filter do |route|
+      data.fetch('Routes', []).filter do |route|
         route['isActive']
       end.map do |body|
         id = body['routeID']

data/lib/vng/version.rb

@@ -1,3 +1,3 @@
 module Vng
-  VERSION = '2.2.0'
+  VERSION = '2.2.1'
 end

data/lib/vng/zip.rb

@@ -19,9 +19,8 @@ module Vng
     def self.all
       data = request path: PATH
 
-      data['Zips'].reject do |franchise|
-        # TODO: add "Owned - Not In Service"
-        franchise['zipStatus'].eql? 'Owned – Deactivated'
+      data.fetch('Zips', []).reject do |franchise|
+        ['Owned – Deactivated', 'Owned - Not In Service'].include? franchise['zipStatus']
       end.map do |body|
         zip = body['zip']
         state = body['state']

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vng
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.2.1
 platform: ruby
 authors:
 - claudiob