vng 1.7.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ec68041442659731246003b523c47c70f41ac3127190c3f966a0c774274f9a2e
-  data.tar.gz: b34853bfd235358cb485ff8fbe84a090dd4104e01f6f01065d6269b20f7f9fbe
+  metadata.gz: 2ba9ded97747e245e2102d52fc515f78a6b836b5e5a19709c40413d6c135f62b
+  data.tar.gz: 356ecdbc427ba9f6d1977972bafa3b81a4afa3122bc66ed11bbc9d69cfa1e6f9
 SHA512:
-  metadata.gz: b2c9cb81c4ec152b7e98800ee01ba68b05617e5b5f85d6dee04607e9c3347faa402f0d3e8109d9579e3683bd7e8d234c5c209ef3e67e8e7d6dd8277e08930dd7
-  data.tar.gz: 91abf7c0f28cd38e7cd9151797eb3312ea6046db8c07af63ba53861b00cf6603f0b2e17c5a585bba9b75623fe2a58aa17c89df739437ee8de027893a25836d32
+  metadata.gz: 1547625c3428ba7727be689119387e1c29b3a931037a01ac6cd03e8df0a9f80a21bf5486d17d23bb5428b902b4d7620696f997fad59e53ec101a8f62c8441f6f
+  data.tar.gz: 0646cbea6e388d76db71cf24505862ec92d808901e1c465b3c2796383c24ba93c1bdea676bcab98968e79b79004030133cce0e2c9f533346371ce1b930df595b

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## [2.0.0] - 2024-12-26
+
+** Breaking changes**
+
+- Remove ServiceType.all and ServiceType.where(zip:)
+
 ## [1.7.0] - 2024-12-26
 
 - Adds PriceItem.for_price_list_id

data/lib/vng/service_type.rb

@@ -5,42 +5,13 @@ module Vng
   class ServiceType < Resource
     PATH = '/api/v1/resources/serviceTypes/'
 
-    attr_reader :id, :type, :duration
+    attr_reader :id, :type, :duration, :price_list_id
 
-    def initialize(id:, type:, duration:)
+    def initialize(id:, type:, duration:, price_list_id:)
       @id = id
       @type = type
       @duration = duration
-    end
-
-    def self.all
-      data = request path: PATH
-
-      data['ServiceTypes'].map do |body|
-        id = body['serviceTypeID']
-        type = body['serviceType']
-        duration = body['duration']
-
-        new id: id, type: type, duration: duration
-      end
-    end
-
-    def self.where(zip:)
-      body = {
-        zip: zip,
-      }
-
-      data = request path: PATH, body: body
-
-      data.fetch('ServiceTypes', []).filter do |body|
-        body['isActive']
-      end.map do |body|
-        id = body['serviceTypeID']
-        type = body['serviceType']
-        duration = body['duration']
-
-        new id: id, type: type, duration: duration
-      end
+      @price_list_id = price_list_id
     end
   end
 end

data/lib/vng/version.rb

@@ -1,3 +1,3 @@
 module Vng
-  VERSION = '1.7.0'
+  VERSION = '2.0.0'
 end

data/lib/vng/zip.rb

@@ -20,6 +20,7 @@ module Vng
       data = request path: PATH
 
       data['Zips'].reject do |franchise|
+        # TODO: add "Owned - Not In Service"
         franchise['zipStatus'].eql? 'Owned – Deactivated'
       end.map do |body|
         zip = body['zip']
@@ -39,12 +40,15 @@ module Vng
       data = request path: PATH, body: body
       zip_data = data['Zip']
 
+      # TODO: Remove ServiceType class, store duration and price_list_id
+      # inside Zip itself
       unless zip_data['zipCodeID'] == '0'
         service_types = data['ServiceTypes'].map do |body|
           id = body['serviceTypeID']
           type = body['serviceType']
           duration = body['duration']
-          ServiceType.new id: id, type: type, duration: duration
+          price_list_id = body['priceID']
+          ServiceType.new id: id, type: type, duration: duration, price_list_id: price_list_id
         end
 
         new zip: zip_data['zipCode'], state: zip_data['provinceAbbr'], zone_name: zip_data['zoneName'], city: zip_data['defaultCity'], service_types: service_types

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vng
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 2.0.0
 platform: ruby
 authors:
 - claudiob