vmware-vra 2.4.0 → 2.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 11be1f053e0b79413a97f73d65dd7736e5da7c3c
-  data.tar.gz: 5f034f6c50a4bd6a3ec8ee69a72672deb291747d
+  metadata.gz: 02e1b10df2a11fb1f980c90789893abd150206e9
+  data.tar.gz: 90be02ee5327c620bc60433006d0c793c9001669
 SHA512:
-  metadata.gz: 12f97a5705101ab63b43212722a3501ac03ba76365f4cb856dfcbc39015ae86de6745c9090bd76c59dfd44362387964eff4e4a5b7cb55a4eab15bf8026aaeb19
-  data.tar.gz: a6b900474a68a4b02064429cba79606423e34f085a46b86f3a73394d837cbf240433238e4b3cc87cb0efa1b5deab6a3c6376e30126e7cc6458cb967ce9786f28
+  metadata.gz: b090835fe0a8e5cf65efab244878adb1110430427d2e9eb3f2ea3768db1dedefe682c88e2318637b22f1bcb73cc896aa33138173bbec00147dfb0adabce8d9e4
+  data.tar.gz: e084aca8bf49456971c54844c7619c7465287b7f2b2657af6225558b95af0616697c18fcb92e498265355b6263e86fd71ec42e3c7951a7d90ac8e7a58a7c776b

data/CHANGELOG.md

@@ -1,7 +1,18 @@
 # Change Log
 
-## [2.4.0](https://github.com/chef-partners/vmware-vra-gem/tree/2.4.0) (2017-09-19)
-[Full Changelog](https://github.com/chef-partners/vmware-vra-gem/compare/v2.3.0...2.4.0)
+## [2.5.0](https://github.com/chef-partners/vmware-vra-gem/tree/2.5.0) (2017-10-17)
+[Full Changelog](https://github.com/chef-partners/vmware-vra-gem/compare/v2.4.0...2.5.0)
+
+**Closed issues:**
+
+- Use mkdir\_p when creating template directory [\#60](https://github.com/chef-partners/vmware-vra-gem/issues/60)
+
+**Merged pull requests:**
+
+- Adds ability to lookup resource by name [\#62](https://github.com/chef-partners/vmware-vra-gem/pull/62) ([logicminds](https://github.com/logicminds))
+
+## [v2.4.0](https://github.com/chef-partners/vmware-vra-gem/tree/v2.4.0) (2017-09-19)
+[Full Changelog](https://github.com/chef-partners/vmware-vra-gem/compare/v2.3.0...v2.4.0)
 
 **Closed issues:**
 

data/lib/vra/catalog_item.rb

@@ -118,7 +118,7 @@ module Vra
     # @param [Boolean] - set to true if you wish the file name to be the id of the catalog item
     # @return [Array[String]] - a array of all the files that were generated
     def self.dump_templates(client, dir_name = "vra_templates", use_id = false)
-      FileUtils.mkdir(dir_name) unless File.exist?(dir_name)
+      FileUtils.mkdir_p(dir_name) unless File.exist?(dir_name)
       client.catalog.entitled_items.map do |c|
         id = use_id ? c.id : c.name.tr(" ", "_")
         filename = File.join(dir_name, "#{id}.json").downcase

data/lib/vra/request.rb

@@ -80,19 +80,12 @@ module Vra
     end
 
     def resources
-      resources = []
-
       begin
         request_resources = client.http_get_paginated_array!("/catalog-service/api/consumer/requests/#{@id}/resources")
       rescue Vra::Exception::HTTPNotFound
         raise Vra::Exception::NotFound, "resources for request ID #{@id} are not found"
       end
-
-      request_resources.each do |resource|
-        resources << Vra::Resource.new(client, data: resource)
-      end
-
-      resources
+      request_resources.map { |resource| Vra::Resource.new(client, data: resource) }
     end
   end
 end

data/lib/vra/resource.rb

@@ -44,6 +44,15 @@ module Vra
       end
     end
 
+    # @param client [Vra::Client]
+    # @param name [String] - the hostname of the client you wish to lookup
+    # @preturn [Vra::Resource] - return nil if not found, otherwise the resource associated with the name
+    def self.by_name(client, name)
+      raise ArgumentError.new("name cannot be nil") if name.nil?
+      raise ArgumentError.new("client cannot be nil") if client.nil?
+      Resources.all.find { |r| r.name.downcase =~ /#{name.downcase}/ }
+    end
+
     def fetch_resource_data
       @resource_data = client.get_parsed("/catalog-service/api/consumer/resources/#{@id}")
     rescue Vra::Exception::HTTPNotFound

data/lib/vra/resources.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 #
 # Author:: Chef Partner Engineering (<partnereng@chef.io>)
 # Copyright:: Copyright (c) 2015 Chef Software, Inc.
@@ -25,15 +26,16 @@ module Vra
       @client = client
     end
 
-    def all_resources
-      resources = []
-
+    # @return [Array[Vra::Resource]] - returns an array of all the resources owned by the user
+    # @param [Vra::Client]
+    def self.all(client)
       items = client.http_get_paginated_array!("/catalog-service/api/consumer/resources")
-      items.each do |item|
-        resources << Vra::Resource.new(client, data: item)
-      end
+      items.map { |item| Vra::Resource.new(client, data: item) }
+    end
 
-      resources
+    # @return [Array[Vra::Resource]] - returns an array of all the resources owned by the user
+    def all_resources
+      self.class.all(client)
     end
 
     def by_id(id)

data/lib/vra/version.rb

@@ -18,5 +18,5 @@
 #
 
 module Vra
-  VERSION = "2.4.0"
+  VERSION = "2.5.0"
 end

data/spec/resource_spec.rb

@@ -67,6 +67,24 @@ describe Vra::Resource do
                                                "non_vm_resource.json")))
   end
 
+  describe "#by_name" do
+    it "can lookup and return resource" do
+      resource = Vra::Resource.allocate
+      allow(resource).to receive(:name).and_return("host1234")
+      name = resource.name
+      allow(Vra::Resources).to receive(:all).and_return([resource])
+      expect(Vra::Resource.by_name(client, name)).to eq(resource)
+    end
+
+    it "returns nil if nothing found" do
+      resource = Vra::Resource.allocate
+      allow(resource).to receive(:name).and_return("host1234")
+      name = "somethingelse1234"
+      allow(Vra::Resources).to receive(:all).and_return([resource])
+      expect(Vra::Resource.by_name(client, name)).to be nil
+    end
+  end
+
   describe "#initialize" do
     it "raises an error if no ID or resource data have been provided" do
       expect { Vra::Resource.new }.to raise_error(ArgumentError)

data/spec/resources_spec.rb

@@ -29,6 +29,17 @@ describe Vra::Resources do
 
   let(:resources) { Vra::Resources.new(client) }
 
+  it "#all" do
+    allow(client).to receive(:http_get_paginated_array!)
+    .with("/catalog-service/api/consumer/resources")
+    .and_return([ { "id" => "1" }, { "id" => "2" } ])
+
+    items = resources.all_resources
+
+    expect(items[0]).to be_an_instance_of(Vra::Resource)
+    expect(items[1]).to be_an_instance_of(Vra::Resource)
+  end
+
   describe "#all_resources" do
     it "calls the resources API endpoint" do
       expect(client).to receive(:http_get_paginated_array!)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vmware-vra
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.5.0
 platform: ruby
 authors:
 - Adam Leff
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-19 00:00:00.000000000 Z
+date: 2017-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ffi-yajl