vizjerai-google-checkout 0.2.3 → 0.3.0

data/.gitignore

@@ -0,0 +1,2 @@
+.rspec
+Gemfile.lock

data/Gemfile

@@ -0,0 +1,4 @@
+source 'https://rubygems.org'
+
+# Specify your gem's dependencies in vizjerai-google-checkout.gemspec
+gemspec

data/Rakefile

@@ -1,37 +1,2 @@
-require 'rake'
-require 'rake/rdoctask'
-require 'spec/rake/spectask'
-
-desc 'Run the specs'
-Spec::Rake::SpecTask.new(:spec) do |t|
-  t.spec_opts = ['--colour --format progress --loadby mtime --reverse']
-  t.spec_files = FileList['spec/**/*_spec.rb']
-end
-
-Rake::RDocTask.new do |t|
-  t.rdoc_dir = 'doc'
-  t.rdoc_files.include('README')
-  t.rdoc_files.include('lib/**/*.rb')
-  t.options << '--inline-source'
-  t.options << '--all'
-  t.options << '--line-numbers'
-end
-
-begin
-  require 'jeweler'
-  Jeweler::Tasks.new do |s|
-    s.name = "vizjerai-google-checkout"
-    s.summary = "An experimental library for sending payment requests to Google Checkout."
-    s.email = "assarata@gmail.com"
-    s.homepage = "http://github.com/vizjerai/google-checkout/"
-    s.description = "An experimental library for sending payment requests to Google Checkout."
-    s.authors = ["Peter Elmore", "Geoffrey Grosenbach", "Matt Lins", "Steel Fu", "Andrew Assarattanakul"]
-    s.files = FileList["[A-Z]*", "{lib,spec,support,examples}/**/*"]
-    s.add_dependency(%q<activesupport>, [">= 2.3.0"])
-    s.add_dependency(%q<money>, [">= 2.3.0"])
-    s.add_dependency(%q<nokogiri>, [">=0"])
-    s.add_development_dependency(%q<rspec>, ["~> 1.3.0"])
-  end
-rescue LoadError
-  puts "Jeweler not available. Install it with: sudo gem install jeweler"
-end
+#!/usr/bin/env rake
+require "bundler/gem_tasks"

data/lib/google-checkout.rb

@@ -7,7 +7,8 @@
 $: << File.dirname(__FILE__)
 $: << File.dirname(__FILE__) + "/vendor/ruby-hmac/lib"
 
-require 'rubygems'
+require 'google-checkout/version'
+
 require 'active_support'
 
 require 'openssl'
@@ -17,7 +18,7 @@ require 'nokogiri'
 require 'money'
 require 'net/https'
 
-require 'duck_punches/hpricot'
+require 'duck_punches/nokogiri'
 require 'duck_punches/inflector'
 require 'google-checkout/notification'
 require 'google-checkout/merchant_calculation'
@@ -35,8 +36,6 @@ require 'google-checkout/geography'
 
 module GoogleCheckout
 
-  #VERSION = '0.2.0'
-
   @@live_system = true
   
   ##
@@ -61,6 +60,4 @@ module GoogleCheckout
     @@live_system
   end
 
-  class APIError < Exception; end
-
 end

data/lib/google-checkout/cart.rb

@@ -268,7 +268,7 @@ module GoogleCheckout
               }
             }
           }
-          unless @merchant_private_data.blank?
+          unless @merchant_private_data.nil? || @merchant_private_data.empty?
             xml.tag!("merchant-private-data") {
               xml << @merchant_private_data
             }
@@ -290,7 +290,8 @@ module GoogleCheckout
             xml.tag!('parameterized-urls') {
               @parameterized_urls.each do |param_url|
                 xml.tag!('parameterized-url', :url => param_url[:url]) {
-                  next if param_url[:parameters].blank?
+                  next if param_url[:parameters].nil?
+                  next if param_url[:parameters].empty?
                   xml.tag!('parameters') {
                     param_url[:parameters].each do |parameter|
                       xml.tag!('url-parameter', :name => parameter[:name], :type => parameter[:type]) {}
@@ -298,7 +299,7 @@ module GoogleCheckout
                   }
                 }
               end
-            } unless @parameterized_urls.blank?
+            } unless @parameterized_urls.nil? || @parameterized_urls.empty?
 
             xml.tag!('shipping-methods') {
               @shipping_methods.each do |shipping_method|

data/lib/google-checkout/command.rb

@@ -59,15 +59,11 @@ module GoogleCheckout
       #      is from the server.
       case response
       when Net::HTTPSuccess, Net::HTTPClientError
-        notification = Notification.parse(response.body)
-        if notification.error? && !notification.message.eql?('You cannot charge an order that is already completely charged')
-          raise APIError, "#{notification.message} [in #{GoogleCheckout.production? ? 'production' : 'sandbox' }]"
-        end
-        return notification
+        Notification.parse(response.body)
       when Net::HTTPRedirection, Net::HTTPServerError, Net::HTTPInformation
-        raise "Unexpected response code (#{response.class}): #{response.code} - #{response.message}"
+        Error.new(nil, :message => "Unexpected response code (#{response.class}): #{response.code} - #{response.message}")
       else
-        raise "Unknown response code: #{response.code} - #{response.message}"
+        Error.new(nil, :message => "Unknown response code: #{response.code} - #{response.message}")
       end
     end
 
@@ -222,7 +218,7 @@ module GoogleCheckout
       }) do
         xml.tag!("amount", @amount, {:currency => @currency})
         xml.tag!("reason", @reason)
-        xml.tag!("comment", @comment) unless @comment.blank?
+        xml.tag!("comment", @comment) unless @comment.nil? || @comment.empty?
       end
       @xml
     end

data/lib/google-checkout/merchant_calculation.rb

@@ -1,7 +1,9 @@
 module GoogleCheckout
   class MerchantCalculation
 
-    attr_accessor :doc
+    def doc
+      @doc ||= Nokogiri::XML::Builder.new
+    end
 
     def self.parse(raw_xml)
       doc = Nokogiri::XML(raw_xml)
@@ -13,12 +15,12 @@ module GoogleCheckout
     end
 
     def address_id
-      (@doc/"anonymous-address").attr('id').value
+      (doc/"anonymous-address").attr('id').value
     end
 
     def method_missing(method_name, *args)
       element_name = method_name.to_s.gsub(/_/, '-')
-      if element = (@doc.at element_name)
+      if element = (doc.at element_name)
         if element.respond_to?(:inner_html)
           return element.inner_html
         end

data/lib/google-checkout/notification.rb

@@ -20,7 +20,9 @@ module GoogleCheckout
   class Notification
 
     # The Nokogiri XML document received from Google.
-    attr_accessor :doc
+    def doc
+      @doc ||= Nokogiri::XML::Builder.new
+    end
 
     ##
     # The entry point for notifications.
@@ -78,10 +80,10 @@ module GoogleCheckout
     # Please see the Order States section for more information about these states.
 
     def state
-      if (@doc.at 'financial-order-state')
-        return (@doc/'financial-order-state').inner_html
-      elsif (@doc.at 'new-financial-order-state')
-        return (@doc/'new-financial-order-state').inner_html
+      if (doc.at 'financial-order-state')
+        return (doc/'financial-order-state').inner_html
+      elsif (doc.at 'new-financial-order-state')
+        return (doc/'new-financial-order-state').inner_html
       end
     end
 
@@ -129,7 +131,7 @@ module GoogleCheckout
 
     def method_missing(method_name, *args)
       element_name = method_name.to_s.gsub(/_/, '-')
-      if element = (@doc.at element_name)
+      if element = (doc.at element_name)
         if element.respond_to?(:inner_html)
           return element.inner_html
         end
@@ -144,11 +146,11 @@ module GoogleCheckout
   class ChargeAmountNotification < Notification
 
     def latest_charge_amount
-      (@doc/"latest-charge-amount").to_money
+      (doc/"latest-charge-amount").to_money
     end
 
     def total_charge_amount
-      (@doc/"total-charge-amount").to_money
+      (doc/"total-charge-amount").to_money
     end
 
   end
@@ -156,11 +158,11 @@ module GoogleCheckout
   class ChargebackAmountNotification < Notification
 
     def latest_chargeback_amount
-      (@doc/"latest-chargeback-amount").to_money
+      (doc/"latest-chargeback-amount").to_money
     end
 
     def total_chargeback_amount
-      (@doc/"total-chargeback-amount").to_money
+      (doc/"total-chargeback-amount").to_money
     end
 
   end
@@ -171,161 +173,161 @@ module GoogleCheckout
     # Returns a Money object representing the total price of the order.
     
     def order_total
-      (@doc/"order-total").to_money
+      (doc/"order-total").to_money
     end
 
     ##
     # Returns a Money object representing the total tax added.
     
     def total_tax
-      (@doc/"total-tax").to_money
+      (doc/"total-tax").to_money
     end
 
     ##
     # Returns true if the buyer wants to received marketing emails.
     
     def email_allowed
-      (@doc/"buyer-marketing-preferences"/"email-allowed").to_boolean
+      (doc/"buyer-marketing-preferences"/"email-allowed").to_boolean
     end
 
     ##
     # Returns billing name.
 
     def billing_name
-      (@doc/"buyer-billing-address"/"contact-name").inner_html
+      (doc/"buyer-billing-address"/"contact-name").inner_html
     end
 
     ##
     # Returns billing email
 
     def billing_email
-      (@doc/"buyer-billing-address"/"email").inner_html
+      (doc/"buyer-billing-address"/"email").inner_html
     end
 
     ##
     # Returns billing address1
 
     def billing_address1
-      (@doc/"buyer-billing-address"/"address1").inner_html
+      (doc/"buyer-billing-address"/"address1").inner_html
     end
 
     ##
     # Returns billing city
 
     def billing_city
-      (@doc/"buyer-billing-address"/"city").inner_html
+      (doc/"buyer-billing-address"/"city").inner_html
     end
 
     ##
     # Returns billing region
 
     def billing_region
-      (@doc/"buyer-billing-address"/"region").inner_html
+      (doc/"buyer-billing-address"/"region").inner_html
     end
 
     ##
     # Returns billing postal code
 
     def billing_postal_code
-      (@doc/"buyer-billing-address"/"postal-code").inner_html
+      (doc/"buyer-billing-address"/"postal-code").inner_html
     end
 
     ##
     # Returns billing country code
 
     def billing_country_code
-      (@doc/"buyer-billing-address"/"country-code").inner_html
+      (doc/"buyer-billing-address"/"country-code").inner_html
     end
 
     ##
     # Returns billing phone
 
     def billing_phone
-      (@doc/"buyer-billing-address"/"phone").inner_html
+      (doc/"buyer-billing-address"/"phone").inner_html
     end
 
     ##
     # Returns billing first name
 
     def billing_first_name
-      (@doc/"buyer-billing-address"/"structured-name"/"first-name").inner_html
+      (doc/"buyer-billing-address"/"structured-name"/"first-name").inner_html
     end
 
     ##
     # Returns billing last name
 
     def billing_last_name
-      (@doc/"buyer-billing-address"/"structured-name"/"last-name").inner_html
+      (doc/"buyer-billing-address"/"structured-name"/"last-name").inner_html
     end
 
     ##
     # Returns shipping contact name
 
     def shipping_name
-      (@doc/"buyer-shipping-address"/"contact-name").inner_html
+      (doc/"buyer-shipping-address"/"contact-name").inner_html
     end
 
     ##
     # Returns shipping email
 
     def shipping_email
-      (@doc/"buyer-shipping-address"/"email").inner_html
+      (doc/"buyer-shipping-address"/"email").inner_html
     end
 
     ##
     # Returns shipping address1
 
     def shipping_address1
-      (@doc/"buyer-shipping-address"/"address1").inner_html
+      (doc/"buyer-shipping-address"/"address1").inner_html
     end
 
     ##
     # Returns shipping city
 
     def shipping_city
-      (@doc/"buyer-shipping-address"/"city").inner_html
+      (doc/"buyer-shipping-address"/"city").inner_html
     end
 
     ##
     # Returns shipping region
 
     def shipping_region
-      (@doc/"buyer-shipping-address"/"region").inner_html
+      (doc/"buyer-shipping-address"/"region").inner_html
     end
 
     ##
     # Returns shipping postal code
 
     def shipping_postal_code
-      (@doc/"buyer-shipping-address"/"postal-code").inner_html
+      (doc/"buyer-shipping-address"/"postal-code").inner_html
     end
 
     ##
     # Returns shipping country code
 
     def shipping_country_code
-      (@doc/"buyer-shipping-address"/"country-code").inner_html
+      (doc/"buyer-shipping-address"/"country-code").inner_html
     end
 
     ##
     # Returns shipping phone
 
     def shipping_phone
-      (@doc/"buyer-shipping-address"/"phone").inner_html
+      (doc/"buyer-shipping-address"/"phone").inner_html
     end
 
     ##
     # Returns shipping first name
 
     def shipping_first_name
-      (@doc/"buyer-shipping-address"/"structured-name"/"first-name").inner_html
+      (doc/"buyer-shipping-address"/"structured-name"/"first-name").inner_html
     end
 
     ##
     # Returns shipping last name
 
     def shipping_last_name
-      (@doc/"buyer-shipping-address"/"structured-name"/"last-name").inner_html
+      (doc/"buyer-shipping-address"/"structured-name"/"last-name").inner_html
     end
 
   end
@@ -344,19 +346,22 @@ module GoogleCheckout
     # Returns redirect-url with ampersands escaped, as specified by Google API docs.
 
     def redirect_url
-      (@doc/"redirect-url").inner_html.gsub(/&amp;/, '&')
+      (doc/"redirect-url").inner_html.gsub(/&amp;/, '&')
     end
 
   end    
 
   class Error < Notification
 
-    ##
-    # Alias for +error_message+
+    def initialize(doc, options={})
+      @error_message = options[:message]
+      super(doc)
+    end
 
-    def message
-      (@doc/'error-message').inner_html
+    def error_message
+      @error_message || (doc/'error-message').inner_html
     end
+    alias :message :error_message
 
   end
 

data/lib/google-checkout/version.rb

@@ -0,0 +1,5 @@
+module GoogleCheckout
+  unless defined? GoogleCheckout::VERSION
+    VERSION = '0.3.0'
+  end
+end

data/spec/google-checkout/cart_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + "/../spec_helper"
+require "spec_helper"
 
 describe GoogleCheckout, "Cart (generic)" do
 
@@ -56,7 +56,7 @@ describe GoogleCheckout, "Cart Post" do
 
   it "should post request to Google" do
     # :null_object means eat all other methods and return self
-    net_http = mock("net_http", { :null_object => true })
+    net_http = double("net_http").as_null_object
     Net::HTTP.should_receive(:new).and_return(net_http)
 
     success_response = Net::HTTPSuccess.new(Net::HTTP.version_1_2, 200, "OK")

data/spec/google-checkout/command_spec.rb

@@ -1,12 +1,4 @@
-require File.dirname(__FILE__) + "/../spec_helper"
-
-describe "basic command", :shared => true do
-
-  it "should include XML header" do
-    @order.to_xml.should match(/^<\?xml version=\"1\.0\" encoding=\"UTF-8\"\?>/)
-  end
-
-end
+require "spec_helper"
 
 describe GoogleCheckout, "Command class" do
 
@@ -63,7 +55,7 @@ describe GoogleCheckout, "Charge Order" do
 
   it "should post request to Google successfully" do
     # :null_object means eat all other methods and return self
-    net_http = mock("net_http", { :null_object => true })
+    net_http = double("net_http").as_null_object
     Net::HTTP.should_receive(:new).and_return(net_http)
 
     success_response = Net::HTTPSuccess.new(Net::HTTP.version_1_2, 200, "OK")
@@ -78,7 +70,7 @@ describe GoogleCheckout, "Charge Order" do
 
   it "should post request to Google and return error" do
     # :null_object means eat all other methods and return self
-    net_http = mock("net_http", { :null_object => true })
+    net_http = double("net_http").as_null_object
     Net::HTTP.should_receive(:new).and_return(net_http)
 
     # NOTE HTTP response code is irrelevant here.
@@ -86,11 +78,16 @@ describe GoogleCheckout, "Charge Order" do
     error_response.should_receive(:body).and_return(read_xml_fixture('responses/error'))
     net_http.should_receive(:request).and_return(error_response)
 
-    lambda { @order.post }.should raise_error(GoogleCheckout::APIError)
+    response = @order.post
+    response.should be_kind_of(GoogleCheckout::Error)
+    response.should be_error
+    response.serial_number.should == 'bea6bc1b-e1e2-44fe-80ff-0180e33a2614'
+    response.error_message.should == 'Bad username and/or password for API Access.'
+    response.message.should == 'Bad username and/or password for API Access.'
   end
 
   it "should post request to Google and return error charged already" do
-    net_http = mock("net_http", { :null_object => true })
+    net_http = double("net_http").as_null_object
     Net::HTTP.should_receive(:new).and_return(net_http)
 
     # NOTE HTTP response code is irrelevant here.
@@ -99,9 +96,49 @@ describe GoogleCheckout, "Charge Order" do
     net_http.should_receive(:request).and_return(error_response)
 
     response = @order.post
+    response.should be_kind_of(GoogleCheckout::Error)
+    response.should be_error
+    response.serial_number.should == 'bea6bc1b-e1e2-44fe-80ff-0180e33a2614'
+    response.error_message.should == 'You cannot charge an order that is already completely charged'
     response.message.should == 'You cannot charge an order that is already completely charged'
   end
 
+  context 'with Net::HTTPRedirection response' do
+    before do
+      net_http = double('net_http').as_null_object
+      Net::HTTP.should_receive(:new).and_return(net_http)
+
+      response = Net::HTTPRedirection.new(Net::HTTP.version_1_2, 301, "Redirect")
+      net_http.should_receive(:request).and_return(response)
+    end
+
+    it "return error" do
+      response = @order.post
+      response.should be_kind_of(GoogleCheckout::Error)
+      response.should be_error
+      response.serial_number.should be_nil
+      response.message.should == 'Unexpected response code (Net::HTTPRedirection): 301 - Redirect'
+    end
+  end
+
+  context 'with HTTPUnknownResponse response' do
+    before do
+      net_http = double('net_http').as_null_object
+      Net::HTTP.should_receive(:new).and_return(net_http)
+
+      response = Net::HTTPUnknownResponse.new(Net::HTTP.version_1_2, 600, "Unknown Response")
+      net_http.should_receive(:request).and_return(response)
+    end
+
+    it "return error" do
+      response = @order.post
+      response.should be_kind_of(GoogleCheckout::Error)
+      response.should be_error
+      response.serial_number.should be_nil
+      response.message.should == 'Unknown response code: 600 - Unknown Response'
+    end
+  end
+
 end
 
 describe GoogleCheckout, "Add Tracking Data" do

data/spec/google-checkout/geography/postal_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + "/../../spec_helper"
+require "spec_helper"
 
 describe GoogleCheckout::Geography::Postal do
   before(:each) do
@@ -23,4 +23,4 @@ describe GoogleCheckout::Geography::Postal do
     @area.to_xml.should match(%r{<postal-code-pattern>53\*</postal-code-pattern>})
   end
 
-end
+end

data/spec/google-checkout/geography/us_country_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + "/../../spec_helper"
+require "spec_helper"
 
 describe GoogleCheckout::Geography::UsCountry do
   before(:each) do
@@ -23,4 +23,4 @@ describe GoogleCheckout::Geography::UsCountry do
     lambda {GoogleCheckout::Geography::UsCountry.new(:my_house).to_xml}.should raise_error(ArgumentError)
   end
   
-end
+end

data/spec/google-checkout/geography/us_state_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + "/../../spec_helper"
+require "spec_helper"
 
 describe GoogleCheckout::Geography::UsState do
   before(:each) do
@@ -8,4 +8,4 @@ describe GoogleCheckout::Geography::UsState do
   it 'should include the state' do
     @area.to_xml.should match(%r{<us-state-area><state>WI</state></us-state-area>})
   end
-end
+end

data/spec/google-checkout/geography/us_zip_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + "/../../spec_helper"
+require "spec_helper"
 
 describe GoogleCheckout::Geography::UsZip do
   before(:each) do
@@ -8,4 +8,4 @@ describe GoogleCheckout::Geography::UsZip do
   it 'should generate the us zip area tag' do
     @area.to_xml.should match(%r{<us-zip-area>.*</us-zip-area>})
   end
-end
+end

data/spec/google-checkout/geography/world_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + "/../../spec_helper"
+require "spec_helper"
 
 describe GoogleCheckout::Geography::World do
   before(:each) do
@@ -9,4 +9,4 @@ describe GoogleCheckout::Geography::World do
     @area.to_xml.should eql("<world-area/>")
   end
 
-end
+end

data/spec/google-checkout/merchant_calculation_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + "/../spec_helper"
+require "spec_helper"
 
 describe GoogleCheckout, "Merchant Calculation" do
 
@@ -14,4 +14,4 @@ describe GoogleCheckout, "Merchant Calculation" do
     @calculation.address_id.should == "739030698069958"
   end
 
-end
+end

data/spec/google-checkout/notification_spec.rb

@@ -1,20 +1,4 @@
-require File.dirname(__FILE__) + "/../spec_helper"
-
-describe "basic notification", :shared => true do
-
-  it "should get serial number" do
-    @notification.serial_number.should == 'bea6bc1b-e1e2-44fe-80ff-0180e33a2614'
-  end
-
-  it "should get google order number" do
-    @notification.google_order_number.should == '841171949013218'
-  end
-
-  it "should generate acknowledgment XML" do
-    @notification.acknowledgment_xml.should match(/notification-acknowledgment/)
-  end
-
-end
+require "spec_helper"
 
 describe GoogleCheckout, "New Order Notification" do
 
@@ -270,3 +254,23 @@ describe GoogleCheckout, "Cancelled Order Notification" do
   end  
     
 end
+
+describe GoogleCheckout, "Error Notification" do
+  let(:notification) { GoogleCheckout::Notification.parse(read_xml_fixture('responses/error')) }
+  before do
+    @notification = notification
+  end
+
+  it "should identify type of notication" do
+    notification.should be_kind_of GoogleCheckout::Error
+  end
+
+  it "should have error message" do
+    notification.error_message.should == 'Bad username and/or password for API Access.'
+  end
+
+  it "should have message" do
+    notification.message.should == 'Bad username and/or password for API Access.'
+  end
+
+end

data/spec/google-checkout/response_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + "/../spec_helper"
+require "spec_helper"
 
 # Responses
 

data/spec/google-checkout/shipping/flat_rate_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + "/../../spec_helper"
+require "spec_helper"
 
 describe GoogleCheckout::Shipping::FlatRate do
   before(:each) do
@@ -43,4 +43,4 @@ describe GoogleCheckout::Shipping::FlatRate do
     @shipping.to_xml.should match(%r{<allow-us-po-box>false</allow-us-po-box>})
   end
 
-end
+end

data/spec/google-checkout/shipping/merchant_calculated_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + "/../../spec_helper"
+require "spec_helper"
 
 describe GoogleCheckout::Shipping::FlatRate do
   before(:each) do
@@ -67,4 +67,4 @@ describe GoogleCheckout::Shipping::FlatRate do
     @shipping.to_xml.should match(%r{<address-filters>.*<allow-us-po-box>false</allow-us-po-box>.*</address-filters>})
   end
 
-end
+end

data/spec/google-checkout/shipping/pickup_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + "/../../spec_helper"
+require "spec_helper"
 
 describe GoogleCheckout::Shipping::Pickup do
   before(:each) do
@@ -19,4 +19,4 @@ describe GoogleCheckout::Shipping::Pickup do
     @shipping.to_xml.should match(%r{<price currency="CAD">})
   end
 
-end
+end

data/spec/google-checkout_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + "/spec_helper"
+require 'spec_helper'
 
 describe GoogleCheckout do
 

data/spec/spec_helper.rb

@@ -1,47 +1,25 @@
-require 'rubygems'
-require 'spec'
-require File.dirname(__FILE__) + "/../lib/google-checkout"
+require File.expand_path('../../lib/google-checkout', __FILE__)
 
-def read_xml_fixture(filename)
-  File.read(File.dirname(__FILE__) + "/fixtures/google/#{filename}.xml")
-end
+Dir[File.expand_path('../support/**/*.rb', __FILE__)].each {|f| require f}
 
-# A better +be_kind_of+ with more informative error messages.
-#
-# The default +be_kind_of+ just says 
-#
-#   "expected to return true but got false"
+# This file was generated by the `rspec --init` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# Require this file using `require "spec_helper"` to ensure that it is only
+# loaded once.
 #
-# This one says
-#
-#   "expected File but got Tempfile"
-
-class BeKindOf
-  
-  def initialize(expected) # + args
-    @expected = expected
-  end
-
-  def matches?(target)
-    @target = target
-    @target.kind_of?(@expected)
-  end
-
-  def failure_message
-    "expected #{@expected} but got #{@target.class}"
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  config.treat_symbols_as_metadata_keys_with_true_values = true
+  config.run_all_when_everything_filtered = true
+  config.filter_run :focus
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = 'random'
+
+  def read_xml_fixture(filename)
+    File.read(File.dirname(__FILE__) + "/fixtures/google/#{filename}.xml")
   end
-
-  def negative_failure_message
-    "expected #{@expected} to not be #{@target.class}"
-  end
-
-  def description
-    "be_kind_of #{@target}"
-  end
-
-end
-
-def be_kind_of(expected) # + args
-  BeKindOf.new(expected)
 end
-

data/spec/support/shared_example_groups/basic_command.rb

@@ -0,0 +1,5 @@
+shared_examples_for "basic command" do
+  it "should include XML header" do
+    @order.to_xml.should match(/^<\?xml version=\"1\.0\" encoding=\"UTF-8\"\?>/)
+  end
+end

data/spec/support/shared_example_groups/basic_notification.rb

@@ -0,0 +1,15 @@
+shared_examples_for "basic notification" do
+
+  it "should get serial number" do
+    @notification.serial_number.should == 'bea6bc1b-e1e2-44fe-80ff-0180e33a2614'
+  end
+
+  it "should get google order number" do
+    @notification.google_order_number.should == '841171949013218'
+  end
+
+  it "should generate acknowledgment XML" do
+    @notification.acknowledgment_xml.should match(/notification-acknowledgment/)
+  end
+
+end

data/vizjerai-google-checkout.gemspec

@@ -0,0 +1,26 @@
+# -*- encoding: utf-8 -*-
+require File.expand_path('../lib/google-checkout/version', __FILE__)
+
+Gem::Specification.new do |gem|
+  gem.authors       = ["Peter Elmore", "Geoffrey Grosenbach", "Matt Lins", "Steel Fu", "Andrew Assarattanakul"]
+  gem.email         = ["assarata@gmail.com"]
+  gem.description   = %q{An experimental library for sending payment requests to Google Checkout.}
+  gem.summary       = %q{Google Checkout}
+  gem.homepage      = "https://github.com/vizjerai/google-checkout"
+
+  gem.files         = `git ls-files`.split($\)
+  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
+  gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
+  gem.name          = "vizjerai-google-checkout"
+  gem.require_paths = ["lib"]
+  gem.version       = GoogleCheckout::VERSION
+
+  gem.add_dependency 'activesupport', '>= 2.3.0'
+  gem.add_dependency 'money', '>= 2.3.0'
+  gem.add_dependency 'nokogiri'
+  gem.add_dependency 'builder'
+
+  gem.add_development_dependency 'bundler'
+  gem.add_development_dependency 'rubygems-bundler'
+  gem.add_development_dependency 'rspec'
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: vizjerai-google-checkout
 version: !ruby/object:Gem::Version 
-  hash: 17
-  prerelease: 
+  hash: 19
+  prerelease: false
   segments: 
   - 0
-  - 2
   - 3
-  version: 0.2.3
+  - 0
+  version: 0.3.0
 platform: ruby
 authors: 
 - Peter Elmore
@@ -19,7 +19,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-02-14 00:00:00 -06:00
+date: 2012-07-27 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -69,38 +69,80 @@ dependencies:
   type: :runtime
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
-  name: rspec
+  name: builder
   prerelease: false
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version 
-        hash: 27
+        hash: 3
         segments: 
-        - 1
-        - 3
         - 0
-        version: 1.3.0
-  type: :development
+        version: "0"
+  type: :runtime
   version_requirements: *id004
+- !ruby/object:Gem::Dependency 
+  name: bundler
+  prerelease: false
+  requirement: &id005 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id005
+- !ruby/object:Gem::Dependency 
+  name: rubygems-bundler
+  prerelease: false
+  requirement: &id006 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id006
+- !ruby/object:Gem::Dependency 
+  name: rspec
+  prerelease: false
+  requirement: &id007 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id007
 description: An experimental library for sending payment requests to Google Checkout.
-email: assarata@gmail.com
+email: 
+- assarata@gmail.com
 executables: []
 
 extensions: []
 
-extra_rdoc_files: 
-- README.txt
+extra_rdoc_files: []
+
 files: 
+- .gitignore
+- Gemfile
 - History.txt
 - MIT-LICENSE.txt
 - README.txt
 - Rakefile
-- VERSION
 - examples/google_notifications_controller.rb
-- lib/duck_punches/hpricot.rb
 - lib/duck_punches/inflector.rb
+- lib/duck_punches/nokogiri.rb
 - lib/google-checkout.rb
 - lib/google-checkout/cart.rb
 - lib/google-checkout/command.rb
@@ -120,6 +162,7 @@ files:
 - lib/google-checkout/shipping/method.rb
 - lib/google-checkout/shipping/pickup.rb
 - lib/google-checkout/shipping/restrictions.rb
+- lib/google-checkout/version.rb
 - spec/fixtures/google/checkout-shopping-cart.xml
 - spec/fixtures/google/commands/add-merchant-order-number.xml
 - spec/fixtures/google/commands/add-tracking-data.xml
@@ -161,9 +204,12 @@ files:
 - spec/google-checkout/shipping/pickup_spec.rb
 - spec/google-checkout_spec.rb
 - spec/spec_helper.rb
+- spec/support/shared_example_groups/basic_command.rb
+- spec/support/shared_example_groups/basic_notification.rb
 - support/cacert.pem
+- vizjerai-google-checkout.gemspec
 has_rdoc: true
-homepage: http://github.com/vizjerai/google-checkout/
+homepage: https://github.com/vizjerai/google-checkout
 licenses: []
 
 post_install_message: 
@@ -192,12 +238,37 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.5.2
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
-summary: An experimental library for sending payment requests to Google Checkout.
+summary: Google Checkout
 test_files: 
-- examples/google_notifications_controller.rb
+- spec/fixtures/google/checkout-shopping-cart.xml
+- spec/fixtures/google/commands/add-merchant-order-number.xml
+- spec/fixtures/google/commands/add-tracking-data.xml
+- spec/fixtures/google/commands/archive-order.xml
+- spec/fixtures/google/commands/authorize-order.xml
+- spec/fixtures/google/commands/cancel-order.xml
+- spec/fixtures/google/commands/charge-order.xml
+- spec/fixtures/google/commands/deliver-order.xml
+- spec/fixtures/google/commands/process-order.xml
+- spec/fixtures/google/commands/refund-order.xml
+- spec/fixtures/google/commands/send-buyer-message.xml
+- spec/fixtures/google/commands/unarchive-order.xml
+- spec/fixtures/google/merchant_calculations/shipping.xml
+- spec/fixtures/google/notifications/authorization-amount-notification.xml
+- spec/fixtures/google/notifications/cancelled-subscription-notification.xml
+- spec/fixtures/google/notifications/charge-amount-notification.xml
+- spec/fixtures/google/notifications/chargeback-amount-notification.xml
+- spec/fixtures/google/notifications/new-order-notification.xml
+- spec/fixtures/google/notifications/order-state-change-notification-missing.xml
+- spec/fixtures/google/notifications/order-state-change-notification.xml
+- spec/fixtures/google/notifications/refund-amount-notification.xml
+- spec/fixtures/google/notifications/risk-information-notification.xml
+- spec/fixtures/google/responses/checkout-redirect.xml
+- spec/fixtures/google/responses/error-charged.xml
+- spec/fixtures/google/responses/error.xml
+- spec/fixtures/google/responses/request-received.xml
 - spec/google-checkout/cart_spec.rb
 - spec/google-checkout/command_spec.rb
 - spec/google-checkout/geography/postal_spec.rb
@@ -213,3 +284,5 @@ test_files:
 - spec/google-checkout/shipping/pickup_spec.rb
 - spec/google-checkout_spec.rb
 - spec/spec_helper.rb
+- spec/support/shared_example_groups/basic_command.rb
+- spec/support/shared_example_groups/basic_notification.rb

data/VERSION

@@ -1 +0,0 @@
-0.2.3