vite_ruby 1.2.8 → 1.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e208284305c3370dd47dac35ef06af231c8ddd55b13b8870b7f32179e4c350c4
-  data.tar.gz: 1390d37229bf7d4139b0df3ce08d7e7b64877e2ad7ec041b7d49722545caa652
+  metadata.gz: 4d76db7c0a459f6a410ce71f7bb44e50eeaff89f7a071ad6beddab4b9ea272f6
+  data.tar.gz: 5d77215308acacbe91f286665d74bf406205bd3e3a31b30f07022c56a719c51a
 SHA512:
-  metadata.gz: b99b7aaf20cb938245f5f83f61d5aace6ffc40519f139b51b9fa9ecd86c14b9098cfafb0b966e08048d64cb62848ff25b4ee086990b44469a44ec739c61712ba
-  data.tar.gz: cf4db82501767990f54d994a0c8fce16404a9d5156ef956990a1b3fb403ddd8a71a8e220f629c03c6d188400cc40176be650a2985dde6d2c677838fa25a87fee
+  metadata.gz: 0f9ceb9ded8010c698349d4cc17d1671544033e4e83d12d6d5b0c134aba0d06182836fa0d5b320c31eaf4111b8acb1c4edeb20e59b9444a28b7c61f3663e50ff
+  data.tar.gz: 0a8858be21aa01da1e29f0fbff8a01702eb1b6f56a3aefca06786ff631eb3ecc311154ce6543c684ceae2b35300eac3b4ea694d89a8fbdbde3576342fdd26783

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## [1.2.9](https://github.com/ElMassimo/vite_ruby/compare/vite_ruby@1.2.8...vite_ruby@1.2.9) (2021-05-04)
+
+
+### Bug Fixes
+
+* Stream output during installation and don't skip installation of npm packages when no lockfile is detected ([#73](https://github.com/ElMassimo/vite_ruby/issues/73)) ([028a5ba](https://github.com/ElMassimo/vite_ruby/commit/028a5bae359085a36aa942d2ad63c23616a00ffb))
+
+
+
 ## [1.2.8](https://github.com/ElMassimo/vite_ruby/compare/vite_ruby@1.2.7...vite_ruby@1.2.8) (2021-04-29)
 
 

data/lib/vite_ruby.rb

@@ -10,6 +10,7 @@ loader.ignore("#{ __dir__ }/install")
 loader.ignore("#{ __dir__ }/tasks")
 loader.ignore("#{ __dir__ }/exe")
 loader.inflector.inflect('cli' => 'CLI')
+loader.inflector.inflect('io' => 'IO')
 loader.setup
 
 class ViteRuby

data/lib/vite_ruby/builder.rb

@@ -69,7 +69,7 @@ private
   def build_with_vite(*args)
     logger.info 'Building with Vite ⚡️'
 
-    stdout, stderr, status = ViteRuby.run(['build', *args], capture: true)
+    stdout, stderr, status = ViteRuby.run(['build', *args])
     log_build_result(stdout, stderr.to_s, status)
 
     status.success?

data/lib/vite_ruby/cli/dev.rb

@@ -8,6 +8,6 @@ class ViteRuby::CLI::Dev < ViteRuby::CLI::Build
   option(:force, desc: 'Force Vite to re-bundle dependencies', type: :boolean)
 
   def call(**options)
-    super { |args| ViteRuby.run(args) }
+    super { |args| ViteRuby.run(args, exec: true) }
   end
 end

data/lib/vite_ruby/cli/install.rb

@@ -2,7 +2,6 @@
 
 require 'dry/cli/utils/files'
 require 'stringio'
-require 'open3'
 
 class ViteRuby::CLI::Install < Dry::CLI::Command
   desc 'Performs the initial configuration setup to get started with Vite Ruby.'
@@ -73,11 +72,12 @@ private
   def install_js_dependencies
     package_json = root.join('package.json')
     write(package_json, '{}') unless package_json.exist?
+
     Dir.chdir(root) do
       deps = "vite@#{ ViteRuby::DEFAULT_VITE_VERSION } vite-plugin-ruby@#{ ViteRuby::DEFAULT_PLUGIN_VERSION }"
-      stdout, stderr, status = Open3.capture3({}, "npx --yes --package @antfu/ni -- ni -D #{ deps }")
-      stdout, stderr, = Open3.capture3({}, "yarn add -D #{ deps }") unless status.success?
-      say(stdout, "\n", stderr)
+      _, stderr, status = ViteRuby::IO.capture("npx --package @antfu/ni -- ni -D #{ deps }", stdin_data: "\n")
+      _, stderr, = ViteRuby::IO.capture("yarn add -D #{ deps }") unless status.success?
+      say("Could not install JS dependencies.\n", stderr) unless stderr.to_s.empty?
     end
   end
 

data/lib/vite_ruby/io.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+require 'open3'
+
+# Public: Builds on top of Ruby I/O open3 providing a friendlier experience.
+module ViteRuby::IO
+  class << self
+    # Internal: A modified version of capture3 that can continuosly print stdout.
+    # NOTE: Streaming output provides a better UX when running bin/vite build.
+    def capture(*cmd, with_output: $stdout.method(:puts), stdin_data: '', **opts)
+      return Open3.capture3(*cmd, **opts) unless with_output
+
+      Open3.popen3(*cmd, **opts) { |stdin, stdout, stderr, wait_threads|
+        stdin << stdin_data
+        stdin.close
+        out = Thread.new { read_lines(stdout, &with_output) }
+        err = Thread.new { stderr.read }
+        [out.value, err.value, wait_threads.value]
+      }
+    end
+
+    # Internal: Reads and yield every line in the stream. Returns the full content.
+    def read_lines(io)
+      buffer = +''
+      while line = io.gets
+        buffer << line
+        yield line
+      end
+      buffer
+    end
+  end
+end

data/lib/vite_ruby/runner.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'open3'
-
 # Public: Executes Vite commands, providing conveniences for debugging.
 class ViteRuby::Runner
   def initialize(vite_ruby)
@@ -9,10 +7,13 @@ class ViteRuby::Runner
   end
 
   # Public: Executes Vite with the specified arguments.
-  def run(argv, capture: false)
+  def run(argv, exec: false)
     Dir.chdir(config.root) {
       cmd = command_for(argv)
-      capture ? capture3_with_output(*cmd, chdir: config.root) : Kernel.exec(*cmd)
+      return Kernel.exec(*cmd) if exec
+
+      log_or_noop = ->(line) { logger.info('vite') { line } } unless config.hide_build_console_output
+      ViteRuby::IO.capture(*cmd, chdir: config.root, with_output: log_or_noop)
     }
   rescue Errno::ENOENT => error
     raise ViteRuby::MissingExecutableError, error
@@ -41,26 +42,4 @@ private
     bin_path = config.vite_bin_path
     File.exist?(bin_path) ? bin_path : "#{ `npm bin`.chomp }/vite"
   end
-
-  # Internal: A modified version of capture3 that continuosly prints stdout.
-  # NOTE: This improves the experience of running bin/vite build.
-  def capture3_with_output(*cmd, **opts)
-    return Open3.capture3(*cmd, opts) if config.hide_build_console_output
-
-    Open3.popen3(*cmd, opts) { |_stdin, stdout, stderr, wait_threads|
-      out = Thread.new { read_lines(stdout) { |l| logger.info('vite') { l } } }
-      err = Thread.new { stderr.read }
-      [out.value, err.value, wait_threads.value]
-    }
-  end
-
-  # Internal: Reads and yield every line in the stream. Returns the full content.
-  def read_lines(io)
-    buffer = +''
-    while line = io.gets
-      buffer << line
-      yield line
-    end
-    buffer
-  end
 end

data/lib/vite_ruby/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class ViteRuby
-  VERSION = '1.2.8'
+  VERSION = '1.2.9'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: vite_ruby
 version: !ruby/object:Gem::Version
-  version: 1.2.8
+  version: 1.2.9
 platform: ruby
 authors:
 - Máximo Mussini
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-04-29 00:00:00.000000000 Z
+date: 2021-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-cli
@@ -225,6 +225,7 @@ files:
 - lib/vite_ruby/config.rb
 - lib/vite_ruby/dev_server_proxy.rb
 - lib/vite_ruby/error.rb
+- lib/vite_ruby/io.rb
 - lib/vite_ruby/manifest.rb
 - lib/vite_ruby/missing_entrypoint_error.rb
 - lib/vite_ruby/missing_executable_error.rb
@@ -237,8 +238,8 @@ homepage: https://github.com/ElMassimo/vite_ruby
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/ElMassimo/vite_ruby/tree/vite_ruby@1.2.8/vite_ruby
-  changelog_uri: https://github.com/ElMassimo/vite_ruby/blob/vite_ruby@1.2.8/vite_ruby/CHANGELOG.md
+  source_code_uri: https://github.com/ElMassimo/vite_ruby/tree/vite_ruby@1.2.9/vite_ruby
+  changelog_uri: https://github.com/ElMassimo/vite_ruby/blob/vite_ruby@1.2.9/vite_ruby/CHANGELOG.md
 post_install_message:
 rdoc_options: []
 require_paths: