vite_ruby 1.0.4 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f8ef54a43f8457a31e8af99da6da97e50b9c406c7f0595f7840057dbf830c557
-  data.tar.gz: fa00714f7a3ad4c63562950b596c564ffc1a8a1592c88a7e313f8a74027a05cb
+  metadata.gz: edbaa4a25307c203d7d4e5fafa8605f5fffe05eecd078432d9db5e0e065a3105
+  data.tar.gz: 71ccf0533e961a9344cdfb321dad6f53391a65b46bb7a6a3ca88d2403842fd2f
 SHA512:
-  metadata.gz: 65f96a4b01af3c5a773fb6545d893ec072b5eaea006a7456878f651fdac459bd27ea9172dca776b5194011e513b6a10ed623c3c73705f1206825f88dc4909f76
-  data.tar.gz: 60d845e48ac820e6791a7dafa4d5d549fb652b52c7e60bdcdca22cf6c62862717f04bef0043b9e3bbad6fddd9167eab58e93c5654ca1c5858c452960f07413a5
+  metadata.gz: '09c608d897769b244a674eaf52623fd2fb62a9ff12677bfc2c10ea9685e5985a8e4a45f9f0751d257e3d162fee522ab1d2c0677aec230e7178d9ec9b1a50002b'
+  data.tar.gz: f5a2f1dd5a74109a4bc1d0bcfa0e5b7fff6a2abe1538cb33c9db90c99ebfe84814af80a51f4e5426cda933934de4d517c78d699260120c25036cef32794dece8

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## [1.0.5](https://github.com/ElMassimo/vite_ruby/compare/vite_ruby@1.0.4...vite_ruby@1.0.5) (2021-03-03)
+
+
+### Bug Fixes
+
+* Fix installation of JS packages, prevent silent failures (closes [#22](https://github.com/ElMassimo/vite_ruby/issues/22)) ([#23](https://github.com/ElMassimo/vite_ruby/issues/23)) ([d972e6f](https://github.com/ElMassimo/vite_ruby/commit/d972e6f3968988460753e7a831c8e9199bbd6891))
+
+
+
 ## [1.0.4](https://github.com/ElMassimo/vite_ruby/compare/vite_ruby@1.0.3...vite_ruby@1.0.4) (2021-02-25)
 
 

data/lib/vite_ruby/builder.rb

@@ -84,7 +84,9 @@ private
       logger.info(stdout) unless config.hide_build_console_output
     else
       non_empty_streams = [stdout, stderr].delete_if(&:empty?)
-      logger.error "Build with Vite failed:\n#{ non_empty_streams.join("\n\n") }"
+      errors = non_empty_streams.join("\n\n")
+      errors += "\n❌ Check that vite and vite-plugin-ruby are in devDependencies and have been installed. " if errors.include?('ERR! canceled')
+      logger.error "Build with Vite failed:\n#{ errors }"
     end
   end
 

data/lib/vite_ruby/cli/build.rb

@@ -5,7 +5,7 @@ class ViteRuby::CLI::Build < Dry::CLI::Command
   DEFAULT_ENV = CURRENT_ENV || 'production'
 
   def self.shared_options
-    option(:mode, default: self::DEFAULT_ENV, values: %w[development production], aliases: ['m'], desc: 'The build mode for Vite.')
+    option(:mode, default: self::DEFAULT_ENV, values: %w[development production], aliases: ['m'], desc: 'The build mode for Vite')
   end
 
   desc 'Bundle all entrypoints using Vite.'

data/lib/vite_ruby/cli/install.rb

@@ -75,7 +75,7 @@ private
     write(package_json, '{}') unless package_json.exist?
     Dir.chdir(root) do
       deps = "vite@#{ ViteRuby::DEFAULT_VITE_VERSION } vite-plugin-ruby@#{ ViteRuby::DEFAULT_PLUGIN_VERSION }"
-      stdout, stderr, status = Open3.capture3({ 'CI' => 'true' }, "npx @antfu/ni -D #{ deps }")
+      stdout, stderr, status = Open3.capture3({ 'CI' => 'true' }, "npx --package @antfu/ni -- ni -D #{ deps }")
       stdout, stderr, = Open3.capture3({}, "yarn add -D #{ deps }") unless status.success?
       say(stdout, "\n", stderr)
     end

data/lib/vite_ruby/commands.rb

@@ -69,6 +69,7 @@ class ViteRuby::Commands
   def verify_install
     unless File.exist?(config.root.join('bin/vite'))
       warn <<~WARN
+
         vite binstub not found.
         Have you run `bundle binstub vite`?
         Make sure the bin directory and bin/vite are not included in .gitignore
@@ -78,6 +79,7 @@ class ViteRuby::Commands
     config_path = config.root.join(config.config_path)
     unless config_path.exist?
       warn <<~WARN
+
         Configuration #{ config_path } file for vite-plugin-ruby not found.
         Make sure `bundle exec vite install` has run successfully before running dependent tasks.
       WARN
@@ -88,7 +90,7 @@ class ViteRuby::Commands
   # Internal: Prints information about ViteRuby's environment.
   def print_info
     Dir.chdir(config.root) do
-      $stdout.puts "Is bin/vite present?: #{ File.exist? 'bin/vite' }"
+      $stdout.puts "bin/vite present?: #{ File.exist? 'bin/vite' }"
 
       $stdout.puts "vite_ruby: #{ ViteRuby::VERSION }"
       ViteRuby.framework_libraries.each do |framework, library|
@@ -98,11 +100,14 @@ class ViteRuby::Commands
 
       $stdout.puts "node: #{ `node --version` }"
       $stdout.puts "npm: #{ `npm --version` }"
-      $stdout.puts "yarn: #{ `yarn --version` }"
+      $stdout.puts "yarn: #{ `yarn --version` rescue nil }"
+      $stdout.puts "pnpm: #{ `pnpm --version` rescue nil }"
       $stdout.puts "ruby: #{ `ruby --version` }"
 
       $stdout.puts "\n"
-      $stdout.puts "vite-plugin-ruby: \n#{ `npm list vite-plugin-ruby version` }"
+      packages = `npm ls vite vite-plugin-ruby`
+      packages_msg = packages.include?('vite@') ? "installed packages:\n#{ packages }" : '❌ Check that vite and vite-plugin-ruby have been added as development dependencies and installed.'
+      $stdout.puts packages_msg
     end
   end
 

data/lib/vite_ruby/runner.rb

@@ -52,6 +52,6 @@ private
   # Internal: Resolves to an executable for Vite.
   def vite_executable(cmd)
     npx = cmd.include?('node') ? `which npx`.chomp("\n") : 'npx' rescue 'npx'
-    [npx, 'vite']
+    [npx, '--no-install', '--', 'vite']
   end
 end

data/lib/vite_ruby/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class ViteRuby
-  VERSION = '1.0.4'
+  VERSION = '1.0.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: vite_ruby
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - Máximo Mussini
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-02-25 00:00:00.000000000 Z
+date: 2021-03-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-cli
@@ -128,8 +128,8 @@ homepage: https://github.com/ElMassimo/vite_ruby
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/ElMassimo/vite_ruby/tree/vite_ruby@1.0.4/vite_ruby
-  changelog_uri: https://github.com/ElMassimo/vite_ruby/blob/vite_ruby@1.0.4/vite_ruby/CHANGELOG.md
+  source_code_uri: https://github.com/ElMassimo/vite_ruby/tree/vite_ruby@1.0.5/vite_ruby
+  changelog_uri: https://github.com/ElMassimo/vite_ruby/blob/vite_ruby@1.0.5/vite_ruby/CHANGELOG.md
 post_install_message:
 rdoc_options: []
 require_paths: