visma_eaccounting 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a737f9498f23b71408ea0cb7354a4ab43f1a0d8857b45197264d2917a0a4bda8
-  data.tar.gz: 53477ec8fd7db0e6e6d21bbcb8c99e2d210fcf280be63998edbf6f6426a31276
+  metadata.gz: 7856b9f01600c672d20af36217c68ac8f9fe49abef0d50793da416ee0f190e2a
+  data.tar.gz: 29ea3651d6d89bea0c422174c1e5151debf4d5a79837d5455c9380040b2fd42e
 SHA512:
-  metadata.gz: 96c9e12c4139c153d476b980b8fe284b54529badab45f84887688e6a02d79f5db1433924f2217fba461a8981d243a514e7e7c51f6c2d5f82b234a5ef95e58ce4
-  data.tar.gz: 753cd063742597f284bafcec09031e9ad1bda77816c6155599fcb8be4803f93352127390ff7019512e5ea6bb4ba03e14b2740e07de5846b8b9b2ffc8372c3df1
+  metadata.gz: 007fdcfc59f0e12b3d3f287f8becbfa683fddb63971cff508d792b7dcce4f25ae197b3510cdbac8af29a748d5db7fe1a001d8db9069597ddbf63bc0d1db09800
+  data.tar.gz: f16b78b08b8c1645d6c6c45090c62a5338b1cf9addfdc914af580e442003996c7f959f77342b4b65a479928d05e2975a7b6e1ecdb818e9c909594c6652909d5e

data/README.markdown

@@ -10,9 +10,11 @@ VismaEaccounting returns a `VismaEaccounting::Response` instead of the response
 
     $ gem install visma_eaccounting
 
-## Requirements
+## Authentication
 
-A Visma eAccounting account and oAuth client id.
+The Visma eAccounting API authenticates using a token which you can retrieve when authorizating using OAuth with your Visma eAccounting account.
+
+To retrieve an access token you can use [omniauth-visma](https://github.com/espen/omniauth-visma). Do note that this token expires in one hour so you need to fetch a new access token using the refresh token when required.
 
 ## Usage
 
@@ -114,7 +116,7 @@ By default the Visma API returns 50 results. To set the count to 50:
 visma_eaccounting.customers.retrieve(params: {"pagesize": "100"})
 ```
 
-And to retrieve the next 50 members:
+And to retrieve the next 50 customers:
 
 ```ruby
 visma_eaccounting.customers.retrieve(params: {"pagesize": "100", "page": "2"})
@@ -155,7 +157,7 @@ available depending on the nature of the error. For example:
 
 ```ruby
 begin
-  visma_eaccounting.customers(customer_id).members.create(body: body)
+  visma_eaccounting.customers.create(body: body)
 rescue VismaEaccounting::VismaEaccountingError => e
   puts "Houston, we have a problem: #{e.message} - #{e.raw_body}"
 end

data/lib/visma_eaccounting/api_request.rb

@@ -182,7 +182,7 @@ module VismaEaccounting
     end
 
     def base_api_url
-      case self.class.api_environment
+      case @request_builder.api_environment
       when :sandbox
         "https://eaccountingapi-sandbox.test.vismaonline.com/v2/"
       when :production

data/lib/visma_eaccounting/version.rb

@@ -1,3 +1,3 @@
 module VismaEaccounting
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/visma_eaccounting/api_request_spec.rb

@@ -6,7 +6,7 @@ describe VismaEaccounting::APIRequest do
 
   before do
     @visma_eaccounting = VismaEaccounting::Request.new(token: token)
-    @api_root = "https://eaccountingapi-sandbox.test.vismaonline.com/v2"
+    @api_root = "https://eaccountingapi.vismaonline.com/v2/"
   end
 
   it "surfaces client request exceptions as a VismaEaccounting::APIError" do

data/spec/visma_eaccounting/visma_eaccounting_spec.rb

@@ -14,6 +14,7 @@ describe VismaEaccounting do
       @visma_eaccounting = VismaEaccounting::Request.new
       expect(@visma_eaccounting.token).to be_nil
     end
+
     it "sets an API key in the constructor" do
       @visma_eaccounting = VismaEaccounting::Request.new(token: @token)
       expect(@visma_eaccounting.token).to eq(@token)
@@ -127,6 +128,25 @@ describe VismaEaccounting do
 
   end
 
+  describe "supports different environments" do
+    before do
+      VismaEaccounting::APIRequest.send(:public, *VismaEaccounting::APIRequest.protected_instance_methods)
+    end
+
+    it "has correct api url for default production environment" do
+      @visma_eaccounting = VismaEaccounting::Request.new()
+      @request = VismaEaccounting::APIRequest.new(builder: @visma_eaccounting)
+      expect(@request.send(:base_api_url)).to eq("https://eaccountingapi.vismaonline.com/v2/")
+    end
+
+    it "has corret api url when setting sandbox environment" do
+      @visma_eaccounting = VismaEaccounting::Request.new(api_environment: :sandbox)
+      @request = VismaEaccounting::APIRequest.new(builder: @visma_eaccounting)
+      expect(@request.send(:base_api_url)).to eq("https://eaccountingapi-sandbox.test.vismaonline.com/v2/")
+    end
+
+  end
+
   describe "build api url" do
     before do
       VismaEaccounting::APIRequest.send(:public, *VismaEaccounting::APIRequest.protected_instance_methods)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: visma_eaccounting
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Espen Antonsen