visit-counter 0.1.1 → 0.1.2

data/README.md

@@ -1,5 +1,7 @@
 # VisitCounter
 
+[![Build Status](https://secure.travis-ci.org/KensoDev/visit-counter.png)](https://secure.travis-ci.org/KensoDev/visit-counter)
+
 VisitCounter is a gem which solves the annoying problem of counting visits and displaying them in real time. In an SQL database, for a site with a lot of hits, this can cause quite a lot of overhead. VisitCounter aims to solve this by using a quick key-value store to keep a delta, and only persist to the SQL DB when the delta crosses a certain percent of the saved counter.
 It can be used transparently, by overriding the accessor to the counter, or simply by using the helper functions it defines - incr_counter, read_counter, get_counter_delta and nullify_counter.
 

data/Rakefile

@@ -1,2 +1,10 @@
 #!/usr/bin/env rake
 require "bundler/gem_tasks"
+require 'rspec/core'
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec) do |spec|
+  spec.pattern = FileList['spec/**/*_spec.rb']
+end
+
+task :default => :spec

data/lib/visit-counter/store/redis_store.rb

@@ -38,7 +38,7 @@ module VisitCounter
           redis.decrby(key, by)
         end
 
-        def aquire_lock!(object)
+        def acquire_lock(object)
           redis.setnx(lock_key(object), 1)
         end
 
@@ -51,7 +51,7 @@ module VisitCounter
         end
 
         def with_lock(object, &block)
-          if aquire_lock!(object)
+          if acquire_lock(object)
             begin
               yield
             ensure
@@ -63,4 +63,4 @@ module VisitCounter
       end
     end
   end
-end
+end

data/lib/visit-counter/version.rb

@@ -1,3 +1,3 @@
 module VisitCounter
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/lib/visit-counter/visit_counter.rb

@@ -4,7 +4,7 @@ module VisitCounter
     base.class_eval do
       class << self
         #defining class instance attributes
-        attr_accessor :visit_counter_threshold, :visit_counter_threshold_method
+        attr_accessor :visit_counter_threshold, :visit_counter_threshold_method, :persist_with_callbacks
       end
     end
     base.send(:include, InstanceMethods)
@@ -73,7 +73,12 @@ module VisitCounter
 
       def persist(object, staged_count, diff, name)
         VisitCounter::Store.engine.with_lock(object) do
-          object.update_attribute(name, staged_count + diff)
+          if object.class.persist_with_callbacks
+            object.send("#{name}=", staged_count + diff )
+            object.save
+          else  
+            object.update_attribute(name, staged_count + diff)
+          end
           object.nullify_counter_cache(name, diff)
         end
       end

data/spec/lib/visit_counter_spec.rb

@@ -3,12 +3,16 @@ require "spec_helper"
 class DummyObject
   include VisitCounter
 
-  attr_accessor :counter
+  attr_accessor :counter, :persist_with_callbacks
 
   def update_attribute(attribute, value)
     self.send("#{attribute}=", value)
   end
 
+  def save
+    nil
+  end  
+
   def read_attribute(name)
     #yeah, evals are evil, but it works and it's for testing purposes only. we assume read_attribute is defined the same as in AR wherever we include this module
     eval("@#{name}")
@@ -124,13 +128,13 @@ describe VisitCounter do
     end
 
     it "should not persist if object is locked" do
-      VisitCounter::Store.engine.stub!(:aquire_lock!).and_return(false)
+      VisitCounter::Store.engine.stub!(:acquire_lock).and_return(false)
       @d.should_not_receive(:update_attribute)
       VisitCounter::Helper.persist(@d, 1, 1, :counter)
     end
 
     it "should persist if object is locked" do
-      VisitCounter::Store.engine.stub!(:aquire_lock!).and_return(true)
+      VisitCounter::Store.engine.stub!(:acquire_lock).and_return(true)
       @d.should_receive(:update_attribute)
       VisitCounter::Helper.persist(@d, 1, 1, :counter)
     end
@@ -157,5 +161,15 @@ describe VisitCounter do
       @d.counter.should == 11
     end
   end
+  
+  describe "persist with callbacks" do
+    it "should use save method" do
+      @d = DummyObject.new
+      @d.class.persist_with_callbacks = true
+      @d.stub!(:id).and_return(1)
+      @d.should_receive(:save)
+      @d.incr_counter :counter
+    end  
+  end  
 
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: visit-counter
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,56 +9,56 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-24 00:00:00.000000000 Z
+date: 2013-04-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
+  prerelease: false
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+    none: false
   type: :development
-  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+    none: false
 - !ruby/object:Gem::Dependency
   name: rake
+  prerelease: false
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 0.9.2
+    none: false
   type: :development
-  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 0.9.2
+    none: false
 - !ruby/object:Gem::Dependency
   name: redis
+  prerelease: false
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+    none: false
   type: :runtime
-  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+    none: false
 description: Simple counter increment which only writes to DB once in a while
 email:
 - tcaspy@gmail.com
@@ -90,17 +90,17 @@ rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
+required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+  none: false
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24