virtual_merchant 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e30717bdee04d446b5cc2417afcc1f9150a6192d
-  data.tar.gz: b6fd4d4393eac6a25c7ab0c30a809da460d74e43
+  metadata.gz: dab2530964fc6d14d4f3c26c1f1fb77858009b73
+  data.tar.gz: d39e6c5d3b72c4e85d10243eae9571b15abd0c32
 SHA512:
-  metadata.gz: 945cbe1b26950f5a61cd8a5375cb52d589cede8b9a9bbedeb5a09c4911e0aefa6ff2a68a5a6040177b6624de90fb08eb3baf2d4771598cf7990709a019693da9
-  data.tar.gz: 9cfecd9fa7316803cfed450af806750f46e5807366fc9bcb395cf8124d20cf1c443bb3bf999472b50c83e62f53e5f656ed2dd965dd17ac07985a7ca11b3cbd78
+  metadata.gz: 1808dd81109f9cfca43b4dc0f744e3ac1116975a4f981b62cea2ed59dcc3f6e5cdde0f81ba1cd08d38ccf9576d1e1c88de84c2c092b260bb83a3b0db5f386059
+  data.tar.gz: 752579a21497d52e4b2a359b5fa6d1a34aa4ca7454b676e9a00b75cea26a217931ee33ee8bce59b6ae1b6be6768efc223b5ddd51367e0d44e555f1ec1b8088f7

data/lib/virtual_merchant/credit_card.rb

@@ -1,5 +1,6 @@
 require 'virtual_merchant/swipe_extractor'
 require 'virtual_merchant/user_input'
+
 module VirtualMerchant
   class CreditCard
     attr_accessor :name_on_card, :number, :expiration, :security_code, :swipe, :track2,
@@ -19,10 +20,6 @@ module VirtualMerchant
       end
     end
 
-    def check_for_errors info
-      @errors = VirtualMerchant::UserInput.new(info).errors
-    end
-
     def encrypted?
       self.encrypted
     end
@@ -32,7 +29,7 @@ module VirtualMerchant
     end
 
     def valid?
-      errors.count == 0
+      self.errors.count == 0
     end
 
     def blurred_number
@@ -53,6 +50,10 @@ module VirtualMerchant
     end
 
     private
+      def check_for_errors info
+        @errors = VirtualMerchant::UserInput.new(info).errors
+      end
+
       def from_encrypted (info)
         @encrypted         = true
         @encrypted_track_1 = info[:track_1]

data/lib/virtual_merchant/gateway.rb

@@ -61,7 +61,7 @@ class Gateway
     communication = VirtualMerchant::Communication.new(
       {xml: xml, url: url(creds.demo), referer: creds.referer})
     vm_response = communication.send
-    response = VirtualMerchant::Response.new(vm_response)
+    response = VirtualMerchant::Response.new(xml_string: vm_response)
     VirtualMerchant::Logger.log_response(response)
     response
   end
@@ -76,11 +76,6 @@ class Gateway
   end
 
   def gen_cc_errors(card)
-    card.errors.each do |code, msg|
-      xml = VirtualMerchant::XMLGenerator.error(code, msg)
-      response = VirtualMerchant::Response.new(xml)
-      VirtualMerchant::Logger.log_response(response)
-      response
-    end
+    response = VirtualMerchant::Response.new(type: :invalid_credit_card, errors: card.errors)
   end
 end

data/lib/virtual_merchant/response.rb

@@ -8,7 +8,16 @@ module VirtualMerchant
 
     alias_method :approved?, :approved
 
-    def initialize(xml_string)
+    def initialize(data)
+      if data[:type] == :invalid_credit_card
+        bad_card_error(data[:errors])
+      else
+        read_xml(data[:xml_string])
+      end
+    end
+
+    private
+    def read_xml(xml_string)
       if xml_string == false
         error_response("-1", "VirtualMerchant did not respond.")
       else
@@ -16,8 +25,6 @@ module VirtualMerchant
       end
     end
 
-
-    private
     def decode_xml(xml_string)
       doc = REXML::Document.new(xml_string)
       REXML::XPath.each(doc, "txn") do |xml|
@@ -37,6 +44,12 @@ module VirtualMerchant
       end
     end
 
+    def bad_card_error(errors)
+      @approved       = false
+      @result_message = errors.first[1]
+      @error          = errors.first[0]
+    end
+
     def error_response(code, message)
       @approved       = false
       @result_message = message

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: virtual_merchant
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Lee Quarella
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-16 00:00:00.000000000 Z
+date: 2014-06-17 00:00:00.000000000 Z
 dependencies: []
 description: Makes it easy to charge credit cards with the VirtualMerchant API.
 email: leequarella@gmail.com