virtual_merchant 0.3.8 → 0.3.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8ac34cc9c1554e88c53674e8bb01f2dedfb356de
-  data.tar.gz: 343f72027befad114837e030e0cf669c92d5ab4f
+  metadata.gz: b66fbdd061c01dd0fe3616af2b274b50d4cf15af
+  data.tar.gz: ea8a7a2f2f335dfa46a052d88d39461c950e3542
 SHA512:
-  metadata.gz: e0ad4523bdff048db0cd6edcebbbc26b8aa9f523a2c0da696f105b320ab6b69eec64419dcdd677dc568e03493f18845952d47712b9a6facbc4f9b0e70f3d5915
-  data.tar.gz: d8fa3aa086f4edb3d5ef0c6cd2c8c7d44ee224f9607c8c024d83d7f8889d0b0f0110734492e4fdf269b5cd173e459af5dda15b00d6b913bab8d8b27491d33d4b
+  metadata.gz: bba7caef29bc7de60a0099180a51e5a8a323a2c851d6125b3dfa7d685e38898428658b668bd3efd98b86042e0cf6339e337a84e01e0d34e47a2e68331eb9f462
+  data.tar.gz: a2ba8491b977ce3dd4484f73a309bb17e07b5cd73b3bace09dcefb0d6a9480a790a2bb98a352bf96ff32b8197043dec722d0ddee50c51215cedbd22b4c223743

data/lib/virtual_merchant/credit_card.rb

@@ -1,7 +1,8 @@
+require 'virtual_merchant/swipe_extractor'
 module VirtualMerchant
   class CreditCard
     attr_accessor :name_on_card, :number, :expiration, :security_code, :swipe, :track2,
-      :encrypted_track_1, :encrypted_track_2, :last_four, :encrypted, :swiped
+      :encrypted_track_1, :encrypted_track_2, :last_four, :encrypted, :swiped, :valid, :errors
 
     def self.from_swipe(swipe)
       if swipe.class == Hash && swipe[:encrypted]
@@ -16,6 +17,7 @@ module VirtualMerchant
     end
 
     def initialize(info)
+      @errors = {}
       if info[:encrypted]
         self.from_encrypted(info)
       elsif info[:swipe]
@@ -26,6 +28,7 @@ module VirtualMerchant
     end
 
     def from_encrypted (info)
+      @errors            = {}
       @encrypted         = true
       @encrypted_track_1 = info[:track_1]
       @encrypted_track_2 = info[:track_2]
@@ -33,22 +36,35 @@ module VirtualMerchant
     end
 
     def from_swipe(swipe_raw)
-      @swiped       = true
-      @swipe        = swipe_raw
-      @track2       = extract_track_2(swipe)
-      @number       = extract_card_number(swipe)
-      @expiration   = extract_expiration(swipe)
-      @name_on_card = extract_name(swipe)
-      @last_four    = extract_last_four
+      @errors = {}
+      if check_swipe(swipe_raw)
+        @valid        = true
+        @swiped       = true
+        @swipe        = swipe_raw
+        @track2       = SwipeExtractor.get_track_2(swipe)
+        @number       = SwipeExtractor.get_card_number(swipe)
+        @expiration   = SwipeExtractor.get_expiration(swipe)
+        @name_on_card = SwipeExtractor.get_name(swipe)
+        @last_four    = SwipeExtractor.get_last_four(@number)
+      else
+        @valid = false
+      end
     end
 
     def from_manual(info)
-      @name_on_card  = info[:name_on_card]                if info[:name_on_card]
-      @number        = info[:number].to_s.gsub(/\s+/, "") if info[:number]
-      @expiration    = info[:expiration].to_s             if info[:expiration]
-      @security_code = info[:security_code].to_s          if info[:security_code]
-      @track2        = info[:track_2]                     if info[:track_2]
-      @last_four     = extract_last_four
+      @errors = {}
+      if info[:number] && check_luhn(info[:number].to_s.gsub(/\s+/, ""))
+        @name_on_card  = info[:name_on_card]                if info[:name_on_card]
+        @number        = info[:number].to_s.gsub(/\s+/, "")
+        @expiration    = info[:expiration].to_s             if info[:expiration]
+        @security_code = info[:security_code].to_s          if info[:security_code]
+        @track2        = info[:track_2]                     if info[:track_2]
+        @last_four     = SwipeExtractor.get_last_four(@number)
+        @valid = true
+      else
+        errors[5000] = "The Credit Card Number supplied in the authorization request appears to be invalid."
+        @valid = false
+      end
     end
 
     def encrypted?
@@ -59,50 +75,41 @@ module VirtualMerchant
       self.swiped
     end
 
-    def extract_card_number(swipe)
-      card_number = swipe[2.. swipe.index('^')-1]
-      card_number = card_number.split(' ').join('')
-    end
-
-    def extract_expiration(swipe)
-      secondCarrot = swipe.index("^", swipe.index("^")+1)
-      card_expiration_year = swipe[secondCarrot+1..secondCarrot+2]
-      card_expiration_month = swipe[(secondCarrot + 3)..(secondCarrot + 4)]
-      card_expiration = card_expiration_month.to_s + card_expiration_year.to_s
+    def valid?
+      self.valid
     end
 
-    def extract_name(swipe)
-      secondCarrot = swipe.index("^", swipe.index("^")+1)
-      if swipe.index('/')
-        first_name_on_card = swipe[swipe.index('/')+1..secondCarrot-1]
-        last_name_on_card = swipe[swipe.index('^')+1..swipe.index('/')-1]
-      else
-        if !swipe.index(" ")
-          first_name_on_card = "Gift"
-          last_name_on_card = "Card"
-        else
-          first_name_on_card = swipe.slice(swipe.index('^') + 1, swipe.index(' '))
-          last_name_on_card = swipe.slice(swipe.index(" ") + 1, secondCarrot)
-        end
+    def check_swipe(swipe_raw)
+      if swipe_raw.index('%') == nil
+        @errors[5012] = "The track data sent appears to be invalid."
+        return false
       end
-      name_on_card = first_name_on_card + " " + last_name_on_card
-    end
-
-    def extract_track_2(swipe)
-      # Magtek reader:  Track 2 starts with a semi-colon and goes to the end
-      # I think that is standard for all readers, but not positive. -LQ
-      track2 = swipe.slice(swipe.index(";"), swipe.length)
-      if track2.index("+")
-        #  Some AMEX have extra stuff at the end of track 2 that causes
-        #virtual merchant to return an INVLD DATA5623 message.
-        #Soooo... let's slice that off
-        track2 = track2.slice(0, track2.index("+"))
+      if swipe_raw.index(';') == nil
+        @errors[5013] = "Transaction requires Track2 data to be sent."
+        return false
       end
-      track2
+      track1 = swipe_raw[1.. swipe_raw.index('?')-1]
+      if track1 == nil || track1 == "E"
+        @errors[5012] = "The track data sent appears to be invalid."
+        return false
+      end
+      track2 = swipe_raw[swipe_raw.index(';')+1.. swipe_raw.length-2]
+      if track2 == nil || track2 == "E"
+        @errors[5013] = "Transaction requires Track2 data to be sent."
+        return false
+      end
+      return true
     end
 
-    def extract_last_four
-      self.number[(self.number.length - 4)..self.number.length]
+    def check_luhn(code)
+      s1 = s2 = 0
+      code.to_s.reverse.chars.each_slice(2) do |odd, even|
+        s1 += odd.to_i
+        double = even.to_i * 2
+        double -= 9 if double >= 10
+        s2 += double
+      end
+      (s1 + s2) % 10 == 0
     end
 
    def blurred_number

data/lib/virtual_merchant/gateway.rb

@@ -6,13 +6,21 @@ class Gateway
   end
 
   def ccsale(card, amount, custom_fields)
-    xml = VirtualMerchant::XMLGenerator.generate(card, amount, creds, custom_fields, "ccsale")
-    process(xml, amount)
+    if card.valid?
+      xml = VirtualMerchant::XMLGenerator.generate(card, amount, creds, custom_fields, "ccsale")
+      process(xml, amount)
+    else
+      gen_cc_errors(card)
+    end
   end
 
   def ccauth(card, amount, custom_fields)
-    xml = VirtualMerchant::XMLGenerator.generate(card, amount, creds, custom_fields, "ccauthonly")
-    process(xml, amount)
+    if card.valid?
+      xml = VirtualMerchant::XMLGenerator.generate(card, amount, creds, custom_fields, "ccauthonly")
+      process(xml, amount)
+    else
+      gen_cc_errors(card)
+    end
   end
 
   def cccomplete(amount, transaction_id)
@@ -27,13 +35,21 @@ class Gateway
   end
 
   def ccaddrecurring(card, amount, custom_fields)
-    xml = VirtualMerchant::XMLGenerator.generate(card, amount, creds, custom_fields, "ccaddrecurring")
-    process(xml, amount)
+    if card.valid?
+      xml = VirtualMerchant::XMLGenerator.generate(card, amount, creds, custom_fields, "ccaddrecurring")
+      process(xml, amount)
+    else
+      gen_cc_errors(card)
+    end
   end
 
   def cccredit(card, amount, custom_fields)
-    xml = VirtualMerchant::XMLGenerator.generate(card, amount, creds, custom_fields, 'cccredit')
-    process(xml, amount)
+    if card.valid?
+      xml = VirtualMerchant::XMLGenerator.generate(card, amount, creds, custom_fields, 'cccredit')
+      process(xml, amount)
+    else
+      gen_cc_errors(card)
+    end
   end
 
   def ccvoid(transaction_id)
@@ -58,4 +74,13 @@ class Gateway
       'https://www.myvirtualmerchant.com/VirtualMerchant/processxml.do'
     end
   end
+
+  def gen_cc_errors(card)
+    card.errors.each do |code, msg|
+      xml = VirtualMerchant::XMLGenerator.error(code, msg)
+      response = VirtualMerchant::Response.new(xml)
+      VirtualMerchant::Logger.log_response(response)
+      response
+    end
+  end
 end

data/lib/virtual_merchant/logger.rb

@@ -1,14 +1,12 @@
 module VirtualMerchant
   class Logger
-    @@on = false
+    @@on      = false
+    @@log_xml = false
 
-    def self.on!
-      @@on = true
-    end
-
-    def self.off!
-      @@on = false
-    end
+    def self.on!()      @@on      = true  end
+    def self.off!()     @@on      = false end
+    def self.xml_on!()  @@log_xml = true  end
+    def self.xml_off!() @@log_xml = false end
 
     def self.log_response(response)
       return unless @@on
@@ -21,5 +19,12 @@ module VirtualMerchant
       p "result_message " + response.result_message
       p "!!!!!!!!!!!!!!!!!!!!!!!! End Credit Response !!!!!!!!!!!!!!!!!!!!!!!!!!!!"
     end
+
+    def self.xml(msg, xml)
+      return unless @@log_xml
+      puts msg
+      pp xml
+    end
+
   end
 end

data/lib/virtual_merchant/xml_generator.rb

@@ -8,6 +8,7 @@ module VirtualMerchant
         <ssl_pin>#{creds.pin}</ssl_pin>
         <ssl_txn_id>#{transaction_id}</ssl_txn_id>
         </txn>"
+      VirtualMerchant::Logger.xml('VOID OUTPUT', xml)
       return xml
     end
 
@@ -25,6 +26,7 @@ module VirtualMerchant
           xml += "<#{key}>#{value}</#{key}>"
         end
       xml += "</txn>"
+      VirtualMerchant::Logger.xml('NORMAL OUTPUT', xml)
       xml
     end
 
@@ -37,6 +39,7 @@ module VirtualMerchant
         xml += "<ssl_amount>#{amount.total}</ssl_amount>"
       end
       xml +=   "</txn>"
+      VirtualMerchant::Logger.xml('MODIFY TRANSACTION OUTPUT', xml)
       xml
     end
 
@@ -90,5 +93,13 @@ module VirtualMerchant
       end
       xml
     end
+
+    def self.error(code, message)
+      xml =  "<txn>
+              <errorCode>#{code}</errorCode>
+              <errorMessage>#{message}</errorMessage>
+              </txn>"
+      xml
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: virtual_merchant
 version: !ruby/object:Gem::Version
-  version: 0.3.8
+  version: 0.3.9
 platform: ruby
 authors:
 - Lee Quarella
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-01 00:00:00.000000000 Z
+date: 2014-06-16 00:00:00.000000000 Z
 dependencies: []
 description: Makes it easy to charge credit cards with the VirtualMerchant API.
 email: leequarella@gmail.com
@@ -21,10 +21,10 @@ files:
 - lib/virtual_merchant/communication.rb
 - lib/virtual_merchant/credentials.rb
 - lib/virtual_merchant/credit_card.rb
+- lib/virtual_merchant/gateway.rb
 - lib/virtual_merchant/logger.rb
 - lib/virtual_merchant/response.rb
 - lib/virtual_merchant/xml_generator.rb
-- lib/virtual_merchant/gateway.rb
 homepage: https://github.com/leequarella/VirtualMerchant-Ruby
 licenses:
 - MIT
@@ -35,17 +35,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.10
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Virtual Merchant API