virtual_merchant 0.3.4 → 0.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 72797bfae1434d9bc0273a01cd525c10f07c3df3
-  data.tar.gz: b56f47277819911d30a8c546eb505d30c79181f4
+  metadata.gz: f6ca7cbb9d65a0a2a00731c69a236d6494acdd23
+  data.tar.gz: fe1c36484a1773707966d174e7f47056d4f39bc2
 SHA512:
-  metadata.gz: 2d398dc6ecba591b7def754daa9e53d6f54420b7a4c0f650e20336c4a09e70f0aabb6e18bbf28e3e70e2fcbef8557d83156a46248769cba77811c17ece8d4874
-  data.tar.gz: 2a6b8cb2442f30131f78d6c63532987be1a3cd6518834d6a065a9b9593ec680346c9b786cb4f13fefef42318423e9cd9ba5328ec1ab8c3f3c09702d77c1d2ba8
+  metadata.gz: 5fcc4f723fe2dda3c59202c0ad7be37dd126070e1ab7a32b69ef6610f5b60a2ee9e7435992c81118dfa8fe6c574c8507c489878a1d8d8ac6b17d4570d56a4891
+  data.tar.gz: 306247aa0420dcf3fe86d3e1be29ea41dab737830ce93e32bfb4dc170a996c36d0595f1c2fa47cb3a7234f0c93109e86cc9a4ff4ab0ab06904cf1eebc9c24b19

data/lib/virtual_merchant/credit_card.rb

@@ -106,12 +106,20 @@ module VirtualMerchant
     end
 
    def blurred_number
-      number = self.number.to_s
-      leng = number.length
-      n = number[0..1]
-      (leng-6).times {n+= "*"}
-      n += number[number.length-4..number.length]
-      n
+     begin
+       number = self.number.to_s
+       leng = number.length
+       n = number[0..1]
+       (leng-6).times {n+= "*"}
+       n += number[number.length-4..number.length]
+       n
+     rescue Exception => e
+       puts "-"
+       puts "Error in VirtualMerchant-Ruby Gem when trying to blur card number: #{e}."
+       puts "You either passed a nil value for card_number or a number that is too short."
+       puts caller
+       puts "-"
+     end
     end
   end
 end

data/lib/virtual_merchant/response.rb

@@ -38,29 +38,43 @@ module VirtualMerchant
     end
 
     def error_response(code, message)
-      @approved = false
+      @approved       = false
       @result_message = message
-      @error = code
+      @error          = code
     end
 
     def approval(xml)
-      @approved = true
-      @result_message = xml.elements["ssl_result_message"].text if xml.elements["ssl_result_message"]
-      @result = xml.elements["ssl_result"].text if xml.elements["ssl_result"]
+      basic(xml)
+      if xml.elements["ssl_result"]
+        normal_approval(xml)
+      else #recurring
+        recurring_approval(xml)
+      end
+    end
+
+    def basic(xml)
+      @approved            = true
+      @result_message      = xml.elements["ssl_result_message"].text
       @blurred_card_number = xml.elements["ssl_card_number"].text
-      @exp_date = xml.elements["ssl_exp_date"].text
-      @approval_code = xml.elements["ssl_approval_code"].text if xml.elements["ssl_approval_code"]
-      @cvv2_response = xml.elements["ssl_cvv2_response"].text if xml.elements["ssl_cvv2_response"]
-      @transaction_id = xml.elements["ssl_txn_id"].text if xml.elements["ssl_txn_id"]
-      @transaction_time = xml.elements["ssl_txn_time"].text if xml.elements["ssl_txn_time"]
-      #Recurring variables
-      @billing_cycle = xml.elements["ssl_billing_cycle"].text if xml.elements["ssl_billing_cycle"]
-      @start_payment_date = xml.elements["ssl_start_payment_date"].text if xml.elements["ssl_start_payment_date"]
-      @transaction_type = xml.elements["ssl_transaction_type"].text if xml.elements["ssl_transaction_type"]
-      @recurring_id = xml.elements["ssl_recurring_id"].text if xml.elements["ssl_recurring_id"]
-      @next_payment_date = xml.elements["ssl_next_payment_date"].text if xml.elements["ssl_next_payment_date"]
-      @skip_payment = xml.elements["ssl_skip_payment"].text if xml.elements["ssl_skip_payment"]
-      @recurring_batch_count = xml.elements["ssl_recurring_batch_count"].text if xml.elements["ssl_recurring_batch_count"]
+      @exp_date            = xml.elements["ssl_exp_date"].text
+    end
+
+    def normal_approval(xml)
+      @result           = xml.elements["ssl_result"].text
+      @approval_code    = xml.elements["ssl_approval_code"].text
+      @cvv2_response    = xml.elements["ssl_cvv2_response"].text
+      @transaction_id   = xml.elements["ssl_txn_id"].text
+      @transaction_time = xml.elements["ssl_txn_time"].text
+    end
+
+    def recurring_approval(xml)
+      @billing_cycle         = xml.elements["ssl_billing_cycle"].text
+      @start_payment_date    = xml.elements["ssl_start_payment_date"].text
+      @transaction_type      = xml.elements["ssl_transaction_type"].text
+      @recurring_id          = xml.elements["ssl_recurring_id"].text
+      @next_payment_date     = xml.elements["ssl_next_payment_date"].text
+      @skip_payment          = xml.elements["ssl_skip_payment"].text
+      @recurring_batch_count = xml.elements["ssl_recurring_batch_count"].text
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: virtual_merchant
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.5
 platform: ruby
 authors:
 - Lee Quarella
@@ -45,7 +45,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.1.10
 signing_key: 
 specification_version: 4
 summary: Virtual Merchant API