vinted-ab 0.2.6 → 0.2.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 524583866170f2c146e62a8e3e0856c70c182c30
-  data.tar.gz: 5d2eb21da061a576bf9ba799980f205c69cf5150
+SHA256:
+  metadata.gz: d069e34f8671a2ccc55a6924afb1e255888b4ca740a4a03dbbdd6f360d907b58
+  data.tar.gz: f51aa39c3be297dca1b7fa89d99e414d85505f4bdea797631412540d0e0d1db0
 SHA512:
-  metadata.gz: f272ba169ff0cf3f0ca4c17595cc1d2a0ea2d66573534f2e4f1fd6f316b374dffba59f8b3561bffcc3af143908f8ee111d87689a45c37a5d6c5796498685ecd3
-  data.tar.gz: 58155d2dca6f2cc55cb61ba557e8ddd9d59126b282d6bd4588cf8e421e3d4c96af0956437b64a4bba65746cc6dea232566384c1876cd97efe029d9419d556f8c
+  metadata.gz: 9fbd2529f3c958a563221756ba9f74fd1f89f734d424768a3232f4277ba53f71a00addce8bd45479b9622167597e9d7483bc6139a924667be45045956513e9c6
+  data.tar.gz: 9128f66932480f1fe744e833f599ece23250e317a9787a4864791ee2d8381a42ad3bbad9d5e5076c1b12f745ce54021e941f33532263d15e45d1b1d1e2e63d78

data/.rubocop.yml

@@ -7,5 +7,8 @@ Documentation:
 SignalException:
   EnforcedStyle: only_raise
 
-TrailingComma:
+TrailingCommaInLiteral:
+  Enabled: false
+
+TrailingCommaInArguments:
   Enabled: false

data/.travis.yml

@@ -1,5 +1,7 @@
+sudo: required
+dist: trusty
 language: ruby
 rvm:
-- 1.9.3
-- 2.0.0
-- 2.1.1
+- 2.4.2
+- 2.5.3
+- 2.6.1

data/ab.gemspec

@@ -15,14 +15,12 @@ Gem::Specification.new do |spec|
   spec.required_rubygems_version = '>= 1.3.6'
   spec.license = 'MIT'
 
-  spec.files = `git ls-files`.split($/)
+  spec.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.test_files = `git ls-files -- {spec}/*`.split("\n")
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'rake', '~> 10.3'
+  spec.add_development_dependency 'rake', '~> 11.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rspec-its', '~> 1.0'
   spec.add_development_dependency 'json-schema', '~> 2.2.2', '>= 2.2.2'
-  spec.add_development_dependency 'ruby-prof', '~> 0.15.0', '>= 0.15.0'
-  spec.add_development_dependency 'pry', '~> 0.10.0', '>= 0.10.0'
 end

data/lib/ab/assigned_test.rb

@@ -3,10 +3,8 @@ module Ab
     include Ab::MissingVariant
 
     def initialize(test, id)
-      @test, @id = test, id
-      variants.each do |name|
-        define_singleton_method("#{name}?") { name == variant }
-      end
+      @test = test
+      @id = id
     end
 
     class << self
@@ -20,6 +18,12 @@ module Ab
       end
     end
 
+    def method_missing(name, *args, &block)
+      variant_query = name.to_s[0..-2]
+      return variant == variant_query if variant_method?(name) && variants.include?(variant_query)
+      super
+    end
+
     def variant(run_callbacks = true)
       @variant ||= begin
         return unless part_of_test?

data/lib/ab/test.rb

@@ -1,6 +1,6 @@
 module Ab
   class Test < Struct.new(:hash, :salt, :bucket_count)
-    DEFAULT_START_AT =  DateTime.new(0)
+    DEFAULT_START_AT = DateTime.new(0)
     DEFAULT_END_AT = DateTime.new(3000)
 
     def buckets

data/lib/ab/tests.rb

@@ -13,29 +13,45 @@ module Ab
     def initialize(json, id)
       json ||= {}
       config = json.is_a?(Hash) ? json : JSON.parse(json)
-
-      salt = config['salt']
-      bucket_count = config['bucket_count']
-
-      tests = (config['ab_tests'] || []).map { |test| Test.new(test, salt, bucket_count) }
-
-      @assigned_tests = tests.map do |test|
-        assigned_test = AssignedTest.new(test, id)
-        define_singleton_method(test.name) { assigned_test }
-        [test.name, assigned_test]
-      end
+      @ab_tests = config['ab_tests'] || []
+      @salt = config['salt']
+      @bucket_count = config['bucket_count']
+      @id = id
     end
 
     def all
-      Hash[@assigned_tests.map { |name, assigned_test| [name, assigned_test.variant(false)] }]
+      grouped_ab_tests.keys.map { |name| [name, assigned_test(name).variant(false)] }.to_h
     end
 
-    def method_missing(*)
-      @null_test ||= NullTest.new
+    def method_missing(name, *)
+      assigned_test(name.to_s) || null_test
     end
 
     def respond_to_missing?(*)
       true
     end
+
+    private
+
+    def null_test
+      @null_test ||= NullTest.new
+    end
+
+    def assigned_test(name)
+      @assigned_tests ||= {}
+      if grouped_ab_tests.key?(name)
+        @assigned_tests[name] ||= begin
+                                    test = Test.new(grouped_ab_tests[name], @salt, @bucket_count)
+                                    AssignedTest.new(test, @id)
+                                  end
+      end
+    end
+
+    def grouped_ab_tests
+      @grouped_ab_tests ||= @ab_tests.reduce({}) do |hash, test|
+        hash[test['name']] = test
+        hash
+      end
+    end
   end
 end

data/lib/ab/version.rb

@@ -1,3 +1,3 @@
 module Ab
-  VERSION = '0.2.6'
+  VERSION = '0.2.7'.freeze
 end

data/spec/null_test_spec.rb

@@ -12,12 +12,12 @@ module Ab
       before { Ab.config.logger.should_not_receive(:debug) }
 
       specify 'does not raise' do
-        lambda { subject.bla? }.should_not raise_error
+        -> { subject.bla? }.should_not raise_error
       end
     end
 
     specify 'raises for method not ending in question mark' do
-      lambda { subject.bla }.should raise_error
+      -> { subject.bla }.should raise_error
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vinted-ab
 version: !ruby/object:Gem::Version
-  version: 0.2.6
+  version: 0.2.7
 platform: ruby
 authors:
 - Mindaugas Mozūras
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-29 00:00:00.000000000 Z
+date: 2019-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.3'
+        version: '11.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.3'
+        version: '11.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -73,46 +73,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.2.2
-- !ruby/object:Gem::Dependency
-  name: ruby-prof
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.15.0
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.15.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.15.0
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.15.0
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.10.0
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.10.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.10.0
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.10.0
 description: 
 email:
 - mindaugas.mozuras@gmail.com
@@ -191,7 +151,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: AB testing gem used internally by Vinted