vinted-ab 0.2.5 → 0.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f227fe8202a3994a25c47c152ed4ca675ad5d571
-  data.tar.gz: f50d6b977402e19d57a62cba1a9affcf749d011a
+  metadata.gz: 524583866170f2c146e62a8e3e0856c70c182c30
+  data.tar.gz: 5d2eb21da061a576bf9ba799980f205c69cf5150
 SHA512:
-  metadata.gz: dedbd7a58d4d5490e6a27677f36e31dc426ec762a063bbb10c7c2b80cd41fa11efed903e575a63f0dc301603f41529d30eb285e1e836ca39b5196e3b40f188bd
-  data.tar.gz: 41246c457af514bea7a803938b3418a87a195e4cae254abe0080ea081ffd6e850f5a183c1065af8a7a9077257af6b649c961b92cf2d29bbc1d67ee051a9d382c
+  metadata.gz: f272ba169ff0cf3f0ca4c17595cc1d2a0ea2d66573534f2e4f1fd6f316b374dffba59f8b3561bffcc3af143908f8ee111d87689a45c37a5d6c5796498685ecd3
+  data.tar.gz: 58155d2dca6f2cc55cb61ba557e8ddd9d59126b282d6bd4588cf8e421e3d4c96af0956437b64a4bba65746cc6dea232566384c1876cd97efe029d9419d556f8c

data/lib/ab/assigned_test.rb

@@ -25,11 +25,11 @@ module Ab
         return unless part_of_test?
         return unless running?
 
-        AssignedTest.before.call(@test.name) if run_callbacks && AssignedTest.before.respond_to?(:call)
+        AssignedTest.before.call(name) if run_callbacks && AssignedTest.before.respond_to?(:call)
         picked_variant = @test.variants.find { |v| v.accumulated_chance_weight > weight_id }
 
         result = picked_variant.name if picked_variant
-        AssignedTest.after.call(@test.name, result) if run_callbacks && AssignedTest.after.respond_to?(:call)
+        AssignedTest.after.call(name, result) if run_callbacks && AssignedTest.after.respond_to?(:call)
         result
       end
     end
@@ -48,6 +48,10 @@ module Ab
 
     private
 
+    def name
+      @test.name
+    end
+
     def part_of_test?
       @test.all_buckets? ||
         @test.buckets && @test.buckets.include?(bucket_id)
@@ -58,7 +62,7 @@ module Ab
     end
 
     def running?
-      DateTime.now.between?(@test.start_at, @test.end_at)
+      DateTime.now.between?(start_at, end_at)
     end
 
     def weight_id

data/lib/ab/missing_variant.rb

@@ -20,7 +20,13 @@ module Ab
     end
 
     def log_missing_variant(meth)
-      Ab.config.logger.debug("[AB_testing] Checking non-existing variant: #{meth}")
+      return unless name
+
+      Ab.config.logger.debug("[AB_testing] Checking non-existing variant: #{name}##{meth}")
+    end
+
+    def name
+      nil
     end
   end
 end

data/lib/ab/version.rb

@@ -1,3 +1,3 @@
 module Ab
-  VERSION = '0.2.5'
+  VERSION = '0.2.6'
 end

data/spec/assigned_test_spec.rb

@@ -18,7 +18,7 @@ module Ab
 
     context 'with non existent variant' do
       let(:variants) { [OpenStruct.new(name: 'enabled', accumulated_chance_weight: 2)] }
-      let(:message) { '[AB_testing] Checking non-existing variant: disabled?' }
+      let(:message) { '[AB_testing] Checking non-existing variant: feed#disabled?' }
 
       before { Ab.config.logger.should_receive(:debug).with(message) }
 

data/spec/null_test_spec.rb

@@ -8,8 +8,12 @@ module Ab
     its(:start_at) { should_not be_nil }
     its(:end_at) { should_not be_nil }
 
-    specify 'does not raise for method ending in question mark' do
-      lambda { subject.bla? }.should_not raise_error
+    context 'with method ending in question mark' do
+      before { Ab.config.logger.should_not_receive(:debug) }
+
+      specify 'does not raise' do
+        lambda { subject.bla? }.should_not raise_error
+      end
     end
 
     specify 'raises for method not ending in question mark' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vinted-ab
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 0.2.6
 platform: ruby
 authors:
 - Mindaugas Mozūras
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-19 00:00:00.000000000 Z
+date: 2015-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake