vinted-ab 0.2.4 → 0.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f6e46f66084e779a1eeca15edf6b3eba928b747b
-  data.tar.gz: 5e47066cb8520292d863b97be976f42c7d93e0fa
+  metadata.gz: f227fe8202a3994a25c47c152ed4ca675ad5d571
+  data.tar.gz: f50d6b977402e19d57a62cba1a9affcf749d011a
 SHA512:
-  metadata.gz: ed4970561d2c2ec748f29ea3d5c378d8b181a1dea026a12d6d7eea4fcaa0d930c5c55283bead185d8d81bb9f35e5a13675d56e4f455397ec58456e431c46310b
-  data.tar.gz: b56781fed1989fe0f536afafbb7dcce815feb0a7bc99c2056bef91a5b15e4af1c5c5000eb6c02ec19277207da6a6493cc42fbf93994fcb48c791362ef106dd39
+  metadata.gz: dedbd7a58d4d5490e6a27677f36e31dc426ec762a063bbb10c7c2b80cd41fa11efed903e575a63f0dc301603f41529d30eb285e1e836ca39b5196e3b40f188bd
+  data.tar.gz: 41246c457af514bea7a803938b3418a87a195e4cae254abe0080ea081ffd6e850f5a183c1065af8a7a9077257af6b649c961b92cf2d29bbc1d67ee051a9d382c

data/.travis.yml

@@ -0,0 +1,5 @@
+language: ruby
+rvm:
+- 1.9.3
+- 2.0.0
+- 2.1.1

data/README.md

@@ -1,6 +1,7 @@
 # ab
 
 [![Code Climate](https://codeclimate.com/github/vinted/ab.png)](https://codeclimate.com/github/vinted/ab)
+[![Build Status](https://secure.travis-ci.org/vinted/ab.png)](http://travis-ci.org/vinted/ab)
 [![Gem Version](https://badge.fury.io/rb/vinted-ab.png)](http://badge.fury.io/rb/vinted-ab)
 [![Dependency Status](https://gemnasium.com/vinted/ab.png)](https://gemnasium.com/vinted/ab)
 
@@ -19,6 +20,11 @@ ab = Ab::Tests.new(configuration, identifier)
 Ab::Tests.before_picking_variant { |test| puts "picking variant for #{test}" }
 Ab::Tests.after_picking_variant { |test, variant| puts "#{variant_name}" }
 
+# by default messages are logged to null logger. Can be changed by setting your own logger:
+Ab.configure do |config|
+  config.logger = Logger.new($stdout)
+end
+
 # ab.test never returns nil, but #variant can
 case ab.test.variant
 when 'red_button'
@@ -32,6 +38,9 @@ end
 # calls #variant underneath, results of that call are cached
 puts 'red button' if ab.test.red_button?
 
+# non existant variants return false
+puts 'this will not get printed' if ab.test.there_is_no_button?
+
 # both start_at and end_at dates are accessible
 puts 'newbie button' if user.created_at > ab.test.start_at && ab.test.for_newbies?
 ```

data/Rakefile

@@ -1 +1,9 @@
-require 'bundler/gem_tasks'
+#!/usr/bin/env rake
+require 'bundler'
+require 'rspec/core/rake_task'
+
+Bundler::GemHelper.install_tasks
+RSpec::Core::RakeTask.new(:spec)
+
+task(:default).clear
+task default: [:spec]

data/ab.gemspec

@@ -19,10 +19,9 @@ Gem::Specification.new do |spec|
   spec.test_files = `git ls-files -- {spec}/*`.split("\n")
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake', '~> 10.1', '>= 10.1.0'
-  spec.add_development_dependency 'rspec', '~> 2.14', '>= 2.14.0'
-  spec.add_development_dependency 'rspec-its', '~> 1.0.1'
+  spec.add_development_dependency 'rake', '~> 10.3'
+  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'rspec-its', '~> 1.0'
   spec.add_development_dependency 'json-schema', '~> 2.2.2', '>= 2.2.2'
   spec.add_development_dependency 'ruby-prof', '~> 0.15.0', '>= 0.15.0'
   spec.add_development_dependency 'pry', '~> 0.10.0', '>= 0.10.0'

data/lib/ab.rb

@@ -1,4 +1,9 @@
+require 'securerandom'
+require 'date'
+require 'logger'
 require 'ab/version'
+require 'ab/configuration'
+require 'ab/missing_variant'
 require 'ab/null_test'
 require 'ab/variant'
 require 'ab/test'

data/lib/ab/assigned_test.rb

@@ -1,5 +1,7 @@
 module Ab
   class AssignedTest
+    include Ab::MissingVariant
+
     def initialize(test, id)
       @test, @id = test, id
       variants.each do |name|

data/lib/ab/configuration.rb

@@ -0,0 +1,22 @@
+module Ab
+  class << self
+    attr_writer :config
+
+    def config
+      @config ||= Config.new
+    end
+
+    def configure
+      @config ||= Config.new
+      yield(@config)
+    end
+  end
+
+  class Config
+    attr_accessor :logger
+
+    def initialize
+      @logger = Logger.new(nil)
+    end
+  end
+end

data/lib/ab/missing_variant.rb

@@ -0,0 +1,26 @@
+module Ab
+  module MissingVariant
+    def method_missing(meth, *args, &block)
+      if variant_method?(meth)
+        log_missing_variant(meth)
+        false
+      else
+        super
+      end
+    end
+
+    def respond_to_missing?(meth, *)
+      variant_method?(meth) ? true : super
+    end
+
+    private
+
+    def variant_method?(meth)
+      meth.to_s.end_with?('?')
+    end
+
+    def log_missing_variant(meth)
+      Ab.config.logger.debug("[AB_testing] Checking non-existing variant: #{meth}")
+    end
+  end
+end

data/lib/ab/null_test.rb

@@ -1,5 +1,7 @@
 module Ab
   class NullTest
+    include Ab::MissingVariant
+
     def variant
     end
 
@@ -10,14 +12,5 @@ module Ab
     def end_at
       Test::DEFAULT_END_AT
     end
-
-
-    def method_missing(meth, *args, &block)
-      meth.to_s.end_with?('?') ? false : super
-    end
-
-    def respond_to?(meth)
-      meth.to_s.end_with?('?') ? true : super
-    end
   end
 end

data/lib/ab/tests.rb

@@ -34,7 +34,7 @@ module Ab
       @null_test ||= NullTest.new
     end
 
-    def respond_to?(*)
+    def respond_to_missing?(*)
       true
     end
   end

data/lib/ab/version.rb

@@ -1,3 +1,3 @@
 module Ab
-  VERSION = '0.2.4'
+  VERSION = '0.2.5'
 end

data/spec/assigned_test_spec.rb

@@ -16,6 +16,17 @@ module Ab
     let(:buckets) { 1..1000 }
     let(:thousand_variants) { 1.upto(1000).map { |i| AssignedTest.new(test, i).variant } }
 
+    context 'with non existent variant' do
+      let(:variants) { [OpenStruct.new(name: 'enabled', accumulated_chance_weight: 2)] }
+      let(:message) { '[AB_testing] Checking non-existing variant: disabled?' }
+
+      before { Ab.config.logger.should_receive(:debug).with(message) }
+
+      subject { assigned_test.disabled? }
+
+      it { should be false }
+    end
+
     describe '#variant' do
       subject { assigned_test.variant }
 

data/spec/examples/no_end/input.json

@@ -0,0 +1,23 @@
+{
+    "salt": "61b81d7844c40c4057ebe6fc1a7a4a54",
+    "bucket_count": 20,
+    "ab_tests": [
+        {
+            "id": 6,
+            "name": "no_end",
+            "seed": "1995f6808c018b6dd91a3bc927fd7e92",
+            "start_at": "1605-11-05T00:00:00+0100",
+            "all_buckets": true,
+            "variants": [
+                {
+                    "name": "green",
+                    "chance_weight": 1
+                },
+                {
+                    "name": "red",
+                    "chance_weight": 1
+                }
+            ]
+        }
+    ]
+}

data/spec/examples/no_end/output.json

@@ -0,0 +1,7 @@
+{
+    "test": "no_end",
+    "variants": {
+      "green": [1, 2, 3, 7, 8, 9, 12, 19, 31, 34],
+      "red": [6, 13, 18, 22, 23, 26, 27, 29, 36, 39]
+    }
+}

data/spec/null_test_spec.rb

@@ -9,11 +9,11 @@ module Ab
     its(:end_at) { should_not be_nil }
 
     specify 'does not raise for method ending in question mark' do
-      expect { subject.bla? }.to_not raise_error
+      lambda { subject.bla? }.should_not raise_error
     end
 
     specify 'raises for method not ending in question mark' do
-      expect { subject.bla }.to raise_error
+      lambda { subject.bla }.should raise_error
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,8 +1,9 @@
+require 'json'
 require 'rspec'
 require 'rspec/its'
 require 'ab'
 
 RSpec.configure do |config|
-  config.color = true
-  config.treat_symbols_as_metadata_keys_with_true_values = true
+  config.expect_with(:rspec) { |c| c.syntax = :should }
+  config.mock_with(:rspec) { |c| c.syntax = :should }
 end

data/spec/tests_spec.rb

@@ -52,7 +52,7 @@ module Ab
       subject { tests }
 
       specify 'has no public methods' do
-        (subject.public_methods(false) - [:method_missing, :respond_to?, :all]).count.should == 0
+        (subject.public_methods(false) - [:method_missing, :respond_to_missing?, :all]).count.should == 0
       end
 
       context 'single experiment with single variant' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vinted-ab
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.5
 platform: ruby
 authors:
 - Mindaugas Mozūras
@@ -9,76 +9,50 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-08 00:00:00.000000000 Z
+date: 2015-05-19 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 10.1.0
+        version: '10.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 10.1.0
+        version: '10.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.14'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.14.0
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.14'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.14.0
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.1
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.1
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: json-schema
   requirement: !ruby/object:Gem::Requirement
@@ -149,6 +123,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rubocop.yml"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -157,6 +132,8 @@ files:
 - config.json
 - lib/ab.rb
 - lib/ab/assigned_test.rb
+- lib/ab/configuration.rb
+- lib/ab/missing_variant.rb
 - lib/ab/null_test.rb
 - lib/ab/test.rb
 - lib/ab/tests.rb
@@ -181,6 +158,8 @@ files:
 - spec/examples/multiple_variants/output.json
 - spec/examples/no_buckets/input.json
 - spec/examples/no_buckets/output.json
+- spec/examples/no_end/input.json
+- spec/examples/no_end/output.json
 - spec/examples/no_variants/input.json
 - spec/examples/no_variants/output.json
 - spec/examples/zero_buckets/input.json
@@ -212,7 +191,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.3.0
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: AB testing gem used internally by Vinted