vinted-ab 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9b99ce135ea2599d2b7eed9d8a99652741fb5e63
-  data.tar.gz: d2a4c0f817404e112e425374c9647a675e687c86
+  metadata.gz: 68b075c639ff1ef723c81b9f60ff1ac8f517f1dd
+  data.tar.gz: df20ae610c9aa79b8204930fb3079f9edeb80132
 SHA512:
-  metadata.gz: 32e40803fc1a40193395ff3220b23ce6ccb5c7d96cadedb68ea0f186783d2ab66396a49d1b4d31c5ec76c53bf5d3497a263a2df41107a2597e079ccb3354bb77
-  data.tar.gz: 1229b0fe8d22740adbf0e04377dc490bd5f20366bfaacace608cf04f7b7d224b24aa80a483b59720ec18325cb3e04c9f3d1f5ab8047f1f5bec265c66b8a37741
+  metadata.gz: 4f1dd1e36834fe06efc1318c4847a4b6121cb4093534a193a6ca321a4f5762696699e89a7d675b71423b2d7323302eb68889def55a0aca4833cb662a0ea502aa
+  data.tar.gz: c6c2691cdd4fa3ba241e461930491324f31331fd675ba15edc9199ddefcb87fb7d456ae22e34e18ef1d18faf33437e202fa7ff9b17ba8568ac30279645f0f422

data/lib/ab/assigned_test.rb

@@ -18,16 +18,16 @@ module Ab
       end
     end
 
-    def variant
+    def variant(run_callbacks = true)
       @variant ||= begin
         return unless part_of_test?
         return unless running?
 
-        AssignedTest.before.call(@test.name) if AssignedTest.before.respond_to?(:call)
+        AssignedTest.before.call(@test.name) if run_callbacks && AssignedTest.before.respond_to?(:call)
         picked_variant = @test.variants.find { |v| v.accumulated_chance_weight > weight_id }
 
         result = picked_variant.name if picked_variant
-        AssignedTest.after.call(@test.name, result) if AssignedTest.after.respond_to?(:call)
+        AssignedTest.after.call(@test.name, result) if run_callbacks && AssignedTest.after.respond_to?(:call)
         result
       end
     end

data/lib/ab/tests.rb

@@ -27,14 +27,15 @@ module Ab
     end
 
     def all
-      Hash[@assigned_tests.map { |name, assigned_test| [name, assigned_test.variant] }]
+      # TODO: temporary feature to support old Vinted ab testing system
+      Hash[@assigned_tests.map { |name, assigned_test| [name, assigned_test.variant(false)] }]
     end
 
-    def method_missing(meth, *args, &block)
+    def method_missing(*)
       @null_test ||= NullTest.new
     end
 
-    def respond_to?(meth)
+    def respond_to?(*)
       true
     end
   end

data/lib/ab/version.rb

@@ -1,3 +1,3 @@
 module Ab
-  VERSION = '0.2.2'
+  VERSION = '0.2.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vinted-ab
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Mindaugas Mozūras