vinted-ab 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 67031305b2c5c180288a616ff7d931d4918604dc
-  data.tar.gz: de313c446acea2eda841eea20930c82938628c0c
+  metadata.gz: 9b99ce135ea2599d2b7eed9d8a99652741fb5e63
+  data.tar.gz: d2a4c0f817404e112e425374c9647a675e687c86
 SHA512:
-  metadata.gz: 8cd252fbb99403b6405401584879f9a410450adbaf2b8efa1c942d113e6046089fea519c90c7d4a9ae449e3e45a236acc1fc2ec0d9762071dcde2e2b88e07712
-  data.tar.gz: e0f21c86e0a21c40359da87572cfcfc9a23b955ea4d61c0730b547ea80d16a565e85c9a4c75da3551fbabda8f7c76703ae07c8cb7fa35f3bf3edeb8dc90fe9bd
+  metadata.gz: 32e40803fc1a40193395ff3220b23ce6ccb5c7d96cadedb68ea0f186783d2ab66396a49d1b4d31c5ec76c53bf5d3497a263a2df41107a2597e079ccb3354bb77
+  data.tar.gz: 1229b0fe8d22740adbf0e04377dc490bd5f20366bfaacace608cf04f7b7d224b24aa80a483b59720ec18325cb3e04c9f3d1f5ab8047f1f5bec265c66b8a37741

data/README.md

@@ -15,7 +15,7 @@ Each identifier is assigned to a bucket, using a hashing function. Buckets can t
 ```ruby
 ab = Ab::Tests.new(configuration, identifier)
 
-# defining callbacks
+# defining callbacks, will use caller's context
 Ab::Tests.before_picking_variant { |test| puts "picking variant for #{test}" }
 Ab::Tests.after_picking_variant { |test, variant| puts "#{variant_name}" }
 
@@ -113,3 +113,8 @@ seeded_identifier = test.seed + identifier.to_string
 weight_id = SHA256.hexdigest(seeded_identifier).to_int % chance_weight_sum
 test.variants.find { |variant| variant.accumulated_chance_weight > weight_id }
 ```
+
+## Other Implementations
+
+* [Java](https://github.com/vinted/ab-java) - intended to be used on Android, but not limited to that
+* [Objective-C](https://github.com/vinted/ab-ios) - intended to be used on iOS devices

data/ab.gemspec

@@ -19,7 +19,6 @@ Gem::Specification.new do |spec|
   spec.test_files = `git ls-files -- {spec}/*`.split("\n")
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'hooks', '~> 0.4', '>= 0.4.0'
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake', '~> 10.1', '>= 10.1.0'
   spec.add_development_dependency 'rspec', '~> 2.14', '>= 2.14.0'

data/lib/ab.rb

@@ -1,4 +1,3 @@
-require 'hooks'
 require 'ab/version'
 require 'ab/null_test'
 require 'ab/variant'

data/lib/ab/assigned_test.rb

@@ -1,8 +1,5 @@
 module Ab
   class AssignedTest
-    include Hooks
-    define_hooks :before_picking_variant, :after_picking_variant
-
     def initialize(test, id)
       @test, @id = test, id
       @test.variants.map(&:name).each do |name|
@@ -10,16 +7,27 @@ module Ab
       end
     end
 
+    class << self
+      attr_reader :before, :after
+      def before_picking_variant(&block)
+        @before = block
+      end
+
+      def after_picking_variant(&block)
+        @after = block
+      end
+    end
+
     def variant
       @variant ||= begin
         return unless part_of_test?
         return unless running?
 
-        run_hook :before_picking_variant, @test.name
+        AssignedTest.before.call(@test.name) if AssignedTest.before.respond_to?(:call)
         picked_variant = @test.variants.find { |v| v.accumulated_chance_weight > weight_id }
 
         result = picked_variant.name if picked_variant
-        run_hook :after_picking_variant, @test.name, result
+        AssignedTest.after.call(@test.name, result) if AssignedTest.after.respond_to?(:call)
         result
       end
     end

data/lib/ab/tests.rb

@@ -1,13 +1,13 @@
 module Ab
   class Tests
-    include Hooks
-    define_hooks :before_picking_variant, :after_picking_variant
+    class << self
+      def before_picking_variant(&block)
+        AssignedTest.before_picking_variant(&block)
+      end
 
-    Ab::AssignedTest.before_picking_variant do |test|
-      Ab::Tests.run_hook :before_picking_variant, test
-    end
-    Ab::AssignedTest.after_picking_variant do |test, variant|
-      Ab::Tests.run_hook :after_picking_variant, test, variant
+      def after_picking_variant(&block)
+        AssignedTest.after_picking_variant(&block)
+      end
     end
 
     def initialize(json, id)

data/lib/ab/version.rb

@@ -1,3 +1,3 @@
 module Ab
-  VERSION = '0.2.1'
+  VERSION = '0.2.2'
 end

data/spec/examples/already_finished/output.json

@@ -1,6 +1,6 @@
 {
     "test": "already_finished",
     "variants": {
-      "": [291605, 304029, 260623, 330108, 579320, 530360, 372392, 700813, 244200, 541818, 432400, 943631, 437817, 226191, 569129, 436127, 490360, 929904, 603358, 437705, 878118, 807422, 972099, 404677, 67694, 384045, 48608, 518304, 830501, 902758, 915681, 211550, 748688, 606226, 309490, 12909, 762, 560680, 945245, 795680, 358793, 850366, 278017, 765934, 378015, 156624, 878811, 814470, 830857, 712438]
+      "": [null, 291605, 304029, 260623, 330108, 579320, 530360, 372392, 700813, 244200, 541818, 432400, 943631, 437817, 226191, 569129, 436127, 490360, 929904, 603358, 437705, 878118, 807422, 972099, 404677, 67694, 384045, 48608, 518304, 830501, 902758, 915681, 211550, 748688, 606226, 309490, 12909, 762, 560680, 945245, 795680, 358793, 850366, 278017, 765934, 378015, 156624, 878811, 814470, 830857, 712438]
     }
 }

data/spec/examples/has_not_started/output.json

@@ -1,6 +1,6 @@
 {
     "test": "has_not_started",
     "variants": {
-      "": [183045, 691488, 793455, 522272, 961068, 778995, 753374, 995071, 219, 9, 765648, 519309, 581785, 419174, 62315, 901724, 739080, 528967, 744073, 751906, 886404, 457847, 817084, 160980, 302650, 911722, 447343, 871078, 450743, 879249, 276816, 826730, 697169, 344382, 511211, 154169, 55093, 648220, 964453, 862546, 208317, 16098, 341078, 111032, 277598, 876165, 650530, 446612, 583245, 7724]
+      "": [null, 183045, 691488, 793455, 522272, 961068, 778995, 753374, 995071, 219, 9, 765648, 519309, 581785, 419174, 62315, 901724, 739080, 528967, 744073, 751906, 886404, 457847, 817084, 160980, 302650, 911722, 447343, 871078, 450743, 879249, 276816, 826730, 697169, 344382, 511211, 154169, 55093, 648220, 964453, 862546, 208317, 16098, 341078, 111032, 277598, 876165, 650530, 446612, 583245, 7724]
     }
 }

data/spec/examples/no_buckets/output.json

@@ -1,6 +1,6 @@
 {
     "test": "no_buckets",
     "variants": {
-      "": [221661, 512005, 429796, 860028, 10044, 249906, 491257, 188883, 793187, 86200, 155542, 257569, 534172, 506476, 461784, 123346, 882492, 933085, 105147, 575351, 756286, 293415, 946852, 894051, 109248, 285169, 499834, 422777, 793, 353968, 470821, 300689, 994515, 352756, 527621, 811497, 12865, 405584, 783387, 23868, 1577, 402157, 645302, 921879, 743877, 65532, 729269, 704958, 473143, 621616]
+      "": [null, 221661, 512005, 429796, 860028, 10044, 249906, 491257, 188883, 793187, 86200, 155542, 257569, 534172, 506476, 461784, 123346, 882492, 933085, 105147, 575351, 756286, 293415, 946852, 894051, 109248, 285169, 499834, 422777, 793, 353968, 470821, 300689, 994515, 352756, 527621, 811497, 12865, 405584, 783387, 23868, 1577, 402157, 645302, 921879, 743877, 65532, 729269, 704958, 473143, 621616]
     }
 }

data/spec/examples/zero_buckets/output.json

@@ -1,6 +1,6 @@
 {
     "test": "zero_buckets",
     "variants": {
-      "": [407157, 680726, 413486, 225300, 884397, 493575, 77961, 191171, 540935, 504825, 276950, 750121, 964532, 987549, 250191, 644840, 906385, 584061, 56659, 397052, 544631, 107797, 485280, 418972, 547068, 726896, 224553, 369481, 713741, 739533, 639550, 895066, 397180, 829280, 581343, 566108, 438772, 173296, 99849, 106325, 308317, 135582, 82913, 994233, 882570, 72915, 699850, 161517, 420297, 836392]
+      "": [null, 407157, 680726, 413486, 225300, 884397, 493575, 77961, 191171, 540935, 504825, 276950, 750121, 964532, 987549, 250191, 644840, 906385, 584061, 56659, 397052, 544631, 107797, 485280, 418972, 547068, 726896, 224553, 369481, 713741, 739533, 639550, 895066, 397180, 829280, 581343, 566108, 438772, 173296, 99849, 106325, 308317, 135582, 82913, 994233, 882570, 72915, 699850, 161517, 420297, 836392]
     }
 }

data/spec/examples/zero_weight/output.json

@@ -1,6 +1,6 @@
 {
     "test": "zero_weight",
     "variants": {
-      "": [407157, 680726, 413486, 225300, 884397, 493575, 77961, 191171, 540935, 504825, 276950, 750121, 964532, 987549, 250191, 644840, 906385, 584061, 56659, 397052, 544631, 107797, 485280, 418972, 547068, 726896, 224553, 369481, 713741, 739533, 639550, 895066, 397180, 829280, 581343, 566108, 438772, 173296, 99849, 106325, 308317, 135582, 82913, 994233, 882570, 72915, 699850, 161517, 420297, 836392]
+      "": [null, 407157, 680726, 413486, 225300, 884397, 493575, 77961, 191171, 540935, 504825, 276950, 750121, 964532, 987549, 250191, 644840, 906385, 584061, 56659, 397052, 544631, 107797, 485280, 418972, 547068, 726896, 224553, 369481, 713741, 739533, 639550, 895066, 397180, 829280, 581343, 566108, 438772, 173296, 99849, 106325, 308317, 135582, 82913, 994233, 882570, 72915, 699850, 161517, 420297, 836392]
     }
 }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vinted-ab
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Mindaugas Mozūras
@@ -9,140 +9,120 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-19 00:00:00.000000000 Z
+date: 2014-07-07 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: hooks
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '0.4'
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: 0.4.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '0.4'
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: 0.4.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.1'
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 10.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.1'
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 10.1.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.14'
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.14.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.14'
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.14.0
 - !ruby/object:Gem::Dependency
   name: json-schema
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.2.2
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.2.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.2.2
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.2.2
 - !ruby/object:Gem::Dependency
   name: ruby-prof
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.15.0
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.15.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.15.0
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.15.0
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.10.0
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.10.0
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.10.0
 description: 
@@ -153,8 +133,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rubocop.yml
+- ".gitignore"
+- ".rubocop.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -208,17 +188,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.3.0
 signing_key: 
 specification_version: 4
 summary: AB testing gem used internally by Vinted