vimaly 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e67a18552b8d4a3c3bf527a2bb4fb859a15b8c59e0fded3fc7f5138df00d375
-  data.tar.gz: 5a1c9269b2556e45fe0eb867f4ad31f4fa73b11bd581da743ea5dc15eca2717c
+  metadata.gz: 2fbe16192cd230b1bc9195d5ef9f8faea9c0bdd99041be3b04abf87fb26f27e6
+  data.tar.gz: 713fa776cc88c0cf8b37dcbeae00cc4a3faabc5da76e17ad36c1e4cfd37fe385
 SHA512:
-  metadata.gz: 610de2b9dac4235222006ab0361a3d62f0c42ff6c6a67e5c6173ddb700ba19608a17f51e6d06c7d07bdf10b3791f3a88fe9dd98bf52a3cd6f355fb227a474142
-  data.tar.gz: a58e11c17157e1192383164018457b11502f6b284582432c6d04224bdbd7365f2a322847cfd7eebb8176f713a5025098276683bcee79277a9b6294d487741c4d
+  metadata.gz: f68b2e105cf61343ac2d2eb452ac3bb1b427deef775fc0d31b9a327839debe8a403a2c37780bd013275b16b8b70fde7be07a2211ba2ce12b670a99711b05c416
+  data.tar.gz: c50e2bb91e042557c69a74a608c6625898b6272359822e4c10e846e86aaad959e1d408d3babcc194e6be130c94dd94449703294c7a412c8e0cffd5efdfc9a1e8

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 1.3.0
+
+* add support for more than 200 results when searching for tickets [#22](https://github.com/sharesight/vimaly/pull/22)
+
 ## 1.2.0
 
 * add support for more than 500 bins, refactored and options added [#21](https://github.com/sharesight/vimaly/pull/21)

data/lib/vimaly/client.rb

@@ -58,9 +58,32 @@ module Vimaly
       ticket_type_map = Hash[ticket_types.map { |t| [t.id, t] }]
       bin_map = Hash[bins.map { |b| [b.id, b] }]
 
-      get("/ticket-search?text=#{query_string}&state=#{state}").map do |ticket_data|
-        Ticket.from_vimaly(ticket_data, ticket_type_map, bin_map, custom_fields)
+      tickets = []
+      i = 0
+
+      while (i * 500) <= 5000
+        # Without max-results the request defaults to 200.
+        # The maximum max-results is 500, so will do 10 requests to get our maximum of 5000 tickets.
+        search_response = get("/ticket-search?text=#{query_string}&state=#{state}&max-results=500&page-token=#{i * 500}")
+
+        response_tickets = case search_response
+          when Array
+            search_response.map do |ticket_data|
+              Ticket.from_vimaly(ticket_data, ticket_type_map, bin_map, custom_fields)
+            end
+          when Hash # Will be a hash when only 1 ticket is returned.
+            [Ticket.from_vimaly(search_response, ticket_type_map, bin_map, custom_fields)]
+          else # If reponse is nil then we know we've got all the data
+            break
+        end
+
+        tickets.concat(response_tickets)
+        break if response_tickets.size < 500 # Can finish search because we've returned all there is.
+
+        i += 1
       end
+
+      tickets
     end
 
     def add_attachment(ticket_id, file_name, file_content, request_options={})

data/lib/vimaly/version.rb

@@ -1,3 +1,3 @@
 module Vimaly
-  VERSION = "1.2.0".freeze
+  VERSION = "1.3.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: vimaly
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Thorsten Boettger
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-09-02 00:00:00.000000000 Z
+date: 2021-10-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -181,7 +181,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.17
+rubygems_version: 3.0.6
 signing_key:
 specification_version: 4
 summary: Wrapper for the Vimaly API