view_component_reflex 3.3.2 → 3.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9703632395793a339cac01282d844023f02d90e8aeb5cd76837a9e2148145a78
-  data.tar.gz: 88cbd96fc2415caff8c846ffd6390268597f0b0f2124790362761bcd825bec3a
+  metadata.gz: d0f8913f474b23d0c743eb8a48015bd0f6971f698f51511ff216143648171b17
+  data.tar.gz: 4dbfdaf02139d4ac986ff19b314fa1e88d9e7757a2907b26249767c5ed584d13
 SHA512:
-  metadata.gz: ce8c2f3535b8496a684a32f83a41050bfcf8d79a67b26ee7537f82713b1d272998fcef1e41d78633085c290d78bd91bc8613e3308e119a8e5bfa0bf9e636ada1
-  data.tar.gz: 0c7426733e654c76133d74e448fb62575ff4f48e7a072e712ac4eb4cfde910fcd8eae32447f0c5508ad7979060da10a2b8cf7e0e347d8ab5e549b4b3e69d5858
+  metadata.gz: 342b1fc02d9cf677e68beca8dedf2efb98d97173363c64e516e311cc3c16ec9f7ddce0ed2698b08c61e9cd13f92217d48b1256b48c33dc9066e492d81587a795
+  data.tar.gz: 419f897312a32ce4bfb13f871967fdc4dcc94621c6edc3842aefe8f0cc109e21fe75499fef5c411c7f9880fd611c930f4c61e2ef1918409634bd81dc7c302c13

data/lib/view_component_reflex/reflex.rb

@@ -111,21 +111,7 @@ module ViewComponentReflex
       "[data-controller~=\"#{stimulus_controller}\"][data-key=\"#{element.dataset[:key]}\"]"
     end
 
-    # SR's delegate_call_to_reflex in channel.rb
-    # uses method to gather the method parameters, but since we're abusing
-    # method_missing here, that'll always fail
-    def method(name)
-      component.adapter.extend_reflex(self)
-      component.method(name.to_sym)
-    end
-
-    def respond_to_missing?(name, _ = false)
-      !!name.to_proc
-    end
-
-    def method_missing(name, *args, &blk)
-      super unless respond_to_missing?(name)
-
+    def delegate_call_to_reflex(name, *args, &blk)
       state.each do |k, v|
         component.instance_variable_set(k, v)
       end

data/lib/view_component_reflex/reflex_factory.rb

@@ -31,7 +31,23 @@ module ViewComponentReflex
     end
 
     def reflex_instance
-      @reflex_instance ||= Class.new(@component.reflex_base_class)
+      @reflex_instance ||= build_reflex_instance
+    end
+
+    ##
+    # Beyond just creating the <Component>Reflex class, we need to define all the component methods on the reflex
+    # class.
+    # This replaces the old method_missing implementation, and passes more strict validation of recent SR versions
+    def build_reflex_instance
+      reflex_methods = @component.instance_methods - @component.superclass.instance_methods - [:call, :"_call_#{@component.name.underscore}"]
+
+      Class.new(@component.reflex_base_class).tap do |klass|
+        reflex_methods.each do |m|
+          klass.define_method(m) do |*args, &blk|
+            delegate_call_to_reflex(method_name, *args, &blk)
+          end
+        end
+      end
     end
 
     def reflex_from_nested_component

data/lib/view_component_reflex/version.rb

@@ -1,3 +1,3 @@
 module ViewComponentReflex
-  VERSION = '3.3.2'
+  VERSION = '3.3.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: view_component_reflex
 version: !ruby/object:Gem::Version
-  version: 3.3.2
+  version: 3.3.3
 platform: ruby
 authors:
 - Joshua LeBlanc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-03-02 00:00:00.000000000 Z
+date: 2024-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -116,7 +116,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.3
+rubygems_version: 3.5.6
 signing_key: 
 specification_version: 4
 summary: Allow stimulus reflexes in a view component