view_component 4.22.0 → 4.23.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 347185365d72f04ae47e10751bdaafc79ca1b92a5cc60659464cd91ea3fe5b1d
-  data.tar.gz: 8cc35ca70babcf15504c6cf3329357045b92cf5bce0b7059a376b465b9d82b3a
+  metadata.gz: d782aede72b310a730951e5b9357dcf8b02184f4d459d0ef0c7106671bfa80a1
+  data.tar.gz: 6edb2094b07d7245782cb1d1292dbd7983e70ce5d1872165a4bae99bde537275
 SHA512:
-  metadata.gz: 1f65ef1db7168f46ff4c0e41bcd7d329e30f5da9cfb05b06500c67686eaef0705b9b26433f644b39138c79ecf5d904176451c511f8dc48438cae9d9d6cbe81f8
-  data.tar.gz: 5b8df5a1f324a0fb481da6c822333e08e0bd424535310d851634da151702cb50a6a92d56be23f49f573c66aa5b9f9b8137a288969d85f4d5cec47ea59c114cca
+  metadata.gz: f9fbe9cd4bfdb862d5a6d2bda711380d43abbf744af542b09158f57adf0c5de0b32002fcd7710859743cc3abe80fce416f4280c638a0b436dd5495beff4c0269
+  data.tar.gz: '09cf2dd6d5b054283943b02feecd1037bc41cfcac37553ef1bc4823d32ab4e34ac2bb469105579d6144ec76972944c7ac5ace6bd4c711e5bdff1cc4e1b1227b7'

data/docs/CHANGELOG.md

@@ -10,6 +10,16 @@ nav_order: 6
 
 ## main
 
+## 4.23.0
+
+* Restore request-dependent URL generation when using `render_preview` inside `with_request_url`.
+
+    *Joel Hawksley*
+
+* Speed up cold cache digests by skipping the `# Template Dependency:` scan for sources that declare none, and by not translating class names in synthetic templates, which only declare paths.
+
+    *Erik Axel Nielsen*
+
 ## 4.22.0
 
 * Comment on release pull requests with benchmark results compared to the previous release.

data/lib/view_component/cache_digest/dependency_tracking.rb

@@ -21,6 +21,10 @@ module ViewComponent
           dependencies = super
           source = template.source
 
+          # Synthetic templates already declare every dependency found in their
+          # sources, as paths.
+          next dependencies if name.start_with?("#{CacheDigest::VIRTUAL_PATH_PREFIX}/")
+
           # `# Template Dependency: SomeComponent` names a class, which Rails
           # would resolve as a template path and never find. Swap it for the path
           # the component is digested under, so the declaration resolves instead
@@ -29,8 +33,6 @@ module ViewComponent
             dependencies = dependencies - [declared] + [virtual_path]
           end
 
-          # Synthetic templates already declare every dependency found in their sources.
-          next dependencies if name.start_with?("#{CacheDigest::VIRTUAL_PATH_PREFIX}/")
           next dependencies unless CacheDigest.template_dependencies?(source, template.handler)
 
           component_paths, inferred_partials =

data/lib/view_component/cache_digest/resolver.rb

@@ -184,6 +184,10 @@ module ViewComponent
 
       def explicit_dependencies(sources)
         sources.flat_map { |source|
+          # A cheap check first: most sources declare nothing, and the
+          # pattern is slow to scan for in sources with many comments.
+          next [] unless source.include?("Template Dependency:")
+
           declared = source.scan(CacheDigest::EXPLICIT_DEPENDENCY).flatten
 
           # Component class names are translated to the path they're digested

data/lib/view_component/test_helpers.rb

@@ -89,14 +89,16 @@ module ViewComponent
       controller_class = Rails.application.config.view_component.previews.controller.constantize
       request = ActionDispatch::TestRequest.new(vc_test_request.env.dup)
       query_parameters = vc_test_request.query_parameters.deep_dup.merge(params.stringify_keys)
-      request.path_parameters = vc_test_request.path_parameters.except(*params.keys.map(&:to_sym)).merge(
-        controller: controller_class.controller_path,
-        action: "previews",
-        path: "#{from.preview_name}/#{name}"
-      )
+      request.path_parameters = vc_test_request.path_parameters.deep_dup
       request.set_header("action_dispatch.request.query_parameters", query_parameters)
       request.set_header(Rack::QUERY_STRING, query_parameters.to_query)
       previews_controller = __vc_test_helpers_build_controller(controller_class, request: request)
+      # Dispatch the preview without replacing the request's URL generation context.
+      previews_controller.params = request.parameters.merge(params.stringify_keys).merge(
+        "controller" => controller_class.controller_path,
+        "action" => "previews",
+        "path" => "#{from.preview_name}/#{name}"
+      )
       previews_controller.set_response!(ActionDispatch::Response.new)
       previews_controller.process(:previews)
       @rendered_content = previews_controller.response.body

data/lib/view_component/version.rb

@@ -3,7 +3,7 @@
 module ViewComponent
   module VERSION
     MAJOR = 4
-    MINOR = 22
+    MINOR = 23
     PATCH = 0
     PRE = nil
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: view_component
 version: !ruby/object:Gem::Version
-  version: 4.22.0
+  version: 4.23.0
 platform: ruby
 authors:
 - ViewComponent Team