view_assets 0.0.7 → 0.0.8

data/lib/view_assets/assets_finder.rb

@@ -128,6 +128,7 @@ module ViewAssets
 
     private
 
+    # start point of parsing dependent assets
     def retrieve_assets_from(manifest)
       assets = []
       directive = Directive.new(asset_type)
@@ -135,6 +136,7 @@ module ViewAssets
       Pathname.new(manifest).each_line do |line|
         # break if directive.ending_directive?(l) # TODO add ending_directive support
         next unless directive.legal_directive?(line)
+        
         assets.concat(analyze(*directive.parse(line)))
       end
 
@@ -175,6 +177,7 @@ module ViewAssets
     #
     # NOTE: All assets returned will be "unabsolutely_pathized" here. That
     #       means each string of file path does not contain any root path info.
+    # todo BUG => can't retrieve assets with slash-asterisk(/*= xxx */) directive.
     def meta_retrieve(manifest_path, manifest)
       single_file_lib = absolutely_pathize("#{ manifest_path }/#{ manifest }")
 

data/lib/view_assets/directives.rb

@@ -83,6 +83,8 @@ module ViewAssets
       # 
       # TODO refactor: use reasonable and effective regular expression
       # TODO use "require_app" as app asset directive and make "require" as a relative directive
+      # TODO BUG => rspec examples is unqualified on slash-asterisk syntax for css
+      #             can't detect mistakes like this: `^/\*=\s#{requiring_type}\s(?<path_params>.*)*\s\*/$`
       def generate_formula(requiring_type = 'require')
         if javascript? asset_type
           %r{
@@ -96,7 +98,7 @@ module ViewAssets
           %r{
               ^\s\*=\s#{requiring_type}\s(?<path_params>.*)$  # space-asterisk syntax
             |
-              ^/\*=\s#{requiring_type}\s(?<path_params>.*)*\s\*/$  # slash-asterisk syntax
+              ^/\*=\s#{requiring_type}\s(?<path_params>.*)\s\*/$  # slash-asterisk syntax
           }x
         end
       end

data/lib/view_assets/js_assets.rb

@@ -15,7 +15,7 @@ module ViewAssets
     end
     
     def tag(js_src)
-      "<script src='#{js_src}'></script>"
+      %(<script src="#{js_src}" type="text/javascript"></script>)
     end
   end
 end

data/lib/view_assets/version.rb

@@ -1,3 +1,3 @@
 module ViewAssets
-  VERSION = "0.0.7"
+  VERSION = "0.0.8"
 end

data/lib/view_assets.rb

@@ -1,10 +1,10 @@
 ##
-# TODO documentation
+# Introduction is in readme.md
 module ViewAssets
-  # todo figure out why can't use require in this case
-  # todo find another way to include rake tasks, this method seems weird.
+  # TODO figure out why can't use require in this case
+  # TODO find another way to include rake tasks, this method seems weird.
   load 'tasks/view_assets_tasks.rake' if defined?(Rake)
-  
+
   require 'pathname'
 
   require 'view_assets/error'
@@ -16,16 +16,16 @@ module ViewAssets
   ##
   # To verify all assets and throw exception when find out inexistent asset
   # Defaults to turn off. DO NOT use it in production.
-  # todo find out how to document constant
+  # TODO find out how to document constant.
   TO_VERIFY = false
-  
+
   attr_accessor :js_assets, :css_assets
-  
-  # TODO need a new controller-action configuring interface, try to configure them in helper instead of view files
+
+  # TODO need a new controller-action configuring interface, try to configure them in helper instead of view files.
   def include_assets_with_assets_mvc(controller, action)
     @va_controller = controller
     @va_action = action
-    
+
     raw [css_assets.all, js_assets.all].flatten.uniq.join("\n ")
   end
 

data/readme.md

@@ -1,16 +1,33 @@
 # ViewAssets
+A new method to manage assets in a rails project.   
+Instead of using the default assets managing style in rails 3.2, this gem will introduce a new way to manage your assets.   
+This is only a prototype of the whole project, the fullfledged version will publish soon.
+It works like assetpipeline, but comes with different conventions. It doesn't include all your assets simply even if you have view/page or controller specific assets. It is page-specific.
 
-## Simple Introductin
+## Conventions/Rules
 
-A new method to manage assets in a rails project.   
+According to ViewAssets, there are three folders in `/public` folder:
 
-Instead of using the default assets managing style in rails 3.2, this gem will introduce a new way to manage your assets. This is still a prototype, the fullfledged version will publish soon.
+    * vendor
+    * lib
+    * app
 
-## Conventions/Rules
+Each sence of them are the same as in rails3 assetpipeline.
+
+## DIRECTIVES
+
+  for javascript
+    double-slash syntax => "//= require_vendor xxx"
+    space-asterisk syntax => " *= require_vendor xxx"
+    slash-asterisk syntax => "/*= require_vendor xxx */"
+
+  for stylesheets
+    space-asterisk syntax => " *= require_vendor xxx"
+    slash-asterisk syntax => "/*= require_vendor xxx */"
 
 ## Usage
 
-Include this gem in your `helpers/application_helper.rb`
+First, include `ViewAssets` in `helpers/application_helper.rb`
 
 ```ruby
 module ApplicationHelper
@@ -26,4 +43,4 @@ Add some other codes in your `views/layouts/application.html.rb`
 
 If some of your controllers use their own layout file, and following rules in ViewAssets, then you should add that code above too.
 
-This project rocks and uses MIT-LICENSE.
+This project rocks and uses MIT-LICENSE.

data/test/dummy/log/development.log

@@ -1544,3 +1544,93 @@ Started GET "/foo/index" for 127.0.0.1 at 2013-01-03 15:33:55 +0800
 Processing by FooController#index as HTML
   Rendered foo/index.html.erb within layouts/application (0.0ms)
 Completed 200 OK in 4ms (Views: 4.1ms | ActiveRecord: 0.0ms)
+
+
+Started GET "/foo/index" for 127.0.0.1 at 2013-01-03 16:21:52 +0800
+Connecting to database specified by database.yml
+Processing by FooController#index as HTML
+  Rendered foo/index.html.erb within layouts/application (2.9ms)
+Completed 200 OK in 25ms (Views: 24.3ms | ActiveRecord: 0.0ms)
+
+
+Started GET "/foo/index" for 127.0.0.1 at 2013-01-03 16:24:48 +0800
+Processing by FooController#index as HTML
+  Rendered foo/index.html.erb within layouts/application (0.0ms)
+Completed 200 OK in 4ms (Views: 4.1ms | ActiveRecord: 0.0ms)
+
+
+Started GET "/foo/index" for 127.0.0.1 at 2013-01-03 16:25:51 +0800
+Connecting to database specified by database.yml
+Processing by FooController#index as HTML
+  Rendered foo/index.html.erb within layouts/application (2.6ms)
+Completed 200 OK in 56ms (Views: 55.1ms | ActiveRecord: 0.0ms)
+
+
+Started GET "/foo/index" for 127.0.0.1 at 2013-01-03 16:26:22 +0800
+Processing by FooController#index as HTML
+  Rendered foo/index.html.erb within layouts/application (0.0ms)
+Completed 200 OK in 4ms (Views: 4.2ms | ActiveRecord: 0.0ms)
+
+
+Started GET "/foo/index" for 127.0.0.1 at 2013-01-04 10:56:39 +0800
+Connecting to database specified by database.yml
+Processing by FooController#index as HTML
+  Rendered foo/index.html.erb within layouts/application (66.8ms)
+Completed 200 OK in 396ms (Views: 396.0ms | ActiveRecord: 0.0ms)
+
+
+Started GET "/foo/index" for 127.0.0.1 at 2013-01-04 10:58:26 +0800
+Processing by FooController#index as HTML
+  Rendered foo/index.html.erb within layouts/application (0.0ms)
+Completed 200 OK in 4ms (Views: 3.9ms | ActiveRecord: 0.0ms)
+
+
+Started GET "/foo/index" for 127.0.0.1 at 2013-01-04 10:58:33 +0800
+Connecting to database specified by database.yml
+Processing by FooController#index as HTML
+  Rendered foo/index.html.erb within layouts/application (40.4ms)
+Completed 200 OK in 56ms (Views: 55.2ms | ActiveRecord: 0.0ms)
+
+
+Started GET "/foo/index" for 127.0.0.1 at 2013-01-04 11:02:01 +0800
+Processing by FooController#index as HTML
+  Rendered foo/index.html.erb within layouts/application (0.0ms)
+Completed 200 OK in 5ms (Views: 4.9ms | ActiveRecord: 0.0ms)
+
+
+Started GET "/foo/index" for 127.0.0.1 at 2013-01-04 11:03:03 +0800
+Processing by FooController#index as HTML
+  Rendered foo/index.html.erb within layouts/application (0.0ms)
+Completed 200 OK in 4ms (Views: 3.7ms | ActiveRecord: 0.0ms)
+
+
+Started GET "/bar/index" for 127.0.0.1 at 2013-01-04 11:03:12 +0800
+Processing by BarController#index as HTML
+  Rendered bar/index.html.erb within layouts/application (0.4ms)
+Completed 200 OK in 6ms (Views: 5.4ms | ActiveRecord: 0.0ms)
+
+
+Started GET "/bar/index" for 127.0.0.1 at 2013-01-04 11:03:42 +0800
+Connecting to database specified by database.yml
+Processing by BarController#index as HTML
+  Rendered bar/index.html.erb within layouts/application (2.6ms)
+Completed 200 OK in 18ms (Views: 17.0ms | ActiveRecord: 0.0ms)
+
+
+Started GET "/foo/index" for 127.0.0.1 at 2013-01-04 15:35:14 +0800
+Processing by FooController#index as HTML
+  Rendered foo/index.html.erb within layouts/application (23.7ms)
+Completed 200 OK in 216ms (Views: 202.3ms | ActiveRecord: 0.0ms)
+
+
+Started GET "/foo/index" for 127.0.0.1 at 2013-01-04 15:40:36 +0800
+Connecting to database specified by database.yml
+Processing by FooController#index as HTML
+  Rendered foo/index.html.erb within layouts/application (2.9ms)
+Completed 200 OK in 47ms (Views: 46.0ms | ActiveRecord: 0.0ms)
+
+
+Started GET "/foo/index" for 127.0.0.1 at 2013-01-04 15:40:41 +0800
+Processing by FooController#index as HTML
+  Rendered foo/index.html.erb within layouts/application (0.1ms)
+Completed 200 OK in 4ms (Views: 3.9ms | ActiveRecord: 0.0ms)

data/test/dummy/public/app/javascripts/application.js

@@ -1,2 +1,2 @@
 //= require_vendor vendor1
-//= require_lib lib1
+/*= require_lib lib1 */

data/test/dummy/public/app/stylesheets/application.css

@@ -1,3 +1 @@
-/**
- *= require_vendor vendor1
- */
+/*= require_vendor vendor1 */

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: view_assets
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-03 00:00:00.000000000 Z
+date: 2013-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails