versions 0.2.0 → 0.2.1

data/History.txt

@@ -1,9 +1,14 @@
+== 0.2.1 2010-02-16
+
+* 1 major enhancement
+  * Attachment was not creating the 'file' method
+
 == 0.2.0 2010-02-15
 
 * 1 major enhancement
-  * Changed inverse option from 'as' to 'inverse' in Multi
-  * Implemented the Attachment module
-  * Added AfterCommit module
+  * changed inverse option from 'as' to 'inverse' in Multi
+  * implemented the Attachment module
+  * added AfterCommit module
 
 == 0.1.0 2010-02-14
 

data/README.rdoc

@@ -77,3 +77,14 @@ and deleted when no more versions are using them. Example:
     store_attachments_in :version, :attachment_class => 'Attachment'
   end
 
+== Testing Gotcha
+
+If you are testing your application with AfterCommit, you should note that the 'after_commit' code will
+*NEVER BE EXECUTED* if you have enabled transactional fixtures. You can fix this by disabling transactional
+fixtures in the tests where you need the after_commit code to execute (save file).
+
+  class DocumentTest < Test::Unit::TestCase
+    self.use_transactional_fixtures = false
+
+    # ...
+  end

data/lib/versions/attachment.rb

@@ -67,9 +67,14 @@ module Versions
           self.attachment = nil
         end
         @attachment_need_save = true
+        @file = file
         self.build_attachment(:file => file)
       end
 
+      def file
+        @file ||= attachment ? attachment.file : nil
+      end
+
       def filepath
         attachment ? attachment.filepath : nil
       end

data/lib/versions/shared_attachment.rb

@@ -18,6 +18,10 @@ module Versions
       self[:filename] = get_filename(file)
     end
 
+    def file
+      File.new(filepath)
+    end
+
     def filepath
       @filepath ||= begin digest = ::Digest::SHA1.hexdigest(self[:id].to_s)
         "#{digest[0..0]}/#{digest[1..1]}/#{filename}"
@@ -42,7 +46,11 @@ module Versions
         if data.respond_to?(:rewind)
           data.rewind
         end
-        File.open(path, "wb") { |f| f.syswrite(data.read) }
+        File.open(path, "wb") do |file|
+          while buffer = data.read(2_024_000)
+            file.syswrite(buffer)
+          end
+        end
       end
 
       def remove_file

data/lib/versions/version.rb

@@ -1,3 +1,3 @@
 module Versions
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 end

data/test/fixtures.rb

@@ -37,7 +37,6 @@ begin
       end
 
       create_table 'attachments' do |t|
-        t.string 'owner_table'
         t.string 'filename'
         t.timestamps
       end

data/test/unit/attachment_test.rb

@@ -53,6 +53,11 @@ class AttachmentTest < Test::Unit::TestCase
       assert_equal @owner.filepath, attachment.filepath
     end
 
+    should 'restore the file with the database' do
+      attachment = Attachment.find(@owner.attachment_id)
+      assert_equal uploaded_jpg('bird.jpg').read, attachment.file.read
+    end
+
     should 'rename file on bad original_filename' do
       file = uploaded_jpg('bird.jpg')
       class << file
@@ -118,6 +123,15 @@ class AttachmentTest < Test::Unit::TestCase
       assert_equal uploaded_jpg('lake.jpg').read, File.read(@owner.filepath)
       assert !File.exist?(old_filepath)
     end
+
+    should 'get file when sent :file' do
+      assert_equal uploaded_jpg('bird.jpg').read, @owner.file.read
+    end
+
+    should 'get file before save when sent :file' do
+      @owner = Version.new(:file => uploaded_jpg('bird.jpg'))
+      assert_equal uploaded_jpg('bird.jpg').read, @owner.file.read
+    end
   end
 
   context 'Updating document' do

data/test/unit/auto_test.rb

@@ -41,7 +41,7 @@ class AutoTest < Test::Unit::TestCase
           end
         end
       end
-      
+
       context 'if not changed' do
         should 'not clone on update' do
           assert_difference('Version.count', 0) do

data/versions.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{versions}
-  s.version = "0.2.0"
+  s.version = "0.2.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Gaspard Bucher"]
-  s.date = %q{2010-02-15}
+  s.date = %q{2010-02-22}
   s.description = %q{A list of libraries to work with ActiveRecord model versioning: Auto (duplicate on save), Multi (hide many versions behind a single one), Transparent (hide versions from outside world), Property (define properties on model, store them in versions)}
   s.email = %q{gaspard@teti.ch}
   s.extra_rdoc_files = [

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: versions
 version: !ruby/object:Gem::Version 
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors: 
 - Gaspard Bucher
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-02-15 00:00:00 +01:00
+date: 2010-02-22 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency