versioncake 3.3.0 → 3.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 528ead5896829c40e35bf158b7313781c6e0f617
-  data.tar.gz: 5f6ad615f20ebb354e48645000dc3d06a2dccf51
+  metadata.gz: 3b123482ee49261b07fe0401505628dbeec8ac0d
+  data.tar.gz: 7328d725356e07f50637f42e142d8bfae143804f
 SHA512:
-  metadata.gz: 406f567291185122b3cb72391ce4cf72136256561353ee612fc4eb0207afec7854918bce313d18841f4be7ebe1b9b697115b7ed8967515801f340855987a65b6
-  data.tar.gz: da661fbcf7d007dd1d8dd43ac66338c13cd4d42b2aae6e7c84e952e85a37b716bc50750151ca4ad9ccff9f617aa13e2bb420a5a1cde07e143f04611654453acc
+  metadata.gz: d52bdf13972f46c24260222d3030ada9d6e9debbb9caa04b4881711ae17b232d2a8c4b999339b9572d9e790e49a197c1955e73757eac8f6e7d0909d9d1979146
+  data.tar.gz: 3b67d99ef5758d3d116abb6f3dc67bdefd3d9aeed365378ebc65529b430e74913f093be3d6045764a2eceb7f71195e9cdf7bf2dd5b27649bb86cd6576f4c4f42

data/CHANGELOG.md

@@ -1,6 +1,6 @@
 ## Unreleased Changes
 
-[Full Changelog](https://github.com/bwillis/versioncake/compare/v3.3...master)
+[Full Changelog](https://github.com/bwillis/versioncake/compare/v3.4...master)
 
 Bug Fixes:
 
@@ -14,6 +14,20 @@ Deprecations:
 
 * None
 
+## 3.4.0 (March 4, 2018)
+
+Bug Fixes:
+
+* don't replace frozen strings to support Rails v5.2 (#72) thanks [Bartosz Bonisławski](https://github.com/bbonislawski)
+
+Enhancements:
+
+* None
+
+Deprecations:
+
+* None
+
 ## 3.3.0 (May 7, 2017)
 
 Bug Fixes:

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    versioncake (3.3.0)
+    versioncake (3.4.0)
       actionpack (>= 3.2)
       activesupport (>= 3.2)
       railties (>= 3.2)
@@ -10,20 +10,20 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (5.1.0)
-      actionview (= 5.1.0)
-      activesupport (= 5.1.0)
+    actionpack (5.1.4)
+      actionview (= 5.1.4)
+      activesupport (= 5.1.4)
       rack (~> 2.0)
-      rack-test (~> 0.6.3)
+      rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (5.1.0)
-      activesupport (= 5.1.0)
+    actionview (5.1.4)
+      activesupport (= 5.1.4)
       builder (~> 3.1)
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.0.3)
-    activesupport (5.1.0)
+    activesupport (5.1.4)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (~> 0.7)
       minitest (~> 5.1)
@@ -40,33 +40,35 @@ GEM
       term-ansicolor (~> 1.3)
       thor (~> 0.19.4)
       tins (~> 1.6)
+    crass (1.0.2)
     diff-lcs (1.3)
     docile (1.1.5)
-    erubi (1.6.0)
-    i18n (0.8.1)
+    erubi (1.7.0)
+    i18n (0.8.6)
     json (2.1.0)
-    loofah (2.0.3)
+    loofah (2.1.1)
+      crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
-    method_source (0.8.2)
-    mini_portile2 (2.1.0)
-    minitest (5.10.1)
-    nokogiri (1.7.1)
-      mini_portile2 (~> 2.1.0)
-    rack (2.0.1)
-    rack-test (0.6.3)
-      rack (>= 1.0)
-    rails-dom-testing (2.0.2)
-      activesupport (>= 4.2.0, < 6.0)
-      nokogiri (~> 1.6)
+    method_source (0.9.0)
+    mini_portile2 (2.3.0)
+    minitest (5.10.3)
+    nokogiri (1.8.1)
+      mini_portile2 (~> 2.3.0)
+    rack (2.0.3)
+    rack-test (0.7.0)
+      rack (>= 1.0, < 3)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
     rails-html-sanitizer (1.0.3)
       loofah (~> 2.0)
-    railties (5.1.0)
-      actionpack (= 5.1.0)
-      activesupport (= 5.1.0)
+    railties (5.1.4)
+      actionpack (= 5.1.4)
+      activesupport (= 5.1.4)
       method_source
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
-    rake (12.0.0)
+    rake (12.1.0)
     rspec (3.6.0)
       rspec-core (~> 3.6.0)
       rspec-expectations (~> 3.6.0)
@@ -79,7 +81,7 @@ GEM
     rspec-mocks (3.6.0)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.6.0)
-    rspec-rails (3.6.0)
+    rspec-rails (3.6.1)
       actionpack (>= 3.0)
       activesupport (>= 3.0)
       railties (>= 3.0)
@@ -92,12 +94,12 @@ GEM
       docile (~> 1.1.0)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.0)
+    simplecov-html (0.10.2)
     term-ansicolor (1.6.0)
       tins (~> 1.0)
     thor (0.19.4)
     thread_safe (0.3.6)
-    tins (1.13.2)
+    tins (1.15.0)
     tzinfo (1.2.3)
       thread_safe (~> 0.1)
 

data/README.md

@@ -34,15 +34,16 @@ rails g versioncake:install
 
 ### Requirements
 
-| Version | Rails 3.2 Support? | Rails 4 Support? | Rails >4.1 Support? | Rails >5 Support? | [Rails API](https://github.com/rails-api/rails-api) 0.2 Support? |
-| -------:|:---------:| -------:| -------:| -------:| -------:|
-| [1.0](CHANGELOG.md#100-march-14-2013) | Yes       | No      | No      | No   | No   |
-| [1.1](CHANGELOG.md#110-may-18-2013)   | Yes       | No      | No      | No   | No   |
-| [1.2](CHANGELOG.md#120-may-26-2013)   | Yes       | Yes     | No      | No   | No   |
-| [1.3](CHANGELOG.md#130-sept-26-2013)  | Yes       | Yes     | No      | No   | No   |
-| [>2.0](CHANGELOG.md#200-feb-6-2014)   | Yes       | Yes     | Yes     | No   | No   |
-| [>2.4](CHANGELOG.md#200-feb-6-2014)   | Yes       | Yes     | Yes     | No   | Yes  |
-| [>3.0](CHANGELOG.md)                  | Yes       | Yes     | Yes     | Yes  | Yes  |
+| Version | Rails 3.2 Support? | Rails 4 Support? | Rails >4.1 Support? | Rails >5 Support? | Rails >5.2 Support? | [Rails API](https://github.com/rails-api/rails-api) 0.2 Support? |
+| -------:|:---------:| -------:| -------:| -------:| -------:| -------:|
+| [1.0](CHANGELOG.md#100-march-14-2013) | Yes       | No      | No      | No   | No  | No   |
+| [1.1](CHANGELOG.md#110-may-18-2013)   | Yes       | No      | No      | No   | No  | No   |
+| [1.2](CHANGELOG.md#120-may-26-2013)   | Yes       | Yes     | No      | No   | No  | No   |
+| [1.3](CHANGELOG.md#130-sept-26-2013)  | Yes       | Yes     | No      | No   | No  | No   |
+| [>2.0](CHANGELOG.md#200-feb-6-2014)   | Yes       | Yes     | Yes     | No   | No  | No   |
+| [>2.4](CHANGELOG.md#200-feb-6-2014)   | Yes       | Yes     | Yes     | No   | No  | Yes  |
+| [>3.0](CHANGELOG.md)                  | Yes       | Yes     | Yes     | Yes  | No  | Yes  |
+| [>3.3](CHANGELOG.md)                  | Yes       | Yes     | Yes     | Yes  | Yes | Yes  |
 
 ## Upgrade v2.0 -> v3.0
 
@@ -252,7 +253,7 @@ Strategy | Description | Example
 :path_parameter | version in the url path parameter | `api/v:api_version/`
 :request_parameter | version that is sent in the body of the request | Good for testing.
 :http_header | Api version HTTP header | `API-Version: 1`
-:http_accept_parameter | HTTP Accept header | `Accept: application/xml; version=1` [why do this?](http://blog.steveklabnik.com/posts/2011-07-03-nobody-understands-rest-or-http#i_want_my_api_to_be_versioned)
+:http_accept_parameter | HTTP Accept header | `Accept: application/xml; api_version=1` [why do this?](http://blog.steveklabnik.com/posts/2011-07-03-nobody-understands-rest-or-http#i_want_my_api_to_be_versioned)
 custom | takes the request object and must return an integer | lambda {|request| request.headers["HTTP_X_MY_VERSION"].to_i } or class ExtractorStrategy; def execute(request);end;end
 
 If you use the path_parameter strategy with resources routes, you will want to setup your routes.rb config file to capture the api version.  You can do that in a few ways.  If you have just a few api routes you might specify the path directly like this:
@@ -433,6 +434,8 @@ Thanks to all those who have helped make Version Cake really sweet:
 * [Jeroen K.](https://github.com/jrnkntl)
 * [Masaya Myojin](https://github.com/mmyoji)
 * [John Hawthorn](https://github.com/jhawthorn)
+* [Ersin Akinci](https://github.com/earksiinni)
+* [Bartosz Bonisławski](https://github.com/bbonislawski)
 
 # Related Material
 

data/gemfiles/rails3.2.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    versioncake (3.3.0)
+    versioncake (3.4.0)
       actionpack (>= 3.2)
       activesupport (>= 3.2)
       railties (>= 3.2)

data/gemfiles/rails4.0.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    versioncake (3.3.0)
+    versioncake (3.4.0)
       actionpack (>= 3.2)
       activesupport (>= 3.2)
       railties (>= 3.2)

data/gemfiles/rails4.1.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    versioncake (3.3.0)
+    versioncake (3.4.0)
       actionpack (>= 3.2)
       activesupport (>= 3.2)
       railties (>= 3.2)

data/gemfiles/rails4.2.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    versioncake (3.3.0)
+    versioncake (3.4.0)
       actionpack (>= 3.2)
       activesupport (>= 3.2)
       railties (>= 3.2)

data/gemfiles/rails5.0.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    versioncake (3.3.0)
+    versioncake (3.4.0)
       actionpack (>= 3.2)
       activesupport (>= 3.2)
       railties (>= 3.2)

data/lib/versioncake/configuration.rb

@@ -3,8 +3,6 @@ require 'active_support/core_ext/array/wrap.rb'
 
 module VersionCake
   class Configuration
-
-    SUPPORTED_VERSIONS_DEFAULT = (1..10)
     VERSION_KEY_DEFAULT = 'api_version'
 
     attr_reader :extraction_strategies, :response_strategies, :supported_version_numbers,
@@ -17,7 +15,6 @@ module VersionCake
       @rails_view_versioning         = true
       @missing_version_use_unversioned_template = true
       @default_version = nil
-      self.supported_version_numbers = SUPPORTED_VERSIONS_DEFAULT
       self.extraction_strategy       = [
           :http_accept_parameter,
           :http_header,
@@ -53,27 +50,6 @@ module VersionCake
       end
     end
 
-    def supported_version_numbers=(val)
-      @supported_version_numbers = val.respond_to?(:to_a) ? val.to_a : Array.wrap(val)
-      @supported_version_numbers.sort!.reverse!
-    end
-
-    def supported_versions(requested_version_number=nil)
-      @supported_version_numbers.collect do |supported_version_number|
-        if requested_version_number.nil? || supported_version_number <= requested_version_number
-          :"v#{supported_version_number}"
-        end
-      end
-    end
-
-    def supports_version?(version)
-      @supported_version_numbers.include? version
-    end
-
-    def latest_version
-      @supported_version_numbers.first
-    end
-
     def resources
       builder = ResourceBuilder.new
       yield builder

data/lib/versioncake/version.rb

@@ -1,3 +1,3 @@
 module VersionCake
-  VERSION = '3.3.0'
+  VERSION = '3.4.0'
 end

data/lib/versioncake/view_additions.rb

@@ -16,7 +16,10 @@ ActionView::PathResolver.class_eval do
                                                      handlers: "."
                                                  })
 
-    ActionView::PathResolver::DEFAULT_PATTERN.replace ":prefix/:action{.:locale,}{.:formats,}{+:variants,}{.:versions,}{.:handlers,}"
+    def initialize(pattern = nil)
+      @pattern = pattern || ":prefix/:action{.:locale,}{.:formats,}{+:variants,}{.:versions,}{.:handlers,}"
+      super()
+    end
   else
     ActionView::PathResolver::EXTENSIONS.replace [:locale, :formats, :versions, :handlers]
 

data/spec/unit/configuration_spec.rb

@@ -1,64 +1,7 @@
 require 'spec_helper'
 
 describe VersionCake::Configuration do
-  let(:supported_versions) { }
-  subject(:config) do
-    config = described_class.new
-    if supported_versions
-      config.supported_version_numbers = supported_versions
-    end
-    config
-  end
-
-  context '#supported_version_numbers' do
-    context 'by default' do
-      let(:supported_versions) { nil }
-
-      it 'is a logical set of version numbers' do
-        expect(config.supported_version_numbers).to eq (1..10).to_a.reverse
-      end
-    end
-
-    context 'when set with a range' do
-      let(:supported_versions) { (1..7) }
-
-      it { expect(config.supported_version_numbers).to eq [7,6,5,4,3,2,1] }
-    end
-
-    context 'when set with an unordered array' do
-      let(:supported_versions) { [2,4,1,5,3,6,7] }
-
-      it { expect(config.supported_version_numbers).to eq [7,6,5,4,3,2,1] }
-    end
-
-    context 'when set with a single value' do
-      let(:supported_versions) { 19 }
-
-      it { expect(config.supported_version_numbers).to eq [19] }
-    end
-  end
-
-  context '#supports_version?' do
-    let(:supported_versions) { (1..7) }
-
-    it 'is true for all supported versions' do
-      config.supported_version_numbers.each do |supported_version|
-        expect(config.supports_version?(supported_version)).to be_truthy
-      end
-    end
-
-    it 'is false for other versions' do
-      [-2,-1,0,8,9,10].each do |unsupported_version|
-        expect(config.supports_version?(unsupported_version)).to be_falsey
-      end
-    end
-  end
-
-  context '#latest_version' do
-    let(:supported_versions) { [4,1,3,9,2,54] }
-
-    it { expect(config.latest_version).to eq 54 }
-  end
+  subject(:config) { described_class.new }
 
   context '#missing_version' do
     before { config.missing_version = 5 }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: versioncake
 version: !ruby/object:Gem::Version
-  version: 3.3.0
+  version: 3.4.0
 platform: ruby
 authors:
 - Jim Jones
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-08 00:00:00.000000000 Z
+date: 2018-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -272,7 +272,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Easily render versions of your rails views.