versioncake 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ab0ef110750d5d6c29da0ac41b7f16c1419ebb80
-  data.tar.gz: 73d8a03d11d238326a7da5846cf43e3a3986a477
+  metadata.gz: d61aa19d50e26e583ce2eea0fca2d2e12cc0337c
+  data.tar.gz: 024e457348b85cb229be55db1319944da4ce2a9f
 SHA512:
-  metadata.gz: 247f480c40da96d017f03226043292ec8846fa46a4e900934eb434d7df2c162139bae51a79e9cb2646cff4af9b4ee0693463549a46709855d46b763d592445bf
-  data.tar.gz: 869e0fc8d10302248570520a888e3fc7d5d082a4ddfbf4cf57cf0a5f9d7a02d508874097328a2cde360afa449a5ca3a3249db47a00d7f8194ae0170e57ed5f74
+  metadata.gz: edc4648ae169a2c6c61ff8def796b3bf5c5abaf568beb1d80d187f96d2a3ba870ed56ad2ec9c5405cb5865c46bdd97651916b08c57a5f4ede932019d0817ad57
+  data.tar.gz: a8610d6612b85369d1338e27614369d55494d63277ea218b3500457458bc6dcd023c8ffdc27f386356a7446ba6e0d8d5f31f637dc93a71cbbbae3d2fa659b2cb

data/.travis.yml

@@ -6,9 +6,12 @@ rvm:
 
 gemfile:
   - gemfiles/rails3.2.gemfile
-  - gemfiles/rails4.0.rc1.gemfile
+  - gemfiles/rails4.0.gemfile
 
 matrix:
   exclude:
     - rvm: 1.9.2
-      gemfile: gemfiles/rails4.0.rc1.gemfile
+      gemfile: gemfiles/rails4.0.gemfile
+
+  allow_failures:
+    - rvm: ruby-head

data/Appraisals

@@ -4,8 +4,8 @@ appraise "rails3.2" do
   gem('railties',       '~> 3.2.0')
 end
 
-appraise "rails4.0.rc1" do
-  gem('actionpack',     '4.0.0.rc1')
-  gem('activesupport',  '4.0.0.rc1')
-  gem('railties',       '4.0.0.rc1')
+appraise "rails4.0" do
+  gem('actionpack',     '~> 4.0.0')
+  gem('activesupport',  '~> 4.0.0')
+  gem('railties',       '~> 4.0.0')
 end

data/CHANGELOG.md

@@ -1,6 +1,14 @@
 ## Unreleased Changes
 
-[Full Changelog](https://github.com/bwillis/versioncake/compare/v1.2...master)
+[Full Changelog](https://github.com/bwillis/versioncake/compare/v1.3...master)
+
+## 1.3.0 (Sept 26, 2013)
+
+[Full Changelog](https://github.com/bwillis/versioncake/compare/v1.2...v1.3)
+
+Bug Fixes:
+
+* Default supported versions were not being set correctly (issue #13), thanks [Jérémie Meyer de Ville](https://github.com/jeremiemv)
 
 ## 1.2.0 (May 26, 2013)
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    versioncake (1.2.0)
+    versioncake (1.3.0)
       actionpack (>= 3.2)
       activesupport (>= 3.2)
       railties (>= 3.2)
@@ -10,26 +10,23 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (3.2.13)
-      activemodel (= 3.2.13)
-      activesupport (= 3.2.13)
-      builder (~> 3.0.0)
+    actionpack (4.0.0)
+      activesupport (= 4.0.0)
+      builder (~> 3.1.0)
       erubis (~> 2.7.0)
-      journey (~> 1.0.4)
-      rack (~> 1.4.5)
-      rack-cache (~> 1.2)
-      rack-test (~> 0.6.1)
-      sprockets (~> 2.2.1)
-    activemodel (3.2.13)
-      activesupport (= 3.2.13)
-      builder (~> 3.0.0)
-    activesupport (3.2.13)
-      i18n (= 0.6.1)
-      multi_json (~> 1.0)
+      rack (~> 1.5.2)
+      rack-test (~> 0.6.2)
+    activesupport (4.0.0)
+      i18n (~> 0.6, >= 0.6.4)
+      minitest (~> 4.2)
+      multi_json (~> 1.3)
+      thread_safe (~> 0.1)
+      tzinfo (~> 0.3.37)
     appraisal (0.5.2)
       bundler
       rake
-    builder (3.0.4)
+    atomic (1.1.10)
+    builder (3.1.4)
     colorize (0.5.8)
     coveralls (0.6.7)
       colorize
@@ -38,46 +35,32 @@ GEM
       simplecov (>= 0.7)
       thor
     erubis (2.7.0)
-    hike (1.2.2)
-    i18n (0.6.1)
-    journey (1.0.4)
-    json (1.8.0)
+    i18n (0.6.4)
     metaclass (0.0.1)
     mime-types (1.23)
+    minitest (4.7.5)
     mocha (0.14.0)
       metaclass (~> 0.0.1)
     multi_json (1.7.3)
-    rack (1.4.5)
-    rack-cache (1.2)
-      rack (>= 0.4)
-    rack-ssl (1.3.3)
-      rack
+    rack (1.5.2)
     rack-test (0.6.2)
       rack (>= 1.0)
-    railties (3.2.13)
-      actionpack (= 3.2.13)
-      activesupport (= 3.2.13)
-      rack-ssl (~> 1.3.2)
+    railties (4.0.0)
+      actionpack (= 4.0.0)
+      activesupport (= 4.0.0)
       rake (>= 0.8.7)
-      rdoc (~> 3.4)
-      thor (>= 0.14.6, < 2.0)
+      thor (>= 0.18.1, < 2.0)
     rake (10.0.4)
-    rdoc (3.12.2)
-      json (~> 1.4)
     rest-client (1.6.7)
       mime-types (>= 1.16)
     simplecov (0.7.1)
       multi_json (~> 1.0)
       simplecov-html (~> 0.7.1)
     simplecov-html (0.7.1)
-    sprockets (2.2.2)
-      hike (~> 1.2)
-      multi_json (~> 1.0)
-      rack (~> 1.0)
-      tilt (~> 1.1, != 1.3.0)
     test-unit (2.5.5)
     thor (0.18.1)
-    tilt (1.4.1)
+    thread_safe (0.1.0)
+      atomic
     tzinfo (0.3.37)
 
 PLATFORMS

data/README.md

@@ -295,6 +295,7 @@ Thanks to all those who have helped make Version Cake really sweet:
 * [Rohit](https://github.com/rg)
 * Sevag
 * [Billy](https://github.com/bcatherall)
+* [Jérémie Meyer de Ville](https://github.com/jeremiemv)
 
 # Related Material
 
@@ -311,6 +312,7 @@ Thanks to all those who have helped make Version Cake really sweet:
 
 ## Discussions
 
+- [Peter Williams on versioning rest web services](http://barelyenough.org/blog/2008/05/versioning-rest-web-services/)
 - [Steve Klabnik on how to version in a resful way](http://blog.steveklabnik.com/posts/2011-07-03-nobody-understands-rest-or-http#i_want_my_api_to_be_versioned)
 - [Rails API project disucssion on versioning](https://github.com/rails-api/rails-api/issues/8)
 - [Railscast on versioning](http://railscasts.com/episodes/350-rest-api-versioning)

data/RELEASE.md

@@ -0,0 +1,27 @@
+# Release
+
+Keeping releases consistent is important so here are the steps to follow when pushing a new version.
+
+1. Bump [lib/versioncake/version.rb](https://github.com/bwillis/versioncake/blob/master/lib/versioncake/version.rb) to the next major.minor version
+2. Make sure all tests are passing ```bundle && rake && rake appraisal test```
+3. Smoke test in 350-rest-api-versioning/store-after-versioncake
+
+ Verify:
+  - latest version works
+  - getting old version works
+  - config flags
+  - rails versions
+
+4. Make sure [CHANGELOG](https://github.com/bwillis/versioncake/blob/master/CHANGELOG.md) is up to date
+5. Commit changes ```git commit -am "bumping to vX.X"```
+
+ Changes committed:
+  - Gemfile.lock && gemfiles/*.lock
+  - version.rb
+
+6. Push to github ```git push origin/master```
+7. Tag the version ```git tag -a vX.X -m 'Version X.X Stable' && git push --tags```
+
+8. Build the gem ```gem build versioncake.gemspec```
+9. Push the gem to ruby gems ```gem push versioncake-vX.X.X.gem```
+10. Remove the built gem locally ```rm versioncake-X.X.X.gem```

data/gemfiles/rails3.2.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    versioncake (1.2.0)
+    versioncake (1.3.0)
       actionpack (>= 3.2)
       activesupport (>= 3.2)
       railties (>= 3.2)

data/gemfiles/rails4.0.gemfile

@@ -0,0 +1,9 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "actionpack", "~> 4.0.0"
+gem "activesupport", "~> 4.0.0"
+gem "railties", "~> 4.0.0"
+
+gemspec :path=>"../"

data/gemfiles/{rails4.0.rc1.gemfile.lock → rails4.0.gemfile.lock}

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    versioncake (1.2.0)
+    versioncake (1.3.0)
       actionpack (>= 3.2)
       activesupport (>= 3.2)
       railties (>= 3.2)
@@ -10,13 +10,13 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (4.0.0.rc1)
-      activesupport (= 4.0.0.rc1)
+    actionpack (4.0.0)
+      activesupport (= 4.0.0)
       builder (~> 3.1.0)
       erubis (~> 2.7.0)
       rack (~> 1.5.2)
       rack-test (~> 0.6.2)
-    activesupport (4.0.0.rc1)
+    activesupport (4.0.0)
       i18n (~> 0.6, >= 0.6.4)
       minitest (~> 4.2)
       multi_json (~> 1.3)
@@ -25,7 +25,7 @@ GEM
     appraisal (0.5.2)
       bundler
       rake
-    atomic (1.1.9)
+    atomic (1.1.10)
     builder (3.1.4)
     colorize (0.5.8)
     coveralls (0.6.7)
@@ -38,19 +38,19 @@ GEM
     i18n (0.6.4)
     metaclass (0.0.1)
     mime-types (1.23)
-    minitest (4.7.4)
+    minitest (4.7.5)
     mocha (0.14.0)
       metaclass (~> 0.0.1)
-    multi_json (1.7.3)
+    multi_json (1.7.7)
     rack (1.5.2)
     rack-test (0.6.2)
       rack (>= 1.0)
-    railties (4.0.0.rc1)
-      actionpack (= 4.0.0.rc1)
-      activesupport (= 4.0.0.rc1)
+    railties (4.0.0)
+      actionpack (= 4.0.0)
+      activesupport (= 4.0.0)
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
-    rake (10.0.4)
+    rake (10.1.0)
     rest-client (1.6.7)
       mime-types (>= 1.16)
     simplecov (0.7.1)
@@ -67,12 +67,12 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  actionpack (= 4.0.0.rc1)
-  activesupport (= 4.0.0.rc1)
+  actionpack (~> 4.0.0)
+  activesupport (~> 4.0.0)
   appraisal
   coveralls
   mocha
-  railties (= 4.0.0.rc1)
+  railties (~> 4.0.0)
   rake
   test-unit
   versioncake!

data/lib/versioncake/configuration.rb

@@ -1,15 +1,15 @@
 require 'active_support/core_ext/module/attribute_accessors.rb'
+require 'active_support/core_ext/array/wrap.rb'
 
 module VersionCake
   module Configuration
 
     SUPPORTED_VERSIONS_DEFAULT = (1..10)
 
-    mattr_accessor :supported_version_numbers
-    self.supported_version_numbers = SUPPORTED_VERSIONS_DEFAULT
+    mattr_reader :supported_version_numbers
 
     mattr_accessor :extraction_strategies
-    self.extraction_strategies = [VersionCake::QueryParameterStrategy.new]
+    self.extraction_strategies = []
 
     mattr_accessor :default_version
     self.default_version = nil
@@ -42,5 +42,7 @@ module VersionCake
       supported_version_numbers.first
     end
 
+    self.extraction_strategy       = :query_parameter
+    self.supported_version_numbers = SUPPORTED_VERSIONS_DEFAULT
   end
 end

data/lib/versioncake/controller_additions.rb

@@ -4,13 +4,31 @@ module VersionCake
   module ControllerAdditions
     extend ActiveSupport::Concern
 
-    attr_accessor :requested_version, :is_latest_version, :derived_version
+    # The explicit version requested by a client, this may not
+    # be the rendered version and may also be nil.
+    attr_accessor :requested_version
 
+    # A boolean check to determine if the latest version is requested.
+    attr_accessor :is_latest_version
+
+    # The requested version by a client or if it's nil the latest or default
+    # version configured.
+    attr_accessor :derived_version
+
+    # set_version is the prepend filter that will determine the version of the
+    # requests.
     included do
       prepend_before_filter :set_version
     end
 
     protected
+
+    # Sets the version of the request as well as several accessor variables.
+    #
+    # @param override_version a version number to use instead of the one extracted
+    #     from the request
+    #
+    # @return No explicit return, but several attributes are exposed
     def set_version(override_version=nil)
       versioned_request         = VersionCake::VersionedRequest.new(request, override_version)
       @requested_version        = versioned_request.extracted_version

data/lib/versioncake/strategies/extraction_strategy.rb

@@ -1,4 +1,5 @@
 require 'active_support/core_ext/class/attribute_accessors.rb'
+require 'active_support/core_ext/string/inflections.rb'
 
 module VersionCake
   class ExtractionStrategy

data/lib/versioncake/version.rb

@@ -1,3 +1,3 @@
 module VersionCake
-  VERSION = "1.2.0"
+  VERSION = "1.3.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: versioncake
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Jim Jones
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-27 00:00:00.000000000 Z
+date: 2013-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -153,11 +153,12 @@ files:
 - Gemfile
 - Gemfile.lock
 - README.md
+- RELEASE.md
 - Rakefile
 - gemfiles/rails3.2.gemfile
 - gemfiles/rails3.2.gemfile.lock
-- gemfiles/rails4.0.rc1.gemfile
-- gemfiles/rails4.0.rc1.gemfile.lock
+- gemfiles/rails4.0.gemfile
+- gemfiles/rails4.0.gemfile.lock
 - images/versioncake-logo450x100.png
 - lib/versioncake.rb
 - lib/versioncake/configuration.rb

data/gemfiles/rails4.0.rc1.gemfile

@@ -1,9 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "actionpack", "4.0.0.rc1"
-gem "activesupport", "4.0.0.rc1"
-gem "railties", "4.0.0.rc1"
-
-gemspec :path=>"../"