verm-client 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0ce2084d3b2424bcc2e768dd946436af8e38925a
-  data.tar.gz: 8be9a875f01d58e946f7c3671cf3178c01f7a922
+  metadata.gz: 7842cddb4253491aa3367dea8adc82f9e1f72af6
+  data.tar.gz: 00e2dd3ae0cc1ec10fc7078e67a3e19523fd3f1b
 SHA512:
-  metadata.gz: 1d462b82e2eaaf10e7c466d020a02b94e592c1a76f842bb3cc667b0364b640451f85257c25d9acff3f092abe44e1612d18ee675283f2cc9124d0899b3bad1ac8
-  data.tar.gz: 58294b9e7814e6fc2a5d2eb41acec6c53a43ac8fd5fb394295205c7fefea3d90041f6d25e58978fb7d08d81d3be4057b9ebb5e4f0f30884ae5d4b63db77b5921
+  metadata.gz: b55bac23d4ca297dad0cf96bacb229c97f1d34664dee5dc7c905b2735a4d36ddfe1d1e2123cbaaa3ef82b003ee0104af8aeceaf42e566338c25d17325804747f
+  data.tar.gz: 890a5df057851e3f0e747dca3632fd3aa5a0e3d49d745ad013de7f45dc43737fd4c8304a526a05d87ab37569f44f371f2320d3497c02c0fe74754b204e0cd7e3

data/lib/verm.rb

@@ -1 +1,2 @@
+require 'verm/http_no_delay'
 require 'verm/client'

data/lib/verm/client.rb

@@ -1,5 +1,3 @@
-require 'net/http'
-
 module Verm
   class Client
     def self.incompressible_types
@@ -8,7 +6,7 @@ module Verm
 
     attr_reader :http_client
 
-    def initialize(hostname, port: 3404, timeout: 15, http_class: Net::HTTP)
+    def initialize(hostname, port: 3404, timeout: 15, http_class: Net::HTTPNoDelay)
       @http_client = http_class.new(hostname, port)
       @http_client.open_timeout = timeout
       @http_client.read_timeout = timeout

data/lib/verm/http_no_delay.rb

@@ -0,0 +1,20 @@
+require 'net/http'
+
+# This class can be used as a workaround for Net::HTTP's lack of TCP_CORK/TCP_NOPUSH in sending
+# requests.  When using a Linux client and a Linux server we observe awful latency POSTing files on
+# reused HTTP connections because Post class writes one block of data for the header and separate
+# block(s) for the body.  If the body is not sufficiently large to fill another packet itself, the
+# Nagle algorithm will have Linux (by default) wait for the ACK from the first packet to be received
+# back; unfortunately, this won't be sent immediately because of the Delayed ACK algorithm.  As a
+# result we typically observe 40ms of extra latency when POSTing small files.  This class disables
+# the Nagle algorithm to work around that.  It's not an ideal fix because we would rather combine
+# the write for the header with the write for the first N bytes of the body, but it should give
+# performance better than the standard Ruby implementation in all cases because Nagle is of no
+# benefit when queuing large blocks only to the OS (as both the streaming and non-streaming
+# variants of the body write calls will do), and the way that Ruby is writing the header separately
+# to the body means there will always be at least two packets anyway.
+class Net::HTTPNoDelay < Net::HTTP
+  def on_connect()
+    @socket.io.setsockopt(Socket::IPPROTO_TCP, Socket::TCP_NODELAY, 1)
+  end
+end

data/lib/verm/version.rb

@@ -1,3 +1,3 @@
 module Verm
-  VERSION = '1.2.0'
+  VERSION = '1.2.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: verm-client
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Will Bryant
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-06 00:00:00.000000000 Z
+date: 2015-08-08 00:00:00.000000000 Z
 dependencies: []
 description: |
   Adds one-line methods for storing files in Verm and retrieving them again.
@@ -23,6 +23,7 @@ files:
 - Rakefile
 - lib/verm.rb
 - lib/verm/client.rb
+- lib/verm/http_no_delay.rb
 - lib/verm/version.rb
 - test/fixtures/binary_file
 - test/fixtures/binary_file.gz