veritrans 2.0.0 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7e5610cd76eb75ec441c3163cc61628015281b1f
-  data.tar.gz: 30699bb305825a89ed1c458692f1d6b847ddb874
+  metadata.gz: 931d9054ff90cd1ba889f74542f676b54d6fd46b
+  data.tar.gz: df6815a8f4c46a28feb241a7ddc0c335aeecdcf9
 SHA512:
-  metadata.gz: 37686f3294e0373f26f475fa80ac34ad1239f5d953323e0e819c4491907797836f54fc68e8de3ad429c05c796633ee10d6381c973bf80a0092f4f843361ecabd
-  data.tar.gz: cc509a41393b64ee5356b9e70b324fc13355df3fe1470b24dd7bb248111853890ebdc3a35b0028fd0ac8dc5ce7cff94a7ea420c320dac2a61f4587898bc4fc87
+  metadata.gz: db0a441e12e6a7c4ccf3a89481503007337ef5577c520413dca0f4ed327b55269f86becaa80a32c33578471aabfa24174537e804cbdac88473287b9aa5b2efa2
+  data.tar.gz: 179e13bdcaae50bfc3b8e1723ba87fe347033d84eedb8ab6d505e5cbae336df28c515004e2fbc888a3d4c4660f9d11e43f555d4028d8cf6fc52c3286673949ce

data/.gitignore

@@ -1,4 +1,5 @@
 coverage
 rails_example*
 .DS_Store
-
+tmp
+doc/

data/.travis.yml

@@ -0,0 +1,5 @@
+script: "bundle exec rspec"
+rvm:
+  - 2.0.0
+  - 2.1.5
+  - 2.2.0

data/CHANGELOG.md

@@ -0,0 +1,14 @@
+### Version 2.0.2  (date: 20 Feb 2014)
+
+* Add feature to add default http options, via Veritrans.config.http_options
+* Start writing documentation in RDoc format
+
+### Version 2.0.1  (date: 20 Jan 2014)
+
+* Fix confusing json format, we don't have it anymore.
+* Add testing for rails generator
+* Disable logging in sample form generated by plugin
+
+### Version 2.0.0  (date: 12 Dec 2014)
+
+* Complete rewrite from version 1.* to support new API version

data/Gemfile

@@ -1,5 +1,3 @@
 source "https://rubygems.org"
 
 gemspec
-
-gem 'vcr'

data/Gemfile.lock

@@ -1,92 +1,139 @@
 PATH
   remote: .
   specs:
-    veritrans (2.0.0beta)
+    veritrans (2.0.2)
       excon (~> 0.20)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actionmailer (4.1.6)
-      actionpack (= 4.1.6)
-      actionview (= 4.1.6)
+    actionmailer (4.2.0)
+      actionpack (= 4.2.0)
+      actionview (= 4.2.0)
+      activejob (= 4.2.0)
       mail (~> 2.5, >= 2.5.4)
-    actionpack (4.1.6)
-      actionview (= 4.1.6)
-      activesupport (= 4.1.6)
-      rack (~> 1.5.2)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+    actionpack (4.2.0)
+      actionview (= 4.2.0)
+      activesupport (= 4.2.0)
+      rack (~> 1.6.0)
       rack-test (~> 0.6.2)
-    actionview (4.1.6)
-      activesupport (= 4.1.6)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+      rails-html-sanitizer (~> 1.0, >= 1.0.1)
+    actionview (4.2.0)
+      activesupport (= 4.2.0)
       builder (~> 3.1)
       erubis (~> 2.7.0)
-    activemodel (4.1.6)
-      activesupport (= 4.1.6)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+      rails-html-sanitizer (~> 1.0, >= 1.0.1)
+    activejob (4.2.0)
+      activesupport (= 4.2.0)
+      globalid (>= 0.3.0)
+    activemodel (4.2.0)
+      activesupport (= 4.2.0)
       builder (~> 3.1)
-    activerecord (4.1.6)
-      activemodel (= 4.1.6)
-      activesupport (= 4.1.6)
-      arel (~> 5.0.0)
-    activesupport (4.1.6)
-      i18n (~> 0.6, >= 0.6.9)
+    activerecord (4.2.0)
+      activemodel (= 4.2.0)
+      activesupport (= 4.2.0)
+      arel (~> 6.0)
+    activesupport (4.2.0)
+      i18n (~> 0.7)
       json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
-      thread_safe (~> 0.1)
+      thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
-    addressable (2.3.6)
-    arel (5.0.1.20140414130214)
+    addressable (2.3.7)
+    arel (6.0.0)
     builder (3.2.2)
+    capybara (2.4.4)
+      mime-types (>= 1.16)
+      nokogiri (>= 1.3.3)
+      rack (>= 1.0.0)
+      rack-test (>= 0.5.4)
+      xpath (~> 2.0)
+    cliver (0.3.2)
     crack (0.4.2)
       safe_yaml (~> 1.0.0)
+    cucumber (1.3.19)
+      builder (>= 2.1.2)
+      diff-lcs (>= 1.1.3)
+      gherkin (~> 2.12)
+      multi_json (>= 1.7.5, < 2.0)
+      multi_test (>= 0.1.2)
     diff-lcs (1.2.5)
     erubis (2.7.0)
-    excon (0.40.0)
+    excon (0.44.2)
+    gherkin (2.12.2)
+      multi_json (~> 1.3)
+    globalid (0.3.3)
+      activesupport (>= 4.1.0)
     hike (1.2.3)
-    i18n (0.6.11)
-    json (1.8.1)
-    mail (2.6.1)
+    i18n (0.7.0)
+    json (1.8.2)
+    loofah (2.0.1)
+      nokogiri (>= 1.5.9)
+    mail (2.6.3)
       mime-types (>= 1.16, < 3)
     mime-types (2.4.3)
-    minitest (5.4.2)
+    mini_portile (0.6.2)
+    minitest (5.5.1)
     multi_json (1.10.1)
-    rack (1.5.2)
-    rack-test (0.6.2)
+    multi_test (0.1.2)
+    nokogiri (1.6.6.2)
+      mini_portile (~> 0.6.0)
+    poltergeist (1.6.0)
+      capybara (~> 2.1)
+      cliver (~> 0.3.1)
+      multi_json (~> 1.0)
+      websocket-driver (>= 0.2.0)
+    rack (1.6.0)
+    rack-test (0.6.3)
       rack (>= 1.0)
-    rails (4.1.6)
-      actionmailer (= 4.1.6)
-      actionpack (= 4.1.6)
-      actionview (= 4.1.6)
-      activemodel (= 4.1.6)
-      activerecord (= 4.1.6)
-      activesupport (= 4.1.6)
+    rails (4.2.0)
+      actionmailer (= 4.2.0)
+      actionpack (= 4.2.0)
+      actionview (= 4.2.0)
+      activejob (= 4.2.0)
+      activemodel (= 4.2.0)
+      activerecord (= 4.2.0)
+      activesupport (= 4.2.0)
       bundler (>= 1.3.0, < 2.0)
-      railties (= 4.1.6)
-      sprockets-rails (~> 2.0)
-    railties (4.1.6)
-      actionpack (= 4.1.6)
-      activesupport (= 4.1.6)
+      railties (= 4.2.0)
+      sprockets-rails
+    rails-deprecated_sanitizer (1.0.3)
+      activesupport (>= 4.2.0.alpha)
+    rails-dom-testing (1.0.5)
+      activesupport (>= 4.2.0.beta, < 5.0)
+      nokogiri (~> 1.6.0)
+      rails-deprecated_sanitizer (>= 1.0.1)
+    rails-html-sanitizer (1.0.1)
+      loofah (~> 2.0)
+    railties (4.2.0)
+      actionpack (= 4.2.0)
+      activesupport (= 4.2.0)
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
-    rake (10.3.2)
-    rspec (3.1.0)
-      rspec-core (~> 3.1.0)
-      rspec-expectations (~> 3.1.0)
-      rspec-mocks (~> 3.1.0)
-    rspec-core (3.1.7)
-      rspec-support (~> 3.1.0)
-    rspec-expectations (3.1.2)
+    rake (10.4.2)
+    rspec (3.2.0)
+      rspec-core (~> 3.2.0)
+      rspec-expectations (~> 3.2.0)
+      rspec-mocks (~> 3.2.0)
+    rspec-core (3.2.0)
+      rspec-support (~> 3.2.0)
+    rspec-expectations (3.2.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.2.0)
+    rspec-mocks (3.2.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.1.0)
-    rspec-mocks (3.1.3)
-      rspec-support (~> 3.1.0)
-    rspec-support (3.1.2)
+      rspec-support (~> 3.2.0)
+    rspec-support (3.2.1)
     safe_yaml (1.0.4)
-    sprockets (2.11.3)
+    sprockets (2.12.3)
       hike (~> 1.2)
       multi_json (~> 1.0)
       rack (~> 1.0)
       tilt (~> 1.1, != 1.3.0)
-    sprockets-rails (2.2.0)
+    sprockets-rails (2.2.4)
       actionpack (>= 3.0)
       activesupport (>= 3.0)
       sprockets (>= 2.8, < 4.0)
@@ -96,14 +143,21 @@ GEM
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
     vcr (2.9.3)
-    webmock (1.20.2)
+    webmock (1.20.4)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
+    websocket-driver (0.5.2)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.2)
+    xpath (2.0.0)
+      nokogiri (~> 1.3)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
+  cucumber
+  poltergeist
   rails
   rspec (>= 2.9.0)
   vcr

data/README.md

@@ -1,12 +1,11 @@
 # Veritrans ruby library
 
-## Installation
-
-     $ gem install veritrans
+[![Gem Version](https://badge.fury.io/rb/veritrans.svg)](http://badge.fury.io/rb/veritrans)
+[![Build Status](https://travis-ci.org/veritrans/veritrans-ruby.svg?branch=master)](https://travis-ci.org/veritrans/veritrans-ruby)
 
 ## How to use (Rails)
 
-### Add veritrans to Gemfile
+### Add gem veritrans to Gemfile
 
 ```ruby
 gem 'veritrans'
@@ -69,6 +68,7 @@ File: "app/views/shared/_veritrans_include.erb"
 ```
 
 Payment form:
+
 ```html
 <form action="/charge_vtdirect" method="post" id="card_form">
   <input type="hidden" name="token_id" id="card_token">
@@ -177,7 +177,7 @@ For every transaction success and failed we will send you HTTP POST notification
 
 First you should set callback url in our dashboard https://my.sandbox.veritrans.co.id/settings/vtweb_configuration
 
-In development mode please read our [Testing webhooks tutorial](https://github.com/Paxa/veritrans-ruby/blob/new_api/testing_webhooks.md)
+For testing in development phase please read our [Testing webhooks tutorial](https://github.com/Paxa/veritrans-ruby/blob/new_api/testing_webhooks.md) and [command line tool](#command-line-tool)
 
 
 For rails:
@@ -188,7 +188,10 @@ match "/payments/receive_webhook" => "payments#receive_webhook", via: [:post]
 
 # app/controllers/payments_controller.rb
 def receive_webhook
-  verified_data = Veritrans.status(params[:transaction_id])
+  post_body = request.body.read
+  callback_params = Veritrans.decode_notification_json(post_body)
+
+  verified_data = Veritrans.status(callback_params['transaction_id'])
 
   if verified_data.status_code != 404
     puts "--- Transaction callback ---"
@@ -206,6 +209,8 @@ def receive_webhook
 end
 ```
 
+----
+
 #### Veritrans::Events
 
 Other option to handle callbacks is our rack-based handler
@@ -231,12 +236,12 @@ end
 
 #### Logging
 
-By default gem veritrans will show information via rails' logger. And in addition save important information to `RAILS_APP/config/veritrans.log`
+By default gem veritrans will show information via rails' logger. And in addition save important information to `RAILS_APP/log/veritrans.log`
 
 It's configurable.
 
 ```ruby
-Veritrans.logger = Logger.new("/my/logs/veritrans.log")
+Veritrans.logger = Rails.logger
 Veritrans.file_logger = Logger.new("/my/important_logs/veritrans.log")
 ```
 
@@ -247,6 +252,22 @@ Veritrans.file_logger = Logger.new("/my/important_logs/veritrans.log")
 * Received http notifications
 * Errors and exception while processing http notifications
 
+----
+
+#### Command line tool
+
+**Installation**
+
+    $ gem install veritrans
+
+**Usage**
+
+Testing http notification:
+
+    $ veritrans testhook http://localhost:3000/vt_events
+    $ veritrans testhook -o my-order-1 -c ~/path/to/veritrans.yml http://localhost:3000/vt_events
+
+
 
 #### Get help
 

data/Rakefile

@@ -5,3 +5,10 @@ task :default => :spec
 desc "Run Specs"
 require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec)
+
+desc "Generate documentation with sdoc"
+task :doc do
+  Bundler.with_clean_env do
+    exec %{sdoc -i ./*.md ./lib/*.rb ./lib/veritrans/*.rb  -m "Veritrans Ruby Library"}
+  end
+end

data/api_reference.md

@@ -49,7 +49,9 @@ please use our [documentation](http://docs.veritrans.co.id/sandbox/introduction.
 </table>
 
 
-### <a name="charge"></a> Charge
+<a name="charge"></a>
+
+### Charge
 
 Actually make transaction. But for vt-web create a redirect url, and for vt-link creates payment page
 
@@ -134,7 +136,8 @@ q.success? # => true
 ```
 
 
-### <a name="status"></a> Status
+<a name="status"></a>
+### Status
 
 Return current status of transaction.
 
@@ -158,7 +161,8 @@ q.data == {
 ```
 
 
-### <a name="cancel"></a> Cancel
+<a name="cancel"></a>
+### Cancel
 
 Cancel transaction, before it was settled. For credit card payments you can cancel it before we trigger settlement in bank.
 Usually we do settlement next day after payment happen, about 4pm.
@@ -185,7 +189,8 @@ q.data == {
 ```
 
 
-### <a name="approve"></a> Approve
+<a name="approve"></a>
+### Approve
 
 Some transactions marked as challenge. If challenge you can approve it or cancel it. Usual way is to use our dashboard web interface,
 but you also can do it programatically, via API
@@ -208,8 +213,8 @@ q.data == {
 }
 ```
 
-
-### <a name="capture"></a> Capture
+<a name="capture"></a>
+### Capture
 
 This API method is only for merchants who have pre-authorise feature (can be requested) and have pre-authorise payments.
 

data/lib/generators/templates/assets/credit_card_form.js

@@ -25,8 +25,8 @@ $(document).ready(function () {
     button.val("Processing ...");
 
     Veritrans.token(VT_createTokenData, function (data) {
-      console.log('Get token response:');
-      console.log(data);
+      // console.log('Get token response:');
+      // console.log(data);
 
       // if we get redirect_url then it's 3d-secure transaction
       // so we need to open that page

data/lib/generators/templates/payments_controller.rb

@@ -32,14 +32,13 @@ class PaymentsController < ApplicationController
 
   def receive_webhook
     post_body = request.body.read
-    callback_params = Veritrans.decode_notification_json(post_body)
 
     Veritrans.file_logger.info("Callback for order: " +
-      "#{callback_params[:order_id]} #{callback_params[:transaction_status]}\n" +
+      "#{params[:order_id]} #{params[:transaction_status]}\n" +
       post_body + "\n"
     )
 
-    verified_data = Veritrans.status(callback_params["transaction_id"])
+    verified_data = Veritrans.status(params["transaction_id"])
 
     if verified_data.status_code != 404
       puts "--- Transaction callback ---"
@@ -53,7 +52,7 @@ class PaymentsController < ApplicationController
       render text: "ok"
     else
       Veritrans.file_logger.info("Callback verification failed for order: " +
-        "#{callback_params[:order_id]} #{callback_params[:transaction_status]}}\n" +
+        "#{params[:order_id]} #{params[:transaction_status]}}\n" +
         verified_data.body + "\n"
       )
 

data/lib/veritrans.rb

@@ -1,4 +1,5 @@
 require 'veritrans/version'
+require 'veritrans/core_extensions'
 require 'veritrans/config'
 require 'veritrans/client'
 require 'veritrans/api'
@@ -66,17 +67,8 @@ module Veritrans
       Veritrans::Events if defined?(Veritrans::Events)
     end
 
-    # Note: Veritrans sending notification data as json, encoded twice
-    # so we should call JSON.parse twice
     def decode_notification_json(input)
-      if input.start_with?('"{') && input.end_with?('}"')
-        # ruby's JSON library can't excpect only hash or array. To decode string I wrap it in array.
-        request_data = Veritrans::Client._json_decode('[' + input + ']').first
-        return Veritrans::Client._json_decode(request_data)
-      else
-        # in case we will make it in expected way later
-        return Veritrans::Client._json_decode(input)
-      end
+      return Veritrans::Client._json_decode(input)
     end
 
   end

data/lib/veritrans/cli.rb

@@ -2,17 +2,6 @@ require 'json'
 require 'securerandom'
 require 'logger'
 
-class Hash
-  def except!(*keys)
-    keys.each { |key| delete(key) }
-    self
-  end
-
-  def except(*keys)
-    dup.except!(*keys)
-  end
-end
-
 module Veritrans
   module CLI
     # can't find order
@@ -134,7 +123,7 @@ module Veritrans
         data = data.except(:fraud_status, :masked_card).merge(order_data)
       end
 
-      JSON.dump(JSON.pretty_generate(data))
+      JSON.pretty_generate(data)
     end
 
     def colorize(str, color_code)

data/lib/veritrans/client.rb

@@ -70,10 +70,12 @@ module Veritrans
       method = method.to_s.upcase
       logger.info "Veritrans: #{method} #{url} #{_json_encode(params)}"
 
+      default_options = config.http_options || {}
+
       # Add authentication and content type
       # Docs http://docs.veritrans.co.id/sandbox/introduction.html
-      options = {
-        :body => _json_encode(params),
+      request_options = {
+        :path => URI.parse(url).path,
         :headers => {
           :Authorization => auth_header || basic_auth_header(config.server_key),
           :Accept => "application/json",
@@ -83,18 +85,25 @@ module Veritrans
       }
 
       if method == "GET"
-        options.delete(:body)
-        options[:query] = URI.encode_www_form(params)
+        request_options[:query] = URI.encode_www_form(params)
+      else
+        request_options[:body] = _json_encode(params)
       end
 
+      connection_options = {
+        read_timeout: 40,
+        write_timeout: 40,
+        connect_timeout: 40
+      }.deep_merge(default_options)
+
       s_time = Time.now
-      request = Excon.new(url, read_timeout: 40, write_timeout: 40, connect_timeout: 40)
+      request = Excon.new(url, connection_options)
 
-      response = request.send(method.downcase.to_sym, options.merge(path: URI.parse(url).path))
+      response = request.send(method.downcase.to_sym, request_options)
 
       logger.info "Veritrans: got #{(Time.now - s_time).round(3)} sec #{response.status} #{response.body}"
 
-      Result.new(response, url, options, Time.now - s_time)
+      Result.new(response, url, request_options, Time.now - s_time)
 
     rescue Excon::Errors::SocketError => error
       logger.info "PAPI: socket error, can not connect"

data/lib/veritrans/config.rb

@@ -1,4 +1,5 @@
 require 'yaml'
+require 'excon'
 
 module Veritrans
 
@@ -7,30 +8,90 @@ module Veritrans
 
     @api_host = "https://api.sandbox.veritrans.co.id"
 
+    ##
+    # Merhcant's Client key, used to make getToken request. (only for VT-Direct)
+    #
+    # Can be found in merchant portal: Settings -> Access Keys
+    #
+    def client_key=(value)
+      @client_key = value
+    end
+
+
     def client_key
       @client_key
     end
 
-    def client_key=(value)
-      @client_key = value
+    ##
+    # Merhcant's Server key, used to sign every http API call.
+    #
+    # Can be found in merchant portal: Settings -> Access Keys
+    #
+    def server_key=(value)
+      @server_key = value
     end
 
     def server_key
       @server_key
     end
 
-    def server_key=(value)
-      @server_key = value
+    ##
+    # API Server hostname, this allow to switch between production and sandbox
+    #
+    # Should be "https://api.sandbox.veritrans.co.id" or "https://api.veritrans.co.id"
+    #
+    # Default is "https://api.sandbox.veritrans.co.id"
+    #
+    def api_host=(value)
+      @api_host = value
     end
 
     def api_host
       @api_host
     end
 
-    def api_host=(value)
-      @api_host = value
+    ##
+    # This will override http request settings for api calls.
+    # http_options should be hash, it will be merged with connection options for every request.
+    #
+    # Full list of options: https://github.com/excon/excon/blob/master/lib/excon/constants.rb
+    #
+    # For unsupported key it will raise ArgumentError
+    #
+    #   Veritrans.config.http_options = {tcp_nodelay: true, ssl_version: 'TLSv1'}
+    #
+    def http_options=(options)
+      unless options.is_a?(Hash)
+        raise ArgumentError, "http_options should be a hash"
+      end
+
+      # Validate allowed keys
+      diff = options.keys.map(&:to_sym) - Excon::VALID_CONNECTION_KEYS
+      if diff.size > 0
+        raise ArgumentError,
+          "http_options contain unsupported keys: #{diff.inspect}\n" +
+          "Supported keys are: #{Excon::VALID_CONNECTION_KEYS.inspect}"
+      end
+
+      @http_options = options
+    end
+
+    def http_options
+      @http_options
     end
 
+    ##
+    # Loads YAML file and assign config values
+    #
+    # Supports #section in filename to choose one section.
+    # If you are using Rails, it will try to use Rails.env as a section name
+    #
+    # Available config keys: server_key, client_key, api_host, http_options
+    #
+    #   Veritrans.setup do
+    #     config.load_yml "#{Rails.root.to_s}/config/veritrans.yml#development"
+    #   end
+    #
     def load_config(filename)
       yml_file, yml_section = filename.to_s.split('#')
       config_data = YAML.load(File.read(yml_file))
@@ -45,7 +106,11 @@ module Veritrans
     alias :load_yml :load_config
 
     def inspect
-      "<Veritrans::Config @api_host=#{@api_host.inspect} @server_key=#{@server_key.inspect} @client_key=#{@client_key.inspect}>"
+      "<Veritrans::Config " +
+        "@api_host=#{@api_host.inspect} " +
+        "@server_key=#{@server_key.inspect} " +
+        "@client_key=#{@client_key.inspect} " +
+        "@http_options=#{@http_options.inspect}>"
     end
 
     private

data/lib/veritrans/core_extensions.rb

@@ -0,0 +1,32 @@
+# This is replacement for Hash#deep_merge in acive_support
+# when acive_support not loaded
+
+class Hash #:nodoc:
+
+  unless method_defined?(:deep_merge)
+    def deep_merge(second)
+      merger = proc { |key, v1, v2|
+        if Hash === v1 && Hash === v2
+          v1.merge(v2, &merger)
+        else
+          [:undefined, nil, :nil].include?(v2) ? v1 : v2
+        end
+      }
+      self.merge(second, &merger)
+    end
+  end
+
+  unless method_defined?(:except!)
+    def except!(*keys)
+      keys.each { |key| delete(key) }
+      self
+    end
+  end
+
+  unless method_defined?(:except)
+    def except(*keys)
+      dup.except!(*keys)
+    end
+  end
+
+end

data/lib/veritrans/version.rb

@@ -1,3 +1,3 @@
 module Veritrans
-  VERSION = "2.0.0"
+  VERSION = "2.0.2"
 end

data/spec/cli_spec.rb

@@ -15,8 +15,6 @@ describe Veritrans do
     end
 
     data = ActiveSupport::JSON.decode(@request.body)
-    data.class.should == String
-    data = ActiveSupport::JSON.decode(data)
 
     data["status_code"].should == "200"
     data["status_message"].should == "Veritrans payment notification"
@@ -74,8 +72,6 @@ describe Veritrans do
     end
 
     data = ActiveSupport::JSON.decode(@request.body)
-    data.class.should == String
-    data = ActiveSupport::JSON.decode(data)
 
     data["status_code"].should == "200"
     data["status_message"].should == "Veritrans payment notification"

data/spec/rails_plugin_spec.rb

@@ -0,0 +1,212 @@
+require 'fileutils'
+require 'open3'
+require 'shellwords'
+require 'socket'
+
+describe "Rails plugin", vcr: false do
+  include Capybara::DSL
+
+  RAILS_VER = "4.1.9"
+  APP_DIR = "plugin_test"
+  PLUGIN_DIR = File.expand_path("..", File.dirname(__FILE__))
+
+  before :all do
+    FileUtils.mkdir_p("#{PLUGIN_DIR}/tmp")
+    #Capybara::Screenshot.instance_variable_set(:@capybara_root, "#{PLUGIN_DIR}/tmp")
+  end
+
+  def capture_stdout(&block)
+    original_stdout = $stdout
+    $stdout = fake = StringIO.new
+    begin
+      yield
+    ensure
+      $stdout = original_stdout
+    end
+    fake.string
+  end
+
+  def run_cmd(cmd, cli_args = [])
+    full_cmd = ([cmd] + cli_args).join.strip
+
+    stdout_str, stderr_str, status = Open3.capture3(full_cmd)
+
+    if status != 0
+      puts "CMD: #{full_cmd}"
+      puts "FAILED"
+      puts stderr_str
+
+      exit 1
+    end
+
+    #puts stdout_str
+
+    return stdout_str
+  end
+
+  def install_rails_in_tmp
+    @rails_dir = Dir.mktmpdir()
+    @app_abs_path = "#{@rails_dir}/#{APP_DIR}"
+
+    Dir.chdir(@rails_dir) do
+      Bundler.with_clean_env do
+        ENV["RAILS_ENV"] = "development"
+        find_or_install_rails
+        generate_rails_app
+        generate_plugin_things
+      end
+    end
+  end
+
+  def find_or_install_rails
+    response = run_cmd('gem list \^rails\$ -q')
+    if response =~ /[^\d]#{RAILS_VER}[^\d]/
+      return true
+    else
+      run_cmd("gem install rails -v #{RAILS_VER} --no-ri --no-rdoc")
+    end
+  end
+
+  def generate_rails_app
+    gen = "rails _#{RAILS_VER}_ new #{APP_DIR} -B -G --skip-spring -d sqlite3 --skip-turbolinks --skip-test-unit --no-rc"
+    run_cmd(gen)
+
+    gemfile_content = "
+      source 'https://rubygems.org'
+
+      gem 'rails', '#{RAILS_VER}'
+      gem 'sqlite3'
+      gem 'turbolinks'
+      gem 'jquery-rails'
+      gem 'veritrans', path: '#{PLUGIN_DIR}'
+    ".gsub(/^\s+/, '')
+
+    File.open("#{@app_abs_path}/Gemfile", "w") {|f| f.write(gemfile_content) }
+
+    Dir.chdir(@app_abs_path) do
+      run_cmd("bundle")
+    end
+  end
+
+  def generate_plugin_things
+    Dir.chdir(@app_abs_path) do
+      run_cmd("rails g veritrans:install")
+      run_cmd("rails g veritrans:payment_form")
+    end
+
+    config_content = "
+development:
+  client_key: VT-client-NArmatJZqzsmTmzR
+  server_key: VT-server-9Htb-RxXkg7-7hznSCCjxvoY
+  api_host: https://api.sandbox.veritrans.co.id
+"
+
+    File.open("#{@app_abs_path}/config/veritrans.yml", "w") {|f| f.write(config_content) }
+  end
+
+  def run_rails_app
+    @rails_port = find_open_port
+
+    Bundler.with_clean_env do
+      ENV["RAILS_ENV"] = "development"
+      Dir.chdir(@app_abs_path) do
+        run_cmd("./bin/rails server -d -p #{@rails_port} --bind 127.0.0.1")
+      end
+    end
+
+    Capybara.app_host = "http://localhost:#{@rails_port}"
+
+    #puts "RAILS_DIR: #{@app_abs_path}"
+
+    while true
+      begin
+        run_cmd("curl #{Capybara.app_host}/payments/new > /dev/null")
+        break
+      rescue Object => error
+        p error
+        puts "Retry"
+      end
+    end
+  end
+
+  def stop_rails_app
+    Dir.chdir(@app_abs_path) do
+      if File.exist?("./tmp/pids/server.pid")
+        run_cmd("kill `cat tmp/pids/server.pid`")
+      end
+    end
+  end
+
+  def find_open_port
+    socket = Socket.new(:INET, :STREAM, 0)
+    socket.bind(Addrinfo.tcp("127.0.0.1", 0))
+    return socket.local_address.ip_port
+  ensure
+    socket.close
+  end
+
+  after do
+    stop_rails_app
+    FileUtils.remove_entry_secure(@rails_dir) if @rails_dir
+  end
+
+  it "should tests plugin" do
+    # PREPARE APP
+    install_rails_in_tmp
+    run_rails_app
+
+    # CREATE PAYMENT 1
+    visit "/payments/new"
+
+    click_button "Pay via VT-Direct"
+
+    # Waiting for get token request in javascript...
+    Timeout.timeout(30.seconds) do
+      loop do
+        break if current_path != "/payments/new"
+        sleep 0.1
+      end
+    end
+
+    Timeout.timeout(10.seconds) do
+      loop do
+        break if page.body =~ /<body>/
+        sleep 0.1
+      end
+    end
+
+    if page.body =~ /too many transactions/
+      page.should have_content("Merchant has sent too many transactions to the same card number")
+    else
+      page.should have_content("Success, Credit Card transaction is successful")
+    end
+
+    created_order_id = ActiveSupport::JSON.decode(find("pre").text)["order_id"]
+    #Capybara::Screenshot.screenshot_and_open_image
+
+    # CREATE PAYMENT 2
+    visit "/payments/new"
+    click_link "Pay via VT-Web"
+
+    page.should have_content("Payment is securely processed by Veritrans")
+    #Capybara::Screenshot.screenshot_and_open_image
+
+    # TEST CALLBACK FOR WRONG DATA
+    stub_const("CONFIG", {})
+    result1 = capture_stdout do
+      Veritrans::CLI.test_webhook(["#{Capybara.app_host}/payments/receive_webhook"])
+    end
+
+    result1.should =~ /status: 404/
+
+    # TEST CALLBACK FOR CORRECT DATA
+    stub_const("CONFIG", {order: created_order_id, config_path: "#{@app_abs_path}/config/veritrans.yml"})
+    result2 = capture_stdout do
+      Veritrans::CLI.test_webhook(["#{Capybara.app_host}/payments/receive_webhook"])
+    end
+
+    result2.should =~ /status: 200/
+    result2.should =~ /body: ok/
+  end
+
+end

data/spec/spec_helper.rb

@@ -10,6 +10,19 @@ require 'rails'
 require 'webmock/rspec'
 require 'vcr'
 
+require 'capybara/rspec'
+require 'capybara/poltergeist'
+
+Capybara.configure do |config|
+  config.javascript_driver = :poltergeist
+  config.default_driver = :poltergeist
+  config.app_host = ""
+  config.run_server = false
+end
+
+GEM_ROOT = File.expand_path("../..", __FILE__)
+ENV['RAILS_ENV'] = 'development'
+
 VCR.configure do |c|
   c.cassette_library_dir = 'spec/fixtures'
   c.hook_into :webmock # or :fakeweb
@@ -26,4 +39,14 @@ RSpec.configure do |config|
   config.mock_with :rspec do |c|
     c.syntax = [:should, :expect]
   end
+
+  config.around(:each) do |example|
+    if example.metadata[:vcr] === false
+      WebMock.allow_net_connect!
+      VCR.turned_off { example.run }
+      WebMock.disable_net_connect!
+    else
+      example.run
+    end
+  end
 end

data/spec/veritrans_client_spec.rb

@@ -8,6 +8,38 @@ describe Veritrans do
     end
   end
 
+  it "should use Veritrans.http_options", vcr: false do
+    Veritrans::Config.stub(:http_options) do
+      { omit_default_port: true }
+    end
+
+    api_request = nil
+    stub_request(:any, /.*/).to_return(lambda { |request|
+      api_request = request
+      {body: request.body}
+    })
+
+    result = Veritrans.request_with_logging(:get, Veritrans.config.api_host + "/ping", {})
+
+    api_request.headers["Host"].should == "api.sandbox.veritrans.co.id"
+  end
+
+  it "should use Veritrans.http_options to attach hedaers", vcr: false do
+    Veritrans::Config.stub(:http_options) do
+      { headers: { "X-Rspec" => "ok" } }
+    end
+
+    api_request = nil
+    stub_request(:any, /.*/).to_return(lambda { |request|
+      api_request = request
+      {body: request.body}
+    })
+
+    result = Veritrans.request_with_logging(:get, Veritrans.config.api_host + "/ping", {})
+
+    api_request.headers["X-Rspec"].should == "ok"
+  end
+
   it "should send charge vt-web request" do
     VCR.use_cassette('charge_vtweb') do
       result = Veritrans.charge('vtweb', transaction: { order_id: Time.now.to_s, gross_amount: 100_000 } )

data/spec/veritrans_config_spec.rb

@@ -45,4 +45,15 @@ describe Veritrans::Config do
     data.should == {"client_key" => "test_client_key", "server_key" => "test_server_key"}
   end
 
-end
+  it "should validate http_params type" do
+    expect {
+      Veritrans.config.http_options = nil
+    }.to raise_error(ArgumentError, "http_options should be a hash")
+  end
+
+  it "should validate http_params type" do
+    expect {
+      Veritrans.config.http_options = {foo: "bar", tcp_nodelay: true}
+    }.to raise_error(ArgumentError, /http_options contain unsupported keys: \[:foo\]/)
+  end
+end

data/veritrans.gemspec

@@ -20,4 +20,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency "rspec", ">= 2.9.0"
   s.add_development_dependency "rails"
   s.add_development_dependency 'webmock'
+  s.add_development_dependency 'vcr'
+  s.add_development_dependency 'cucumber'
+  s.add_development_dependency "poltergeist"
 end

metadata

@@ -1,69 +1,111 @@
 --- !ruby/object:Gem::Specification
 name: veritrans
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.2
 platform: ruby
 authors:
 - Veritrans Dev Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-12 00:00:00.000000000 Z
+date: 2015-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: excon
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.20'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.20'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.9.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.9.0
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: vcr
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: cucumber
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: poltergeist
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: 
@@ -74,8 +116,10 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - README.md
@@ -102,6 +146,7 @@ files:
 - lib/veritrans/cli.rb
 - lib/veritrans/client.rb
 - lib/veritrans/config.rb
+- lib/veritrans/core_extensions.rb
 - lib/veritrans/events.rb
 - lib/veritrans/result.rb
 - lib/veritrans/version.rb
@@ -123,6 +168,7 @@ files:
 - spec/fixtures/events_test_real_txn.yml
 - spec/fixtures/status_fail.yml
 - spec/fixtures/status_success.yml
+- spec/rails_plugin_spec.rb
 - spec/spec_helper.rb
 - spec/veritrans_client_spec.rb
 - spec/veritrans_config_spec.rb
@@ -139,18 +185,19 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.4.4
 signing_key: 
 specification_version: 4
 summary: Veritrans ruby library
 test_files: []
+has_rdoc: