verified_double 0.5.2 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8d1eb25be783652e30676de88ae7f8015cff10b6
-  data.tar.gz: b85e9d5184092922884ea5fe2da0d88006b4ff26
+  metadata.gz: 97ca8fc74d9ad9dddff6b285850a673f46e092f1
+  data.tar.gz: 638a65c4724ac5023ba85c717cda05c93bf9fde9
 SHA512:
-  metadata.gz: 6cb478d8d914bf335840d899141f476da301a2fa827bc6e633198bd66284bfb32203125a056f021bd77aec0b5ce017ec12f21642b508e2c7c2694f6316b87166
-  data.tar.gz: 4154b09a4cea4f65b23116ed916d5191c82f8c4a466ba07314b170d629c775e2cf8b6f2fa33d68affdbbea4cdf03f969d348f28f2fc7d6981f36c807bea41712
+  metadata.gz: e813041bbf2731d2b2b4f7aae3bb547c1e57cf85181da4422f563e0ad725b3b90841a9fae2d32ae1bc9597f3767077de97202b658e70880596d315c0af5d51db
+  data.tar.gz: 3180a6b9822c22912b9117cc993be47ebbfe8770c5bef2e3304a706005f141741b731396598e74528a3f03a4da0243a97d9a593c76a192fcacd35607f462b6bb

data/CHANGELOG.markdown

@@ -1,3 +1,8 @@
+0.5.3 - 2013-12-26
+------------------
+
+* Implement any_instance mocks with new RSpec syntax.
+
 0.5.2 - 2013-12-26
 ------------------
 

data/README.md

@@ -153,12 +153,12 @@ end
 Aside for instance and class doubles, VerifiedDouble also supports `any_instance` mocks:
 
 ```
-VerifiedDouble.any_instance_of(Collaborator)
-  .should_receive(:some_method).with(input).and_return(output)
-```
+VerifiedDouble.expect_any_instance_of(Collaborator)
+  .to receive(:some_method).with(input).and_return(output)
 
-You'll need to use should_receive for `any_instance` mocks. I still have to figure
-out how to make it work with RSpec's `expect_any_instance_of` syntax :p
+VerifiedDouble.allow_any_instance_of(Collaborator)
+  .to receive(:some_method).with(input).and_return(output)
+```
 
 ## Complete documentation
 

data/features/CHANGELOG.markdown

@@ -1,3 +1,8 @@
+0.5.3 - 2013-12-26
+------------------
+
+* Implement any_instance mocks with new RSpec syntax.
+
 0.5.2 - 2013-12-26
 ------------------
 

data/features/any_instance.feature

@@ -45,8 +45,8 @@ Feature: 60. Any instance
         let(:output) { SomeOutput.new }
 
         it "tests something" do
-          VerifiedDouble.any_instance_of(Collaborator)
-            .should_receive(:some_method).with(input).and_return(output)
+          VerifiedDouble.expect_any_instance_of(Collaborator)
+            .to receive(:some_method).with(input).and_return(output)
 
           ObjectUnderTest.new.do_something(Collaborator.new, input)
         end
@@ -77,8 +77,8 @@ Feature: 60. Any instance
         let(:output) { SomeOutput.new }
 
         it "tests something" do
-          VerifiedDouble.any_instance_of(Collaborator)
-            .should_receive(:some_method).with(input).and_return(output)
+          VerifiedDouble.expect_any_instance_of(Collaborator)
+            .to receive(:some_method).with(input).and_return(output)
 
           ObjectUnderTest.new.do_something(Collaborator.new, input)
         end
@@ -93,3 +93,62 @@ Feature: 60. Any instance
 
       1. Collaborator#some_method(SomeInput)=>SomeOutput
       """
+
+  Scenario: Verify any instance of a class
+
+    Given a test that uses VerifiedDouble to stub any instance of the class:
+      """
+      require 'spec_helper'
+      describe ObjectUnderTest do
+        let(:input) { SomeInput.new }
+        let(:output) { SomeOutput.new }
+
+        it "tests something" do
+          VerifiedDouble.allow_any_instance_of(Collaborator)
+            .to receive(:some_method).with(input).and_return(output)
+
+          ObjectUnderTest.new.do_something(Collaborator.new, input)
+        end
+      end
+      """
+
+    And the test suite has a contract test for the mock:
+      """
+      require 'spec_helper'
+
+      describe 'Collaborator' do
+        it "tests something",
+          verifies_contract: 'Collaborator#some_method(SomeInput)=>SomeOutput' do
+          # do nothing
+        end
+      end
+      """
+
+    When I run the test suite
+    Then I should not see any output saying the stub is unverified
+
+  Scenario: Unverified any_instance stub
+    Given a test that uses VerifiedDouble to stub any instance of the class:
+      """
+      require 'spec_helper'
+      describe ObjectUnderTest do
+        let(:input) { SomeInput.new }
+        let(:output) { SomeOutput.new }
+
+        it "tests something" do
+          VerifiedDouble.allow_any_instance_of(Collaborator)
+            .to receive(:some_method).with(input).and_return(output)
+
+          ObjectUnderTest.new.do_something(Collaborator.new, input)
+        end
+      end
+      """
+
+    And the test suite does not have a contract test for the stub
+    When I run the test suite
+    Then I should be informed that the stub is unverified:
+      """
+      The following mocks are not verified:
+
+      1. Collaborator#some_method(SomeInput)=>SomeOutput
+      """

data/features/readme.md

@@ -153,12 +153,12 @@ end
 Aside for instance and class doubles, VerifiedDouble also supports `any_instance` mocks:
 
 ```
-VerifiedDouble.any_instance_of(Collaborator)
-  .should_receive(:some_method).with(input).and_return(output)
-```
+VerifiedDouble.expect_any_instance_of(Collaborator)
+  .to receive(:some_method).with(input).and_return(output)
 
-You'll need to use should_receive for `any_instance` mocks. I still have to figure
-out how to make it work with RSpec's `expect_any_instance_of` syntax :p
+VerifiedDouble.allow_any_instance_of(Collaborator)
+  .to receive(:some_method).with(input).and_return(output)
+```
 
 ## Complete documentation
 

data/features/step_definitions/verified_double_steps.rb

@@ -14,6 +14,10 @@ Given /^a test that uses VerifiedDouble to stub an object:$/ do |string|
   write_file 'spec/main_spec.rb', string
 end
 
+Given(/^a test that uses VerifiedDouble to stub any instance of the class:$/) do |string|
+  write_file 'spec/main_spec.rb', string
+end
+
 Given /^a test that uses VerifiedDouble to mock a class:$/ do |string|
   write_file 'spec/main_spec.rb', string
 end
@@ -34,6 +38,10 @@ Given /^the test suite does not have a contract test for the mock$/ do
   # do nothing
 end
 
+Given /^the test suite does not have a contract test for the stub$/ do
+  # do nothing
+end
+
 When /^I run the test suite$/ do
   run_simple(unescape("rspec"), false)
 end
@@ -43,6 +51,11 @@ Then /^I should be informed that the mock is unverified:$/ do |string|
   assert_success('pass')
 end
 
+Then /^I should be informed that the stub is unverified:$/ do |string|
+  assert_partial_output(string, all_output)
+  assert_success('pass')
+end
+
 Then /^I should not see any output saying the mock is unverified$/ do
   assert_no_partial_output("The following mocks are not verified", all_output)
   assert_success('pass')

data/lib/verified_double/rspec_mocks_syntax_overrides.rb

@@ -11,14 +11,7 @@ module VerifiedDouble
 
     def expect(*args)
       if args[0].respond_to?(:can_record_interactions?)
-        if args[0].respond_to?(:verified_any_instance_double?)
-          raise "VerifiedDouble.any_instance_of doesn't support yet Rspec's " \
-            "expect/allow syntax. Please use should_receive."
-        else
-          VerifiedDouble.registry.current_double = args[0]
-        end
-
-
+        VerifiedDouble.registry.current_double = args[0]
       else
         VerifiedDouble.registry.current_double = nil
       end

data/lib/verified_double/simple_double.rb

@@ -20,14 +20,14 @@ module VerifiedDouble
       elsif instance_double?
         internal.instance_variable_get('@name').to_s
       elsif any_instance_double?
-        internal.instance_variable_get('@klass').to_s
+        internal.instance_variable_get('@target').to_s
       else
-        raise
+        raise 'Unable to handle internal #{internal.inspect}'
       end
     end
 
     def any_instance_double?
-      !! internal.instance_variable_get('@klass')
+      !! internal.instance_variable_get('@target')
     end
 
     def class_double?

data/lib/verified_double/version.rb

@@ -1,3 +1,3 @@
 module VerifiedDouble
-  VERSION = "0.5.2"
+  VERSION = "0.5.3"
 end

data/lib/verified_double.rb

@@ -5,7 +5,6 @@ require 'verified_double/boolean'
 require 'verified_double/can_record_interactions'
 require 'verified_double/example_metadata'
 require 'verified_double/is_a_class_double'
-require 'verified_double/is_an_any_instance_double'
 require 'verified_double/is_an_instance_double'
 require 'verified_double/matchers'
 require 'verified_double/method_signature'
@@ -25,10 +24,16 @@ require 'verified_double/stack_frame'
 module VerifiedDouble
   extend RSpec::Mocks::ExampleMethods
 
-  def self.any_instance_of(klass)
-    d = klass.any_instance
-    d.extend(VerifiedDouble::IsAnAnyInstanceDouble)
-    VerifiedDouble.record(d)
+  def self.allow_any_instance_of(klass)
+    super(klass).tap do |d|
+      VerifiedDouble.registry.current_double = VerifiedDouble.record(d)
+    end
+  end
+
+  def self.expect_any_instance_of(klass)
+    super(klass).tap do |d|
+      VerifiedDouble.registry.current_double = VerifiedDouble.record(d)
+    end
   end
 
   def self.of_class(class_value, options = {})

data/spec/verified_double/rspec_mocks_syntax_overrides_spec.rb

@@ -15,15 +15,6 @@ describe VerifiedDouble::RSpecMocksSyntaxOverrides do
       end
     end
 
-    context "where the double arg is an RSpec::Mocks::AnyInstance::Recorder" do
-      let(:a_double) { VerifiedDouble.of_instance('Object') }
-
-      it "should tell the user to use should_receive instead" do
-        expect(lambda { expect(VerifiedDouble.any_instance_of(Object)) })
-          .to raise_error
-      end
-    end
-
     context "where the double arg does not record VerifiedDouble interactions" do
       let(:a_double) { double('Object') }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: verified_double
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.3
 platform: ruby
 authors:
 - George Mendoza
@@ -168,7 +168,6 @@ files:
 - lib/verified_double/can_record_interactions.rb
 - lib/verified_double/example_metadata.rb
 - lib/verified_double/is_a_class_double.rb
-- lib/verified_double/is_an_any_instance_double.rb
 - lib/verified_double/is_an_instance_double.rb
 - lib/verified_double/matchers.rb
 - lib/verified_double/method_signature.rb

data/lib/verified_double/is_an_any_instance_double.rb

@@ -1,12 +0,0 @@
-require 'verified_double/is_an_instance_double'
-
-module VerifiedDouble
-  module IsAnAnyInstanceDouble
-    include IsAnInstanceDouble
-
-    def verified_any_instance_double?
-      true
-    end
-  end
-end
-