verdict 0.6.3 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a92b885958acdb2076598cf696dcd91c8a2247a9
-  data.tar.gz: 942c8fca6745450639522b541f703d01ef3dab3f
+  metadata.gz: a1929eb3266514c557ec595e7fa7f80065a1b600
+  data.tar.gz: 1f34b0ad26c876f348649ad04d96a9f0c077ea48
 SHA512:
-  metadata.gz: 6d7a2547e02b9e07864a0c26d74d244033d21e5ad8eaabf4aed09b92e1d356cc34aea7a70a4fd16271d740ff5393a3d1c13ebe940ceb7e56ea544ef3316b90bb
-  data.tar.gz: f3d02419590bd341634b7946282aab584daf19db6d6fa7718425b8565d239b227906c3ef0354c17a253cb2f956f2a25c63b6bb4150a93323865f8b8ebcbbcf91
+  metadata.gz: 63801e6ec63ae74dcb33c418090fec977a4598e23da4ff6bc642e2041025915f5ea8eda536ff7c5415dfd18106d1dc1c1fe339b6901b26663b70bfcad4d8803f
+  data.tar.gz: 982e62386331ba13174d3e758a9624ba76b80e45e30ba59f788c65a239585a74abd6386f79622e0dd7314328c0e7843852a01bb6a4b4f7597f6b1d3618f99644

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+## v0.7.0
+**This version has breaking changes**
+
+* Experiment can now specify multiple qualify blocks
+  * `Verdict::Experiment#qualifier` has been removed in favor for `Verdict::Experiment#qualifiers`, which returns an array of procs
+* Allow pass of an argument to qualify with a method name as a symbol, instead of a block
+
 ## v0.6.3
 
 * Fix bug were Verdict.directory is overwritten

data/lib/verdict/experiment.rb

@@ -2,7 +2,7 @@ class Verdict::Experiment
 
   include Verdict::Metadata
 
-  attr_reader :handle, :qualifier, :storage, :event_logger
+  attr_reader :handle, :qualifiers, :storage, :event_logger
 
   def self.define(handle, *args, &block)
     experiment = self.new(handle, *args, &block)
@@ -14,7 +14,7 @@ class Verdict::Experiment
     @handle = handle.to_s
 
     options = default_options.merge(options)
-    @qualifier                    = options[:qualifier]
+    @qualifiers                   = Array(options[:qualifier] || options[:qualifiers])
     @event_logger                 = options[:event_logger] || Verdict::EventLogger.new(Verdict.default_logger)
     @storage                      = storage(options[:storage] || :memory)
     @store_unqualified            = options[:store_unqualified]
@@ -58,8 +58,16 @@ class Verdict::Experiment
     end
   end
 
-  def qualify(&block)
-    @qualifier = block
+  def qualify(method_name = nil, &block)
+    if block_given?
+      @qualifiers << block
+    elsif method_name.nil?
+      raise ArgumentError, "no method nor blocked passed!"
+    elsif respond_to?(method_name, true)
+      @qualifiers << method(method_name).to_proc
+    else
+      raise ArgumentError, "No helper for #{method_name.inspect}"
+    end
   end
 
   def storage(storage = nil, options = {})
@@ -169,7 +177,7 @@ class Verdict::Experiment
   end
 
   def has_qualifier?
-    !@qualifier.nil?
+    @qualifiers.any?
   end
 
   def everybody_qualifies?
@@ -204,7 +212,7 @@ class Verdict::Experiment
 
   def subject_qualifies?(subject, context = nil)
     ensure_experiment_has_started
-    everybody_qualifies? || @qualifier.call(subject, context)
+    everybody_qualifies? || @qualifiers.all? { |qualifier| qualifier.call(subject, context) }
   end
 
   protected

data/lib/verdict/version.rb

@@ -1,3 +1,3 @@
 module Verdict
-  VERSION = "0.6.3"
+  VERSION = "0.7.0"
 end

data/test/experiment_test.rb

@@ -5,7 +5,7 @@ class ExperimentTest < Minitest::Test
 
   def test_no_qualifier
     e = Verdict::Experiment.new('test')
-    assert !e.has_qualifier?
+    refute e.has_qualifier?
     assert e.everybody_qualifies?
   end
 
@@ -18,14 +18,14 @@ class ExperimentTest < Minitest::Test
     end
 
     assert e.has_qualifier?
-    assert !e.everybody_qualifies?
+    refute e.everybody_qualifies?
 
     subject_stub = Struct.new(:id, :country)
     ca_subject = subject_stub.new(1, 'CA')
     us_subject = subject_stub.new(1, 'US')
 
-    assert e.qualifier.call(ca_subject)
-    assert !e.qualifier.call(us_subject)
+    assert e.qualifiers.all? { |q| q.call(ca_subject) }
+    refute e.qualifiers.all? { |q| q.call(us_subject) }
 
     qualified = e.assign(ca_subject)
     assert_kind_of Verdict::Assignment, qualified
@@ -33,7 +33,74 @@ class ExperimentTest < Minitest::Test
 
     non_qualified = e.assign(us_subject)
     assert_kind_of Verdict::Assignment, non_qualified
-    assert !non_qualified.qualified?
+    refute non_qualified.qualified?
+    assert_equal nil, non_qualified.group
+  end
+
+  def test_multiple_qualifier
+    e = Verdict::Experiment.new('test') do |experiment|
+      qualify { |subject| subject.language == 'fr' }
+      qualify { |subject| subject.country == 'CA' }
+
+      groups do
+        group :all, 100
+      end
+    end
+
+    assert e.has_qualifier?
+    refute e.everybody_qualifies?
+
+    subject_stub = Struct.new(:id, :country, :language)
+    fr_subject = subject_stub.new(1, 'CA', 'fr')
+    en_subject = subject_stub.new(2, 'CA', 'en')
+
+    assert e.qualifiers.all? { |q| q.call(fr_subject) }
+    refute e.qualifiers.all? { |q| q.call(en_subject) }
+
+    qualified = e.assign(fr_subject)
+    assert_kind_of Verdict::Assignment, qualified
+    assert_equal e.group(:all), qualified.group
+
+    non_qualified = e.assign(en_subject)
+    assert_kind_of Verdict::Assignment, non_qualified
+    refute non_qualified.qualified?
+    assert_equal nil, non_qualified.group
+  end
+
+  module CountryIsCanadaHelper
+    def country_is_canada(subject, _context)
+      subject.country == 'CA'
+    end
+  end
+  def test_method_qualifier
+
+    e = Verdict::Experiment.new('test') do |experiment|
+      extend CountryIsCanadaHelper
+
+      qualify :country_is_canada
+
+      groups do
+        group :all, 100
+      end
+    end
+
+    assert e.has_qualifier?
+    refute e.everybody_qualifies?
+
+    subject_stub = Struct.new(:id, :country)
+    ca_subject = subject_stub.new(1, 'CA')
+    us_subject = subject_stub.new(1, 'US')
+
+    assert e.qualifiers.all? { |q| q.call(ca_subject, nil) }
+    refute e.qualifiers.all? { |q| q.call(us_subject, nil) }
+
+    qualified = e.assign(ca_subject)
+    assert_kind_of Verdict::Assignment, qualified
+    assert_equal e.group(:all), qualified.group
+
+    non_qualified = e.assign(us_subject)
+    assert_kind_of Verdict::Assignment, non_qualified
+    refute non_qualified.qualified?
     assert_equal nil, non_qualified.group
   end
 
@@ -45,7 +112,7 @@ class ExperimentTest < Minitest::Test
       end
     end
 
-    assert !e.assign(nil).qualified?
+    refute e.assign(nil).qualified?
     assert_equal nil, e.convert('', :mygoal)
   end
 
@@ -63,12 +130,12 @@ class ExperimentTest < Minitest::Test
     assignment = e.assign(1)
     assert_kind_of Verdict::Assignment, assignment
     assert assignment.qualified?
-    assert !assignment.returning?
+    refute assignment.returning?
     assert_equal assignment.group, e.group(:a)
 
     assignment = e.assign(3)
     assert_kind_of Verdict::Assignment, assignment
-    assert !assignment.qualified?
+    refute assignment.qualified?
 
     assert_equal :a,  e.switch(1)
     assert_equal :b,  e.switch(2)
@@ -175,7 +242,7 @@ class ExperimentTest < Minitest::Test
     original_assignment = e.assign(subject)
     assert original_assignment.qualified?
     new_assignment = e.disqualify_manually(subject)
-    assert !new_assignment.qualified?
+    refute new_assignment.qualified?
   end
 
   def test_disqualify_manually_fails_with_store_unqualified_disabled
@@ -212,7 +279,7 @@ class ExperimentTest < Minitest::Test
     mock_store.expects(:store_assignment).never
 
     assignment = e.assign(mock('subject'))
-    assert !assignment.qualified?
+    refute assignment.qualified?
   end
 
   def test_assignment_event_logging
@@ -273,7 +340,7 @@ class ExperimentTest < Minitest::Test
 
     storage_mock.stubs(:retrieve_assignment).raises(Verdict::StorageError, 'storage read issues')
     rescued_assignment = e.assign(stub(id: 123))
-    assert !rescued_assignment.qualified?
+    refute rescued_assignment.qualified?
   end
 
   def test_storage_write_failure
@@ -286,7 +353,7 @@ class ExperimentTest < Minitest::Test
     storage_mock.expects(:retrieve_assignment).returns(e.subject_assignment(mock('subject_identifier'), e.group(:all), nil))
     storage_mock.expects(:store_assignment).raises(Verdict::StorageError, 'storage write issues')
     rescued_assignment = e.assign(stub(id: 456))
-    assert !rescued_assignment.qualified?
+    refute rescued_assignment.qualified?
   end
 
   def test_initial_started_at
@@ -328,7 +395,7 @@ class ExperimentTest < Minitest::Test
       end
 
       subject = stub(id: 'old', created_at: Time.new(2011))
-      assert !e.assign(subject).qualified?
+      refute e.assign(subject).qualified?
 
       subject = stub(id: 'new', created_at: Time.new(2013))
       assert e.assign(subject).qualified?
@@ -340,7 +407,7 @@ class ExperimentTest < Minitest::Test
       groups { group :all, 100 }
     end
 
-    assert !e.started?, "The experiment should not have started yet"
+    refute e.started?, "The experiment should not have started yet"
 
     e.assign(stub(id: '123'))
     assert e.started?, "The experiment should have started after the first assignment"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: verdict
 version: !ruby/object:Gem::Version
-  version: 0.6.3
+  version: 0.7.0
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-19 00:00:00.000000000 Z
+date: 2017-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest