verdict 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2e529fa9948f7f7176df69a622210e40594d3c91
-  data.tar.gz: e576284cd0a3eed14ebb597acf31bbf87b86a681
+  metadata.gz: e5d867e9231108358536850b04548a9a43594d79
+  data.tar.gz: 272e5fb808e0083732fd5516660812ce92ade4c9
 SHA512:
-  metadata.gz: 8347a5f689329717098cb9d9d42c3c78731a55863e5f1fe8c6debf6db3f8155ffd65fb22b4d7af50d05a05e1980af41d42e5a72bef81ce84cd43371b045bf0e9
-  data.tar.gz: 3a27b4ff3dd5db6705be1f715cfd1e8860a5df9c1b54344f5e3693ea6bf426d8c40f6b3d2a1e6f2007f0a7c94057325fb18c2dabe9e1ed5f1dc287e5c1db7a8e
+  metadata.gz: 4883a16667083e18a41955708c0624abf6caa0360df42b7a58968b528a4a04cef3aee013733f4e046ce37994b437834a14182429324c454313f3061e68cf6767
+  data.tar.gz: a62aba796b913ca660d039881149edfa5cbda21f240683b9fe66e28441058e4f0ce6e0c49dcd2e7af02f224005824d91c5b72731963cda6f6e3f52871c56402d

data/.travis.yml

@@ -1,4 +1,6 @@
 language: ruby
+cache: bundler
+before_install: gem update bundler
 script: bundle exec rake
 rvm:
   - 1.9.3

data/lib/verdict/assignment.rb

@@ -1,12 +1,11 @@
 class Verdict::Assignment
-
   attr_reader :experiment, :subject_identifier, :group, :created_at
 
   def initialize(experiment, subject_identifier, group, originally_created_at, temporary = false)
     @experiment         = experiment
     @subject_identifier = subject_identifier
     @group              = group
-    @returning          = !originally_created_at.nil?
+    @first              = originally_created_at.nil? || experiment.manual_assignment_timestamps?
     @created_at         = originally_created_at || Time.now.utc
     @temporary          = temporary
   end
@@ -32,7 +31,7 @@ class Verdict::Assignment
   end
 
   def returning?
-    @returning
+    @first.nil?
   end
 
   def handle

data/lib/verdict/experiment.rb

@@ -14,13 +14,14 @@ class Verdict::Experiment
     @handle = handle.to_s
 
     options = default_options.merge(options)
-    @qualifier                   = options[:qualifier]
-    @event_logger                = options[:event_logger] || Verdict::EventLogger.new(Verdict.default_logger)
-    @storage                     = storage(options[:storage] || :memory)
-    @store_unqualified           = options[:store_unqualified]
-    @segmenter                   = options[:segmenter]
-    @subject_type                = options[:subject_type]
-    @disqualify_empty_identifier = options[:disqualify_empty_identifier]
+    @qualifier                    = options[:qualifier]
+    @event_logger                 = options[:event_logger] || Verdict::EventLogger.new(Verdict.default_logger)
+    @storage                      = storage(options[:storage] || :memory)
+    @store_unqualified            = options[:store_unqualified]
+    @segmenter                    = options[:segmenter]
+    @subject_type                 = options[:subject_type]
+    @disqualify_empty_identifier  = options[:disqualify_empty_identifier]
+    @manual_assignment_timestamps = options[:manual_assignment_timestamps]
 
     instance_eval(&block) if block_given?
   end
@@ -35,6 +36,10 @@ class Verdict::Experiment
     @store_unqualified
   end
 
+  def manual_assignment_timestamps?
+    @manual_assignment_timestamps
+  end
+
   def group(handle)
     segmenter.groups[handle.to_s]
   end

data/lib/verdict/version.rb

@@ -1,3 +1,3 @@
 module Verdict
-  VERSION = "0.4.1"
+  VERSION = "0.5.0"
 end

data/test/assignment_test.rb

@@ -73,4 +73,22 @@ class AssignmentTest < Minitest::Test
       assert_equal '2012-01-01T00:00:00Z', json['created_at']
     end
   end
+
+  def test_returning_assignment
+    assignment_with_timestamp = Verdict::Assignment.new(@experiment, 'test_subject_id', @group, Time.now.utc)
+    assert assignment_with_timestamp.returning?
+
+    assignment_without_timestamp = Verdict::Assignment.new(@experiment, 'test_subject_id', @group, nil)
+    refute assignment_without_timestamp.returning?
+  end
+
+  def test_returning_with_manual_assignment_timestamps_experiment_option
+    experiment = Verdict::Experiment.new('assignment test', manual_assignment_timestamps: true)
+
+    assignment_with_timestamp = Verdict::Assignment.new(experiment, 'test_subject_id', @group, Time.now.utc)
+    refute assignment_with_timestamp.returning?
+
+    assignment_without_timestamp = Verdict::Assignment.new(experiment, 'test_subject_id', @group, nil)
+    refute assignment_without_timestamp.returning?
+  end
 end

data/test/experiment_test.rb

@@ -75,6 +75,22 @@ class ExperimentTest < Minitest::Test
     assert_equal nil, e.switch(3)
   end
 
+  def test_experiment_without_manual_assignment_timestamps_option
+    e = Verdict::Experiment.new('test') do
+      groups { group :all, 100 }
+    end
+
+    refute e.manual_assignment_timestamps?
+  end
+
+  def test_experiment_with_manual_assignment_timestamps_option
+    e = Verdict::Experiment.new('test', manual_assignment_timestamps: true) do
+      groups { group :all, 100 }
+    end   
+
+    assert e.manual_assignment_timestamps?
+  end
+
   def test_subject_identifier
     e = Verdict::Experiment.new('test')
     assert_equal '123', e.retrieve_subject_identifier(stub(id: 123, to_s: '456'))

metadata

@@ -1,83 +1,83 @@
 --- !ruby/object:Gem::Specification
 name: verdict
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-17 00:00:00.000000000 Z
+date: 2016-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '5.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '5.2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: redis
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Shopify Experiments classes
@@ -88,8 +88,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -144,17 +144,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.2.3
 signing_key: 
 specification_version: 4
 summary: A library to centrally define experiments for your application, and collect