veracodecli 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 38a85c2a0d02935e016488510c19cfe2d3d34fcc
-  data.tar.gz: e46ceafd154bfb498b2f20dcb0c629ffb77f811b
+  metadata.gz: 827da5c760675286fc6a2401713dbd844237d54d
+  data.tar.gz: e231f9e7dc2f4f7d034314ead5edba8e50d2b860
 SHA512:
-  metadata.gz: 2f6b49907d5d2920f734c8dcf1c34dab1332ef24a4c578377152f1fa7011bc1456419cd00052839acd13646c8711b99ad6b26552f573659a7269219dab264c86
-  data.tar.gz: 7164c3bea8001f0c235c5cb852c9c488248c47868f6e55241af8314132de12e9a5f0db015038bc896093e95adff7309b1c05dc816313cf8396acf9c5d5ddefbe
+  metadata.gz: d42ba6d8ecd48ec4303bb8191f02b5ad65ee5ec90993d2285809ae13fb0a33f76367ad1a42a7f47990bb6f97b2867211d8409df8c003d5f755ec9bab57016f79
+  data.tar.gz: ca77d8f24973a65401fb23ac514980eb43ec1dd34fc4f5d159f4e56bf4c62f371d928665ef7d3458b42e49c67907fffa8fc265d3081fcc7c46bc8c20f9870308

data/lib/veracodecli/api.rb

@@ -10,7 +10,6 @@ module VeracodeApiBase
   def veracode_api_request(api_call, api_version: '4.0', **params)
     check_environment_login_variables
     response = RestClient.get "https://#{ENV['VERACODE_USERNAME']}:#{ENV['VERACODE_PASSWORD']}@analysiscenter.veracode.com/api/#{api_version}/#{api_call}", { params: params }
-    response.body
   end
 end
 
@@ -21,11 +20,12 @@ module VeracodeApiScan
     app_list = veracode_api_request 'getapplist.do', include_user_info: 'true'
     scan = app_list.scan(/app_id=\"(.+)\" app_name=\"#{app_name}\"/)
     if !scan.nil? then app_id = scan[0][0] else app_id = nil end
+    app_id
   end
 
   def create_app_profile(app_name, business_criticality, business_unit, teams)
     create_app_response = veracode_api_request 'createapp.do', app_name: app_name, business_criticality: business_criticality, business_unit: business_unit, teams: teams
-    app_id = create_app_response.scan(/app_id=\"(.+)\" app_name=\"#{of}\"/)[0][0]
+    app_id = create_app_response.body.scan(/app_id=\"(.+)\" app_name=\"#{app_name}\"/)[0][0]
   end
 
   def upload_file(app_id, archive_path)
@@ -44,24 +44,27 @@ module VeracodeApiResults
 
   def get_most_recent_build_id(app_id)
     build_list = veracode_api_request 'getbuildlist.do', app_id: app_id
-    build_list.scan(/build_id="(.*?)"/).last[0]
+    build_list.body.scan(/build_id="(.*?)"/).last[0]
   end
 
   def get_build_status(app_id)
     build_info = veracode_api_request 'getbuildinfo.do', app_id: app_id
-    build_id = build_info.scan(/build_id="(.*?)"/)[0][0]
-    build_status = build_info.scan(/status="(.*?)"/).last[0]
+    build_id = build_info.body.scan(/build_id="(.*?)"/)[0][0]
+    build_status = build_info.body.scan(/status="(.*?)"/).last[0]
     puts build_status
+    build_status
   end
 
   def get_prescan_results(app_id)
     results = veracode_api_request 'getprescanresults.do', app_id: app_id
     puts "Fetched prescan results for #{app_id}"
-    puts results
+    puts results.body
+    results
   end
 
-  def get_scan_report(app_id)
+  def get_scan_report(build_id)
     report = veracode_api_request 'detailedreport.do', api_version: '3.0', build_id: build_id
+    report = report.body
   end
 end
 

data/test/test_veracodecli.rb

@@ -2,19 +2,46 @@ require 'test/unit'
 require 'shoulda/context'
 require_relative '../lib/veracodecli/api'
 include VeracodeApiScan
+include VeracodeApiResults
 
 class TestVeracodecli < Test::Unit::TestCase
   context 'VeracodeApi' do
 
     setup do
-      ENV['VERACODE_USERNAME'] = 'foo'
-      ENV['VERACODE_PASSWORD'] = 'bar'
-      ENV['VERACODE_TEAM'] = 'foobar'
+      ENV['VERACODE_USERNAME'] = 'telusdigitalapi'
+      ENV['VERACODE_PASSWORD'] = 'OSJ939q4'
     end
 
-    should 'Return HTTP 401' do
-      assert_kind_of String, veracode_api_request('getapplist.do')
+    should 'Return existing application profile ID' do
+      assert_equal '12379', get_app_id('Test1')
     end
 
+    should 'Return HTTP 200 for createapp.do' do
+      assert_equal 200, veracode_api_request('createapp.do', app_name: 'Test1', business_criticality: 'Low', business_unit: 'TELUS Digital', teams: 'TELUS Digital').code
+    end
+
+    should 'Return HTTP 200 from beginprescan.do' do
+      assert_equal 200, veracode_api_request('beginprescan.do', app_id:'12379').code
+    end
+
+    # should 'Return XML response for uploadfile.do' do
+    #   assert_boolean upload_file('12379', '/home/zaya/Documents/test.php.tar').include?('Uploaded')
+    # end
+
+    should 'Return HTTP from get_prescan_results function' do
+      assert_equal 200, get_prescan_results('12379').code
+    end
+
+    should 'Return XML response' do
+      assert_boolean get_scan_report('12379').include?('<detailedreport')
+    end
+
+    should 'Return Application Scan Status' do
+      assert_kind_of String, get_build_status('12379')
+    end
+
+    should 'Return Most recent Build ID' do
+      assert_match /\d+/, get_most_recent_build_id('12379')
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: veracodecli
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - isaiah thiessen